75453 2012-01-02 16:50:42 -0800 alignment issue when building with Solaris Studio 2012-01-16 02:23:22 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Other Other RESOLVED FIXED P3 Normal --- 0 tropikhajma webkit-unassigned webkit.review.bot oldest_to_newest 528603 0 120900 tropikhajma 2012-01-02 16:50:42 -0800 Created attachment 120900 patch building Qt 4.8 with Solaris Studio fails with the below message. ... "./wtf/Alignment.h", line 33: Error: #error WTF_ALIGN macros need alignment control.. See also https://bugs.webkit.org/show_bug.cgi?id=57231, basically alignment macros are supported in Sun/Solaris Studio since v.12 I'm not sure from which webkit version comes the Qt snapshot, but I can see the same code is still present in webkit trunk. The attached patch helped me. 528833 1 ap 2012-01-03 10:03:04 -0800 Would you be willing to make a patch that could be reviewed and landed in WebKit trunk, as described in <http://www.webkit.org/coding/contributing.html>? We don't normally keep open bugs for patches that are not intended for landing. 531292 2 121473 tropikhajma 2012-01-06 12:47:33 -0800 Created attachment 121473 Patch 536424 3 121473 morrita 2012-01-16 01:35:51 -0800 Comment on attachment 121473 Patch Now this has a ChangeLog entry. Bots don't cry. Looks OK to land. 536440 4 121473 webkit.review.bot 2012-01-16 02:23:18 -0800 Comment on attachment 121473 Patch Clearing flags on attachment: 121473 Committed r105044: <http://trac.webkit.org/changeset/105044> 536441 5 webkit.review.bot 2012-01-16 02:23:22 -0800 All reviewed patches have been landed. Closing bug. 120900 2012-01-02 16:50:42 -0800 2012-01-06 12:47:23 -0800 patch qt-align2.diff text/plain 640 tropikhajma LS0tIHNyYy8zcmRwYXJ0eS93ZWJraXQvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9BbGlnbm1l bnQuaC5vcmlnCVR1ZSBKYW4gIDMgMDA6Mzc6MzMgMjAxMgorKysgc3JjLzNyZHBhcnR5L3dlYmtp dC9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0FsaWdubWVudC5oCVR1ZSBKYW4gIDMgMDA6Mzg6 MTUgMjAxMgpAQCAtMjMsNyArMjMsNyBAQAogCiAjaW5jbHVkZSA8d3RmL1BsYXRmb3JtLmg+CiAK LSNpZiBDT01QSUxFUihHQ0MpIHx8IENPTVBJTEVSKE1JTkdXKSB8fCBDT01QSUxFUihSVkNUKSB8 fCBDT01QSUxFUihXSU5TQ1cpIHx8IENPTVBJTEVSKEdDQ0UpCisjaWYgQ09NUElMRVIoR0NDKSB8 fCBDT01QSUxFUihNSU5HVykgfHwgQ09NUElMRVIoUlZDVCkgfHwgQ09NUElMRVIoV0lOU0NXKSB8 fCBDT01QSUxFUihHQ0NFKSB8fCAoQ09NUElMRVIoU1VOQ0MpICYmIF9fU1VOUFJPX0NDID4gMHg1 OTApCiAgICAgI2RlZmluZSBXVEZfQUxJR05fT0YodHlwZSkgX19hbGlnbm9mX18odHlwZSkKICAg ICAjZGVmaW5lIFdURl9BTElHTkVEKHZhcmlhYmxlX3R5cGUsIHZhcmlhYmxlLCBuKSB2YXJpYWJs ZV90eXBlIHZhcmlhYmxlIF9fYXR0cmlidXRlX18oKF9fYWxpZ25lZF9fKG4pKSkKICNlbGlmIENP TVBJTEVSKE1TVkMpCg== 121473 2012-01-06 12:47:33 -0800 2012-01-16 02:23:18 -0800 Patch bug-75453-20120106214506.patch text/plain 1196 tropikhajma SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTA0MzE3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEyLTAxLTA2ICBQYXZlbCBIZWltbGljaCAgPHRyb3Bpa2hham1hQGdtYWlsLmNvbT4KKwor ICAgICAgICBTb2xhcmlzIFN0dWRpbyBzdXBwb3J0cyBhbGlnbm1lbnQgbWFjcm9zIHRvbworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU0NTMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9BbGlnbm1l bnQuaDoKKwogMjAxMi0wMS0wNiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJlbW92ZSB1bnVzZWQgT3duRmFzdE1hbGxvY1B0ciBjbGFzcy4KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvQWxpZ25tZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi9BbGlnbm1lbnQuaAkocmV2aXNpb24gMTAzMTgwKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL3d0Zi9BbGlnbm1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMjYsNyArMjYs NyBAQAogCiBuYW1lc3BhY2UgV1RGIHsKIAotI2lmIENPTVBJTEVSKEdDQykgfHwgQ09NUElMRVIo TUlOR1cpIHx8IENPTVBJTEVSKFJWQ1QpIHx8IENPTVBJTEVSKEdDQ0UpCisjaWYgQ09NUElMRVIo R0NDKSB8fCBDT01QSUxFUihNSU5HVykgfHwgQ09NUElMRVIoUlZDVCkgfHwgQ09NUElMRVIoR0ND RSkgfHwgKENPTVBJTEVSKFNVTkNDKSAmJiBfX1NVTlBST19DQyA+IDB4NTkwKQogICAgICNkZWZp bmUgV1RGX0FMSUdOX09GKHR5cGUpIF9fYWxpZ25vZl9fKHR5cGUpCiAgICAgI2RlZmluZSBXVEZf QUxJR05FRCh2YXJpYWJsZV90eXBlLCB2YXJpYWJsZSwgbikgdmFyaWFibGVfdHlwZSB2YXJpYWJs ZSBfX2F0dHJpYnV0ZV9fKChfX2FsaWduZWRfXyhuKSkpCiAjZWxpZiBDT01QSUxFUihNU1ZDKQo=