75452 2012-01-02 15:51:37 -0800 If argument to Error is undefined, message is not set 2012-01-02 22:57:07 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough webkit-unassigned oldest_to_newest 528597 0 barraclough 2012-01-02 15:51:37 -0800 We currently set message to the empty string. 528600 1 120899 barraclough 2012-01-02 16:21:41 -0800 Created attachment 120899 Fix 528647 2 120899 sam 2012-01-02 20:09:33 -0800 Comment on attachment 120899 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=120899&action=review > LayoutTests/fast/js/native-error-prototype-expected.txt:1 > +This is a test case for bug 55346 and bug 70889 https://bugs.webkit.org/show_bug.cgi?id=75452. :\ > LayoutTests/fast/js/script-tests/native-error-prototype.js:2 > +'This is a test case for <a href="https://bugs.webkit.org/show_bug.cgi?id=55346">bug 55346</a> and <a href="https://bugs.webkit.org/show_bug.cgi?id=70889">bug 70889</a> https://bugs.webkit.org/show_bug.cgi?id=75452.' The grammar here could use some updating. 528673 3 barraclough 2012-01-02 22:57:07 -0800 > The grammar here could use some updating. Ooops, I made the grammar better good. Fixed in r103924 120899 2012-01-02 16:21:41 -0800 2012-01-02 20:09:33 -0800 Fix 75452.patch text/plain 4596 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAzOTE2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTAxLTAyICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU0NTIK KyAgICAgICAgSWYgYXJndW1lbnQgdG8gRXJyb3IgaXMgdW5kZWZpbmVkLCBtZXNzYWdlIGlzIG5v dCBzZXQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQ ZXIgc2VjdGlvbiAxNS4xMS4xLjEgb2YgdGhlIHNwZWMuCisKKyAgICAgICAgKiBydW50aW1lL0Vy cm9ySW5zdGFuY2UuaDoKKyAgICAgICAgKEpTQzo6RXJyb3JJbnN0YW5jZTo6Y3JlYXRlKToKKyAg ICAgICAgKEpTQzo6RXJyb3JJbnN0YW5jZTo6ZmluaXNoQ3JlYXRpb24pOgorCiAyMDEyLTAxLTAx ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQ2FsbCBpbnN0cnVj dGlvbnMgc2hvdWxkIGxlYXZlIHJvb20gZm9yIGxpbmtpbmcgaW5mb3JtYXRpb24KSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Vycm9ySW5zdGFuY2UuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FcnJvckluc3RhbmNlLmgJKHJldmlzaW9u IDEwMzgyMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Vycm9ySW5zdGFuY2Uu aAkod29ya2luZyBjb3B5KQpAQCAtNDYsNyArNDYsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAg ICAgewogICAgICAgICAgICAgaWYgKG1lc3NhZ2UuaXNVbmRlZmluZWQoKSkgewogICAgICAgICAg ICAgICAgIEVycm9ySW5zdGFuY2UqIGluc3RhbmNlID0gbmV3IChOb3ROdWxsLCBhbGxvY2F0ZUNl bGw8RXJyb3JJbnN0YW5jZT4oKmV4ZWMtPmhlYXAoKSkpIEVycm9ySW5zdGFuY2UoZXhlYy0+Z2xv YmFsRGF0YSgpLCBzdHJ1Y3R1cmUpOwotICAgICAgICAgICAgICAgIGluc3RhbmNlLT5maW5pc2hD cmVhdGlvbihleGVjLT5nbG9iYWxEYXRhKCksIFVTdHJpbmcoIiIsIDApKTsKKyAgICAgICAgICAg ICAgICBpbnN0YW5jZS0+ZmluaXNoQ3JlYXRpb24oZXhlYy0+Z2xvYmFsRGF0YSgpLCBVU3RyaW5n KCkpOwogICAgICAgICAgICAgICAgIHJldHVybiBpbnN0YW5jZTsKICAgICAgICAgICAgIH0KICAg ICAgICAgICAgIHJldHVybiBjcmVhdGUoZXhlYy0+Z2xvYmFsRGF0YSgpLCBzdHJ1Y3R1cmUsIG1l c3NhZ2UudG9TdHJpbmcoZXhlYykpOwpAQCAtNjMsNyArNjMsOCBAQCBuYW1lc3BhY2UgSlNDIHsK ICAgICAgICAgewogICAgICAgICAgICAgQmFzZTo6ZmluaXNoQ3JlYXRpb24oZ2xvYmFsRGF0YSk7 CiAgICAgICAgICAgICBBU1NFUlQoaW5oZXJpdHMoJnNfaW5mbykpOwotICAgICAgICAgICAgcHV0 RGlyZWN0KGdsb2JhbERhdGEsIGdsb2JhbERhdGEucHJvcGVydHlOYW1lcy0+bWVzc2FnZSwganNT dHJpbmcoJmdsb2JhbERhdGEsIG1lc3NhZ2UpLCBEb250RW51bSk7CisgICAgICAgICAgICBpZiAo IW1lc3NhZ2UuaXNOdWxsKCkpCisgICAgICAgICAgICAgICAgcHV0RGlyZWN0KGdsb2JhbERhdGEs IGdsb2JhbERhdGEucHJvcGVydHlOYW1lcy0+bWVzc2FnZSwganNTdHJpbmcoJmdsb2JhbERhdGEs IG1lc3NhZ2UpLCBEb250RW51bSk7CiAgICAgICAgIH0KIAogICAgICAgICBib29sIG1fYXBwZW5k U291cmNlVG9NZXNzYWdlOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTAzOTE2KQorKysgTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDEtMDIg IEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTQ1MgorICAgICAgICBJZiBh cmd1bWVudCB0byBFcnJvciBpcyB1bmRlZmluZWQsIG1lc3NhZ2UgaXMgbm90IHNldAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIHRlc3QgY2Fz ZS4KKworICAgICAgICAqIGZhc3QvanMvbmF0aXZlLWVycm9yLXByb3RvdHlwZS1leHBlY3RlZC50 eHQ6CisgICAgICAgICogZmFzdC9qcy9zY3JpcHQtdGVzdHMvbmF0aXZlLWVycm9yLXByb3RvdHlw ZS5qczoKKwogMjAxMi0wMS0wMiAgQmFsYXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgVW5yZXZpZXdlZCBRdC1XSzIgZ2FyZGVuaW5nLgpJbmRleDogTGF5b3V0VGVz dHMvZmFzdC9qcy9uYXRpdmUtZXJyb3ItcHJvdG90eXBlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL25hdGl2ZS1lcnJvci1wcm90b3R5cGUtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAxMDM4MjMpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL25hdGl2ZS1lcnJv ci1wcm90b3R5cGUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAot VGhpcyBpcyBhIHRlc3QgY2FzZSBmb3IgYnVnIDU1MzQ2IGFuZCBidWcgNzA4ODkuCitUaGlzIGlz IGEgdGVzdCBjYXNlIGZvciBidWcgNTUzNDYgYW5kIGJ1ZyA3MDg4OSBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU0NTIuCiAKIE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNl ZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRF Ii4KIApAQCAtNiw2ICs2LDggQEAgT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9m ICJQQQogUEFTUyAoe30pLnRvU3RyaW5nLmNhbGwoRXJyb3IucHJvdG90eXBlKSBpcyAiW29iamVj dCBFcnJvcl0iCiBQQVNTICh7fSkudG9TdHJpbmcuY2FsbChSYW5nZUVycm9yLnByb3RvdHlwZSkg aXMgIltvYmplY3QgRXJyb3JdIgogUEFTUyBlcnIudG9TdHJpbmcoKSBpcyAibWVzc2FnZSIKK1BB U1MgZXJyLmhhc093blByb3BlcnR5KCdtZXNzYWdlJykgaXMgZmFsc2UKK1BBU1MgZXJyLmhhc093 blByb3BlcnR5KCdtZXNzYWdlJykgaXMgZmFsc2UKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlz IHRydWUKIAogVEVTVCBDT01QTEVURQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQt dGVzdHMvbmF0aXZlLWVycm9yLXByb3RvdHlwZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9uYXRpdmUtZXJyb3ItcHJvdG90eXBlLmpzCShyZXZpc2lv biAxMDM4MjMpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9uYXRpdmUtZXJy b3ItcHJvdG90eXBlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogZGVzY3JpcHRp b24oCi0nVGhpcyBpcyBhIHRlc3QgY2FzZSBmb3IgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU1MzQ2Ij5idWcgNTUzNDY8L2E+IGFuZCA8YSBocmVmPSJo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzA4ODkiPmJ1ZyA3MDg4OTwv YT4uJworJ1RoaXMgaXMgYSB0ZXN0IGNhc2UgZm9yIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NTM0NiI+YnVnIDU1MzQ2PC9hPiBhbmQgPGEgaHJlZj0i aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcwODg5Ij5idWcgNzA4ODk8 L2E+IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTQ1Mi4nCiApOwog CiBzaG91bGRCZSgiKHt9KS50b1N0cmluZy5jYWxsKEVycm9yLnByb3RvdHlwZSkiLCAnIltvYmpl Y3QgRXJyb3JdIicpOwpAQCAtOCwzICs4LDkgQEAgc2hvdWxkQmUoIih7fSkudG9TdHJpbmcuY2Fs bChSYW5nZUVycm9yLgogdmFyIGVyciA9IG5ldyBFcnJvcigibWVzc2FnZSIpOwogZXJyLm5hbWUg PSAiIjsKIHNob3VsZEJlKCJlcnIudG9TdHJpbmcoKSIsICcibWVzc2FnZSInKTsKKwordmFyIGVy ciA9IG5ldyBFcnJvcigpOworc2hvdWxkQmVGYWxzZSgiZXJyLmhhc093blByb3BlcnR5KCdtZXNz YWdlJykiKTsKKwordmFyIGVyciA9IG5ldyBFcnJvcih1bmRlZmluZWQpOworc2hvdWxkQmVGYWxz ZSgiZXJyLmhhc093blByb3BlcnR5KCdtZXNzYWdlJykiKTsK