75451 2012-01-02 15:19:57 -0800 REGRESSION(r100517): Finalizers are not run for many, many DOM objects! 2012-04-03 15:35:49 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All NEW InRadar P2 Normal --- 1 sam sam abarth ap ggaren japhet mhahnenberg mrowe webkit.review.bot oldest_to_newest 528591 0 sam 2012-01-02 15:19:57 -0800 After r100517 we appear to be leaking many DOM objects. It appears that their wrappers are not being finalized which is leading to the wrapped object not being deref'd before the wrapper is destroyed. * STEPS TO REPRODUCE 1. Load <http://www.google.com/>. 2. Run "leaks WebProcess". * RESULTS You'll see 50 - 100 reported leaks of objects like CSSComputedStyleDeclaration and so on. 528592 1 sam 2012-01-02 15:21:01 -0800 It seems the assumption that a finalizer will run for each DOM object wrapper (based on the assumption that each DOM object wrapper has a handle which can get finalized) is not holding true. 528593 2 120896 sam 2012-01-02 15:23:46 -0800 Created attachment 120896 Temporary workaround patch 528594 3 sam 2012-01-02 15:32:08 -0800 Committed r103913: <http://trac.webkit.org/changeset/103913> 528595 4 sam 2012-01-02 15:41:25 -0800 <rdar://problem/10611063> 528598 5 sam 2012-01-02 15:56:12 -0800 Fixed the build due to bad patch landing in r103915. 594964 6 ap 2012-04-03 15:35:49 -0700 Re-titling to track a proper fix, now that the symptom is under the carpet. 120896 2012-01-02 15:23:46 -0800 2012-01-02 15:46:47 -0800 Temporary workaround patch bug-75451-20120102152406.patch text/plain 3213 sam U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzOTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODFhOWQxZmM5MjE5NTRm ZDZhZThiNmEyYzMyZmU3MzYyMWJhZGZlMy4uMDc1NzQ1ZTI3MTY1NzdiZjFmYjA5MjU0ZDYxZTJm MTQ5MTgzNTAzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAxLTAyICBTYW0g V2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTAwNTE3KTog V2UncmUgbGVha2luZyBtYW55LCBtYW55IERPTSBvYmplY3RzIQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU0NTEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvckpTLnBtOgorICAgICAgICBBZGQgYSB0ZW1wb3Jhcnkgd29ya2Fyb3VuZCB0byB0aGUgcHJv YmxlbSBvZiBoYW5kbGUgZmluYWxpemVycworICAgICAgICBub3QgZ2V0dGluZyBjYWxsZWQgYnkg YWRkaW5nIGJhY2sgdGhlIGRlc3RydWN0b3JzIChvciByYXRoZXIKKyAgICAgICAgdGhlaXIgcmVw bGFjZW1lbnQsIGRlc3Ryb3koKSBmdW5jdGlvbnMpLgorCiAyMDEyLTAxLTAyICBDYWlvIE1hcmNl bG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CiAKICAg ICAgICAgRml4IGNocm9taXVtIG1hYyBidWlsZCBhZnRlciByMTAzOTA1CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbSBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCmluZGV4IGJkYjY2 YjlhNTNlZDRlYmUyOWUzMmIyZDI2YTQzNmNhODQxNDFiM2EuLmJjNTg1MzhmMWYyYTcwNmY0MzVj MzMwYjgxZTdlNWQ0ZGEwOGI0NmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCkBAIC04MTYsNiArODE2LDEwIEBAIHN1YiBHZW5l cmF0ZUhlYWRlcgogICAgICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCAiICAgIGJvb2wgcHV0RGVs ZWdhdGUoSlNDOjpFeGVjU3RhdGUqLCBjb25zdCBKU0M6OklkZW50aWZpZXImLCBKU0M6OkpTVmFs dWUsIEpTQzo6UHV0UHJvcGVydHlTbG90Jik7XG4iKSBpZiAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0 cmlidXRlcy0+eyJEZWxlZ2F0aW5nUHV0RnVuY3Rpb24ifTsKICAgICB9CiAKKyAgICBpZiAoISRo YXNQYXJlbnQpIHsKKyAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAgICBzdGF0aWMgdm9p ZCBkZXN0cm95KEpTQzo6SlNDZWxsKik7XG4iKTsKKyAgICB9CisKICAgICAjIENsYXNzIGluZm8K ICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCAiICAgIHN0YXRpYyBjb25zdCBKU0M6OkNsYXNzSW5m byBzX2luZm87XG5cbiIpOwogCkBAIC05NTMsNiArOTU3LDcgQEAgc3ViIEdlbmVyYXRlSGVhZGVy CiAgICAgaWYgKCEkaGFzUGFyZW50KSB7CiAgICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICIg ICAgJGltcGxUeXBlKiBpbXBsKCkgY29uc3QgeyByZXR1cm4gbV9pbXBsOyB9XG4iKTsKICAgICAg ICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAgICB2b2lkIHJlbGVhc2VJbXBsKCkgeyBtX2ltcGwt PmRlcmVmKCk7IG1faW1wbCA9IDA7IH1cblxuIik7CisgICAgICAgIHB1c2goQGhlYWRlckNvbnRl bnQsICIgICAgdm9pZCByZWxlYXNlSW1wbElmTm90TnVsbCgpIHsgaWYgKG1faW1wbCkgeyBtX2lt cGwtPmRlcmVmKCk7IG1faW1wbCA9IDA7IH0gfVxuXG4iKTsKICAgICAgICAgcHVzaChAaGVhZGVy Q29udGVudCwgInByaXZhdGU6XG4iKTsKICAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAg ICAkaW1wbFR5cGUqIG1faW1wbDtcbiIpOwogICAgIH0gZWxzaWYgKCRkYXRhTm9kZS0+ZXh0ZW5k ZWRBdHRyaWJ1dGVzLT57IkdlbmVyYXRlTmF0aXZlQ29udmVydGVyIn0pIHsKQEAgLTE2NzAsNiAr MTY3NSwyMCBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbgogICAgICAgICBwdXNoKEBpbXBs Q29udGVudCwgIn1cblxuIik7CiAgICAgfQogCisgICAgaWYgKCEkaGFzUGFyZW50KSB7CisgICAg ICAgICMgRklYTUU6IFRoaXMgZGVzdHJveSBmdW5jdGlvbiBzaG91bGQgbm90IGJlIG5lY2Vzc2Fy eSwgYXMgCisgICAgICAgICMgYSBmaW5hbGl6ZXIgc2hvdWxkIGJlIGNhbGxlZCBmb3IgZWFjaCBE T00gb2JqZWN0IHdyYXBwZXIuCisgICAgICAgICMgSG93ZXZlciwgdGhhdCBzZWVtcyBub3QgdG8g YmUgdGhlIGNhc2UsIHNvIHRoaXMgaGFzIGJlZW4KKyAgICAgICAgIyBhZGRlZCBiYWNrIHRvIGF2 b2lkIGxlYWtpbmcgd2hpbGUgd2UgZmlndXJlIG91dCB3aHkgdGhlCisgICAgICAgICMgZmluYWxp emVycyBhcmUgbm90IGFsd2F5cyBnZXR0aW5nIGNhbGxlZC4gVGhlIHdvcmsgdHJhY2tpbmcKKyAg ICAgICAgIyB0aGUgZmluYWxpemVyIGlzc3VlIGlzIGJlaW5nIHRyYWNrZWQgaW4gaHR0cDovL3dl YmtpdC5vcmcvYi83NTQ1MQorICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgInZvaWQgJHtjbGFz c05hbWV9OjpkZXN0cm95KEpTQzo6SlNDZWxsKiBjZWxsKVxuIik7CisgICAgICAgIHB1c2goQGlt cGxDb250ZW50LCAie1xuIik7CisgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgICR7Y2xh c3NOYW1lfSogdGhpc09iamVjdCA9IGpzQ2FzdDwke2NsYXNzTmFtZX0qPihjZWxsKTtcbiIpOwor ICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICB0aGlzT2JqZWN0LT5yZWxlYXNlSW1wbElm Tm90TnVsbCgpO1xuIik7CisgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAifVxuXG4iKTsKKyAg ICB9CisKICAgICBteSAkaGFzR2V0dGVyID0gJG51bUF0dHJpYnV0ZXMgPiAwIAogICAgICAgICAg ICAgICAgICB8fCAhJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiT21pdENvbnN0cnVj dG9yIn0gCiAgICAgICAgICAgICAgICAgIHx8ICRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVz LT57Ikhhc0luZGV4R2V0dGVyIn0K