75447 2012-01-02 14:21:22 -0800 Ambiguous if-then-else in Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm 2012-01-04 14:03:03 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 isanbard andersca andersca ap enrica oliver oldest_to_newest 528581 0 isanbard 2012-01-02 14:21:22 -0800 Clang discovered an ambiguous if-then-else in Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm. Here's the code (around line 254): if (archive) if ([types containsObject:WebArchivePboardType]) [self setData:[archive data] forType:WebArchivePboardType]; else { // We should not have declared types that we aren't going to write (4031826). ASSERT(![types containsObject:NSRTFDPboardType]); ASSERT(![types containsObject:WebArchivePboardType]); } Clang suggests adding explicit braces. Indeed, the indenting suggests that the code should be different from what it is. 528864 1 ap 2012-01-03 11:06:43 -0800 This was introduced in <http://trac.webkit.org/changeset/21533>. No release build impact though, as it's only assertions. How did clang discover this? Did you use static analyzer, or different warnings flags with a regular build? 528978 2 isanbard 2012-01-03 13:00:44 -0800 I was using ToT clang and doing a normal build. I believe it's a new warning flag that's on by default. 529729 3 121145 andersca 2012-01-04 13:59:44 -0800 Created attachment 121145 Patch 529734 4 andersca 2012-01-04 14:03:03 -0800 Committed r104066: <http://trac.webkit.org/changeset/104066> 121145 2012-01-04 13:59:44 -0800 2012-01-04 14:01:14 -0800 Patch bug-75447-20120104140021.patch text/plain 1959 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0MDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggZjQxZTc0MTMx OTA3MmYwMTY5YmY1OWQ2NzcwMDczYzhiMDNiNmY1NC4uNTU5ZmU0Nzg4M2JiYTNmMjk3N2QyNWYy NmNhNjVhNmYxOTdlNWJjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEy LTAxLTA0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAg QW1iaWd1b3VzIGlmLXRoZW4tZWxzZSBpbiBTb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dlYk5TUGFz dGVib2FyZEV4dHJhcy5tbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzU0NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSZXNvbHZlIHRoZSBhbWJpZ3VpdHkuCisKKyAgICAgICAgKiBNaXNjL1dlYk5TUGFz dGVib2FyZEV4dHJhcy5tbToKKyAgICAgICAgKC1bTlNQYXN0ZWJvYXJkIF93ZWJfd3JpdGVJbWFn ZTplbGVtZW50OlVSTDp0aXRsZTphcmNoaXZlOnR5cGVzOnNvdXJjZTpdKToKKwogMjAxMi0wMS0w NCAgTWlobmVhIE92aWRlbmllICA8bWlobmVhQGFkb2JlLmNvbT4KIAogICAgICAgICBbTWFjXUZp eCBidWlsZCBhZnRlciBjaGFuZ2VzZXQgMTAzOTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L21hYy9NaXNjL1dlYk5TUGFzdGVib2FyZEV4dHJhcy5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL01p c2MvV2ViTlNQYXN0ZWJvYXJkRXh0cmFzLm1tCmluZGV4IGY1Yzc0MzZlY2FmNWRkNDgzOGY0ZmYy NTRmOWRhYzg1ZTQ4YTBhYWIuLmU0NDA0ZjcxMGM4ZTc0M2ZkMzczNjEzOGUyMzJjMzRjZjQ0NDll NzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViTlNQYXN0ZWJvYXJkRXh0 cmFzLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViTlNQYXN0ZWJvYXJkRXh0cmFz Lm1tCkBAIC0yNDgsMTQgKzI0OCwxNSBAQCBzdGF0aWMgQ2FjaGVkSW1hZ2UqIGltYWdlRnJvbUVs ZW1lbnQoRE9NRWxlbWVudCAqZG9tRWxlbWVudCkKICAgICAgICAgICAgIFtzZWxmIHNldERhdGE6 W2VsZW1lbnQgX2ltYWdlVElGRlJlcHJlc2VudGF0aW9uXSBmb3JUeXBlOk5TVElGRlBib2FyZFR5 cGVdOwogICAgIH0KICAgICAKLSAgICBpZiAoYXJjaGl2ZSkKKyAgICBpZiAoYXJjaGl2ZSkgewog ICAgICAgICBpZiAoW3R5cGVzIGNvbnRhaW5zT2JqZWN0OldlYkFyY2hpdmVQYm9hcmRUeXBlXSkK ICAgICAgICAgICAgIFtzZWxmIHNldERhdGE6W2FyY2hpdmUgZGF0YV0gZm9yVHlwZTpXZWJBcmNo aXZlUGJvYXJkVHlwZV07Ci0gICAgZWxzZSB7Ci0gICAgICAgIC8vIFdlIHNob3VsZCBub3QgaGF2 ZSBkZWNsYXJlZCB0eXBlcyB0aGF0IHdlIGFyZW4ndCBnb2luZyB0byB3cml0ZSAoNDAzMTgyNiku Ci0gICAgICAgIEFTU0VSVCghW3R5cGVzIGNvbnRhaW5zT2JqZWN0Ok5TUlRGRFBib2FyZFR5cGVd KTsKLSAgICAgICAgQVNTRVJUKCFbdHlwZXMgY29udGFpbnNPYmplY3Q6V2ViQXJjaGl2ZVBib2Fy ZFR5cGVdKTsKKyAgICAgICAgcmV0dXJuOwogICAgIH0KKworICAgIC8vIFdlIHNob3VsZCBub3Qg aGF2ZSBkZWNsYXJlZCB0eXBlcyB0aGF0IHdlIGFyZW4ndCBnb2luZyB0byB3cml0ZSAoNDAzMTgy NikuCisgICAgQVNTRVJUKCFbdHlwZXMgY29udGFpbnNPYmplY3Q6TlNSVEZEUGJvYXJkVHlwZV0p OworICAgIEFTU0VSVCghW3R5cGVzIGNvbnRhaW5zT2JqZWN0OldlYkFyY2hpdmVQYm9hcmRUeXBl XSk7CiB9CiAKIC0gKGlkKV93ZWJfZGVjbGFyZUFuZFdyaXRlRHJhZ0ltYWdlRm9yRWxlbWVudDoo RE9NRWxlbWVudCAqKWVsZW1lbnQK