75445 2012-01-02 13:35:03 -0800 [Qt][WK2] QQuickWebView breaks when an empty url is loaded (debug mode) 2012-01-06 05:34:47 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Critical --- 1 rafael.lobo rafael.lobo cmarcelo hausmann jesus kenneth menard noam webkit.review.bot zoltan oldest_to_newest 528576 0 rafael.lobo 2012-01-02 13:35:03 -0800 I've tested it on Chrome and Safari, and both of them just ignore the request (once it is an empty url) and stays in the same page. If we don't handle this and request to load an empty url, an empty ResourceRequest is created, asserting on MainResourceLoader::willSendRequest. This behavior is well handled when we are using substitute data with an empty url as base url: the base url is changed to "about:blank", thus not crashing at all. It makes sense to ignore empty url requests, but it is weird that we crash when we get it. Right now, QQuickWebView starts with an empty url and no content displayed. Once we load something with it, we can never return to the original state: no url and no content (this is how I've found this bug). This use case is very appropriate to create test cases, but I can't think of anything else where this would fit well. A possible solution is to make QQuickWebView start with the url "about:blank" instead of a blank url, and ignore loads for empty urls as other browsers do (and add this to the documentation). We could also change the way WebCore works handling it there, but I still couldn't find out why that assert is there and I suppose there's a good reason. What you guys think? 528722 1 rafael.lobo 2012-01-03 04:25:22 -0800 Ignoring the assert there, the url is loaded just like it was expected... it loads an empty page. The code on MainResourceLoader is very old, it is possible that the assert is no longer necessary but I'm still looking on it. The comment preceding the assert on MainResourceLoader::willSendRequest is very confusing, it says the following code doesn't have any asserts for example. :-/ 529041 2 120992 rafael.lobo 2012-01-03 14:11:48 -0800 Created attachment 120992 Patch 529042 3 rafael.lobo 2012-01-03 14:13:13 -0800 (In reply to comment #2) > Created an attachment (id=120992) [details] > Patch As we've discussed on IRC, it make sense to ignore an empty url when it is requested to be loaded. 529053 4 120992 kenneth 2012-01-03 14:15:47 -0800 Comment on attachment 120992 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120992&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:757 > void QQuickWebView::load(const QUrl& url) > { > + if (url.isEmpty()) > + return; > + > Q_D(QQuickWebView); > d->webPageProxy->loadURL(url.toString()); > } Should we emit load failed? a user might call load while doing another load which say reached 50% and with this change I believe it will just continue loading that page. Is this intended and can such a case be tested? 529448 5 rafael.lobo 2012-01-04 04:02:24 -0800 (In reply to comment #4) > (From update of attachment 120992 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120992&action=review > > > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:757 > > void QQuickWebView::load(const QUrl& url) > > { > > + if (url.isEmpty()) > > + return; > > + > > Q_D(QQuickWebView); > > d->webPageProxy->loadURL(url.toString()); > > } > > Should we emit load failed? a user might call load while doing another load which say reached 50% and with this change I believe it will just continue loading that page. Is this intended and can such a case be tested? Maybe load fail would look like we actually tried to load it but we are just ignoring. I've looked how Chrome behaves and it keeps the old page loading, like nothing has happened (as we're doing). Safari reloads the same page when you use an empty url. 529455 6 kenneth 2012-01-04 04:17:47 -0800 anyway a test for that is needed. 529483 7 121103 rafael.lobo 2012-01-04 05:55:33 -0800 Created attachment 121103 Patch 531047 8 121103 webkit.review.bot 2012-01-06 05:34:42 -0800 Comment on attachment 121103 Patch Clearing flags on attachment: 121103 Committed r104287: <http://trac.webkit.org/changeset/104287> 531048 9 webkit.review.bot 2012-01-06 05:34:47 -0800 All reviewed patches have been landed. Closing bug. 120992 2012-01-03 14:11:48 -0800 2012-01-04 05:55:26 -0800 Patch bug-75445-20120103191145.patch text/plain 3452 rafael.lobo U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzOTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGFhNmVjNDhiNWQzNWU1 OWMyMDk0NjNhMWNmZmU2Yzk4YzMzMjYzMS4uZGZlNWIwYjFkMTQzMzg3M2I2MzAyMDNkYzdkYmI1 Mzk1ZDdkMjAyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTAxLTAzICBSYWZh ZWwgQnJhbmRhbyAgPHJhZmFlbC5sb2JvQG9wZW5ib3NzYS5vcmc+CiAKKyAgICAgICAgW1F0XVtX SzJdIFFRdWlja1dlYlZpZXcgYnJlYWtzIHdoZW4gYW4gZW1wdHkgdXJsIGlzIGxvYWRlZCAoZGVi dWcgbW9kZSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc1NDQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwOgorICAgICAgICAoUVF1aWNrV2Vi Vmlldzo6bG9hZCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9X ZWJWaWV3L3RzdF9sb2FkVXJsLnFtbDogQWRkZWQgYSB0ZXN0IHRvIGNoZWNrCisgICAgICAgIGlm IGEgcmVxdWVzdCB0byBsb2FkIGFuIGVtcHR5IHVybCBpcyBpZ25vcmVkLiBVc2VyIHNob3VsZCB1 c2UgJ2Fib3V0OmJsYW5rJyBpbnN0ZWFkCisgICAgICAgIHRvIGdldCBhbiBlbXB0eSBwYWdlIGxv YWRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL3FtbHRlc3Rz LnBybzoKKworMjAxMi0wMS0wMyAgUmFmYWVsIEJyYW5kYW8gIDxyYWZhZWwubG9ib0BvcGVuYm9z c2Eub3JnPgorCiAgICAgICAgIFtRdF1bV0syXSB0c3RfZmF2SWNvbkxvYWQucW1sIGNyYXNoZXMg b24gZGVidWcgbW9kZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzU0NDgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9xcXVpY2t3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1 aWNrd2Vidmlldy5jcHAKaW5kZXggNGRiZjkzODZkYWI3MjQ1ZjhhYmY0ZmFhNmM5MTAzMDAxMzQ4 NTM0ZS4uYjhiYTNkM2ZhM2Y0Mzc4MWFlMjdkMzE3MDFiYWQ4MmUwNTkyN2IzYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCkBAIC03 NDksNiArNzQ5LDkgQEAgUVF1aWNrV2ViUGFnZSogUVF1aWNrV2ViVmlldzo6cGFnZSgpCiAKIHZv aWQgUVF1aWNrV2ViVmlldzo6bG9hZChjb25zdCBRVXJsJiB1cmwpCiB7CisgICAgaWYgKHVybC5p c0VtcHR5KCkpCisgICAgICAgIHJldHVybjsKKwogICAgIFFfRChRUXVpY2tXZWJWaWV3KTsKICAg ICBkLT53ZWJQYWdlUHJveHktPmxvYWRVUkwodXJsLnRvU3RyaW5nKCkpOwogfQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3 L3RzdF9sb2FkVXJsLnFtbCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMv cW1sdGVzdHMvV2ViVmlldy90c3RfbG9hZFVybC5xbWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDNhZGEyNGY2MTNk ZDZlOGJmYzVmNjVjYTg3YTgxOTU3MzRjNDNlMwotLS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvV2ViVmlldy90c3RfbG9hZFVy bC5xbWwKQEAgLTAsMCArMSwzNiBAQAoraW1wb3J0IFF0UXVpY2sgMi4wCitpbXBvcnQgUXRUZXN0 IDEuMAoraW1wb3J0IFF0V2ViS2l0IDMuMAorCitXZWJWaWV3IHsKKyAgICBpZDogd2ViVmlldwor ICAgIHByb3BlcnR5IHZhcmlhbnQgbGFzdFVybAorCisgICAgU2lnbmFsU3B5IHsKKyAgICAgICAg aWQ6IHNweQorICAgICAgICB0YXJnZXQ6IHdlYlZpZXcKKyAgICAgICAgc2lnbmFsTmFtZTogImxv YWRTdWNjZWVkZWQiCisgICAgfQorCisgICAgVGVzdENhc2UgeworICAgICAgICBpZDogdGVzdAor ICAgICAgICBuYW1lOiAiV2ViVmlld0xvYWRVcmwiCisgICAgICAgIGZ1bmN0aW9uIHRlc3RfbG9h ZElnbm9yZUVtcHR5VXJsKCkgeworICAgICAgICAgICAgY29tcGFyZShzcHkuY291bnQsIDApCisg ICAgICAgICAgICB3ZWJWaWV3LmxvYWQoUXQucmVzb2x2ZWRVcmwoIi4uL2NvbW1vbi90ZXN0MS5o dG1sIikpCisgICAgICAgICAgICBzcHkud2FpdCgpCisgICAgICAgICAgICBjb21wYXJlKHNweS5j b3VudCwgMSkKKyAgICAgICAgICAgIGxhc3RVcmwgPSB3ZWJWaWV3LnVybAorCisgICAgICAgICAg ICB3ZWJWaWV3LmxvYWQoJycpCisgICAgICAgICAgICB3YWl0KDEwMDApCisgICAgICAgICAgICBj b21wYXJlKHNweS5jb3VudCwgMSkKKyAgICAgICAgICAgIGNvbXBhcmUod2ViVmlldy51cmwsIGxh c3RVcmwpCisKKyAgICAgICAgICAgIHdlYlZpZXcubG9hZCgnYWJvdXQ6YmxhbmsnKQorICAgICAg ICAgICAgc3B5LndhaXQoKQorICAgICAgICAgICAgY29tcGFyZShzcHkuY291bnQsIDIpCisgICAg ICAgICAgICBjb21wYXJlKHdlYlZpZXcudXJsLCAnYWJvdXQ6YmxhbmsnKQorICAgICAgICB9Cisg ICAgfQorfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0 cy9xbWx0ZXN0cy9xbWx0ZXN0cy5wcm8gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3Rlc3RzL3FtbHRlc3RzL3FtbHRlc3RzLnBybwppbmRleCA3ZTg1N2IyMWFjNTJkZmE4ZThmMTVl ZjU1OWFjOWM0MTRhMTFmYzJhLi42YjkwM2VmN2ViNTAwZDFhNzliZDkzNThkMTBlY2YwNjg1Njhh NjVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3Ft bHRlc3RzL3FtbHRlc3RzLnBybworKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3Rlc3RzL3FtbHRlc3RzL3FtbHRlc3RzLnBybwpAQCAtMjcsNiArMjcsNyBAQCBPVEhFUl9GSUxF UyArPSBcCiAgICAgV2ViVmlldy90c3RfaXRlbVNlbGVjdG9yLnFtbCBcCiAgICAgV2ViVmlldy90 c3RfamF2YVNjcmlwdERpYWxvZ3MucW1sIFwKICAgICBXZWJWaWV3L3RzdF9sb2FkRmFpbC5xbWwg XAorICAgIFdlYlZpZXcvdHN0X2xvYWRJZ25vcmUucW1sIFwKICAgICBXZWJWaWV3L3RzdF9sb2Fk SHRtbC5xbWwgXAogICAgIFdlYlZpZXcvdHN0X2xvYWRQcm9ncmVzcy5xbWwgXAogICAgIFdlYlZp ZXcvdHN0X2xvYWRQcm9ncmVzc1NpZ25hbC5xbWwgXAo= 121103 2012-01-04 05:55:33 -0800 2012-01-06 05:34:42 -0800 Patch bug-75445-20120104105530.patch text/plain 3911 rafael.lobo U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0MDI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjY2ZTY4N2VjY2U5MmZl MDM3YjJkOWQ0YzdlYWQwMGE1ZjYwNGZmOS4uZTExZTRlNzRmMjJlOGY0OTU5YWRiMjZkNDg2ODQz ZWU2MmU1ZWE1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAxLTA0ICBSYWZh ZWwgQnJhbmRhbyAgPHJhZmFlbC5sb2JvQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1F0XVtX SzJdIFFRdWlja1dlYlZpZXcgYnJlYWtzIHdoZW4gYW4gZW1wdHkgdXJsIGlzIGxvYWRlZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU0NDUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvcXQvcXF1aWNrd2Vidmlldy5jcHA6CisgICAgICAgIChRUXVpY2tXZWJWaWV3Ojpsb2FkKToK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X2xv YWRVcmwucW1sOiBDaGVjayBpZiBhIHJlcXVlc3QgdG8gbG9hZAorICAgICAgICBhbiBlbXB0eSB1 cmwgaXMgaWdub3JlZC4gJ2Fib3V0OmJsYW5rJyBzaG91bGQgYmUgdXNlZCBpbnN0ZWFkIHRvIGxv YWQgYW4gZW1wdHkgcGFnZS4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRl c3RzL3FtbHRlc3RzLnBybzoKKwogMjAxMi0wMS0wMyAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5z ZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBDbGVhbiB1cCBRdCBzcGVj aWZpYyBwYXJ0IG9mIGVkaXRvclN0YXRlKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCmluZGV4IDRkYmY5Mzg2ZGFiNzI0NWY4YWJmNGZh YTZjOTEwMzAwMTM0ODUzNGUuLmI4YmEzZDNmYTNmNDM3ODFhZTI3ZDMxNzAxYmFkODJlMDU5Mjdi M2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vi dmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2 aWV3LmNwcApAQCAtNzQ5LDYgKzc0OSw5IEBAIFFRdWlja1dlYlBhZ2UqIFFRdWlja1dlYlZpZXc6 OnBhZ2UoKQogCiB2b2lkIFFRdWlja1dlYlZpZXc6OmxvYWQoY29uc3QgUVVybCYgdXJsKQogewor ICAgIGlmICh1cmwuaXNFbXB0eSgpKQorICAgICAgICByZXR1cm47CisKICAgICBRX0QoUVF1aWNr V2ViVmlldyk7CiAgICAgZC0+d2ViUGFnZVByb3h5LT5sb2FkVVJMKHVybC50b1N0cmluZygpKTsK IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1s dGVzdHMvV2ViVmlldy90c3RfbG9hZFVybC5xbWwgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X2xvYWRVcmwucW1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LmQ3MDk3NmM0YTljMTM3MWMzOTg0MmUwNWY0MzA2ZGFlOWU2MWJhY2YKLS0tIC9kZXYvbnVsbAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZp ZXcvdHN0X2xvYWRVcmwucW1sCkBAIC0wLDAgKzEsNTUgQEAKK2ltcG9ydCBRdFF1aWNrIDIuMAor aW1wb3J0IFF0VGVzdCAxLjAKK2ltcG9ydCBRdFdlYktpdCAzLjAKKworV2ViVmlldyB7CisgICAg aWQ6IHdlYlZpZXcKKyAgICBwcm9wZXJ0eSB2YXJpYW50IGxhc3RVcmwKKyAgICBwcm9wZXJ0eSBi b29sIHdhdGNoUHJvZ3Jlc3M6IGZhbHNlCisKKyAgICBvbkxvYWRQcm9ncmVzc0NoYW5nZWQ6IHsK KyAgICAgICAgaWYgKHdhdGNoUHJvZ3Jlc3MgJiYgd2ViVmlldy5sb2FkUHJvZ3Jlc3MgIT0gMTAw KSB7CisgICAgICAgICAgICB3YXRjaFByb2dyZXNzID0gZmFsc2UKKyAgICAgICAgICAgIGxvYWQo JycpCisgICAgICAgIH0KKyAgICB9CisKKyAgICBTaWduYWxTcHkgeworICAgICAgICBpZDogc3B5 CisgICAgICAgIHRhcmdldDogd2ViVmlldworICAgICAgICBzaWduYWxOYW1lOiAibG9hZFN1Y2Nl ZWRlZCIKKyAgICB9CisKKyAgICBUZXN0Q2FzZSB7CisgICAgICAgIGlkOiB0ZXN0CisgICAgICAg IG5hbWU6ICJXZWJWaWV3TG9hZFVybCIKKyAgICAgICAgZnVuY3Rpb24gdGVzdF9sb2FkSWdub3Jl RW1wdHlVcmwoKSB7CisgICAgICAgICAgICBjb21wYXJlKHNweS5jb3VudCwgMCkKKyAgICAgICAg ICAgIHZhciB1cmwgPSBRdC5yZXNvbHZlZFVybCgiLi4vY29tbW9uL3Rlc3QxLmh0bWwiKQorCisg ICAgICAgICAgICB3ZWJWaWV3LmxvYWQodXJsKQorICAgICAgICAgICAgc3B5LndhaXQoKQorICAg ICAgICAgICAgY29tcGFyZShzcHkuY291bnQsIDEpCisgICAgICAgICAgICBjb21wYXJlKHdlYlZp ZXcudXJsLCB1cmwpCisKKyAgICAgICAgICAgIGxhc3RVcmwgPSB3ZWJWaWV3LnVybAorICAgICAg ICAgICAgd2ViVmlldy5sb2FkKCcnKQorICAgICAgICAgICAgd2FpdCgxMDAwKQorICAgICAgICAg ICAgY29tcGFyZShzcHkuY291bnQsIDEpCisgICAgICAgICAgICBjb21wYXJlKHdlYlZpZXcudXJs LCBsYXN0VXJsKQorCisgICAgICAgICAgICB3ZWJWaWV3LmxvYWQoJ2Fib3V0OmJsYW5rJykKKyAg ICAgICAgICAgIHNweS53YWl0KCkKKyAgICAgICAgICAgIGNvbXBhcmUoc3B5LmNvdW50LCAyKQor ICAgICAgICAgICAgY29tcGFyZSh3ZWJWaWV3LnVybCwgJ2Fib3V0OmJsYW5rJykKKworICAgICAg ICAgICAgLy8gSXQgc2hvdWxkbid0IGludGVycnVwdCBhbnkgb25nb2luZyBsb2FkIHdoZW4gYW4g ZW1wdHkgdXJsIGlzIHVzZWQuCisgICAgICAgICAgICB3YXRjaFByb2dyZXNzID0gdHJ1ZQorICAg ICAgICAgICAgd2ViVmlldy5sb2FkKHVybCkKKyAgICAgICAgICAgIHNweS53YWl0KCkKKyAgICAg ICAgICAgIGNvbXBhcmUoc3B5LmNvdW50LCAzKQorICAgICAgICAgICAgdmVyaWZ5KCF3YXRjaFBy b2dyZXNzKQorICAgICAgICAgICAgY29tcGFyZSh3ZWJWaWV3LnVybCwgdXJsKQorICAgICAgICB9 CisgICAgfQorfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90 ZXN0cy9xbWx0ZXN0cy9xbWx0ZXN0cy5wcm8gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3Rlc3RzL3FtbHRlc3RzL3FtbHRlc3RzLnBybwppbmRleCA3ZTg1N2IyMWFjNTJkZmE4ZThm MTVlZjU1OWFjOWM0MTRhMTFmYzJhLi42YjkwM2VmN2ViNTAwZDFhNzliZDkzNThkMTBlY2YwNjg1 NjhhNjVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3Rz L3FtbHRlc3RzL3FtbHRlc3RzLnBybworKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3Rlc3RzL3FtbHRlc3RzL3FtbHRlc3RzLnBybwpAQCAtMjcsNiArMjcsNyBAQCBPVEhFUl9G SUxFUyArPSBcCiAgICAgV2ViVmlldy90c3RfaXRlbVNlbGVjdG9yLnFtbCBcCiAgICAgV2ViVmll dy90c3RfamF2YVNjcmlwdERpYWxvZ3MucW1sIFwKICAgICBXZWJWaWV3L3RzdF9sb2FkRmFpbC5x bWwgXAorICAgIFdlYlZpZXcvdHN0X2xvYWRJZ25vcmUucW1sIFwKICAgICBXZWJWaWV3L3RzdF9s b2FkSHRtbC5xbWwgXAogICAgIFdlYlZpZXcvdHN0X2xvYWRQcm9ncmVzcy5xbWwgXAogICAgIFdl YlZpZXcvdHN0X2xvYWRQcm9ncmVzc1NpZ25hbC5xbWwgXAo=