75441 2012-01-02 10:55:22 -0800 getComputedStyle for outline is not implemented. 2012-01-03 13:08:06 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 menard menard darin hclam kling koivisto macpherson simon.fraser tonikitoo tony webkit.review.bot oldest_to_newest 528557 0 menard 2012-01-02 10:55:22 -0800 getComputedStyle for outline is not implemented. 528558 1 120888 menard 2012-01-02 10:57:09 -0800 Created attachment 120888 Patch 528560 2 120888 menard 2012-01-02 11:11:59 -0800 Comment on attachment 120888 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120888&action=review > LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-shorthand.html:33 > +shouldBe("computedStyle.getPropertyValue('outline')", "'rgb(0, 0, 0) solid 32px'"); I'm a bit puzzled on that return value. http://www.w3.org/TR/CSS2/ui.html#propdef-outline-color specify the default value to be invert (if supported) otherwise as explained "the 'outline-color' property is the value of the 'color' property, similar to the initial value of the 'border-top-color' property." so black here. My hesitation comes from "Computed value: as specified", in that case I didn't specified one so it should return nothing as it fallback to the default color property. It is different from let say border-color where each border-color sides computed value are "when taken from the 'color' property, the computed value of 'color'; otherwise, as specified". So should I return "solid 32px" rather than "rgb(0, 0, 0) solid 32px"? At the end I prefer the value "rgb(0, 0, 0) solid 32px" as the default value is not obvious, if the user is interested in the computed value having the actual displayed color is nice no matter if specified or not, just like border-color especially the fact that the computed color of the outline may not be obvious. On a side note Opera returns "solid 32px" on the same test case. IE and FF doesn't work for this case. 528571 3 menard 2012-01-02 13:03:39 -0800 Antonio, what do you think about my comment as I added after you r+ it. 528644 4 tonikitoo 2012-01-02 19:59:50 -0800 I'd say returning the current value is acceptable as long as we file a bug to actually return the "proper" value. Being compatible with Opera would be good enough to leave it as is? Is Opera returning the right value? Is our current return value "worst or better"? Etc ... These are questions to be answered by this follow up bug I am suggesting. (In reply to comment #2) > (From update of attachment 120888 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120888&action=review > > > LayoutTests/fast/css/getComputedStyle/getComputedStyle-outline-shorthand.html:33 > > +shouldBe("computedStyle.getPropertyValue('outline')", "'rgb(0, 0, 0) solid 32px'"); > > I'm a bit puzzled on that return value. > > http://www.w3.org/TR/CSS2/ui.html#propdef-outline-color specify the default value to be invert (if supported) otherwise as explained "the 'outline-color' property is the value of the 'color' property, similar to the initial value of the 'border-top-color' property." so black here. My hesitation comes from "Computed value: as specified", in that case I didn't specified one so it should return nothing as it fallback to the default color property. It is different from let say border-color where each border-color sides computed value are "when taken from the 'color' property, the computed value of 'color'; otherwise, as specified". So should I return "solid 32px" rather than "rgb(0, 0, 0) solid 32px"? At the end I prefer the value "rgb(0, 0, 0) solid 32px" as the default value is not obvious, if the user is interested in the computed value having the actual displayed color is nice no matter if specified or not, just like border-color especially the fact that the computed color of the outline may not be obvious. > > On a side note Opera returns "solid 32px" on the same test case. IE and FF doesn't work for this case. 528728 5 120888 webkit.review.bot 2012-01-03 04:39:18 -0800 Comment on attachment 120888 Patch Clearing flags on attachment: 120888 Committed r103934: <http://trac.webkit.org/changeset/103934> 528729 6 webkit.review.bot 2012-01-03 04:39:23 -0800 All reviewed patches have been landed. Closing bug. 528952 7 hclam 2012-01-03 12:17:55 -0800 This change seems to create a performance regression for Chromium, see: http://build.chromium.org/p/chromium.perf/builders/Mac10.5%20Perf%281%29/builds/12953 The increase of runtime is coming from WebKit changes between 103933 and 103936, which seems to be coming from this change. Any ideas why this happens? 528958 8 menard 2012-01-03 12:25:02 -0800 (In reply to comment #7) > This change seems to create a performance regression for Chromium, see: > > http://build.chromium.org/p/chromium.perf/builders/Mac10.5%20Perf%281%29/builds/12953 > > The increase of runtime is coming from WebKit changes between 103933 and 103936, which seems to be coming from this change. Any ideas why this happens? What benchmark is regressing/where is this benchmark? This patch adds a new feature, a new code path was added so I'm wondering how a bench could hit that one (but maybe I'm wrong). 528968 9 hclam 2012-01-03 12:42:52 -0800 (In reply to comment #8) > (In reply to comment #7) > > This change seems to create a performance regression for Chromium, see: > > > > http://build.chromium.org/p/chromium.perf/builders/Mac10.5%20Perf%281%29/builds/12953 > > > > The increase of runtime is coming from WebKit changes between 103933 and 103936, which seems to be coming from this change. Any ideas why this happens? > > What benchmark is regressing/where is this benchmark? This patch adds a new feature, a new code path was added so I'm wondering how a bench could hit that one (but maybe I'm wrong). The benchmark runs through several sites, in particular only www.techcrunch.com in the test uses getPropertyValue. Does call getPropertyValue('outline') goes through this code path? 528969 10 menard 2012-01-03 12:46:20 -0800 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > This change seems to create a performance regression for Chromium, see: > > > > > > http://build.chromium.org/p/chromium.perf/builders/Mac10.5%20Perf%281%29/builds/12953 > > > > > > The increase of runtime is coming from WebKit changes between 103933 and 103936, which seems to be coming from this change. Any ideas why this happens? > > > > What benchmark is regressing/where is this benchmark? This patch adds a new feature, a new code path was added so I'm wondering how a bench could hit that one (but maybe I'm wrong). > > The benchmark runs through several sites, in particular only www.techcrunch.com in the test uses getPropertyValue. Does call getPropertyValue('outline') goes through this code path? Yes we implemented it finally. So before the patch getPropertyValue('outline') would early return and return nothing, versus now it actually does stuff and return the correct value. So that explain that it is slower because we finally do something. Now the bench says it is slower but what is the magnitude? To me it sounds like a false alarm unless getting the outline property takes seconds. 528982 11 hclam 2012-01-03 13:08:06 -0800 Thanks for your info! Looks like this is a false alarm, revert WebKit merge didn't help the situation. 120888 2012-01-02 10:57:09 -0800 2012-01-03 04:39:18 -0800 Patch bug-75441-20120102155702.patch text/plain 10415 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzODk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTZlYjgzMGNmMTIxMGQw MTMwYjgwYjk1OTg2MDhiYmNkMWJhOTRlOS4uMWZmNmMyYjk1YWIwZGZiNmMwOTZjNmE3YjZhMDVh NmIyNzU2ZDYxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAxLTAyICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIGdldENv bXB1dGVkU3R5bGUgZm9yIG91dGxpbmUgaXMgbm90IGltcGxlbWVudGVkLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzU0NDEKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgZ2V0Q29tcHV0ZWRT dHlsZSBmb3Igb3V0bGluZS4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy9nZXRDb21wdXRlZFN0 eWxlL2dldENvbXB1dGVkU3R5bGUtb3V0bGluZS1zaG9ydGhhbmQuaHRtbAorCisgICAgICAgICog Y3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpD U1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb246OmdldFByb3BlcnR5Q1NTVmFsdWUpOgorCiAyMDEy LTAxLTAxICBBbmRyZWFzIEtsaW5nICA8YXdlc29tZWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAg ICBDbGVhciBIVE1MQ29sbGVjdGlvbidzIGludGVybmFsIGNhY2hlIG9uIGNvbnN0cnVjdGlvbi4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRp b24uY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5j cHAKaW5kZXggMGQxYzY1NjFlZDVkYzYxMTNmMjU4ZTJhNmNkYTIyOTc3ZjRkYjA1My4uNWU1ZDI4 YzQ2YzU2NDJiMjY2MTg4YmIxOTA2NGQzOWE5ZjQ5Yzg4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAKQEAgLTIxODQsOCArMjE4 NCwxMSBAQCBQYXNzUmVmUHRyPENTU1ZhbHVlPiBDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb246 OmdldFByb3BlcnR5Q1NTVmFsdWUoaW50IHByb3BlcgogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIENTU1Byb3BlcnR5TWFyZ2luQm90dG9tLCBDU1NQcm9wZXJ0eU1hcmdp bkxlZnQgfTsKICAgICAgICAgICAgIHJldHVybiBnZXRDU1NQcm9wZXJ0eVZhbHVlc0ZvclNob3J0 aGFuZFByb3BlcnRpZXMocHJvcGVydGllcywgV1RGX0FSUkFZX0xFTkdUSChwcm9wZXJ0aWVzKSk7 CiAgICAgICAgIH0KLSAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eU91dGxpbmU6Ci0gICAgICAgICAg ICBicmVhazsKKyAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eU91dGxpbmU6IHsKKyAgICAgICAgICAg IGNvbnN0IGludCBwcm9wZXJ0aWVzWzNdID0geyBDU1NQcm9wZXJ0eU91dGxpbmVDb2xvciwgQ1NT UHJvcGVydHlPdXRsaW5lU3R5bGUsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgQ1NTUHJvcGVydHlPdXRsaW5lV2lkdGggfTsKKyAgICAgICAgICAgIHJldHVybiBnZXRD U1NQcm9wZXJ0eVZhbHVlc0ZvclNob3J0aGFuZFByb3BlcnRpZXMocHJvcGVydGllcywgV1RGX0FS UkFZX0xFTkdUSChwcm9wZXJ0aWVzKSk7CisgICAgICAgIH0KICAgICAgICAgY2FzZSBDU1NQcm9w ZXJ0eVBhZGRpbmc6IHsKICAgICAgICAgICAgIGNvbnN0IGludCBwcm9wZXJ0aWVzWzRdID0geyBD U1NQcm9wZXJ0eVBhZGRpbmdUb3AsIENTU1Byb3BlcnR5UGFkZGluZ1JpZ2h0LAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIENTU1Byb3BlcnR5UGFkZGluZ0JvdHRvbSwg Q1NTUHJvcGVydHlQYWRkaW5nTGVmdCB9OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDkxYTcwMmViZDM0MjM2MGE5MjFkOTk1 MDBiYzQ2MzUxZDk3ZGFjYTEuLjdjNmRhMTJjNTQ4YTExMDU3ZDcyZDU1MDhlODFmMTdhZTY2ZTEw NjMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wMS0wMiAgQWxleGlzIE1lbmFyZCAgPGFs ZXhpcy5tZW5hcmRAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBnZXRDb21wdXRlZFN0eWxlIGZv ciBvdXRsaW5lIGlzIG5vdCBpbXBsZW1lbnRlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTc1NDQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWRkIG5ldyB0ZXN0cyB0byBtYWtlIHN1cmUgd2UgcmV0dXJu IHRoZSBjb3JyZWN0IHZhbHVlcy4KKworICAgICAgICAqIGZhc3QvY3NzL2dldENvbXB1dGVkU3R5 bGUvZ2V0Q29tcHV0ZWRTdHlsZS1vdXRsaW5lLXNob3J0aGFuZC1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvY3NzL2dldENvbXB1dGVkU3R5bGUvZ2V0Q29tcHV0ZWRTdHlsZS1v dXRsaW5lLXNob3J0aGFuZC5odG1sOiBBZGRlZC4KKwogMjAxMi0wMS0wMiAgQ3NhYmEgT3N6dHJv Z29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIGZhc3QvZG9tL2h0bWxjb2xsZWN0 aW9uLXpvbWJpZXMuaHRtbCBmYWlscyBvbiBHVEsgYW5kIG9uIFF0CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2Nzcy9nZXRDb21wdXRlZFN0eWxlL2dldENvbXB1dGVkU3R5bGUtb3V0bGlu ZS1zaG9ydGhhbmQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZ2V0Q29tcHV0 ZWRTdHlsZS9nZXRDb21wdXRlZFN0eWxlLW91dGxpbmUtc2hvcnRoYW5kLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi5hNTg5ZDU5MmM5ZTdlOWQ1NGMyMDc0MmExNDQ2MzllYTQ4NjhmOTJmCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvZ2V0Q29tcHV0ZWRTdHlsZS9nZXRD b21wdXRlZFN0eWxlLW91dGxpbmUtc2hvcnRoYW5kLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDM2 IEBACitUZXN0IHRvIG1ha2Ugc3VyZSBvdXRsaW5lIHNob3J0aGFuZCBwcm9wZXJ0eSByZXR1cm5z IENTU1ZhbHVlTGlzdCBwcm9wZXJseS4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2Vy aWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisK K1BBU1MgY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdvdXRsaW5lJykgaXMgJ3JnYigy NTUsIDAsIDApIHNvbGlkIDVweCcKK1BBU1MgY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eUNTU1Zh bHVlKCdvdXRsaW5lJykudG9TdHJpbmcoKSBpcyAnW29iamVjdCBDU1NWYWx1ZUxpc3RdJworUEFT UyBjb21wdXRlZFN0eWxlLmdldFByb3BlcnR5Q1NTVmFsdWUoJ291dGxpbmUnKS5sZW5ndGggaXMg MworUEFTUyBjb21wdXRlZFN0eWxlLmdldFByb3BlcnR5Q1NTVmFsdWUoJ291dGxpbmUnKS5jc3NU ZXh0IGlzICdyZ2IoMjU1LCAwLCAwKSBzb2xpZCA1cHgnCitQQVNTIGNvbXB1dGVkU3R5bGUuZ2V0 UHJvcGVydHlDU1NWYWx1ZSgnb3V0bGluZScpLml0ZW0oMCkuZ2V0UkdCQ29sb3JWYWx1ZSgpLnJl ZC5nZXRGbG9hdFZhbHVlKENTU1ByaW1pdGl2ZVZhbHVlLkNTU19OVU1CRVIpIGlzIDI1NQorUEFT UyBjb21wdXRlZFN0eWxlLmdldFByb3BlcnR5Q1NTVmFsdWUoJ291dGxpbmUnKS5pdGVtKDApLmdl dFJHQkNvbG9yVmFsdWUoKS5ncmVlbi5nZXRGbG9hdFZhbHVlKENTU1ByaW1pdGl2ZVZhbHVlLkNT U19OVU1CRVIpIGlzIDAKK1BBU1MgY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKCdv dXRsaW5lJykuaXRlbSgwKS5nZXRSR0JDb2xvclZhbHVlKCkuYmx1ZS5nZXRGbG9hdFZhbHVlKENT U1ByaW1pdGl2ZVZhbHVlLkNTU19OVU1CRVIpIGlzIDAKK1BBU1MgY29tcHV0ZWRTdHlsZS5nZXRQ cm9wZXJ0eUNTU1ZhbHVlKCdvdXRsaW5lJykuaXRlbSgxKS5nZXRTdHJpbmdWYWx1ZSgpIGlzICdz b2xpZCcKK1BBU1MgY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKCdvdXRsaW5lJyku aXRlbSgyKS5nZXRGbG9hdFZhbHVlKENTU1ByaW1pdGl2ZVZhbHVlLkNTU19OVU1CRVIpIGlzIDUK K1BBU1MgY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdvdXRsaW5lJykgaXMgJ3JnYigw LCAwLCAwKSBzb2xpZCAzMnB4JworUEFTUyBjb21wdXRlZFN0eWxlLmdldFByb3BlcnR5Q1NTVmFs dWUoJ291dGxpbmUnKS50b1N0cmluZygpIGlzICdbb2JqZWN0IENTU1ZhbHVlTGlzdF0nCitQQVNT IGNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZSgnb3V0bGluZScpLmxlbmd0aCBpcyAz CitQQVNTIGNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZSgnb3V0bGluZScpLmNzc1Rl eHQgaXMgJ3JnYigwLCAwLCAwKSBzb2xpZCAzMnB4JworUEFTUyBjb21wdXRlZFN0eWxlLmdldFBy b3BlcnR5Q1NTVmFsdWUoJ291dGxpbmUnKS5pdGVtKDApLmdldFJHQkNvbG9yVmFsdWUoKS5yZWQu Z2V0RmxvYXRWYWx1ZShDU1NQcmltaXRpdmVWYWx1ZS5DU1NfTlVNQkVSKSBpcyAwCitQQVNTIGNv bXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZSgnb3V0bGluZScpLml0ZW0oMCkuZ2V0UkdC Q29sb3JWYWx1ZSgpLmdyZWVuLmdldEZsb2F0VmFsdWUoQ1NTUHJpbWl0aXZlVmFsdWUuQ1NTX05V TUJFUikgaXMgMAorUEFTUyBjb21wdXRlZFN0eWxlLmdldFByb3BlcnR5Q1NTVmFsdWUoJ291dGxp bmUnKS5pdGVtKDApLmdldFJHQkNvbG9yVmFsdWUoKS5ibHVlLmdldEZsb2F0VmFsdWUoQ1NTUHJp bWl0aXZlVmFsdWUuQ1NTX05VTUJFUikgaXMgMAorUEFTUyBjb21wdXRlZFN0eWxlLmdldFByb3Bl cnR5Q1NTVmFsdWUoJ291dGxpbmUnKS5pdGVtKDEpLmdldFN0cmluZ1ZhbHVlKCkgaXMgJ3NvbGlk JworUEFTUyBjb21wdXRlZFN0eWxlLmdldFByb3BlcnR5Q1NTVmFsdWUoJ291dGxpbmUnKS5pdGVt KDIpLmdldEZsb2F0VmFsdWUoQ1NTUHJpbWl0aXZlVmFsdWUuQ1NTX05VTUJFUikgaXMgMzIKK1BB U1MgY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdvdXRsaW5lJykgaXMgJ3JnYigyNTUs IDAsIDApIG5vbmUgMHB4JworUEFTUyBjb21wdXRlZFN0eWxlLmdldFByb3BlcnR5Q1NTVmFsdWUo J291dGxpbmUnKS50b1N0cmluZygpIGlzICdbb2JqZWN0IENTU1ZhbHVlTGlzdF0nCitQQVNTIGNv bXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZSgnb3V0bGluZScpLmxlbmd0aCBpcyAzCitQ QVNTIGNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZSgnb3V0bGluZScpLmNzc1RleHQg aXMgJ3JnYigyNTUsIDAsIDApIG5vbmUgMHB4JworUEFTUyBjb21wdXRlZFN0eWxlLmdldFByb3Bl cnR5Q1NTVmFsdWUoJ291dGxpbmUnKS5pdGVtKDApLmdldFJHQkNvbG9yVmFsdWUoKS5yZWQuZ2V0 RmxvYXRWYWx1ZShDU1NQcmltaXRpdmVWYWx1ZS5DU1NfTlVNQkVSKSBpcyAyNTUKK1BBU1MgY29t cHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKCdvdXRsaW5lJykuaXRlbSgwKS5nZXRSR0JD b2xvclZhbHVlKCkuZ3JlZW4uZ2V0RmxvYXRWYWx1ZShDU1NQcmltaXRpdmVWYWx1ZS5DU1NfTlVN QkVSKSBpcyAwCitQQVNTIGNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZSgnb3V0bGlu ZScpLml0ZW0oMCkuZ2V0UkdCQ29sb3JWYWx1ZSgpLmJsdWUuZ2V0RmxvYXRWYWx1ZShDU1NQcmlt aXRpdmVWYWx1ZS5DU1NfTlVNQkVSKSBpcyAwCitQQVNTIGNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVy dHlDU1NWYWx1ZSgnb3V0bGluZScpLml0ZW0oMSkuZ2V0U3RyaW5nVmFsdWUoKSBpcyAnbm9uZScK K1BBU1MgY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKCdvdXRsaW5lJykuaXRlbSgy KS5nZXRGbG9hdFZhbHVlKENTU1ByaW1pdGl2ZVZhbHVlLkNTU19OVU1CRVIpIGlzIDAKK1BBU1Mg c3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9nZXRDb21wdXRlZFN0eWxlL2dldENvbXB1dGVkU3R5bGUt b3V0bGluZS1zaG9ydGhhbmQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2dldENvbXB1dGVk U3R5bGUvZ2V0Q29tcHV0ZWRTdHlsZS1vdXRsaW5lLXNob3J0aGFuZC5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu Ljc3Nzk1NTUxYzg4ODU1M2Q1MzlmODVkMTIxMTYyMWRiOGIwOWY0MWUKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9nZXRDb21wdXRlZFN0eWxlL2dldENvbXB1dGVkU3R5 bGUtb3V0bGluZS1zaG9ydGhhbmQuaHRtbApAQCAtMCwwICsxLDU5IEBACis8IURPQ1RZUEUgaHRt bD4KKzxodG1sPgorPGhlYWQ+Cis8bWV0YSBjaGFyc2V0PSJ1dGYtOCI+Cis8c2NyaXB0IHNyYz0i Li4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxi b2R5PgorPHNjcmlwdD4KKworZGVzY3JpcHRpb24oIlRlc3QgdG8gbWFrZSBzdXJlIG91dGxpbmUg c2hvcnRoYW5kIHByb3BlcnR5IHJldHVybnMgQ1NTVmFsdWVMaXN0IHByb3Blcmx5LiIpCisKK3Zh ciB0ZXN0Q29udGFpbmVyID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7Cit0ZXN0Q29u dGFpbmVyLmNvbnRlbnRFZGl0YWJsZSA9IHRydWU7Citkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxk KHRlc3RDb250YWluZXIpOworCit0ZXN0Q29udGFpbmVyLmlubmVySFRNTCA9ICc8ZGl2IHN0eWxl PSJ3aWR0aDoxMDBweDtoZWlnaHQ6MTAwcHgiPjxkaXYgaWQ9InRlc3QiPmhlbGxvPC9kaXY+PC9k aXY+JzsKKworZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0ZXN0Jyk7Citjb21wdXRlZFN0 eWxlID0gd2luZG93LmdldENvbXB1dGVkU3R5bGUoZSwgbnVsbCk7CisKK2Uuc3R5bGUub3V0bGlu ZSA9ICJ0aGljayBzb2xpZCByZWQiOworc2hvdWxkQmUoImNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVy dHlWYWx1ZSgnb3V0bGluZScpIiwgIidyZ2IoMjU1LCAwLCAwKSBzb2xpZCA1cHgnIik7CitzaG91 bGRCZSgiY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKCdvdXRsaW5lJykudG9TdHJp bmcoKSIsICInW29iamVjdCBDU1NWYWx1ZUxpc3RdJyIpOworc2hvdWxkQmUoImNvbXB1dGVkU3R5 bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZSgnb3V0bGluZScpLmxlbmd0aCIsICIzIik7CitzaG91bGRC ZSgiY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKCdvdXRsaW5lJykuY3NzVGV4dCIs ICIncmdiKDI1NSwgMCwgMCkgc29saWQgNXB4JyIpOworc2hvdWxkQmUoImNvbXB1dGVkU3R5bGUu Z2V0UHJvcGVydHlDU1NWYWx1ZSgnb3V0bGluZScpLml0ZW0oMCkuZ2V0UkdCQ29sb3JWYWx1ZSgp LnJlZC5nZXRGbG9hdFZhbHVlKENTU1ByaW1pdGl2ZVZhbHVlLkNTU19OVU1CRVIpIiwgIjI1NSIp Oworc2hvdWxkQmUoImNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZSgnb3V0bGluZScp Lml0ZW0oMCkuZ2V0UkdCQ29sb3JWYWx1ZSgpLmdyZWVuLmdldEZsb2F0VmFsdWUoQ1NTUHJpbWl0 aXZlVmFsdWUuQ1NTX05VTUJFUikiLCAiMCIpOworc2hvdWxkQmUoImNvbXB1dGVkU3R5bGUuZ2V0 UHJvcGVydHlDU1NWYWx1ZSgnb3V0bGluZScpLml0ZW0oMCkuZ2V0UkdCQ29sb3JWYWx1ZSgpLmJs dWUuZ2V0RmxvYXRWYWx1ZShDU1NQcmltaXRpdmVWYWx1ZS5DU1NfTlVNQkVSKSIsICIwIik7Citz aG91bGRCZSgiY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKCdvdXRsaW5lJykuaXRl bSgxKS5nZXRTdHJpbmdWYWx1ZSgpIiwgIidzb2xpZCciKTsKK3Nob3VsZEJlKCJjb21wdXRlZFN0 eWxlLmdldFByb3BlcnR5Q1NTVmFsdWUoJ291dGxpbmUnKS5pdGVtKDIpLmdldEZsb2F0VmFsdWUo Q1NTUHJpbWl0aXZlVmFsdWUuQ1NTX05VTUJFUikiLCAiNSIpOworCitlLnN0eWxlLm91dGxpbmUg PSAiMmVtIHNvbGlkIjsKK3Nob3VsZEJlKCJjb21wdXRlZFN0eWxlLmdldFByb3BlcnR5VmFsdWUo J291dGxpbmUnKSIsICIncmdiKDAsIDAsIDApIHNvbGlkIDMycHgnIik7CitzaG91bGRCZSgiY29t cHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKCdvdXRsaW5lJykudG9TdHJpbmcoKSIsICIn W29iamVjdCBDU1NWYWx1ZUxpc3RdJyIpOworc2hvdWxkQmUoImNvbXB1dGVkU3R5bGUuZ2V0UHJv cGVydHlDU1NWYWx1ZSgnb3V0bGluZScpLmxlbmd0aCIsICIzIik7CitzaG91bGRCZSgiY29tcHV0 ZWRTdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKCdvdXRsaW5lJykuY3NzVGV4dCIsICIncmdiKDAs IDAsIDApIHNvbGlkIDMycHgnIik7CitzaG91bGRCZSgiY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0 eUNTU1ZhbHVlKCdvdXRsaW5lJykuaXRlbSgwKS5nZXRSR0JDb2xvclZhbHVlKCkucmVkLmdldEZs b2F0VmFsdWUoQ1NTUHJpbWl0aXZlVmFsdWUuQ1NTX05VTUJFUikiLCAiMCIpOworc2hvdWxkQmUo ImNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZSgnb3V0bGluZScpLml0ZW0oMCkuZ2V0 UkdCQ29sb3JWYWx1ZSgpLmdyZWVuLmdldEZsb2F0VmFsdWUoQ1NTUHJpbWl0aXZlVmFsdWUuQ1NT X05VTUJFUikiLCAiMCIpOworc2hvdWxkQmUoImNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlDU1NW YWx1ZSgnb3V0bGluZScpLml0ZW0oMCkuZ2V0UkdCQ29sb3JWYWx1ZSgpLmJsdWUuZ2V0RmxvYXRW YWx1ZShDU1NQcmltaXRpdmVWYWx1ZS5DU1NfTlVNQkVSKSIsICIwIik7CitzaG91bGRCZSgiY29t cHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKCdvdXRsaW5lJykuaXRlbSgxKS5nZXRTdHJp bmdWYWx1ZSgpIiwgIidzb2xpZCciKTsKK3Nob3VsZEJlKCJjb21wdXRlZFN0eWxlLmdldFByb3Bl cnR5Q1NTVmFsdWUoJ291dGxpbmUnKS5pdGVtKDIpLmdldEZsb2F0VmFsdWUoQ1NTUHJpbWl0aXZl VmFsdWUuQ1NTX05VTUJFUikiLCAiMzIiKTsKKworZS5zdHlsZS5vdXRsaW5lID0gIjRweCBub25l IHJlZCI7CitzaG91bGRCZSgiY29tcHV0ZWRTdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdvdXRsaW5l JykiLCAiJ3JnYigyNTUsIDAsIDApIG5vbmUgMHB4JyIpOworc2hvdWxkQmUoImNvbXB1dGVkU3R5 bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZSgnb3V0bGluZScpLnRvU3RyaW5nKCkiLCAiJ1tvYmplY3Qg Q1NTVmFsdWVMaXN0XSciKTsKK3Nob3VsZEJlKCJjb21wdXRlZFN0eWxlLmdldFByb3BlcnR5Q1NT VmFsdWUoJ291dGxpbmUnKS5sZW5ndGgiLCAiMyIpOworc2hvdWxkQmUoImNvbXB1dGVkU3R5bGUu Z2V0UHJvcGVydHlDU1NWYWx1ZSgnb3V0bGluZScpLmNzc1RleHQiLCAiJ3JnYigyNTUsIDAsIDAp IG5vbmUgMHB4JyIpOworc2hvdWxkQmUoImNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1 ZSgnb3V0bGluZScpLml0ZW0oMCkuZ2V0UkdCQ29sb3JWYWx1ZSgpLnJlZC5nZXRGbG9hdFZhbHVl KENTU1ByaW1pdGl2ZVZhbHVlLkNTU19OVU1CRVIpIiwgIjI1NSIpOworc2hvdWxkQmUoImNvbXB1 dGVkU3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZSgnb3V0bGluZScpLml0ZW0oMCkuZ2V0UkdCQ29s b3JWYWx1ZSgpLmdyZWVuLmdldEZsb2F0VmFsdWUoQ1NTUHJpbWl0aXZlVmFsdWUuQ1NTX05VTUJF UikiLCAiMCIpOworc2hvdWxkQmUoImNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlDU1NWYWx1ZSgn b3V0bGluZScpLml0ZW0oMCkuZ2V0UkdCQ29sb3JWYWx1ZSgpLmJsdWUuZ2V0RmxvYXRWYWx1ZShD U1NQcmltaXRpdmVWYWx1ZS5DU1NfTlVNQkVSKSIsICIwIik7CitzaG91bGRCZSgiY29tcHV0ZWRT dHlsZS5nZXRQcm9wZXJ0eUNTU1ZhbHVlKCdvdXRsaW5lJykuaXRlbSgxKS5nZXRTdHJpbmdWYWx1 ZSgpIiwgIidub25lJyIpOworc2hvdWxkQmUoImNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVydHlDU1NW YWx1ZSgnb3V0bGluZScpLml0ZW0oMikuZ2V0RmxvYXRWYWx1ZShDU1NQcmltaXRpdmVWYWx1ZS5D U1NfTlVNQkVSKSIsICIwIik7CisKK2RvY3VtZW50LmJvZHkucmVtb3ZlQ2hpbGQodGVzdENvbnRh aW5lcik7CisKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10 ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=