75439 2012-01-02 08:57:51 -0800 [GTK] GtkLauncher settings improvements 2012-01-03 00:05:20 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned cgarcia oldest_to_newest 528535 0 pnormand 2012-01-02 08:57:51 -0800 Carlos spotted some issues in the WebSettings code of the launcher: https://bugs.webkit.org/show_bug.cgi?id=73773#c5 Will attach a patch to fix those. 528536 1 120884 pnormand 2012-01-02 09:00:48 -0800 Created attachment 120884 proposed patch 528680 2 pnormand 2012-01-03 00:05:20 -0800 Committed r103927: <http://trac.webkit.org/changeset/103927> 120884 2012-01-02 09:00:48 -0800 2012-01-02 09:20:23 -0800 proposed patch proposed-patch.patch text/plain 4767 pnormand RnJvbSA0YWE5YTc0MWQ5NTI4YzZiMjU2ZDU1ZjgzZjk1ZDg3Y2RjMTMxZTRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDIgSmFuIDIwMTIgMTg6MDA6MzAgKzAxMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgfCAgIDE1ICsrKysr KysrKysrKysrKwogVG9vbHMvR3RrTGF1bmNoZXIvbWFpbi5jIHwgICA0NCArKysrKysrKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA0MCBpbnNl cnRpb25zKCspLCAxOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzZlNTVhMi4uOWVmNzQyYyAxMDA2NDQKLS0tIGEvVG9v bHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEy LTAxLTAyICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXSBHdGtMYXVuY2hlciBzZXR0aW5ncyBpbXByb3ZlbWVudHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1NDM5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBHdGtMYXVuY2hlci9tYWluLmM6Cisg ICAgICAgIChmaWxlbmFtZVRvVVJMKTogV2UgY2FuIHVzZSBOVUxMIGluIEMuCisgICAgICAgIChp c1ZhbGlkUGFyYW1ldGVyVHlwZSk6IFV0aWxpdHkgZnVuY3Rpb24gdG8gZmlsdGVyIEdQYXJhbVR5 cGVzCisgICAgICAgIHRoYXQgY2FuIGJlIGVkaXRlZC4KKyAgICAgICAgKGdldE9wdGlvbkVudHJp ZXNGcm9tV2ViS2l0V2ViU2V0dGluZ3MpOiBBdm9pZCBoYW5kbGluZworICAgICAgICBjb25zdHJ1 Y3Qtb25seSBwcm9wZXJ0aWVzIGFuZCB1c2UgdGhlIGlzVmFsaWRQYXJhbWV0ZXJUeXBlCisgICAg ICAgIGZ1bmN0aW9uLiBNYWtlcyB0aGUgY29kZSBhIGJpdCBjbGVhbmVyLgorCiAyMDExLTEyLTA0 ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV0sy XVtHVEtdIFdlYlNldHRpbmdzIHN1cHBvcnQgaW4gTWluaUJyb3dzZXIKZGlmZiAtLWdpdCBhL1Rv b2xzL0d0a0xhdW5jaGVyL21haW4uYyBiL1Rvb2xzL0d0a0xhdW5jaGVyL21haW4uYwppbmRleCA4 NzZkYWIyLi5lM2E2NmIwIDEwMDY0NAotLS0gYS9Ub29scy9HdGtMYXVuY2hlci9tYWluLmMKKysr IGIvVG9vbHMvR3RrTGF1bmNoZXIvbWFpbi5jCkBAIC0yMzAsNyArMjMwLDcgQEAgc3RhdGljIEd0 a1dpZGdldCogY3JlYXRlV2luZG93KFdlYktpdFdlYlZpZXcqKiBvdXRXZWJWaWV3KQogc3RhdGlj IGdjaGFyKiBmaWxlbmFtZVRvVVJMKGNvbnN0IGNoYXIqIGZpbGVuYW1lKQogewogICAgIGlmICgh Z19maWxlX3Rlc3QoZmlsZW5hbWUsIEdfRklMRV9URVNUX0VYSVNUUykpCi0gICAgICAgIHJldHVy biAwOworICAgICAgICByZXR1cm4gTlVMTDsKIAogICAgIEdGaWxlICpnZmlsZSA9IGdfZmlsZV9u ZXdfZm9yX3BhdGgoZmlsZW5hbWUpOwogICAgIGdjaGFyICpmaWxlVVJMID0gZ19maWxlX2dldF91 cmkoZ2ZpbGUpOwpAQCAtMzA2LDYgKzMwNiwxMiBAQCBzdGF0aWMgZ2Jvb2xlYW4gcGFyc2VPcHRp b25FbnRyeUNhbGxiYWNrKGNvbnN0IGdjaGFyICpvcHRpb25OYW1lRnVsbCwgY29uc3QgZ2NoYQog ICAgIHJldHVybiBUUlVFOwogfQogCitzdGF0aWMgZ2Jvb2xlYW4gaXNWYWxpZFBhcmFtZXRlclR5 cGUoR1R5cGUgZ1BhcmFtVHlwZSkKK3sKKyAgICByZXR1cm4gKGdQYXJhbVR5cGUgPT0gR19UWVBF X0JPT0xFQU4gfHwgZ1BhcmFtVHlwZSA9PSBHX1RZUEVfU1RSSU5HIHx8IGdQYXJhbVR5cGUgPT0g R19UWVBFX0lOVAorICAgICAgICAgICAgfHwgZ1BhcmFtVHlwZSA9PSBHX1RZUEVfRkxPQVQpOwor fQorCiBzdGF0aWMgR09wdGlvbkVudHJ5KiBnZXRPcHRpb25FbnRyaWVzRnJvbVdlYktpdFdlYlNl dHRpbmdzKFdlYktpdFdlYlNldHRpbmdzICp3ZWJTZXR0aW5ncykKIHsKICAgICBHUGFyYW1TcGVj ICoqcHJvcGVydHlTcGVjczsKQEAgLTMxNCwzMyArMzIwLDMzIEBAIHN0YXRpYyBHT3B0aW9uRW50 cnkqIGdldE9wdGlvbkVudHJpZXNGcm9tV2ViS2l0V2ViU2V0dGluZ3MoV2ViS2l0V2ViU2V0dGlu Z3MgKndlCiAKICAgICBwcm9wZXJ0eVNwZWNzID0gZ19vYmplY3RfY2xhc3NfbGlzdF9wcm9wZXJ0 aWVzKEdfT0JKRUNUX0dFVF9DTEFTUyh3ZWJTZXR0aW5ncyksICZudW1Qcm9wZXJ0aWVzKTsKICAg ICBpZiAoIXByb3BlcnR5U3BlY3MpCi0gICAgICAgIHJldHVybiAwOworICAgICAgICByZXR1cm4g TlVMTDsKIAogICAgIG9wdGlvbkVudHJpZXMgPSBnX25ldzAoR09wdGlvbkVudHJ5LCBudW1Qcm9w ZXJ0aWVzICsgMSk7CiAgICAgbnVtRW50cmllcyA9IDA7CiAgICAgZm9yIChpID0gMDsgaSA8IG51 bVByb3BlcnRpZXM7IGkrKykgewogICAgICAgICBHUGFyYW1TcGVjICpwYXJhbSA9IHByb3BlcnR5 U3BlY3NbaV07CiAKLSAgICAgICAgLyogRmlsbCBpbiBzdHJ1Y3R1cmVzIG9ubHkgZm9yIHdyaXRh YmxlIHByb3BlcnRpZXMuICovCi0gICAgICAgIGlmICghcGFyYW0gfHwgIShwYXJhbS0+ZmxhZ3Mg JiBHX1BBUkFNX1dSSVRBQkxFKSkKKyAgICAgICAgLyogRmlsbCBpbiBzdHJ1Y3R1cmVzIG9ubHkg Zm9yIHdyaXRhYmxlIGFuZCBub3QgY29uc3RydWN0LW9ubHkgcHJvcGVydGllcy4gKi8KKyAgICAg ICAgaWYgKCFwYXJhbSB8fCAhKHBhcmFtLT5mbGFncyAmIEdfUEFSQU1fV1JJVEFCTEUpIHx8IChw YXJhbS0+ZmxhZ3MgJiBHX1BBUkFNX0NPTlNUUlVDVF9PTkxZKSkKICAgICAgICAgICAgIGNvbnRp bnVlOwogCiAgICAgICAgIEdUeXBlIGdQYXJhbVR5cGUgPSBHX1BBUkFNX1NQRUNfVkFMVUVfVFlQ RShwYXJhbSk7Ci0gICAgICAgIGlmIChnUGFyYW1UeXBlID09IEdfVFlQRV9CT09MRUFOIHx8IGdQ YXJhbVR5cGUgPT0gR19UWVBFX1NUUklORyB8fCBnUGFyYW1UeXBlID09IEdfVFlQRV9JTlQKLSAg ICAgICAgICAgIHx8IGdQYXJhbVR5cGUgPT0gR19UWVBFX0ZMT0FUKSB7Ci0gICAgICAgICAgICBH T3B0aW9uRW50cnkgKm9wdGlvbkVudHJ5ID0gJm9wdGlvbkVudHJpZXNbbnVtRW50cmllcysrXTsK LSAgICAgICAgICAgIG9wdGlvbkVudHJ5LT5sb25nX25hbWUgPSBnX3BhcmFtX3NwZWNfZ2V0X25h bWUocGFyYW0pOwotCi0gICAgICAgICAgICAvKiBUaGVyZSBpcyBubyBlYXN5IHdheSB0byBmaWd1 cmUgb3VyIHNob3J0IG5hbWUgZm9yIGdlbmVyYXRlZCBvcHRpb24gZW50cmllcy4KLSAgICAgICAg ICAgICAgIG9wdGlvbkVudHJ5LnNob3J0X25hbWU9Ki8KLSAgICAgICAgICAgIC8qIEZvciBib29s IGFyZ3VtZW50cyAiZW5hYmxlIiB0eXBlIG1ha2Ugb3B0aW9uIGFyZ3VtZW50IG5vdCByZXF1aXJl ZC4gKi8KLSAgICAgICAgICAgIGlmIChnUGFyYW1UeXBlID09IEdfVFlQRV9CT09MRUFOICYmIChz dHJzdHIob3B0aW9uRW50cnktPmxvbmdfbmFtZSwgImVuYWJsZSIpKSkKLSAgICAgICAgICAgICAg ICBvcHRpb25FbnRyeS0+ZmxhZ3MgPSBHX09QVElPTl9GTEFHX09QVElPTkFMX0FSRzsKLSAgICAg ICAgICAgIG9wdGlvbkVudHJ5LT5hcmcgPSBHX09QVElPTl9BUkdfQ0FMTEJBQ0s7Ci0gICAgICAg ICAgICBvcHRpb25FbnRyeS0+YXJnX2RhdGEgPSBwYXJzZU9wdGlvbkVudHJ5Q2FsbGJhY2s7Ci0g ICAgICAgICAgICBvcHRpb25FbnRyeS0+ZGVzY3JpcHRpb24gPSBnX3BhcmFtX3NwZWNfZ2V0X2Js dXJiKHBhcmFtKTsKLSAgICAgICAgICAgIG9wdGlvbkVudHJ5LT5hcmdfZGVzY3JpcHRpb24gPSBn X3R5cGVfbmFtZShnUGFyYW1UeXBlKTsKLSAgICAgICAgfQorICAgICAgICBpZiAoIWlzVmFsaWRQ YXJhbWV0ZXJUeXBlKGdQYXJhbVR5cGUpKQorICAgICAgICAgICAgY29udGludWU7CisKKyAgICAg ICAgR09wdGlvbkVudHJ5ICpvcHRpb25FbnRyeSA9ICZvcHRpb25FbnRyaWVzW251bUVudHJpZXMr K107CisgICAgICAgIG9wdGlvbkVudHJ5LT5sb25nX25hbWUgPSBnX3BhcmFtX3NwZWNfZ2V0X25h bWUocGFyYW0pOworCisgICAgICAgIC8qIFRoZXJlIGlzIG5vIGVhc3kgd2F5IHRvIGZpZ3VyZSBv dXIgc2hvcnQgbmFtZSBmb3IgZ2VuZXJhdGVkIG9wdGlvbiBlbnRyaWVzLgorICAgICAgICAgICBv cHRpb25FbnRyeS5zaG9ydF9uYW1lPSovCisgICAgICAgIC8qIEZvciBib29sIGFyZ3VtZW50cyAi ZW5hYmxlIiB0eXBlIG1ha2Ugb3B0aW9uIGFyZ3VtZW50IG5vdCByZXF1aXJlZC4gKi8KKyAgICAg ICAgaWYgKGdQYXJhbVR5cGUgPT0gR19UWVBFX0JPT0xFQU4gJiYgKHN0cnN0cihvcHRpb25FbnRy eS0+bG9uZ19uYW1lLCAiZW5hYmxlIikpKQorICAgICAgICAgICAgb3B0aW9uRW50cnktPmZsYWdz ID0gR19PUFRJT05fRkxBR19PUFRJT05BTF9BUkc7CisgICAgICAgIG9wdGlvbkVudHJ5LT5hcmcg PSBHX09QVElPTl9BUkdfQ0FMTEJBQ0s7CisgICAgICAgIG9wdGlvbkVudHJ5LT5hcmdfZGF0YSA9 IHBhcnNlT3B0aW9uRW50cnlDYWxsYmFjazsKKyAgICAgICAgb3B0aW9uRW50cnktPmRlc2NyaXB0 aW9uID0gZ19wYXJhbV9zcGVjX2dldF9ibHVyYihwYXJhbSk7CisgICAgICAgIG9wdGlvbkVudHJ5 LT5hcmdfZGVzY3JpcHRpb24gPSBnX3R5cGVfbmFtZShnUGFyYW1UeXBlKTsKICAgICB9CiAgICAg Z19mcmVlKHByb3BlcnR5U3BlY3MpOwogCi0tIAoxLjcuNy4z