75426 2012-01-01 21:49:20 -0800 Add resolve-supplemental.pl to project.pbxproj 2012-01-02 19:51:52 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72138 1 haraken haraken abarth mrowe webkit.review.bot oldest_to_newest 528419 0 haraken 2012-01-01 21:49:20 -0800 While I enabled the [Supplemental] IDL on AppleWebKit at the bug 74900, I forgot to add "resolve-supplemental.pl" to project.pbxproj. We should add it. 528473 1 120871 haraken 2012-01-02 05:28:18 -0800 Created attachment 120871 Patch 528604 2 120871 webkit.review.bot 2012-01-02 16:57:37 -0800 Comment on attachment 120871 Patch Clearing flags on attachment: 120871 Committed r103919: <http://trac.webkit.org/changeset/103919> 528605 3 webkit.review.bot 2012-01-02 16:57:41 -0800 All reviewed patches have been landed. Closing bug. 528627 4 mrowe 2012-01-02 18:45:02 -0800 If I'm reading this change correctly, it copies the Perl script in to WebCore.framework/Resources. Is that really what is intended from this change? 528631 5 abarth 2012-01-02 19:06:30 -0800 resolve-supplemental.pl doesn't need to be in the final framework, but it would be nice to have it in the Xcode IDE. Do we need to change some flags somewhere? xcodeproj files are hard to read... 528634 6 mrowe 2012-01-02 19:17:34 -0800 The trick is to add it to the project without adding it to any target. You can see that it is currently in a Copy Resources build phase by the "resolve-supplemental.pl in Resources" line that was added. Fixing this is a simple matter of removing it from the WebCore target in Xcode. 528635 7 haraken 2012-01-02 19:19:41 -0800 (In reply to comment #6) > The trick is to add it to the project without adding it to any target. You can see that it is currently in a Copy Resources build phase by the "resolve-supplemental.pl in Resources" line that was added. Fixing this is a simple matter of removing it from the WebCore target in Xcode. OK, let me try. 528643 8 haraken 2012-01-02 19:51:52 -0800 (In reply to comment #7) > (In reply to comment #6) > > The trick is to add it to the project without adding it to any target. You can see that it is currently in a Copy Resources build phase by the "resolve-supplemental.pl in Resources" line that was added. Fixing this is a simple matter of removing it from the WebCore target in Xcode. > > OK, let me try. bdash: Uploaded a patch on bug 75458. By the way, "/* CodeGenerator.pm in Headers */" and "/* generate-bindings.pl in Headers */" are OK? Should we also remove them? 120871 2012-01-02 05:28:18 -0800 2012-01-02 16:57:37 -0800 Patch bug-75426-20120102222816.patch text/plain 4421 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzODc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQyNTVkYTdkNTBmYTA1 YjI3NDYwZGQ1NjQ0MjE4NmIwODEyMWJhYS4uY2VmMDJiYWJjNWUwNWNkZjVmNjZjOWNiODk3NmE2 ZmQ4ZWY3YTMxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAxLTAyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgcmVzb2x2ZS1z dXBwbGVtZW50YWwucGwgdG8gcHJvamVjdC5wYnhwcm9qCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTQyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBoYXZlIGFkZGVkICJyZXNvbHZlLXN1 cHBsZW1lbnRhbC5wbCIgdG8gYnVpbGQgc2NyaXB0cyBvZiBBcHBsZVdlYktpdAorICAgICAgICB3 aGVuIHdlIGVuYWJsZWQgdGhlIFtTdXBwbGVtZW50YWxdIElETCBvbiBBcHBsZVdlYktpdCBhdCBy MTAzNTE5LgorICAgICAgICBUaGlzIGlzIGEgZm9sbG93LXVwIHBhdGNoIGZvciBpdC4KKworICAg ICAgICBObyB0ZXN0cy4gSnVzdCBjb25maXJtIHRoYXQgdGhlIEFwcGxlV2ViS2l0IGJ1aWxkIHBh c3Nlcy4KKworICAgICAgICAqIFdlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvajoKKwog MjAxMi0wMS0wMSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgVW5yZXZpZXdlZC4gUmViYXNlbGluZWQgcnVuLWJpbmRpbmdzLXRlc3RzIHJlc3VsdHMuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHBy b2ogYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKaW5k ZXggYWM0N2QwZTQ0NmY0ODM3YThhYTUxYWU0MDE3MGIzYWI2ZjIzZTJmZC4uZmM5YTBlYmZlYThk Mjg0OGQ3NjhkYTBiMThhZjRjZWQyMTlmY2E2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv V2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dl YkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagpAQCAtMzkzOCw2ICszOTM4LDcgQEAKIAkJ QThDNEE4MEUwOUQ1NjMyNzAwMDNBQzhEIC8qIEF0dHIuY3BwIGluIFNvdXJjZXMgKi8gPSB7aXNh ID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gQThDNEE3RkMwOUQ1NjMyNzAwMDNBQzhEIC8qIEF0 dHIuY3BwICovOyB9OwogCQlBOEM0QTg0QzA5RDU2NDlEMDAwM0FDOEQgLyogTWFwcGVkQXR0cmli dXRlRW50cnkuaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9 IEE4QzRBODRCMDlENTY0OUQwMDAzQUM4RCAvKiBNYXBwZWRBdHRyaWJ1dGVFbnRyeS5oICovOyBz ZXR0aW5ncyA9IHtBVFRSSUJVVEVTID0gKFByaXZhdGUsICk7IH07IH07CiAJCUE4Q0I0MTNFMEU4 NjMzRkQwMDMyQzRGMCAvKiBEYXNoQXJyYXkuaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1 aWxkRmlsZTsgZmlsZVJlZiA9IEE4Q0I0MTAyMEU4NUI4QTUwMDMyQzRGMCAvKiBEYXNoQXJyYXku aCAqLzsgc2V0dGluZ3MgPSB7QVRUUklCVVRFUyA9IChQcml2YXRlLCApOyB9OyB9OworCQlBOENG NTlCQzE0QjFFN0IyMDA0Q0MzNUMgLyogcmVzb2x2ZS1zdXBwbGVtZW50YWwucGwgaW4gUmVzb3Vy Y2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IEE4Q0Y1OUJCMTRCMUU3QjIw MDRDQzM1QyAvKiByZXNvbHZlLXN1cHBsZW1lbnRhbC5wbCAqLzsgfTsKIAkJQThDRkYwNEQwQTE1 NEYwOTAwMEE0MjM0IC8qIEZpeGVkVGFibGVMYXlvdXQuY3BwIGluIFNvdXJjZXMgKi8gPSB7aXNh ID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gQThDRkYwNDgwQTE1NEYwOTAwMEE0MjM0IC8qIEZp eGVkVGFibGVMYXlvdXQuY3BwICovOyB9OwogCQlBOENGRjA0RTBBMTU0RjA5MDAwQTQyMzQgLyog QXV0b1RhYmxlTGF5b3V0LmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZp bGVSZWYgPSBBOENGRjA0OTBBMTU0RjA5MDAwQTQyMzQgLyogQXV0b1RhYmxlTGF5b3V0LmggKi87 IH07CiAJCUE4Q0ZGMDRGMEExNTRGMDkwMDBBNDIzNCAvKiBGaXhlZFRhYmxlTGF5b3V0LmggaW4g SGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSBBOENGRjA0QTBBMTU0 RjA5MDAwQTQyMzQgLyogRml4ZWRUYWJsZUxheW91dC5oICovOyB9OwpAQCAtMTEwODQsNiArMTEw ODUsNyBAQAogCQlBOEM0QTdGQzA5RDU2MzI3MDAwM0FDOEQgLyogQXR0ci5jcHAgKi8gPSB7aXNh ID0gUEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29kaW5nID0gMzA7IGxhc3RLbm93bkZpbGVUeXBl ID0gc291cmNlY29kZS5jcHAuY3BwOyBwYXRoID0gQXR0ci5jcHA7IHNvdXJjZVRyZWUgPSAiPGdy b3VwPiI7IH07CiAJCUE4QzRBODRCMDlENTY0OUQwMDAzQUM4RCAvKiBNYXBwZWRBdHRyaWJ1dGVF bnRyeS5oICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDMwOyBs YXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuYy5oOyBwYXRoID0gTWFwcGVkQXR0cmlidXRl RW50cnkuaDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKIAkJQThDQjQxMDIwRTg1QjhBNTAw MzJDNEYwIC8qIERhc2hBcnJheS5oICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVF bmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jLmg7IHBhdGggPSBE YXNoQXJyYXkuaDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKKwkJQThDRjU5QkIxNEIxRTdC MjAwNENDMzVDIC8qIHJlc29sdmUtc3VwcGxlbWVudGFsLnBsICovID0ge2lzYSA9IFBCWEZpbGVS ZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gdGV4dC5zY3Jp cHQucGVybDsgbmFtZSA9ICJyZXNvbHZlLXN1cHBsZW1lbnRhbC5wbCI7IHBhdGggPSAic2NyaXB0 cy9yZXNvbHZlLXN1cHBsZW1lbnRhbC5wbCI7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CiAJ CUE4Q0ZGMDQ4MEExNTRGMDkwMDBBNDIzNCAvKiBGaXhlZFRhYmxlTGF5b3V0LmNwcCAqLyA9IHtp c2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSAzMDsgbGFzdEtub3duRmlsZVR5 cGUgPSBzb3VyY2Vjb2RlLmNwcC5jcHA7IHBhdGggPSBGaXhlZFRhYmxlTGF5b3V0LmNwcDsgc291 cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKIAkJQThDRkYwNDkwQTE1NEYwOTAwMEE0MjM0IC8qIEF1 dG9UYWJsZUxheW91dC5oICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGlu ZyA9IDMwOyBsYXN0S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuYy5oOyBwYXRoID0gQXV0b1Rh YmxlTGF5b3V0Lmg7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CiAJCUE4Q0ZGMDRBMEExNTRG MDkwMDBBNDIzNCAvKiBGaXhlZFRhYmxlTGF5b3V0LmggKi8gPSB7aXNhID0gUEJYRmlsZVJlZmVy ZW5jZTsgZmlsZUVuY29kaW5nID0gMzA7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5j Lmg7IHBhdGggPSBGaXhlZFRhYmxlTGF5b3V0Lmg7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07 CkBAIC0xOTY2MCw2ICsxOTY2Miw3IEBACiAJCUJDMUEzNzkwMDk3QzZGOTcwMDE5RjNEOCAvKiBi aW5kaW5ncyAqLyA9IHsKIAkJCWlzYSA9IFBCWEdyb3VwOwogCQkJY2hpbGRyZW4gPSAoCisJCQkJ QThDRjU5QkIxNEIxRTdCMjAwNENDMzVDIC8qIHJlc29sdmUtc3VwcGxlbWVudGFsLnBsICovLAog CQkJCUI1RDMxREY3MTFDRjYwRTUwMDlGMjJCNCAvKiBnZW5lcmljICovLAogCQkJCUJDMUEzNzkz MDk3QzZGQjEwMDE5RjNEOCAvKiBqcyAqLywKIAkJCQlCQzFBMzc5NDA5N0M2RkM0MDAxOUYzRDgg Lyogb2JqYyAqLywKQEAgLTI1MTE3LDYgKzI1MTIwLDcgQEAKIAkJCQk5MzE1M0JFMDE0MTk1QTI4 MDBGQ0Y1QkUgLyogZGVsZXRlQnV0dG9uUHJlc3NlZC5wbmcgaW4gUmVzb3VyY2VzICovLAogCQkJ CTkzMTUzQkUyMTQxOTVBNTcwMEZDRjVCRSAvKiBtaXNzaW5nSW1hZ2UucG5nIGluIFJlc291cmNl cyAqLywKIAkJCQk5MzE1M0JFNDE0MTk1QjJBMDBGQ0Y1QkUgLyogaW5wdXRTcGVlY2gucG5nIGlu IFJlc291cmNlcyAqLywKKwkJCQlBOENGNTlCQzE0QjFFN0IyMDA0Q0MzNUMgLyogcmVzb2x2ZS1z dXBwbGVtZW50YWwucGwgaW4gUmVzb3VyY2VzICovLAogCQkJKTsKIAkJCXJ1bk9ubHlGb3JEZXBs b3ltZW50UG9zdHByb2Nlc3NpbmcgPSAwOwogCQl9Owo=