75420 2012-01-01 14:26:44 -0800 [CMake] Clean up some cruft from wtf's CMakeLists.txt 2012-01-09 11:17:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco dbates paroga oldest_to_newest 528372 0 rakuco 2012-01-01 14:26:44 -0800 [CMake] Clean up some cruft from wtf's CMakeLists.txt 528373 1 120849 rakuco 2012-01-01 14:28:53 -0800 Created attachment 120849 Patch 528378 2 120849 dbates 2012-01-01 16:02:11 -0800 Comment on attachment 120849 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120849&action=review > Source/JavaScriptCore/ChangeLog:3 > + [CMake] Clean up some cruft from wtf's CMakeLists.txt Nit: wtf => WTF > Source/JavaScriptCore/wtf/CMakeLists.txt:-210 > - "${CMAKE_SOURCE_DIR}/Source/ThirdParty" Removing this line will break the build for ports that use the Mersenne Twister pseudorandom number generator, including the WinCE and BlackBerry ports. Notice the file Souece/ThirdParty/mt19937.ar.c is included in wtf/RandomNumber.cpp. 528382 3 120852 rakuco 2012-01-01 16:22:37 -0800 Created attachment 120852 Second attempt 528917 4 120852 dbates 2012-01-03 11:42:37 -0800 Comment on attachment 120852 Second attempt Can you elaborate on how you came to the decision to move the include directory ${CMAKE_SOURCE_DIR}/Source/ThirdParty from Source/JavaScriptCore/wtf/CMakeLists.txt to Platform{BlackBerry, WinCE.cmake}? 529545 5 rakuco 2012-01-04 08:32:40 -0800 (In reply to comment #4) > (From update of attachment 120852 [details]) > Can you elaborate on how you came to the decision to move the include directory ${CMAKE_SOURCE_DIR}/Source/ThirdParty from Source/JavaScriptCore/wtf/CMakeLists.txt to Platform{BlackBerry, WinCE.cmake}? You had previously mentioned BlackBerry and WinCE needed ${THIRDPARTY_DIR} for the Mersenne Twister PRNG, so I moved it to the respective platform files instead of including it for all ports which use CMake. 532334 6 121693 rakuco 2012-01-09 11:10:56 -0800 Created attachment 121693 Third third is a charm: always add THIRDPARTY_DIR 532347 7 rakuco 2012-01-09 11:17:57 -0800 Committed r104468: <http://trac.webkit.org/changeset/104468> 120849 2012-01-01 14:28:53 -0800 2012-01-01 16:22:31 -0800 Patch bug-75420-20120101202946.patch text/plain 1634 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 ZDc2NjkzOTlkMDY1NmZlNWYwMmZiYjFmM2Q3NGExNjgwMGMxZDBlLi5hY2IwMGQ3NTgzZTA1NWVm MGNlZDQxMThiZDE2OWU5ZDQxNGVhNjllIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMi0wMS0wMSAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8a3Vib0Bwcm9m dXNpb24ubW9iaT4KKworICAgICAgICBbQ01ha2VdIENsZWFuIHVwIHNvbWUgY3J1ZnQgZnJvbSB3 dGYncyBDTWFrZUxpc3RzLnR4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzU0MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHd0Zi9DTWFrZUxpc3RzLnR4dDogUmVtb3ZlIHRoZSB1bnVzZWQgV1RGX1BP UlRfRkxBR1MgdmFyaWFibGU7IGRvCisgICAgICAgIG5vdCBhcHBlbmQgc29tZSB1bm5lZWRlZCBw YXRocyB0byBXVEZfSU5DTFVERV9ESVJFQ1RPUklFUy4KKwogMjAxMS0xMi0zMCAgQW5kZXJzIENh cmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIFBhcmFtU3RvcmFn ZVRyYWl0cyBzcGVjaWFsaXphdGlvbiBmb3IgUmV0YWluUHRyCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvd3RmL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi9DTWFrZUxpc3RzLnR4dAppbmRleCA2ZDFjZWU4OTlmOGMxMjBjZGE3MzU3MDBiMDkxNGU2 OTI4ODI1ODI5Li4xYTRlNWE5N2IxYjhhYTkyMDVkOWFiYmE4MmJiNGE3NWIyMTdlZGExIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0NNYWtlTGlzdHMudHh0CisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQ01ha2VMaXN0cy50eHQKQEAgLTE5Miw3ICsxOTIsNiBA QCBTRVQoV1RGX0lOQ0xVREVfRElSRUNUT1JJRVMKIFNFVChXVEZfTElCUkFSSUVTCiApCiAKLQog SUYgKEVOQUJMRV9GQVNUX01BTExPQykKICAgICBMSVNUKEFQUEVORCBXVEZfU09VUkNFUwogICAg ICAgICBUQ1N5c3RlbUFsbG9jLmNwcApAQCAtMjAxLDE1ICsyMDAsOCBAQCBFTFNFICgpCiAgICAg QUREX0RFRklOSVRJT05TKC1EVVNFX1NZU1RFTV9NQUxMT0M9MSkKIEVORElGKCkKIAotCi1TRVQo V1RGX1BPUlRfRkxBR1MgKQogSU5DTFVERV9JRl9FWElTVFMoJHtKQVZBU0NSSVBUQ09SRV9ESVJ9 L3d0Zi9QbGF0Zm9ybSR7UE9SVH0uY21ha2UpCiAKLUxJU1QoQVBQRU5EIFdURl9JTkNMVURFX0RJ UkVDVE9SSUVTCi0gICAgIiR7Q01BS0VfQklOQVJZX0RJUn0iCi0gICAgIiR7Q01BS0VfU09VUkNF X0RJUn0vU291cmNlL1RoaXJkUGFydHkiCi0pCi0KIFdFQktJVF9XUkFQX1NPVVJDRUxJU1QoJHtX VEZfU09VUkNFU30pCiBJTkNMVURFX0RJUkVDVE9SSUVTKCR7V1RGX0lOQ0xVREVfRElSRUNUT1JJ RVN9KQogQUREX0RFRklOSVRJT05TKC1EQlVJTERJTkdfV1RGKQo= 120852 2012-01-01 16:22:37 -0800 2012-01-09 11:10:50 -0800 Second attempt bug-75420-20120101222330.patch text/plain 2866 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 ZDc2NjkzOTlkMDY1NmZlNWYwMmZiYjFmM2Q3NGExNjgwMGMxZDBlLi4zZTY4NWE1MTVhMjA4NTY4 NmFkZWQxOGQ3NjZkYzFjZTA5MzRkOTUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMi0wMS0wMSAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8a3Vib0Bwcm9m dXNpb24ubW9iaT4KKworICAgICAgICBbQ01ha2VdIENsZWFuIHVwIHNvbWUgY3J1ZnQgZnJvbSBX VEYncyBDTWFrZUxpc3RzLnR4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzU0MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHd0Zi9DTWFrZUxpc3RzLnR4dDogUmVtb3ZlIHRoZSB1bnVzZWQgV1RGX1BP UlRfRkxBR1MgdmFyaWFibGU7IGRvCisgICAgICAgIG5vdCBhcHBlbmQgc29tZSB1bm5lZWRlZCBw YXRocyB0byBXVEZfSU5DTFVERV9ESVJFQ1RPUklFUy4KKyAgICAgICAgKiB3dGYvUGxhdGZvcm1C bGFja0JlcnJ5LmNtYWtlOiBBZGQgJHtUSElSRFBBUlRZX0RJUn0gdG8KKyAgICAgICAgV1RGX0lO Q0xVREVfRElSRUNUT1JJRVMgZHVlIHRvIFVTRShNRVJTRU5ORV9UV0lTVEVSXzE5OTM3KS4KKyAg ICAgICAgKiB3dGYvUGxhdGZvcm1XaW5DRS5jbWFrZTogRGl0dG8uCisKIDIwMTEtMTItMzAgIEFu ZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYSBQYXJh bVN0b3JhZ2VUcmFpdHMgc3BlY2lhbGl6YXRpb24gZm9yIFJldGFpblB0cgpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS93dGYvQ01ha2VMaXN0cy50eHQKaW5kZXggNmQxY2VlODk5ZjhjMTIwY2RhNzM1NzAw YjA5MTRlNjkyODgyNTgyOS4uMWE0ZTVhOTdiMWI4YWE5MjA1ZDlhYmJhODJiYjRhNzViMjE3ZWRh MSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9DTWFrZUxpc3RzLnR4dAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0NNYWtlTGlzdHMudHh0CkBAIC0xOTIsNyAr MTkyLDYgQEAgU0VUKFdURl9JTkNMVURFX0RJUkVDVE9SSUVTCiBTRVQoV1RGX0xJQlJBUklFUwog KQogCi0KIElGIChFTkFCTEVfRkFTVF9NQUxMT0MpCiAgICAgTElTVChBUFBFTkQgV1RGX1NPVVJD RVMKICAgICAgICAgVENTeXN0ZW1BbGxvYy5jcHAKQEAgLTIwMSwxNSArMjAwLDggQEAgRUxTRSAo KQogICAgIEFERF9ERUZJTklUSU9OUygtRFVTRV9TWVNURU1fTUFMTE9DPTEpCiBFTkRJRigpCiAK LQotU0VUKFdURl9QT1JUX0ZMQUdTICkKIElOQ0xVREVfSUZfRVhJU1RTKCR7SkFWQVNDUklQVENP UkVfRElSfS93dGYvUGxhdGZvcm0ke1BPUlR9LmNtYWtlKQogCi1MSVNUKEFQUEVORCBXVEZfSU5D TFVERV9ESVJFQ1RPUklFUwotICAgICIke0NNQUtFX0JJTkFSWV9ESVJ9IgotICAgICIke0NNQUtF X1NPVVJDRV9ESVJ9L1NvdXJjZS9UaGlyZFBhcnR5IgotKQotCiBXRUJLSVRfV1JBUF9TT1VSQ0VM SVNUKCR7V1RGX1NPVVJDRVN9KQogSU5DTFVERV9ESVJFQ1RPUklFUygke1dURl9JTkNMVURFX0RJ UkVDVE9SSUVTfSkKIEFERF9ERUZJTklUSU9OUygtREJVSUxESU5HX1dURikKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm1CbGFja0JlcnJ5LmNtYWtlIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybUJsYWNrQmVycnkuY21ha2UKaW5kZXggNWYz MGQwODg5NjE1NzM2NzgzODMyMTZiOTA3NWY5ZWJkMWQwOWEzYS4uYTUwNTdlNDBhNzkyOWUwODIw MmNlYmFhNWVjMjU2YjIyMTY5NThlYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi9QbGF0Zm9ybUJsYWNrQmVycnkuY21ha2UKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi9QbGF0Zm9ybUJsYWNrQmVycnkuY21ha2UKQEAgLTEwLDMgKzEwLDcgQEAgTElTVChBUFBF TkQgV1RGX1NPVVJDRVMKIExJU1QoSU5TRVJUIFdURl9JTkNMVURFX0RJUkVDVE9SSUVTIDAKICAg ICAiJHtCTEFDS0JFUlJZX1RISVJEX1BBUlRZX0RJUn0vaWN1IgogKQorCitMSVNUKEFQUEVORCBX VEZfSU5DTFVERV9ESVJFQ1RPUklFUworICAgICIke1RISVJEUEFSVFlfRElSfSIgIyBEdWUgdG8g VVNFKE1FUlNFTk5FX1RXSVNURVJfMTk5MzcpLgorKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybVdpbkNFLmNtYWtlIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi9QbGF0Zm9ybVdpbkNFLmNtYWtlCmluZGV4IGMzNGM1ZTVhNTE5YmIxYjZhZWRlNTEzZWU4 YjhjMDQxNDk3MzBjMmQuLjhjNzM1NmE3OGM0MWFlN2Q0M2MxZmY0ZTYzNTk5ZmFiZDQzYjlhMTAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm1XaW5DRS5jbWFr ZQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtV2luQ0UuY21ha2UKQEAg LTI0LDMgKzI0LDcgQEAgTElTVChBUFBFTkQgV1RGX1NPVVJDRVMKIExJU1QoQVBQRU5EIFdURl9M SUJSQVJJRVMKICAgICBtbXRpbWVyCiApCisKK0xJU1QoQVBQRU5EIFdURl9JTkNMVURFX0RJUkVD VE9SSUVTCisgICAgIiR7VEhJUkRQQVJUWV9ESVJ9IiAjIER1ZSB0byBVU0UoTUVSU0VOTkVfVFdJ U1RFUl8xOTkzNykuCispCg== 121693 2012-01-09 11:10:56 -0800 2012-01-09 11:12:31 -0800 Third third is a charm: always add THIRDPARTY_DIR bug-75420-20120109171142.patch text/plain 1795 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 ZDc2NjkzOTlkMDY1NmZlNWYwMmZiYjFmM2Q3NGExNjgwMGMxZDBlLi41MWY3ZTQyNjg0NTliYzYx ZTBkYTdkZjQxMGRhNGQ0MDAxMjVkMmE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMi0wMS0wMSAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8a3Vib0Bwcm9m dXNpb24ubW9iaT4KKworICAgICAgICBbQ01ha2VdIENsZWFuIHVwIHNvbWUgY3J1ZnQgZnJvbSBX VEYncyBDTWFrZUxpc3RzLnR4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzU0MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHd0Zi9DTWFrZUxpc3RzLnR4dDogUmVtb3ZlIHRoZSB1bnVzZWQgV1RGX1BP UlRfRkxBR1MgdmFyaWFibGU7IGFkZAorICAgICAgICBhbGwgbmVlZGVkIHBhdGhzIHRvIFdURl9J TkNMVURFX0RJUkVDVE9SSUVTIGluIGEgc2luZ2xlIHBsYWNlLgorCiAyMDExLTEyLTMwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgUGFyYW1T dG9yYWdlVHJhaXRzIHNwZWNpYWxpemF0aW9uIGZvciBSZXRhaW5QdHIKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd3RmL0NNYWtlTGlzdHMudHh0CmluZGV4IDZkMWNlZTg5OWY4YzEyMGNkYTczNTcwMGIw OTE0ZTY5Mjg4MjU4MjkuLjQwOTZmZDcxMGM5YWU5ZjNkOTkzMDdhMTZmYmNiYjJlYjkxNWNmZjIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQ01ha2VMaXN0cy50eHQKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9DTWFrZUxpc3RzLnR4dApAQCAtMTg3LDEyICsx ODcsMTIgQEAgU0VUKFdURl9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgIiR7SkFWQVNDUklQVENP UkVfRElSfS93dGYvdW5pY29kZSIKICAgICAiJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L3d0Zi9kdG9h IgogICAgICIke0phdmFTY3JpcHRDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVN9IgorICAgICIke1RI SVJEUEFSVFlfRElSfSIKICkKIAogU0VUKFdURl9MSUJSQVJJRVMKICkKIAotCiBJRiAoRU5BQkxF X0ZBU1RfTUFMTE9DKQogICAgIExJU1QoQVBQRU5EIFdURl9TT1VSQ0VTCiAgICAgICAgIFRDU3lz dGVtQWxsb2MuY3BwCkBAIC0yMDEsMTUgKzIwMSw4IEBAIEVMU0UgKCkKICAgICBBRERfREVGSU5J VElPTlMoLURVU0VfU1lTVEVNX01BTExPQz0xKQogRU5ESUYoKQogCi0KLVNFVChXVEZfUE9SVF9G TEFHUyApCiBJTkNMVURFX0lGX0VYSVNUUygke0pBVkFTQ1JJUFRDT1JFX0RJUn0vd3RmL1BsYXRm b3JtJHtQT1JUfS5jbWFrZSkKIAotTElTVChBUFBFTkQgV1RGX0lOQ0xVREVfRElSRUNUT1JJRVMK LSAgICAiJHtDTUFLRV9CSU5BUllfRElSfSIKLSAgICAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3Vy Y2UvVGhpcmRQYXJ0eSIKLSkKLQogV0VCS0lUX1dSQVBfU09VUkNFTElTVCgke1dURl9TT1VSQ0VT fSkKIElOQ0xVREVfRElSRUNUT1JJRVMoJHtXVEZfSU5DTFVERV9ESVJFQ1RPUklFU30pCiBBRERf REVGSU5JVElPTlMoLURCVUlMRElOR19XVEYpCg==