7540 2006-03-01 13:19:39 -0800 REGRESSION: frequent cache-related crashes 2006-03-01 21:57:38 -0800 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Blocker --- 1 ap webkit-unassigned mitz oldest_to_newest 34667 0 ap 2006-03-01 13:19:39 -0800 After I landed my XMLHttpRequest patch, crashes started to happen frequently: Thread 2 Crashed: 0 <<00000000>> 0xfffeff20 objc_msgSend_rtp + 32 1 com.apple.Foundation 0x9291ecb0 _replacementObjectForObject + 124 2 com.apple.Foundation 0x9291eb04 _encodeObject_old + 156 3 com.apple.Foundation 0x9291f974 -[NSHTTPURLRequestParameters encodeWithCoder:] + 92 4 com.apple.Foundation 0x9291eb6c _encodeObject_old + 260 5 com.apple.Foundation 0x9291f04c -[NSURLRequest encodeWithCoder:] + 436 6 com.apple.Foundation 0x9291eb6c _encodeObject_old + 260 7 com.apple.Foundation 0x9291e584 -[NSURLCache _diskCacheExecuteWrite:] + 128 8 com.apple.Foundation 0x92917378 -[NSURLCache _diskCacheSync] + 256 9 com.apple.CoreFoundation 0x90770aec __CFRunLoopDoTimer + 184 10 com.apple.CoreFoundation 0x9075d464 __CFRunLoopRun + 1680 11 com.apple.CoreFoundation 0x9075ca18 CFRunLoopRunSpecific + 268 12 com.apple.Foundation 0x9290f9fc +[NSURLCache _diskCacheSyncLoop:] + 152 13 com.apple.Foundation 0x928e73b4 forkThreadForFunction + 108 14 libSystem.B.dylib 0x9002b1e0 _pthread_body + 96 I still don't see any problems in the code, but I have a patch that fixes (masks??) the issue. 34668 1 6794 ap 2006-03-01 13:22:29 -0800 Created attachment 6794 proposed fix The StringImpl change is actually unrelated - looks like a typo, found it while trying to isolate the problem. 34670 2 ap 2006-03-01 13:32:19 -0800 This change obviously needs comments like "this is a workaround for rdar://...", but I'm not sure what to write in this Radar yet. 34697 3 6794 darin 2006-03-01 19:49:49 -0800 Comment on attachment 6794 proposed fix r=me 34700 4 ap 2006-03-01 21:57:38 -0800 Filed the NSURLConnection problem as <rdar://4464032>, added the comment while landing. 6794 2006-03-01 13:22:29 -0800 2006-03-01 19:49:49 -0800 proposed fix 7540r1_patch.txt text/plain 2123 ap SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vU3RyaW5nSW1wbC5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGxhdGZvcm0vU3RyaW5nSW1wbC5oCShyZXZpc2lvbiAxMzA3MikKKysrIFdlYkNvcmUvcGxh dGZvcm0vU3RyaW5nSW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw3ICszNSw3IEBACiAjZW5k aWYKIAogI2lmIF9fT0JKQ19fCi1jbGFzcyBOU1N0cmluZzsKK0BjbGFzcyBOU1N0cmluZzsKICNl bmRpZgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkluZGV4OiBXZWJLaXQvV2ViQ29yZVN1cHBvcnQv V2ViRnJhbWVCcmlkZ2UubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvV2ViQ29yZVN1cHBvcnQvV2Vi RnJhbWVCcmlkZ2UubQkocmV2aXNpb24gMTMwNzIpCisrKyBXZWJLaXQvV2ViQ29yZVN1cHBvcnQv V2ViRnJhbWVCcmlkZ2UubQkod29ya2luZyBjb3B5KQpAQCAtNTQwLDcgKzU0MCw5IEBAIE5TU3Ry aW5nICpXZWJQbHVnaW5Db250YWluZXJLZXkgPSAgIEAiV2UKICAgICBOU011dGFibGVVUkxSZXF1 ZXN0ICpyZXF1ZXN0ID0gW1tOU011dGFibGVVUkxSZXF1ZXN0IGFsbG9jXSBpbml0V2l0aFVSTDpV UkxdOwogICAgIFtyZXF1ZXN0IHNldFRpbWVvdXRJbnRlcnZhbDoxMF07CiAKLSAgICBbcmVxdWVz dCBzZXRIVFRQTWV0aG9kOm1ldGhvZF07CisgICAgaWYgKCFbbWV0aG9kIGlzRXF1YWxUb1N0cmlu ZzpAIkdFVCJdKQorICAgICAgICBbcmVxdWVzdCBzZXRIVFRQTWV0aG9kOm1ldGhvZF07CisKICAg ICBpZiAocG9zdERhdGEpICAgICAgICAKICAgICAgICAgd2ViU2V0SFRUUEJvZHkocmVxdWVzdCwg cG9zdERhdGEpOwogCkluZGV4OiBXZWJLaXQvV2ViQ29yZVN1cHBvcnQvV2ViU3VicmVzb3VyY2VM b2FkZXIubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvV2ViQ29yZVN1cHBvcnQvV2ViU3VicmVzb3Vy Y2VMb2FkZXIubQkocmV2aXNpb24gMTMwNzIpCisrKyBXZWJLaXQvV2ViQ29yZVN1cHBvcnQvV2Vi U3VicmVzb3VyY2VMb2FkZXIubQkod29ya2luZyBjb3B5KQpAQCAtMTA2LDcgKzEwNiw4IEBACiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmb3JEYXRhU291cmNlOihXZWJEYXRhU291 cmNlICopc291cmNlCiB7CiAgICAgTlNNdXRhYmxlVVJMUmVxdWVzdCAqbmV3UmVxdWVzdCA9IFtb TlNNdXRhYmxlVVJMUmVxdWVzdCBhbGxvY10gaW5pdFdpdGhVUkw6VVJMXTsKLSAgICBbbmV3UmVx dWVzdCBzZXRIVFRQTWV0aG9kOm1ldGhvZF07CisgICAgaWYgKCFbbWV0aG9kIGlzRXF1YWxUb1N0 cmluZzpAIkdFVCJdKQorICAgICAgICBbbmV3UmVxdWVzdCBzZXRIVFRQTWV0aG9kOm1ldGhvZF07 CiAKICAgICBXZWJTdWJyZXNvdXJjZUxvYWRlciAqbG9hZGVyID0gW3NlbGYgc3RhcnRMb2FkaW5n UmVzb3VyY2U6ckxvYWRlciB3aXRoUmVxdWVzdDpuZXdSZXF1ZXN0IGN1c3RvbUhlYWRlcnM6Y3Vz dG9tSGVhZGVycyByZWZlcnJlcjpyZWZlcnJlciBmb3JEYXRhU291cmNlOnNvdXJjZV07CiAgICAg W25ld1JlcXVlc3QgcmVsZWFzZV07CkBAIC0xMjQsNyArMTI1LDkgQEAKIHsKICAgICBOU011dGFi bGVVUkxSZXF1ZXN0ICpuZXdSZXF1ZXN0ID0gW1tOU011dGFibGVVUkxSZXF1ZXN0IGFsbG9jXSBp bml0V2l0aFVSTDpVUkxdOwogCi0gICAgW25ld1JlcXVlc3Qgc2V0SFRUUE1ldGhvZDptZXRob2Rd OworICAgIGlmICghW21ldGhvZCBpc0VxdWFsVG9TdHJpbmc6QCJHRVQiXSkKKyAgICAgICAgW25l d1JlcXVlc3Qgc2V0SFRUUE1ldGhvZDptZXRob2RdOworCiAgICAgd2ViU2V0SFRUUEJvZHkobmV3 UmVxdWVzdCwgcG9zdERhdGEpOwogCiAgICAgV2ViU3VicmVzb3VyY2VMb2FkZXIgKmxvYWRlciA9 IFtzZWxmIHN0YXJ0TG9hZGluZ1Jlc291cmNlOnJMb2FkZXIgd2l0aFJlcXVlc3Q6bmV3UmVxdWVz dCBjdXN0b21IZWFkZXJzOmN1c3RvbUhlYWRlcnMgcmVmZXJyZXI6cmVmZXJyZXIgZm9yRGF0YVNv dXJjZTpzb3VyY2VdOwo=