75380 2011-12-30 01:44:41 -0800 [GTK] Allow to show context menu with keyboard in WebKit2 GTK+ 2012-01-04 03:08:54 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED DUPLICATE 72099 Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo jdiggs mario mrobinson pnormand webkit.review.bot oldest_to_newest 528101 0 cgarcia 2011-12-30 01:44:41 -0800 We just need to implement GtkWidget::popup-menu and emit a fake right click event. 528102 1 120787 cgarcia 2011-12-30 01:48:44 -0800 Created attachment 120787 Patch We don't have access to the current focused node, so it always shows the menu at the top-left corner like GtkLauncher and Firefox do when there's no focused node nor selections. 528103 2 webkit.review.bot 2011-12-30 01:53:22 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 528144 3 120787 mrobinson 2011-12-30 07:16:40 -0800 Comment on attachment 120787 Patch This actually isn't going to work, because it's going to determine the contents of the menu by doing a hittest at the location of the mouse event. For this to be accessible we need to get the currently focused node. I'll CC Joanie here because she has all of the requirements for this feature. 528146 4 jdiggs 2011-12-30 07:32:22 -0800 (In reply to comment #3) > (From update of attachment 120787 [details]) > This actually isn't going to work, because it's going to determine the contents of the menu by doing a hittest at the location of the mouse event. For this to be accessible we need to get the currently focused node. I'll CC Joanie here because she has all of the requirements for this feature. I think you do as well, Martin. ;) So I'm guessing that there's some particular aspect I'm not thinking of. In the meantime.... The context menu should base its context about what the user is in or on. * If that's a link, the menu should be for the link. * If it's a widget, it should be for that widget. * If the user is arrowing around the document via caret nav, it should be for the document. In the last case if, say, the caret is within a paragraph does that mean the focused node is that paragraph? If so, unless non-focusable content can have a unique context menu, I suppose you do not always need the currently focused node; just the currently-focused focusable element. If I failed to address any point which needs addressing, please let me know. And thanks for asking! :) 528160 5 mrobinson 2011-12-30 08:26:42 -0800 (In reply to comment #4) > In the last case if, say, the caret is within a paragraph does that mean the focused node is that paragraph? If so, unless non-focusable content can have a unique context menu, I suppose you do not always need the currently focused node; just the currently-focused focusable element. Perhaps it may be simpler to create a new IPC message that means "create a context menu event for the currently focused node." 528161 6 cgarcia 2011-12-30 08:27:16 -0800 (In reply to comment #3) > (From update of attachment 120787 [details]) > This actually isn't going to work, This works. > because it's going to determine the contents of the menu by doing a hittest at the location of the mouse event. For this to be accessible we need to get the currently focused node. I'll CC Joanie here because she has all of the requirements for this feature. The behaviour is exactly the same than wk1 or firefox when there isn't a focused item or selection. When wk2 allows to get the rectangle of the current focused node or selection we can just improve it to use it like I already did for wk1. 528164 7 mrobinson 2011-12-30 08:36:15 -0800 (In reply to comment #6) > This works. Okay. I agree this works when there is no focused node, but I think it's possible to create a more general solution that actually meets our accessibility requirements right now. > The behaviour is exactly the same than wk1 or firefox when there isn't a focused item or selection. When wk2 allows to get the rectangle of the current focused node or selection we can just improve it to use it like I already did for wk1. It's probably saner to just create a new IPC message than to try to determine the focused node in the UIProcess. 528166 8 cgarcia 2011-12-30 08:39:53 -0800 (In reply to comment #7) > (In reply to comment #6) > > > This works. > > Okay. I agree this works when there is no focused node, but I think it's possible to create a more general solution that actually meets our accessibility requirements right now. > > > The behaviour is exactly the same than wk1 or firefox when there isn't a focused item or selection. When wk2 allows to get the rectangle of the current focused node or selection we can just improve it to use it like I already did for wk1. > > It's probably saner to just create a new IPC message than to try to determine the focused node in the UIProcess. I've just found this bug https://bugs.webkit.org/show_bug.cgi?id=72099. That solution looks better than mine and we don't need to create a new IP message. 529431 9 cgarcia 2012-01-04 03:08:54 -0800 *** This bug has been marked as a duplicate of bug 72099 *** 120787 2011-12-30 01:48:44 -0800 2011-12-30 07:16:40 -0800 Patch wk2-keyboard-context-menu.diff text/plain 2930 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiNjVkNGJlLi4xM2M0NjE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMTItMzAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEFsbG93IHRvIHNob3cgY29udGV4dCBtZW51IHdpdGgga2V5Ym9h cmQgaW4gV2ViS2l0MiBHVEsrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03NTM4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwOgorICAg ICAgICAoY3JlYXRlUmlnaHRDbGlja0V2ZW50KTogSGVscGVyIGZ1bmN0aW9uIHRvIGNyZWF0ZSBh IGZha2UgcmlnaHQKKyAgICAgICAgY2xpY2sgZXZlbnQuCisgICAgICAgICh3ZWJraXRXZWJWaWV3 QmFzZVBvcHVwTWVudSk6IENyZWF0ZSBhIHJpZ2h0IGNsaWNrIGV2ZW50IGFuZCBzZW5kCisgICAg ICAgIGl0IHRvIHRoZSBwYWdlIHByb3h5LgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2Jhc2Vf Y2xhc3NfaW5pdCk6IEFkZCBpbXBsZW1lbnRhdGlvbiBmb3IKKyAgICAgICAgR3RrV2lkZ2V0Ojpw b3B1cC1tZW51LgorCiAyMDExLTEyLTI5ICBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8g IDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgW1F0XSBSZW1vdmUgdW51 c2VkIG1fc2lnbmFsTGlzdGVuZXJzIGZyb20gV29ya1F1ZXVlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKaW5kZXggYzM4 NzkwNS4uYjUwZWQ3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApAQCAtMzc5LDYgKzM3OSwzNSBAQCBzdGF0aWMg Z2Jvb2xlYW4gd2Via2l0V2ViVmlld0Jhc2VEcmFnRHJvcChHdGtXaWRnZXQqIHdpZGdldCwgR2Rr RHJhZ0NvbnRleHQqIGNvbgogICAgIHJldHVybiBUUlVFOwogfQogCitzdGF0aWMgdm9pZCBjcmVh dGVSaWdodENsaWNrRXZlbnQoR3RrV2lkZ2V0KiB3aWRnZXQsIEdka0V2ZW50QnV0dG9uKiBldmVu dCkKK3sKKyAgICBtZW1zZXQoZXZlbnQsIDAsIHNpemVvZihHZGtFdmVudEJ1dHRvbikpOworCisg ICAgZXZlbnQtPnR5cGUgPSBHREtfQlVUVE9OX1BSRVNTOworICAgIGV2ZW50LT5idXR0b24gPSAz OworCisgICAgLy8gV2UgZG9uJ3Qga25vdyB0aGUgY3VycmVudCBmb2N1c2VkIG5vZGUgb3Igd2hl dGhlciB3ZSBhcmUgb3ZlciBhIHNlbGVjdGlvbgorICAgIC8vIHNvIGp1c3QgcHV0IHRoZSBjb250 ZXh0IG1lbnUgaW50byB0aGUgY29ybmVyIG9mIHRoZSB2aWV3LCBvZmZzZXQgc2xpZ2h0bHkuCisg ICAgZXZlbnQtPnggPSBldmVudC0+eSA9IDE7CisgICAgSW50UG9pbnQgZ2xvYmFsUG9pbnQoY29u dmVydFdpZGdldFBvaW50VG9TY3JlZW5Qb2ludCh3aWRnZXQsIEludFBvaW50KGV2ZW50LT54LCBl dmVudC0+eSkpKTsKKyAgICBldmVudC0+eF9yb290ID0gZ2xvYmFsUG9pbnQueCgpOworICAgIGV2 ZW50LT55X3Jvb3QgPSBnbG9iYWxQb2ludC55KCk7Cit9CisKK3N0YXRpYyBnYm9vbGVhbiB3ZWJr aXRXZWJWaWV3QmFzZVBvcHVwTWVudShHdGtXaWRnZXQqIHdpZGdldCkKK3sKKyAgICBpZiAoIWd0 a193aWRnZXRfZ2V0X3JlYWxpemVkKHdpZGdldCkpCisgICAgICAgIHJldHVybiBGQUxTRTsKKwor ICAgIEdka0V2ZW50QnV0dG9uIGV2ZW50OworICAgIGNyZWF0ZVJpZ2h0Q2xpY2tFdmVudCh3aWRn ZXQsICZldmVudCk7CisKKyAgICBXZWJLaXRXZWJWaWV3QmFzZSogd2ViVmlld0Jhc2UgPSBXRUJL SVRfV0VCX1ZJRVdfQkFTRSh3aWRnZXQpOworICAgIHdlYlZpZXdCYXNlLT5wcml2LT5wYWdlUHJv eHktPmhhbmRsZU1vdXNlRXZlbnQoTmF0aXZlV2ViTW91c2VFdmVudChyZWludGVycHJldF9jYXN0 PEdka0V2ZW50Kj4oJmV2ZW50KSwgMSkpOworCisgICAgcmV0dXJuIFRSVUU7Cit9CisKIHN0YXRp YyB2b2lkIHdlYmtpdF93ZWJfdmlld19iYXNlX2NsYXNzX2luaXQoV2ViS2l0V2ViVmlld0Jhc2VD bGFzcyogd2Via2l0V2ViVmlld0Jhc2VDbGFzcykKIHsKICAgICBHdGtXaWRnZXRDbGFzcyogd2lk Z2V0Q2xhc3MgPSBHVEtfV0lER0VUX0NMQVNTKHdlYmtpdFdlYlZpZXdCYXNlQ2xhc3MpOwpAQCAt NDAwLDYgKzQyOSw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19iYXNlX2NsYXNzX2lu aXQoV2ViS2l0V2ViVmlld0Jhc2VDbGFzcyogd2Via2l0V2ViVmllCiAgICAgd2lkZ2V0Q2xhc3Mt PmRyYWdfbGVhdmUgPSB3ZWJraXRXZWJWaWV3QmFzZURyYWdMZWF2ZTsKICAgICB3aWRnZXRDbGFz cy0+ZHJhZ19kcm9wID0gd2Via2l0V2ViVmlld0Jhc2VEcmFnRHJvcDsKICAgICB3aWRnZXRDbGFz cy0+ZHJhZ19kYXRhX3JlY2VpdmVkID0gd2Via2l0V2ViVmlld0Jhc2VEcmFnRGF0YVJlY2VpdmVk OworICAgIHdpZGdldENsYXNzLT5wb3B1cF9tZW51ID0gd2Via2l0V2ViVmlld0Jhc2VQb3B1cE1l bnU7CiAKICAgICBHT2JqZWN0Q2xhc3MqIGdvYmplY3RDbGFzcyA9IEdfT0JKRUNUX0NMQVNTKHdl YmtpdFdlYlZpZXdCYXNlQ2xhc3MpOwogICAgIGdvYmplY3RDbGFzcy0+ZmluYWxpemUgPSB3ZWJr aXRXZWJWaWV3QmFzZUZpbmFsaXplOwo=