75372 2011-12-29 15:38:33 -0800 ListHashSetReverseIterator compilation error 2012-01-08 23:19:05 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wangxianzhu wangxianzhu darin hyatt webkit.review.bot oldest_to_newest 528035 0 wangxianzhu 2011-12-29 15:38:33 -0800 Using ListHashSetReverseIterator causes the following compilation error: third_party/WebKit/Source/JavaScriptCore/wtf/ListHashSet.h:319: error: 'WTF::ListHashSetConstIterator<ValueArg, inlineCapacity, HashArg>::ListHashSetConstIterator(const WTF::ListHashSet<Value, inlineCapacity, HashFunctions>*, WTF::ListHashSetNode<ValueArg, inlineCapacity>*) [with ValueArg = int, unsigned int inlineCapacity = 256u, HashArg = WTF::IntHash<unsigned int>]' is private third_party/WebKit/Source/JavaScriptCore/wtf/ListHashSet.h:387: error: within this context There is a typo in class ListHashSetReverseIterator: typedef ListHashSetConstIterator<ValueArg, inlineCapacity, HashArg> const_reverse_iterator; Should be typedef ListHashSetConstReverseIterator<ValueArg, inlineCapacity, HashArg> const_reverse_iterator; 528036 1 120770 wangxianzhu 2011-12-29 15:49:47 -0800 Created attachment 120770 patch 532002 2 120770 webkit.review.bot 2012-01-08 23:19:01 -0800 Comment on attachment 120770 patch Clearing flags on attachment: 120770 Committed r104436: <http://trac.webkit.org/changeset/104436> 532003 3 webkit.review.bot 2012-01-08 23:19:05 -0800 All reviewed patches have been landed. Closing bug. 120770 2011-12-29 15:49:47 -0800 2012-01-08 23:19:01 -0800 patch 75372 text/plain 1700 wangxianzhu SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAzODI5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDExLTEyLTI5ICBYaWFuemh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgRml4IGNvbXBpbGF0aW9uIGVycm9yIGFib3V0IExpc3RIYXNoU2V0UmV2ZXJzZUl0 ZXJhdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 NTM3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZXJlIGlzIGEgdHlwbyBpbiBjbGFzcyBMaXN0SGFzaFNldFJldmVyc2VJdGVyYXRvcjoKKyAgICAg ICAgdHlwZWRlZiBMaXN0SGFzaFNldENvbnN0SXRlcmF0b3I8VmFsdWVBcmcsIGlubGluZUNhcGFj aXR5LCBIYXNoQXJnPiBjb25zdF9yZXZlcnNlX2l0ZXJhdG9yOworICAgICAgICBTaG91bGQgYmUK KyAgICAgICAgdHlwZWRlZiBMaXN0SGFzaFNldENvbnN0UmV2ZXJzZUl0ZXJhdG9yPFZhbHVlQXJn LCBpbmxpbmVDYXBhY2l0eSwgSGFzaEFyZz4gY29uc3RfcmV2ZXJzZV9pdGVyYXRvcjsKKworICAg ICAgICAqIHd0Zi9MaXN0SGFzaFNldC5oOgorCiAyMDExLTEyLTI5ICBHYXZpbiBCYXJyYWNsb3Vn aCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzUxNDAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93 dGYvTGlzdEhhc2hTZXQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3Rm L0xpc3RIYXNoU2V0LmgJKHJldmlzaW9uIDEwMzgyOCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS93dGYvTGlzdEhhc2hTZXQuaAkod29ya2luZyBjb3B5KQpAQCAtMzc1LDcgKzM3NSw3IEBAIG5h bWVzcGFjZSBXVEYgewogICAgIHByaXZhdGU6CiAgICAgICAgIHR5cGVkZWYgTGlzdEhhc2hTZXQ8 VmFsdWVBcmcsIGlubGluZUNhcGFjaXR5LCBIYXNoQXJnPiBMaXN0SGFzaFNldFR5cGU7CiAgICAg ICAgIHR5cGVkZWYgTGlzdEhhc2hTZXRSZXZlcnNlSXRlcmF0b3I8VmFsdWVBcmcsIGlubGluZUNh cGFjaXR5LCBIYXNoQXJnPiByZXZlcnNlX2l0ZXJhdG9yOwotICAgICAgICB0eXBlZGVmIExpc3RI YXNoU2V0Q29uc3RJdGVyYXRvcjxWYWx1ZUFyZywgaW5saW5lQ2FwYWNpdHksIEhhc2hBcmc+IGNv bnN0X3JldmVyc2VfaXRlcmF0b3I7CisgICAgICAgIHR5cGVkZWYgTGlzdEhhc2hTZXRDb25zdFJl dmVyc2VJdGVyYXRvcjxWYWx1ZUFyZywgaW5saW5lQ2FwYWNpdHksIEhhc2hBcmc+IGNvbnN0X3Jl dmVyc2VfaXRlcmF0b3I7CiAgICAgICAgIHR5cGVkZWYgTGlzdEhhc2hTZXROb2RlPFZhbHVlQXJn LCBpbmxpbmVDYXBhY2l0eT4gTm9kZTsKICAgICAgICAgdHlwZWRlZiBWYWx1ZUFyZyBWYWx1ZVR5 cGU7CiAgICAgICAgIHR5cGVkZWYgVmFsdWVUeXBlJiBSZWZlcmVuY2VUeXBlOwo=