75364 2011-12-29 11:31:52 -0800 Use HashMap<OwnPtr> in RenderSVGResourceGradient 2012-01-03 11:08:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 75436 1 cmarcelo cmarcelo atwilson oldest_to_newest 527992 0 cmarcelo 2011-12-29 11:31:52 -0800 Use HashMap<OwnPtr> in RenderSVGResourceGradient 527993 1 120762 cmarcelo 2011-12-29 11:36:28 -0800 Created attachment 120762 Patch 528488 2 cmarcelo 2012-01-02 06:08:16 -0800 Committed r103905: <http://trac.webkit.org/changeset/103905> 528826 3 atwilson 2012-01-03 09:45:01 -0800 We are seeing valgrind errors on the chromium bots that seem to be caused by this change - as an example: <insert_a_suppression_name_here> Memcheck:Uninitialized fun:_ZN7WebCore16SkPMColorToColorEj fun:_ZN7WebCore11ImageBuffer27platformTransformColorSpaceERKN3WTF6VectorIiLm0EEE fun:_ZN7WebCore11ImageBuffer19transformColorSpaceENS_10ColorSpaceES1_ fun:_ZN7WebCore23RenderSVGResourceFilter17postApplyResourceEPNS_12RenderObjectERPNS_15GraphicsContextEtPKNS_4PathEPKNS_14RenderSVGShapeE fun:_ZN7WebCore16SVGRenderSupport22finishRenderSVGContentEPNS_12RenderObjectERNS_9PaintInfoEPNS_15GraphicsContextE fun:_ZN7WebCore14RenderSVGShape5paintERNS_9PaintInfoERKNS_8IntPointE fun:_ZN7WebCore9RenderBox5paintERNS_9PaintInfoERKNS_8IntPointE fun:_ZN7WebCore13RenderSVGRoot5paintERNS_9PaintInfoERKNS_8IntPointE fun:_ZN7WebCore9InlineBox5paintERNS_9PaintInfoERKNS_8IntPointEii fun:_ZN7WebCore13InlineFlowBox5paintERNS_9PaintInfoERKNS_8IntPointEii fun:_ZN7WebCore13RootInlineBox5paintERNS_9PaintInfoERKNS_8IntPointEii fun:_ZNK7WebCore17RenderLineBoxList5paintEPNS_20RenderBoxModelObjectERNS_9PaintInfoERKNS_8IntPointE fun:_ZN7WebCore11RenderBlock13paintContentsERNS_9PaintInfoERKNS_8IntPointE fun:_ZN7WebCore11RenderBlock11paintObjectERNS_9PaintInfoERKNS_8IntPointE fun:_ZN7WebCore11RenderBlock5paintERNS_9PaintInfoERKNS_8IntPointE fun:_ZN7WebCore11RenderBlock13paintChildrenERNS_9PaintInfoERKNS_8IntPointE fun:_ZN7WebCore11RenderBlock13paintContentsERNS_9PaintInfoERKNS_8IntPointE fun:_ZN7WebCore11RenderBlock11paintObjectERNS_9PaintInfoERKNS_8IntPointE fun:_ZN7WebCore11RenderBlock5paintERNS_9PaintInfoERKNS_8IntPointE fun:_ZN7WebCore11RenderBlock13paintChildrenERNS_9PaintInfoERKNS_8IntPointE fun:_ZN7WebCore11RenderBlock13paintContentsERNS_9PaintInfoERKNS_8IntPointE fun:_ZN7WebCore11RenderBlock11paintObjectERNS_9PaintInfoERKNS_8IntPointE } Does this seem related? 528840 4 cmarcelo 2012-01-03 10:33:54 -0800 (In reply to comment #3) > Does this seem related? Doesn't seem directly related. Which tests were run? How can I reproduce them in my machine (I have WebKit checkout compiled with --chromium)? I read some instructions about tools/valgrind but couldn't find it inside the WebKit tree (even after running update-webkit --chromium). 528867 5 atwilson 2012-01-03 11:08:36 -0800 It's not really possible to run valgrind from a webkit tree. OK, let's keep this resolved as "fixed" for now, and we'll see if the problem recurs or goes away in future valgrind build cycles - I'm not convinced that it's due to this change anyway). 120762 2011-12-29 11:36:28 -0800 2011-12-29 16:00:32 -0800 Patch bug-75364-20111229163742.patch text/plain 5114 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzODA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjMyZDlhNjRkMWRlZDM4 OGY5ZDI0YmJhMjI0ODViOTY5MWMxNTNlOS4uOWZiOTk3MTI3MTA4ZDk2YTNjNjcxYmJhODQ3OTI2 ZjE5ZmEwMjk4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDExLTEyLTI5ICBDYWlv IE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+ CiAKKyAgICAgICAgVXNlIEhhc2hNYXA8T3duUHRyPiBpbiBSZW5kZXJTVkdSZXNvdXJjZUdyYWRp ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTM2 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcmVu ZGVyaW5nL3N2Zy9SZW5kZXJTVkdSZXNvdXJjZUdyYWRpZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlclNWR1Jlc291cmNlR3JhZGllbnQ6OnJlbW92ZUFsbENsaWVudHNGcm9tQ2FjaGUp OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyU1ZHUmVzb3VyY2VHcmFkaWVudDo6cmVtb3ZlQ2xp ZW50RnJvbUNhY2hlKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclNWR1Jlc291cmNlR3JhZGll bnQ6OmFwcGx5UmVzb3VyY2UpOiBhdm9pZCBsb29raW5nCisgICAgICAgIHVwIHRoZSBoYXNoIHR3 aWNlIGJ5IHVzaW5nIEhhc2hNYXA6OmFkZCgpLgorICAgICAgICAqIHJlbmRlcmluZy9zdmcvUmVu ZGVyU1ZHUmVzb3VyY2VHcmFkaWVudC5oOiByZW5hbWUgbV9ncmFkaWVudCB0byBtX2dyYWRpZW50 TWFwLgorCisyMDExLTEyLTI5ICBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlv Lm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CisKICAgICAgICAgVXNlIEhhc2hNYXA8T3duUHRyPiBp biBPcmlnaW5BY2Nlc3NNYXAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc1MzI3CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9z dmcvUmVuZGVyU1ZHUmVzb3VyY2VHcmFkaWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvc3ZnL1JlbmRlclNWR1Jlc291cmNlR3JhZGllbnQuY3BwCmluZGV4IGI1MzczZTRmZjNhYjc0 MzEzNjQzOGU2YmViZTNkYWUwZTY1MmNlYjUuLjY2ZDQ1NGJjZmEyOGUyNzNlMmZiOTc3Y2Y4YzBm MThiNzFjZGMzZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVu ZGVyU1ZHUmVzb3VyY2VHcmFkaWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L3N2Zy9SZW5kZXJTVkdSZXNvdXJjZUdyYWRpZW50LmNwcApAQCAtNDQsMjIgKzQ0LDkgQEAgUmVu ZGVyU1ZHUmVzb3VyY2VHcmFkaWVudDo6UmVuZGVyU1ZHUmVzb3VyY2VHcmFkaWVudChTVkdHcmFk aWVudEVsZW1lbnQqIG5vZGUpCiB7CiB9CiAKLVJlbmRlclNWR1Jlc291cmNlR3JhZGllbnQ6On5S ZW5kZXJTVkdSZXNvdXJjZUdyYWRpZW50KCkKLXsKLSAgICBpZiAobV9ncmFkaWVudC5pc0VtcHR5 KCkpCi0gICAgICAgIHJldHVybjsKLQotICAgIGRlbGV0ZUFsbFZhbHVlcyhtX2dyYWRpZW50KTsK LSAgICBtX2dyYWRpZW50LmNsZWFyKCk7Ci19Ci0KIHZvaWQgUmVuZGVyU1ZHUmVzb3VyY2VHcmFk aWVudDo6cmVtb3ZlQWxsQ2xpZW50c0Zyb21DYWNoZShib29sIG1hcmtGb3JJbnZhbGlkYXRpb24p CiB7Ci0gICAgaWYgKCFtX2dyYWRpZW50LmlzRW1wdHkoKSkgewotICAgICAgICBkZWxldGVBbGxW YWx1ZXMobV9ncmFkaWVudCk7Ci0gICAgICAgIG1fZ3JhZGllbnQuY2xlYXIoKTsKLSAgICB9Ci0K KyAgICBtX2dyYWRpZW50TWFwLmNsZWFyKCk7CiAgICAgbV9zaG91bGRDb2xsZWN0R3JhZGllbnRB dHRyaWJ1dGVzID0gdHJ1ZTsKICAgICBtYXJrQWxsQ2xpZW50c0ZvckludmFsaWRhdGlvbihtYXJr Rm9ySW52YWxpZGF0aW9uID8gUmVwYWludEludmFsaWRhdGlvbiA6IFBhcmVudE9ubHlJbnZhbGlk YXRpb24pOwogfQpAQCAtNjcsMTAgKzU0LDcgQEAgdm9pZCBSZW5kZXJTVkdSZXNvdXJjZUdyYWRp ZW50OjpyZW1vdmVBbGxDbGllbnRzRnJvbUNhY2hlKGJvb2wgbWFya0ZvckludmFsaWRhdGkKIHZv aWQgUmVuZGVyU1ZHUmVzb3VyY2VHcmFkaWVudDo6cmVtb3ZlQ2xpZW50RnJvbUNhY2hlKFJlbmRl ck9iamVjdCogY2xpZW50LCBib29sIG1hcmtGb3JJbnZhbGlkYXRpb24pCiB7CiAgICAgQVNTRVJU KGNsaWVudCk7Ci0KLSAgICBpZiAobV9ncmFkaWVudC5jb250YWlucyhjbGllbnQpKQotICAgICAg ICBkZWxldGUgbV9ncmFkaWVudC50YWtlKGNsaWVudCk7Ci0KKyAgICBtX2dyYWRpZW50TWFwLnJl bW92ZShjbGllbnQpOwogICAgIG1hcmtDbGllbnRGb3JJbnZhbGlkYXRpb24oY2xpZW50LCBtYXJr Rm9ySW52YWxpZGF0aW9uID8gUmVwYWludEludmFsaWRhdGlvbiA6IFBhcmVudE9ubHlJbnZhbGlk YXRpb24pOwogfQogCkBAIC0xNjgsMTUgKzE1MiwxNSBAQCBib29sIFJlbmRlclNWR1Jlc291cmNl R3JhZGllbnQ6OmFwcGx5UmVzb3VyY2UoUmVuZGVyT2JqZWN0KiBvYmplY3QsIFJlbmRlclN0eWxl KgogICAgIGlmIChncmFkaWVudFVuaXRzKCkgPT0gU1ZHVW5pdFR5cGVzOjpTVkdfVU5JVF9UWVBF X09CSkVDVEJPVU5ESU5HQk9YICYmIG9iamVjdEJvdW5kaW5nQm94LmlzRW1wdHkoKSkKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogCi0gICAgaWYgKCFtX2dyYWRpZW50LmNvbnRhaW5zKG9iamVjdCkp Ci0gICAgICAgIG1fZ3JhZGllbnQuc2V0KG9iamVjdCwgbmV3IEdyYWRpZW50RGF0YSk7CisgICAg T3duUHRyPEdyYWRpZW50RGF0YT4mIGdyYWRpZW50RGF0YSA9IG1fZ3JhZGllbnRNYXAuYWRkKG9i amVjdCwgbnVsbHB0cikuZmlyc3QtPnNlY29uZDsKKyAgICBpZiAoIWdyYWRpZW50RGF0YSkKKyAg ICAgICAgZ3JhZGllbnREYXRhID0gYWRvcHRQdHIobmV3IEdyYWRpZW50RGF0YSk7CiAKLSAgICBH cmFkaWVudERhdGEqIGdyYWRpZW50RGF0YSA9IG1fZ3JhZGllbnQuZ2V0KG9iamVjdCk7CiAgICAg Ym9vbCBpc1BhaW50aW5nVGV4dCA9IHJlc291cmNlTW9kZSAmIEFwcGx5VG9UZXh0TW9kZTsKIAog ICAgIC8vIENyZWF0ZSBncmFkaWVudCBvYmplY3QKICAgICBpZiAoIWdyYWRpZW50RGF0YS0+Z3Jh ZGllbnQpIHsKLSAgICAgICAgYnVpbGRHcmFkaWVudChncmFkaWVudERhdGEpOworICAgICAgICBi dWlsZEdyYWRpZW50KGdyYWRpZW50RGF0YS5nZXQoKSk7CiAKICAgICAgICAgLy8gQ0cgcGxhdGZv cm1zIHdpbGwgaGFuZGxlIHRoZSBncmFkaWVudCBzcGFjZSB0cmFuc2Zvcm0gZm9yIHRleHQgYWZ0 ZXIgYXBwbHlpbmcgdGhlCiAgICAgICAgIC8vIHJlc291cmNlLCBzbyBkb24ndCBhcHBseSBpdCBo ZXJlLiBGb3Igbm9uLUNHIHBsYXRmb3Jtcywgd2Ugd2FudCB0aGUgdGV4dCBib3VuZGluZwpAQCAt MjQwLDkgKzIyNCw4IEBAIHZvaWQgUmVuZGVyU1ZHUmVzb3VyY2VHcmFkaWVudDo6cG9zdEFwcGx5 UmVzb3VyY2UoUmVuZGVyT2JqZWN0KiBvYmplY3QsIEdyYXBoaWNzCiAgICAgaWYgKHJlc291cmNl TW9kZSAmIEFwcGx5VG9UZXh0TW9kZSkgewogI2lmIFVTRShDRykKICAgICAgICAgLy8gQ0cgcmVx dWlyZXMgc3BlY2lhbCBoYW5kbGluZyBmb3IgZ3JhZGllbnQgb24gdGV4dAotICAgICAgICBpZiAo bV9zYXZlZENvbnRleHQgJiYgbV9ncmFkaWVudC5jb250YWlucyhvYmplY3QpKSB7Ci0gICAgICAg ICAgICBHcmFkaWVudERhdGEqIGdyYWRpZW50RGF0YSA9IG1fZ3JhZGllbnQuZ2V0KG9iamVjdCk7 Ci0KKyAgICAgICAgR3JhZGllbnREYXRhKiBncmFkaWVudERhdGE7CisgICAgICAgIGlmIChtX3Nh dmVkQ29udGV4dCAmJiBncmFkaWVudERhdGEgPSBtX2dyYWRpZW50TWFwLmdldChvYmplY3QpKSB7 CiAgICAgICAgICAgICAvLyBSZXN0b3JlIG9uLXNjcmVlbiBkcmF3aW5nIGNvbnRleHQKICAgICAg ICAgICAgIGNvbnRleHQgPSBtX3NhdmVkQ29udGV4dDsKICAgICAgICAgICAgIG1fc2F2ZWRDb250 ZXh0ID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVy U1ZHUmVzb3VyY2VHcmFkaWVudC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5k ZXJTVkdSZXNvdXJjZUdyYWRpZW50LmgKaW5kZXggYjdlNzgwY2JkMDc1M2MwNzVhOTJmYWJiOTcz NTJiYTg5YjFkMDIwZi4uZDMwYTZiMzQ1ZDVhNmExYzJmNTNmYjdiYWJkNTRjZmQ4MTY0YjgzZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdSZXNvdXJj ZUdyYWRpZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdS ZXNvdXJjZUdyYWRpZW50LmgKQEAgLTQ0LDcgKzQ0LDYgQEAgY2xhc3MgR3JhcGhpY3NDb250ZXh0 OwogY2xhc3MgUmVuZGVyU1ZHUmVzb3VyY2VHcmFkaWVudCA6IHB1YmxpYyBSZW5kZXJTVkdSZXNv dXJjZUNvbnRhaW5lciB7CiBwdWJsaWM6CiAgICAgUmVuZGVyU1ZHUmVzb3VyY2VHcmFkaWVudChT VkdHcmFkaWVudEVsZW1lbnQqKTsKLSAgICB2aXJ0dWFsIH5SZW5kZXJTVkdSZXNvdXJjZUdyYWRp ZW50KCk7CiAKICAgICB2aXJ0dWFsIHZvaWQgcmVtb3ZlQWxsQ2xpZW50c0Zyb21DYWNoZShib29s IG1hcmtGb3JJbnZhbGlkYXRpb24gPSB0cnVlKTsKICAgICB2aXJ0dWFsIHZvaWQgcmVtb3ZlQ2xp ZW50RnJvbUNhY2hlKFJlbmRlck9iamVjdCosIGJvb2wgbWFya0ZvckludmFsaWRhdGlvbiA9IHRy dWUpOwpAQCAtNjUsNyArNjQsNyBAQCBwcm90ZWN0ZWQ6CiAKIHByaXZhdGU6CiAgICAgYm9vbCBt X3Nob3VsZENvbGxlY3RHcmFkaWVudEF0dHJpYnV0ZXMgOiAxOwotICAgIEhhc2hNYXA8UmVuZGVy T2JqZWN0KiwgR3JhZGllbnREYXRhKj4gbV9ncmFkaWVudDsKKyAgICBIYXNoTWFwPFJlbmRlck9i amVjdCosIE93blB0cjxHcmFkaWVudERhdGE+ID4gbV9ncmFkaWVudE1hcDsKIAogI2lmIFVTRShD RykKICAgICBHcmFwaGljc0NvbnRleHQqIG1fc2F2ZWRDb250ZXh0Owo=