75346 2011-12-29 05:26:17 -0800 Use HashMap<OwnPtr> for SourceProviderCache items 2012-01-06 12:20:46 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cmarcelo cmarcelo darin dbates webkit.review.bot oldest_to_newest 527891 0 cmarcelo 2011-12-29 05:26:17 -0800 Use HashMap<OwnPtr> for SourceProviderCache items 527892 1 120735 cmarcelo 2011-12-29 05:26:53 -0800 Created attachment 120735 Patch 527894 2 cmarcelo 2011-12-29 05:30:57 -0800 I couldn't make it work just with the forward declaration to SourceProviderCacheItem. I thought having the destructor for SourceProviderCache defined in the cpp would be enough, but in this case isn't. I think that's because the HashMap containing the OwnPtrs is a member itself -- c.f. the PageGroup that have the maps inside OwnPtrs. But I might be missing something. 528567 3 120735 menard 2012-01-02 12:47:19 -0800 Comment on attachment 120735 Patch LGTM. 531258 4 120735 webkit.review.bot 2012-01-06 12:20:42 -0800 Comment on attachment 120735 Patch Clearing flags on attachment: 120735 Committed r104318: <http://trac.webkit.org/changeset/104318> 531259 5 webkit.review.bot 2012-01-06 12:20:46 -0800 All reviewed patches have been landed. Closing bug. 120735 2011-12-29 05:26:53 -0800 2012-01-06 12:20:42 -0800 Patch bug-75346-20111229102806.patch text/plain 3278 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzNzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 NDNlOWFhOWNlMjM3ZGYzZTZhYzFkMTEyMzQzNGJkZDBjOTY5MjMyLi40YWQyODVmZmRiMGFjOTVh NjE1NDY3YzdlZDcwNjYyYjI3MTEwMzQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMS0xMi0yOSAgQ2FpbyBNYXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8 Y2Fpby5vbGl2ZWlyYUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFVzZSBIYXNoTWFwPE93blB0 cj4gZm9yIFNvdXJjZVByb3ZpZGVyQ2FjaGUgaXRlbXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1MzQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYXJzZXIvUGFyc2VyLmNwcDoKKyAgICAgICAgKiBw YXJzZXIvU291cmNlUHJvdmlkZXJDYWNoZS5jcHA6CisgICAgICAgIChKU0M6OlNvdXJjZVByb3Zp ZGVyQ2FjaGU6OmNsZWFyKToKKyAgICAgICAgKEpTQzo6U291cmNlUHJvdmlkZXJDYWNoZTo6YWRk KToKKyAgICAgICAgKiBwYXJzZXIvU291cmNlUHJvdmlkZXJDYWNoZS5oOgorCiAyMDExLTEyLTI4 ICBZdXFpYW5nIFhpYW4gIDx5dXFpYW5nLnhpYW5AaW50ZWwuY29tPgogCiAgICAgICAgIHNwaWxs IHVuYm94ZWQgdmFsdWVzIGluIERGRyAzMl82NApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9Q YXJzZXIuY3BwCmluZGV4IDdmYjI4NWE2YmM1ZGY3OTMzNmM2ZGVjM2UzYTdiNTYxMTZjZGNmMWEu LjVjMmYwMzgzZmEwNmZlN2QyNjEwYTg5MjIyMDA4MzcwYWQ5MmQyMGIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAKQEAgLTMwLDcgKzMwLDYgQEAKICNpbmNsdWRlICJM ZXhlci5oIgogI2luY2x1ZGUgIk5vZGVJbmZvLmgiCiAjaW5jbHVkZSAiU291cmNlUHJvdmlkZXIu aCIKLSNpbmNsdWRlICJTb3VyY2VQcm92aWRlckNhY2hlSXRlbS5oIgogI2luY2x1ZGUgPHV0aWxp dHk+CiAjaW5jbHVkZSA8d3RmL0hhc2hGdW5jdGlvbnMuaD4KICNpbmNsdWRlIDx3dGYvT3duUHRy Lmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1NvdXJjZVByb3Zp ZGVyQ2FjaGUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9Tb3VyY2VQcm92aWRl ckNhY2hlLmNwcAppbmRleCBhZmVlYzUyODMwZjUxNjM4MWQ5NTJkMDNlNzMyYzg2NGFiNWQ5NzVm Li5hZDFjYmUwMmU3NjQxMDQ5ZDYxOTMyYTUxNzUxYjJjMTZjYjJjNGQ4IDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1NvdXJjZVByb3ZpZGVyQ2FjaGUuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvU291cmNlUHJvdmlkZXJDYWNoZS5jcHAKQEAg LTI2LDggKzI2LDYgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJTb3VyY2VQcm92 aWRlckNhY2hlLmgiCiAKLSNpbmNsdWRlICJTb3VyY2VQcm92aWRlckNhY2hlSXRlbS5oIgotCiBu YW1lc3BhY2UgSlNDIHsKIAogU291cmNlUHJvdmlkZXJDYWNoZTo6flNvdXJjZVByb3ZpZGVyQ2Fj aGUoKQpAQCAtMzcsNyArMzUsNiBAQCBTb3VyY2VQcm92aWRlckNhY2hlOjp+U291cmNlUHJvdmlk ZXJDYWNoZSgpCiAKIHZvaWQgU291cmNlUHJvdmlkZXJDYWNoZTo6Y2xlYXIoKQogewotICAgIGRl bGV0ZUFsbFZhbHVlcyhtX21hcCk7CiAgICAgbV9tYXAuY2xlYXIoKTsKICAgICBtX2NvbnRlbnRC eXRlU2l6ZSA9IDA7CiB9CkBAIC00OSw3ICs0Niw3IEBAIHVuc2lnbmVkIFNvdXJjZVByb3ZpZGVy Q2FjaGU6OmJ5dGVTaXplKCkgY29uc3QKIAogdm9pZCBTb3VyY2VQcm92aWRlckNhY2hlOjphZGQo aW50IHNvdXJjZVBvc2l0aW9uLCBQYXNzT3duUHRyPFNvdXJjZVByb3ZpZGVyQ2FjaGVJdGVtPiBp dGVtLCB1bnNpZ25lZCBzaXplKQogewotICAgIG1fbWFwLmFkZChzb3VyY2VQb3NpdGlvbiwgaXRl bS5sZWFrUHRyKCkpOworICAgIG1fbWFwLmFkZChzb3VyY2VQb3NpdGlvbiwgaXRlbSk7CiAgICAg bV9jb250ZW50Qnl0ZVNpemUgKz0gc2l6ZTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3BhcnNlci9Tb3VyY2VQcm92aWRlckNhY2hlLmggYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcGFyc2VyL1NvdXJjZVByb3ZpZGVyQ2FjaGUuaAppbmRleCBjN2YzMzJkMzg3ZWIyZGM3 NTNkYjkyN2JjNzNhNDE2OWJkNjJhODNhLi5lOTQyMzBkMTAxZGQ0OWNlOTIwOTRlOTQwMmIxYTM5 YjNhMWVlMWVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1NvdXJj ZVByb3ZpZGVyQ2FjaGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1NvdXJj ZVByb3ZpZGVyQ2FjaGUuaApAQCAtMjYsMTMgKzI2LDEzIEBACiAjaWZuZGVmIFNvdXJjZVByb3Zp ZGVyQ2FjaGVfaAogI2RlZmluZSBTb3VyY2VQcm92aWRlckNhY2hlX2gKIAorI2luY2x1ZGUgIlNv dXJjZVByb3ZpZGVyQ2FjaGVJdGVtLmgiCiAjaW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KKyNpbmNs dWRlIDx3dGYvT3duUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1Bhc3NPd25QdHIuaD4KIAogbmFtZXNw YWNlIEpTQyB7CiAKLWNsYXNzIFNvdXJjZVByb3ZpZGVyQ2FjaGVJdGVtOwotCiBjbGFzcyBTb3Vy Y2VQcm92aWRlckNhY2hlIHsKIHB1YmxpYzoKICAgICBTb3VyY2VQcm92aWRlckNhY2hlKCkgOiBt X2NvbnRlbnRCeXRlU2l6ZSgwKSB7fQpAQCAtNDQsNyArNDQsNyBAQCBwdWJsaWM6CiAgICAgY29u c3QgU291cmNlUHJvdmlkZXJDYWNoZUl0ZW0qIGdldChpbnQgc291cmNlUG9zaXRpb24pIGNvbnN0 IHsgcmV0dXJuIG1fbWFwLmdldChzb3VyY2VQb3NpdGlvbik7IH0KIAogcHJpdmF0ZToKLSAgICBI YXNoTWFwPGludCwgU291cmNlUHJvdmlkZXJDYWNoZUl0ZW0qPiBtX21hcDsKKyAgICBIYXNoTWFw PGludCwgT3duUHRyPFNvdXJjZVByb3ZpZGVyQ2FjaGVJdGVtPiA+IG1fbWFwOwogICAgIHVuc2ln bmVkIG1fY29udGVudEJ5dGVTaXplOwogfTsKIAo=