75320 2011-12-28 12:29:27 -0800 Move dispatchSentMessagesUntil out of the RunLoop class. 2012-01-02 15:08:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam levin+threading webkit.review.bot oldest_to_newest 527733 0 sam 2011-12-28 12:29:27 -0800 Move dispatchSentMessagesUntil out of the RunLoop class. 527734 1 120690 sam 2011-12-28 12:29:55 -0800 Created attachment 120690 Patch 528587 2 120690 mitz 2012-01-02 15:01:11 -0800 Comment on attachment 120690 Patch Please remove the declaration from RunLoop.h 528589 3 sam 2012-01-02 15:08:16 -0800 Committed r103912: <http://trac.webkit.org/changeset/103912> 120690 2011-12-28 12:29:55 -0800 2012-01-02 15:01:11 -0800 Patch bug-75320-20111228153031.patch text/plain 6763 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzc3NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDExLTEyLTI4ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTW92ZSBkaXNwYXRjaFNlbnRNZXNzYWdl c1VudGlsIG91dCBvZiB0aGUgUnVuTG9vcCBjbGFzcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1MzIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3Bw OgorICAgICAgICAoQ29yZUlQQzo6Q29ubmVjdGlvbjo6U3luY01lc3NhZ2VTdGF0ZTo6d2FpdFdo aWxlRGlzcGF0Y2hpbmdTZW50V2luMzJNZXNzYWdlcyk6CisgICAgICAgICogUGxhdGZvcm0vQ29y ZUlQQy9Db25uZWN0aW9uLmg6CisgICAgICAgICogUGxhdGZvcm0vQ29yZUlQQy93aW4vQ29ubmVj dGlvbldpbi5jcHA6CisgICAgICAgIChDb3JlSVBDOjpDb25uZWN0aW9uOjpkaXNwYXRjaFNlbnRN ZXNzYWdlc1VudGlsKToKKyAgICAgICAgKiBQbGF0Zm9ybS93aW4vUnVuTG9vcFdpbi5jcHA6CisK IDIwMTEtMTItMjggIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgogCiAgICAg ICAgIFtRdF1bV0syXSBDcmFzaCBpbiB+V2ViR3JhcGhpY3NMYXllciB3aGVuIHJ1bm5pbmcgZmFz dC9tdWx0aWNvbC9wYWdpbmF0aW9uLSogdGVzdHMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1BsYXRm b3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv UGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcAkocmV2aXNpb24gMTAzNjcxKQorKysgU291 cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNTMsNyArNTMsNyBAQCBwdWJsaWM6CiAjaWYgUExBVEZPUk0oV0lOKQogICAgIGJvb2wg d2FpdFdoaWxlRGlzcGF0Y2hpbmdTZW50V2luMzJNZXNzYWdlcyhkb3VibGUgYWJzb2x1dGVUaW1l LCBjb25zdCBWZWN0b3I8SFdORD4mIHdpbmRvd3NUb1JlY2VpdmVNZXNzYWdlcykKICAgICB7Ci0g ICAgICAgIHJldHVybiBSdW5Mb29wOjpkaXNwYXRjaFNlbnRNZXNzYWdlc1VudGlsKHdpbmRvd3NU b1JlY2VpdmVNZXNzYWdlcywgbV93YWl0Rm9yU3luY1JlcGx5U2VtYXBob3JlLCBhYnNvbHV0ZVRp bWUpOworICAgICAgICByZXR1cm4gQ29ubmVjdGlvbjo6ZGlzcGF0Y2hTZW50TWVzc2FnZXNVbnRp bCh3aW5kb3dzVG9SZWNlaXZlTWVzc2FnZXMsIG1fd2FpdEZvclN5bmNSZXBseVNlbWFwaG9yZSwg YWJzb2x1dGVUaW1lKTsKICAgICB9CiAjZW5kaWYKIApJbmRleDogU291cmNlL1dlYktpdDIvUGxh dGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv UGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmgJKHJldmlzaW9uIDEwMzY3MSkKKysrIFNvdXJj ZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBA IC0zMzUsNiArMzM1LDkgQEAgcHJpdmF0ZToKICAgICB2b2lkIHJlYWRFdmVudEhhbmRsZXIoKTsK ICAgICB2b2lkIHdyaXRlRXZlbnRIYW5kbGVyKCk7CiAKKyAgICAvLyBDYWxsZWQgYnkgQ29ubmVj dGlvbjo6U3luY01lc3NhZ2VTdGF0ZTo6d2FpdFdoaWxlRGlzcGF0Y2hpbmdTZW50V2luMzJNZXNz YWdlcy4KKyAgICBzdGF0aWMgdm9pZCBkaXNwYXRjaFNlbnRNZXNzYWdlc1VudGlsKGNvbnN0IFZl Y3RvcjxIV05EPiYgd2luZG93cywgQ29yZUlQQzo6QmluYXJ5U2VtYXBob3JlJiBzZW1hcGhvcmUs IGRvdWJsZSBhYnNvbHV0ZVRpbWUpOworCiAgICAgVmVjdG9yPHVpbnQ4X3Q+IG1fcmVhZEJ1ZmZl cjsKICAgICBPVkVSTEFQUEVEIG1fcmVhZFN0YXRlOwogICAgIE93blB0cjxBcmd1bWVudEVuY29k ZXI+IG1fcGVuZGluZ1dyaXRlQXJndW1lbnRzOwpJbmRleDogU291cmNlL1dlYktpdDIvUGxhdGZv cm0vQ29yZUlQQy93aW4vQ29ubmVjdGlvbldpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvUGxhdGZvcm0vQ29yZUlQQy93aW4vQ29ubmVjdGlvbldpbi5jcHAJKHJldmlzaW9uIDEw MzY3MSkKKysrIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvd2luL0Nvbm5lY3Rpb25X aW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw5ICszMiw2IEBACiAjaW5jbHVkZSA8d3RmL3Rl eHQvV1RGU3RyaW5nLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBzdGQ7Ci0vLyBXZSBleHBsaWNpdGx5 IGRvbid0IHVzZSB0aGUgV2ViQ29yZSBuYW1lc3BhY2UgaGVyZSBiZWNhdXNlIENvcmVJUEMgc2hv dWxkIG9ubHkgdXNlIFdURiB0eXBlcyBhbmQKLS8vIFdURjo6U3RyaW5nIGlzIHJlYWxseSBpbiBX VEYuCi11c2luZyBXVEY6OlN0cmluZzsKICAKIG5hbWVzcGFjZSBDb3JlSVBDIHsKIApAQCAtMzE5 LDQgKzMxNiw0NSBAQCBib29sIENvbm5lY3Rpb246OnNlbmRPdXRnb2luZ01lc3NhZ2UoTWVzCiAg ICAgcmV0dXJuIGZhbHNlOwogfQogCitib29sIENvbm5lY3Rpb246OmRpc3BhdGNoU2VudE1lc3Nh Z2VzVW50aWwoY29uc3QgVmVjdG9yPEhXTkQ+JiB3aW5kb3dzLCBDb3JlSVBDOjpCaW5hcnlTZW1h cGhvcmUmIHNlbWFwaG9yZSwgZG91YmxlIGFic29sdXRlVGltZSkKK3sKKyAgICBpZiAod2luZG93 cy5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybiBzZW1hcGhvcmUud2FpdChhYnNvbHV0ZVRpbWUp OworCisgICAgSEFORExFIGhhbmRsZSA9IHNlbWFwaG9yZS5ldmVudCgpOworICAgIERXT1JEIGhh bmRsZUNvdW50ID0gMTsKKworICAgIHdoaWxlICh0cnVlKSB7CisgICAgICAgIERXT1JEIGludGVy dmFsID0gYWJzb2x1dGVUaW1lVG9XYWl0VGltZW91dEludGVydmFsKGFic29sdXRlVGltZSk7Cisg ICAgICAgIGlmICghaW50ZXJ2YWwpIHsKKyAgICAgICAgICAgIC8vIENvbnNpZGVyIHRoZSB3YWl0 IHRvIGhhdmUgdGltZWQgb3V0LCBldmVuIGlmIHRoZSBzZW1hcGhvcmUgaXMgY3VycmVudGx5IHNp Z25hbGVkLgorICAgICAgICAgICAgLy8gVGhpcyBtYXRjaGVzIHRoZSBXVEY6OlRocmVhZENvbmRp dGlvbiBpbXBsZW1lbnRhdGlvbiBvZiBCaW5hcnlTZW1hcGhvcmU6OndhaXQuCisgICAgICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgICAgIH0KKworICAgICAgICBEV09SRCByZXN1bHQgPSA6Ok1z Z1dhaXRGb3JNdWx0aXBsZU9iamVjdHNFeChoYW5kbGVDb3VudCwgJmhhbmRsZSwgaW50ZXJ2YWws IFFTX1NFTkRNRVNTQUdFLCAwKTsKKyAgICAgICAgaWYgKHJlc3VsdCA9PSBXQUlUX09CSkVDVF8w KSB7CisgICAgICAgICAgICAvLyBUaGUgc2VtYXBob3JlIHdhcyBzaWduYWxlZC4KKyAgICAgICAg ICAgIHJldHVybiB0cnVlOworICAgICAgICB9CisgICAgICAgIGlmIChyZXN1bHQgPT0gV0FJVF9U SU1FT1VUKSB7CisgICAgICAgICAgICAvLyBhYnNvbHV0ZVRpbWUgd2FzIHJlYWNoZWQuCisgICAg ICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIH0KKyAgICAgICAgaWYgKHJlc3VsdCA9PSBX QUlUX09CSkVDVF8wICsgaGFuZGxlQ291bnQpIHsKKyAgICAgICAgICAgIC8vIE9uZSBvciBtb3Jl IHNlbnQgbWVzc2FnZXMgYXJlIGF2YWlsYWJsZS4gUHJvY2VzcyBzZW50IG1lc3NhZ2VzIGZvciBh bGwgdGhlIHdpbmRvd3MKKyAgICAgICAgICAgIC8vIHdlIHdlcmUgZ2l2ZW4sIHNpbmNlIHdlIGRv bid0IGhhdmUgYSB3YXkgb2Yga25vd2luZyB3aGljaCB3aW5kb3cgaGFzIGF2YWlsYWJsZSBzZW50 CisgICAgICAgICAgICAvLyBtZXNzYWdlcy4KKyAgICAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAw OyBpIDwgd2luZG93cy5zaXplKCk7ICsraSkgeworICAgICAgICAgICAgICAgIE1TRyBtZXNzYWdl OworICAgICAgICAgICAgICAgIDo6UGVla01lc3NhZ2VXKCZtZXNzYWdlLCB3aW5kb3dzW2ldLCAw LCAwLCBQTV9OT1JFTU9WRSB8IFBNX1FTX1NFTkRNRVNTQUdFKTsKKyAgICAgICAgICAgIH0KKyAg ICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICB9CisgICAgICAgIEFTU0VSVF9XSVRIX01FU1NB R0UocmVzdWx0ICE9IFdBSVRfRkFJTEVELCAiOjpNc2dXYWl0Rm9yTXVsdGlwbGVPYmplY3RzRXgg ZmFpbGVkIHdpdGggZXJyb3IgJWx1IiwgOjpHZXRMYXN0RXJyb3IoKSk7CisgICAgICAgIEFTU0VS VF9XSVRIX01FU1NBR0UoZmFsc2UsICI6Ok1zZ1dhaXRGb3JNdWx0aXBsZU9iamVjdHNFeCByZXR1 cm5lZCB1bmV4cGVjdGVkIHJlc3VsdCAlbHUiLCByZXN1bHQpOworICAgICAgICByZXR1cm4gZmFs c2U7CisgICAgfQorfQorCiB9IC8vIG5hbWVzcGFjZSBDb3JlSVBDCkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybS93aW4vUnVuTG9vcFdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvUGxhdGZvcm0vd2luL1J1bkxvb3BXaW4uY3BwCShyZXZpc2lvbiAxMDM2NzEpCisrKyBT b3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS93aW4vUnVuTG9vcFdpbi5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTc4LDQ3ICs3OCw2IEBAIHZvaWQgUnVuTG9vcDo6cnVuKCkKICAgICB9CiB9CiAKLWJvb2wg UnVuTG9vcDo6ZGlzcGF0Y2hTZW50TWVzc2FnZXNVbnRpbChjb25zdCBWZWN0b3I8SFdORD4mIHdp bmRvd3MsIENvcmVJUEM6OkJpbmFyeVNlbWFwaG9yZSYgc2VtYXBob3JlLCBkb3VibGUgYWJzb2x1 dGVUaW1lKQotewotICAgIGlmICh3aW5kb3dzLmlzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuIHNl bWFwaG9yZS53YWl0KGFic29sdXRlVGltZSk7Ci0KLSAgICBIQU5ETEUgaGFuZGxlID0gc2VtYXBo b3JlLmV2ZW50KCk7Ci0gICAgRFdPUkQgaGFuZGxlQ291bnQgPSAxOwotCi0gICAgd2hpbGUgKHRy dWUpIHsKLSAgICAgICAgRFdPUkQgaW50ZXJ2YWwgPSBhYnNvbHV0ZVRpbWVUb1dhaXRUaW1lb3V0 SW50ZXJ2YWwoYWJzb2x1dGVUaW1lKTsKLSAgICAgICAgaWYgKCFpbnRlcnZhbCkgewotICAgICAg ICAgICAgLy8gQ29uc2lkZXIgdGhlIHdhaXQgdG8gaGF2ZSB0aW1lZCBvdXQsIGV2ZW4gaWYgdGhl IHNlbWFwaG9yZSBpcyBjdXJyZW50bHkgc2lnbmFsZWQuCi0gICAgICAgICAgICAvLyBUaGlzIG1h dGNoZXMgdGhlIFdURjo6VGhyZWFkQ29uZGl0aW9uIGltcGxlbWVudGF0aW9uIG9mIEJpbmFyeVNl bWFwaG9yZTo6d2FpdC4KLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgfQotCi0g ICAgICAgIERXT1JEIHJlc3VsdCA9IDo6TXNnV2FpdEZvck11bHRpcGxlT2JqZWN0c0V4KGhhbmRs ZUNvdW50LCAmaGFuZGxlLCBpbnRlcnZhbCwgUVNfU0VORE1FU1NBR0UsIDApOwotICAgICAgICBp ZiAocmVzdWx0ID09IFdBSVRfT0JKRUNUXzApIHsKLSAgICAgICAgICAgIC8vIFRoZSBzZW1hcGhv cmUgd2FzIHNpZ25hbGVkLgotICAgICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgICAgIH0KLSAg ICAgICAgaWYgKHJlc3VsdCA9PSBXQUlUX1RJTUVPVVQpIHsKLSAgICAgICAgICAgIC8vIGFic29s dXRlVGltZSB3YXMgcmVhY2hlZC4KLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAg fQotICAgICAgICBpZiAocmVzdWx0ID09IFdBSVRfT0JKRUNUXzAgKyBoYW5kbGVDb3VudCkgewot ICAgICAgICAgICAgLy8gT25lIG9yIG1vcmUgc2VudCBtZXNzYWdlcyBhcmUgYXZhaWxhYmxlLiBQ cm9jZXNzIHNlbnQgbWVzc2FnZXMgZm9yIGFsbCB0aGUgd2luZG93cwotICAgICAgICAgICAgLy8g d2Ugd2VyZSBnaXZlbiwgc2luY2Ugd2UgZG9uJ3QgaGF2ZSBhIHdheSBvZiBrbm93aW5nIHdoaWNo IHdpbmRvdyBoYXMgYXZhaWxhYmxlIHNlbnQKLSAgICAgICAgICAgIC8vIG1lc3NhZ2VzLgotICAg ICAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCB3aW5kb3dzLnNpemUoKTsgKytpKSB7Ci0g ICAgICAgICAgICAgICAgTVNHIG1lc3NhZ2U7Ci0gICAgICAgICAgICAgICAgOjpQZWVrTWVzc2Fn ZVcoJm1lc3NhZ2UsIHdpbmRvd3NbaV0sIDAsIDAsIFBNX05PUkVNT1ZFIHwgUE1fUVNfU0VORE1F U1NBR0UpOwotICAgICAgICAgICAgfQotICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIH0K LSAgICAgICAgQVNTRVJUX1dJVEhfTUVTU0FHRShyZXN1bHQgIT0gV0FJVF9GQUlMRUQsICI6Ok1z Z1dhaXRGb3JNdWx0aXBsZU9iamVjdHNFeCBmYWlsZWQgd2l0aCBlcnJvciAlbHUiLCA6OkdldExh c3RFcnJvcigpKTsKLSAgICAgICAgQVNTRVJUX1dJVEhfTUVTU0FHRShmYWxzZSwgIjo6TXNnV2Fp dEZvck11bHRpcGxlT2JqZWN0c0V4IHJldHVybmVkIHVuZXhwZWN0ZWQgcmVzdWx0ICVsdSIsIHJl c3VsdCk7Ci0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9Ci19Ci0KIHZvaWQgUnVuTG9vcDo6 c3RvcCgpCiB7CiAgICAgOjpQb3N0UXVpdE1lc3NhZ2UoMCk7Cg==