75298 2011-12-28 01:19:54 -0800 QuerySelector should not have side effect. 2012-01-11 23:07:35 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 shinyak webkit-unassigned kling koivisto shinyak webkit.review.bot oldest_to_newest 527585 0 shinyak 2011-12-28 01:19:54 -0800 Currently QuerySelector seems to have side effect that parentStyle's flags are set if some pseudo type (e.g. first-of-type) was used to query. 527587 1 120643 shinyak 2011-12-28 01:24:35 -0800 Created attachment 120643 Patch 527692 2 120643 kling 2011-12-28 09:15:52 -0800 Comment on attachment 120643 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120643&action=review > Source/WebCore/ChangeLog:11 > + No new tests. Covered by existing tests. If this is covered by existing tests, why aren't you unskipping something that used to fail? 528131 3 koivisto 2011-12-30 06:23:00 -0800 (In reply to comment #2) > If this is covered by existing tests, why aren't you unskipping something that used to fail? The flags that these end up setting affect style recalc performance optimizations and are not easily testable. Selector queries itself should should have reasonable coverage. 534585 4 120643 webkit.review.bot 2012-01-11 23:07:30 -0800 Comment on attachment 120643 Patch Clearing flags on attachment: 120643 Committed r104793: <http://trac.webkit.org/changeset/104793> 534586 5 webkit.review.bot 2012-01-11 23:07:35 -0800 All reviewed patches have been landed. Closing bug. 120643 2011-12-28 01:24:35 -0800 2012-01-11 23:07:30 -0800 Patch bug-75298-20111228182433.patch text/plain 1737 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzNzU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2U4MGE5MGE2ZDNkOTRj OWY5ZWNiOWI3NWZlZmQ4OThjNjZiNTc1My4uMWUzZWIwMGRhMWEyNWRiMTM2NGFjOGMzMzcwN2Ji ZTYzZmM3ZGUwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTEyLTI4ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGdvb2dsZS5jb20+CisKKyAgICAgICAgUXVlcnlTZWxlY3Rv ciBzaG91bGQgbm90IGhhdmUgc2lkZSBlZmZlY3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTI5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIFNlbGVjdG9yQ2hlY2tlciBpcyBub3QgY29sbGVj dGluZy1ydWxlcy1vbmx5IG1vZGUsIGl0IG1heSBzZXQgc29tZSBmbGFncyBpbiByZW5kZXIgc3R5 bGVzCisgICAgICAgIGlmIHNvbWUgcHNldWRvIHR5cGVzIChlLmcuIGZpcnN0LW9mLXR5cGUpIGFy ZSB1c2VkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0 cy4KKworICAgICAgICAqIGRvbS9TZWxlY3RvclF1ZXJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlNlbGVjdG9yUXVlcnk6OlNlbGVjdG9yUXVlcnkpOgorICAgICAgICAgIE1hZGUgY29sbGVjdGlu ZyBydWxlcyBvbmx5LgorCiAyMDExLTEyLTI3ICBBbmFudGFuYXJheWFuYW4gRyBJeWVuZ2FyICA8 YW5hbnRhQGNocm9taXVtLm9yZz4KIAogICAgICAgICBDcmFzaCBpbiB0aGUgV2ViS2l0IGFjY2Vz c2liaWxpdHkgY29kZSB3aGlsZSBhdHRlbXB0aW5nIHRvIHJldHJpZXZlIHRoZSB0aXRsZSBVSSBl bGVtZW50LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1NlbGVjdG9yUXVlcnkuY3Bw IGIvU291cmNlL1dlYkNvcmUvZG9tL1NlbGVjdG9yUXVlcnkuY3BwCmluZGV4IDVkZmYwM2NiNzM2 MTU0NWVmNWVlZDhmODcxODhmMGVlZTNlZDQyYTguLjA4MjY2ZWYzMTM2YTkxYTI4Y2Y2MjIzZDRh NTVhZmQxMjg0MmZhZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9TZWxlY3RvclF1 ZXJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2VsZWN0b3JRdWVyeS5jcHAKQEAgLTM3 LDYgKzM3LDggQEAgU2VsZWN0b3JRdWVyeTo6U2VsZWN0b3JRdWVyeShOb2RlKiByb290Tm9kZSwg Y29uc3QgQ1NTU2VsZWN0b3JMaXN0JiBzZWxlY3Rvckxpc3QKICAgICA6IG1fcm9vdE5vZGUocm9v dE5vZGUpCiAgICAgLCBtX3NlbGVjdG9yQ2hlY2tlcihyb290Tm9kZS0+ZG9jdW1lbnQoKSwgIXJv b3ROb2RlLT5kb2N1bWVudCgpLT5pblF1aXJrc01vZGUoKSkKIHsKKyAgICBtX3NlbGVjdG9yQ2hl Y2tlci5zZXRDb2xsZWN0aW5nUnVsZXNPbmx5KHRydWUpOworCiAgICAgZm9yIChDU1NTZWxlY3Rv ciogc2VsZWN0b3IgPSBzZWxlY3Rvckxpc3QuZmlyc3QoKTsgc2VsZWN0b3I7IHNlbGVjdG9yID0g Q1NTU2VsZWN0b3JMaXN0OjpuZXh0KHNlbGVjdG9yKSkKICAgICAgICAgbV9zZWxlY3RvcnMuYXBw ZW5kKFNlbGVjdG9yRGF0YShzZWxlY3RvciwgU2VsZWN0b3JDaGVja2VyOjppc0Zhc3RDaGVja2Fi bGVTZWxlY3RvcihzZWxlY3RvcikpKTsKIH0K