<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>75282</bug_id>
          
          <creation_ts>2011-12-27 17:10:47 -0800</creation_ts>
          <short_desc>[Chromium] webkit-patch rebaseline-expectations doesn&apos;t support chromium-gpu-linux-x86_64</short_desc>
          <delta_ts>2012-06-14 21:43:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P1</priority>
          <bug_severity>Blocker</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>dpranke</cc>
    
    <cc>eric</cc>
    
    <cc>tony</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>527515</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2011-12-27 17:10:47 -0800</bug_when>
    <thetext>It appears that webkit-patch rebaseline isn&apos;t pulling any results from chromium-gpu-linux-x86_64:

rniwa-macbookpro:webkit2 rniwa$ Tools/Scripts/webkit-patch rebaseline-expectations
Retrieving results for chromium-cg-mac-leopard from Webkit Mac10.5 (CG).
Retrieving results for chromium-cg-mac-snowleopard from Webkit Mac10.6 (CG).
Retrieving results for chromium-gpu-cg-mac-leopard from Webkit Mac10.5 (CG) - GPU.
Retrieving results for chromium-gpu-cg-mac-snowleopard from Webkit Mac10.6 (CG) - GPU.
Retrieving results for chromium-gpu-mac-snowleopard from Webkit Mac10.6 - GPU.
    media/video-transformed.html
    media/video-zoom-controls.html
    media/video-layer-crash.html
Retrieving results for chromium-gpu-win-win7 from Webkit Win7 - GPU.
    media/video-transformed.html
    media/video-zoom-controls.html
    media/video-layer-crash.html
Retrieving results for chromium-gpu-win-xp from Webkit Win - GPU.
    media/video-transformed.html
    media/video-zoom-controls.html
    media/video-layer-crash.html
Retrieving results for chromium-linux-x86 from Webkit Linux 32.
Retrieving results for chromium-linux-x86_64 from Webkit Linux.
Retrieving results for chromium-mac-leopard from Webkit Mac10.5.
Retrieving results for chromium-mac-snowleopard from Webkit Mac10.6.
Retrieving results for chromium-win-vista from Webkit Vista.
Retrieving results for chromium-win-win7 from Webkit Win7.
Retrieving results for chromium-win-xp from Webkit Win.
Optimizing baselines for media/video-transformed.html.
Optimizing baselines for media/video-zoom-controls.html.
Optimizing baselines for media/video-layer-crash.html.
rniwa-macbookpro:webkit2 rniwa$ Tools/Scripts/rebaseline-chromium-webkit-tests 

Where as old script would:
rniwa-macbookpro:webkit2 rniwa$ Tools/Scripts/rebaseline-chromium-webkit-tests 
This script is depreciated.  Please use use &quot;webkit-patch rebaseline-expectations&quot; instead.

If that command does not work properly, please file a bug and CC abarth. If you
really need to use the old script, run this command again with
--use-deprecated-script as the first argument.
rniwa-macbookpro:webkit2 rniwa$ Tools/Scripts/rebaseline-chromium-webkit-tests --use-deprecated-script
This script is depreciated.  Please use use &quot;webkit-patch rebaseline-expectations&quot; instead.

If that command does not work properly, please file a bug and CC abarth. If you
really need to use the old script, run this command again with
--use-deprecated-script as the first argument.

Using /Users/rniwa/webkit2/LayoutTests
  and /Users/rniwa/webkit2/LayoutTests/platform/chromium/test_expectations.txt
chromium-mac-lion: No tests to rebaseline.
chromium-mac-snowleopard: No tests to rebaseline.
chromium-mac-leopard: No tests to rebaseline.
chromium-cg-mac-lion: No tests to rebaseline.
chromium-cg-mac-snowleopard: No tests to rebaseline.
chromium-cg-mac-leopard: No tests to rebaseline.
chromium-win-win7: No tests to rebaseline.
chromium-win-vista: No tests to rebaseline.
chromium-win-xp: No tests to rebaseline.
chromium-linux-x86_64: No tests to rebaseline.
chromium-linux-x86: No tests to rebaseline.
chromium-gpu-mac-snowleopard: No tests to rebaseline.
chromium-gpu-win-win7: No tests to rebaseline.

chromium-gpu-linux-x86_64: Rebaselining 3 tests:
  Using http://build.chromium.org/f/chromium/layout_test_results/Webkit_Linux_-_GPU/115857/layout-test-results.zip
  Skipping media/video-transformed.html (matches platform/chromium-win)
  Updating platform/chromium-gpu-linux/media/video-transformed-expected.png
  Updating platform/chromium-gpu-linux/media/video-zoom-controls-expected.png
  Updating platform/chromium-gpu-linux/media/video-layer-crash-expected.png

Rebaselining succeeded.

This makes webkit-patch rebaseline unusable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>527572</commentid>
    <comment_count>1</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-12-28 00:20:00 -0800</bug_when>
    <thetext>I&apos;m not going to add support for the GPU configuration.  If someone else wants to add it, I&apos;m happy to review the patch.  I would rather spend the effort removing the GPU configuration.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>649844</commentid>
    <comment_count>2</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-06-14 21:43:22 -0700</bug_when>
    <thetext>both this script and this configuration are gone :).</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>