75263 2011-12-27 11:43:37 -0800 [Chromium] uninitialized variable in fakeMouseMoveEventTimerFired 2011-12-27 14:50:13 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa webkit-unassigned abarth fishd tony webkit.review.bot oldest_to_newest 527434 0 rniwa 2011-12-27 11:43:37 -0800 20:48:57 memcheck_analyze.py [ERROR] FAIL! There were 1 errors: 20:48:57 memcheck_analyze.py [ERROR] Command: UninitCondition Conditional jump or move depends on uninitialised value(s) WebCore::PlatformEvent::PlatformEvent(WebCore::PlatformEvent::Type, bool, bool, bool, bool, double) (third_party/WebKit/Source/WebCore/platform/PlatformEvent.h:113) WebCore::PlatformMouseEvent::PlatformMouseEvent(WebCore::IntPoint const&, WebCore::IntPoint const&, WebCore::MouseButton, WebCore::PlatformEvent::Type, int, bool, bool, bool, bool, double) (third_party/WebKit/Source/WebCore/platform/PlatformMouseEvent.h:88) WebCore::EventHandler::fakeMouseMoveEventTimerFired(WebCore::Timer<WebCore::EventHandler>*) (third_party/WebKit/Source/WebCore/page/EventHandler.cpp:2426) WebCore::Timer<WebCore::EventHandler>::fired() (third_party/WebKit/Source/WebCore/platform/Timer.h:100) WebCore::ThreadTimers::sharedTimerFiredInternal() (third_party/WebKit/Source/WebCore/platform/ThreadTimers.cpp:115) WebCore::ThreadTimers::sharedTimerFired() (third_party/WebKit/Source/WebCore/platform/ThreadTimers.cpp:93) webkit_glue::WebKitPlatformSupportImpl::DoTimeout() (./webkit/glue/webkitplatformsupport_impl.h:135) base::BaseTimer<webkit_glue::WebKitPlatformSupportImpl, false>::TimerTask::Run() (./base/timer.h:173) The report came from the `BookmarksUITest.BookmarksLoaded` test. Suppression (error hash=#E0AE00D1F1BE808E#): For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports { <insert_a_suppression_name_here> Memcheck:Uninitialized fun:_ZN7WebCore13PlatformEventC2ENS0_4TypeEbbbbd fun:_ZN7WebCore18PlatformMouseEventC1ERKNS_8IntPointES3_NS_11MouseButtonENS_13PlatformEvent4TypeEibbbbd fun:_ZN7WebCore12EventHandler28fakeMouseMoveEventTimerFiredEPNS_5TimerIS0_EE fun:_ZN7WebCore5TimerINS_12EventHandlerEE5firedEv fun:_ZN7WebCore12ThreadTimers24sharedTimerFiredInternalEv fun:_ZN7WebCore12ThreadTimers16sharedTimerFiredEv fun:_ZN11webkit_glue25WebKitPlatformSupportImpl9DoTimeoutEv fun:_ZN4base9BaseTimerIN11webkit_glue25WebKitPlatformSupportImplELb0EE9TimerTask3RunEv } http://crbug.com/108620 527436 1 120609 rniwa 2011-12-27 11:44:44 -0800 Created attachment 120609 Fixes the bug The problem is that PlatformKeyboardEvent::getCurrentModifierState in PlatformKeyboardEventChromium.cpp never initializes arguments on Linux. 527437 2 120609 rniwa 2011-12-27 11:45:44 -0800 Comment on attachment 120609 Fixes the bug Oops, no change log entry :( 527438 3 webkit.review.bot 2011-12-27 11:46:04 -0800 Attachment 120609 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 527440 4 120610 rniwa 2011-12-27 11:47:41 -0800 Created attachment 120610 Added a change log entry 527444 5 120610 rniwa 2011-12-27 12:02:47 -0800 Comment on attachment 120610 Added a change log entry Thanks for the review, Tony! 527471 6 120610 webkit.review.bot 2011-12-27 14:50:08 -0800 Comment on attachment 120610 Added a change log entry Clearing flags on attachment: 120610 Committed r103730: <http://trac.webkit.org/changeset/103730> 527472 7 webkit.review.bot 2011-12-27 14:50:13 -0800 All reviewed patches have been landed. Closing bug. 120609 2011-12-27 11:44:44 -0800 2011-12-27 11:45:43 -0800 Fixes the bug fix75263 text/plain 1188 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzcxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTEyLTI3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlw dGlvbiBhbmQgYnVnIFVSTCAoT09QUyEpCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybUtleWJvYXJkRXZlbnRDaHJvbWl1bS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OmdldEN1cnJlbnRNb2RpZmllclN0YXRl KToKKwogMjAxMS0xMi0yNyAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4K IAogICAgICAgICBVbnJldmlld2VkIHdlYiBpbnNwZWN0b3IgbG9jYWxpemVkU3RyaW5ncy5qcyBm aXguCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybUtleWJv YXJkRXZlbnRDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vUGxhdGZvcm1LZXlib2FyZEV2ZW50Q2hyb21pdW0uY3BwCShyZXZpc2lvbiAx MDM3MTkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybUtleWJv YXJkRXZlbnRDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMCw2ICsxMDAsMTAgQEAK ICAgICBhbHRLZXkgPSBjdXJyZW50TW9kaWZpZXJzICYgOjpvcHRpb25LZXk7CiAgICAgbWV0YUtl eSA9IGN1cnJlbnRNb2RpZmllcnMgJiA6OmNtZEtleTsKICNlbHNlCisgICAgc2hpZnRLZXkgPSBm YWxzZTsKKyAgICBjdHJsS2V5ID0gZmFsc2U7CisgICAgYWx0S2V5ID0gZmFsc2U7CisgICAgbWV0 YUtleSA9IGZhbHNlOwogICAgIG5vdEltcGxlbWVudGVkKCk7CiAjZW5kaWYKIH0K 120610 2011-12-27 11:47:41 -0800 2011-12-27 14:50:07 -0800 Added a change log entry fix75263b text/plain 1563 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzcxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDExLTEyLTI3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gdW5pbml0aWFs aXplZCB2YXJpYWJsZSBpbiBmYWtlTW91c2VNb3ZlRXZlbnRUaW1lckZpcmVkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTI2MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBmYWlsdXJlIHdhcyBjYXVz ZWQgYnkgUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpnZXRDdXJyZW50TW9kaWZpZXJTdGF0ZSBpbiBQ bGF0Zm9ybUtleWJvYXJkRXZlbnRDaHJvbWl1bS5jcHAKKyAgICAgICAgbm90IGluaXRpYWxpemlu ZyBhcmd1bWVudHMgb24gTGludXguIEZpeGVkIHRoZSBmYWlsdXJlIGJ5IGFsd2F5cyBhc3NpZ25p bmcgZmFsc2UgdG8gdGhlIGFyZ3VtZW50cy4KKworICAgICAgICBCdXQgd2Ugc2hvdWxkIHJlYWxs eSBmaXggdGhpcyBmdW5jdGlvbiBmb3IgTGludXguIE5vdCByZWNvZ25pemluZyBhbnkgbW9kaWZp ZXIgaXNuJ3QgZ3JlYXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybUtl eWJvYXJkRXZlbnRDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybUtleWJv YXJkRXZlbnQ6OmdldEN1cnJlbnRNb2RpZmllclN0YXRlKToKKwogMjAxMS0xMi0yNyAgVnNldm9s b2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIHdl YiBpbnNwZWN0b3IgbG9jYWxpemVkU3RyaW5ncy5qcyBmaXguCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybUtleWJvYXJkRXZlbnRDaHJvbWl1bS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUGxhdGZvcm1LZXli b2FyZEV2ZW50Q2hyb21pdW0uY3BwCShyZXZpc2lvbiAxMDM3MTkpCisrKyBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybUtleWJvYXJkRXZlbnRDaHJvbWl1bS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTEwMCw2ICsxMDAsMTAgQEAKICAgICBhbHRLZXkgPSBjdXJyZW50TW9k aWZpZXJzICYgOjpvcHRpb25LZXk7CiAgICAgbWV0YUtleSA9IGN1cnJlbnRNb2RpZmllcnMgJiA6 OmNtZEtleTsKICNlbHNlCisgICAgc2hpZnRLZXkgPSBmYWxzZTsKKyAgICBjdHJsS2V5ID0gZmFs c2U7CisgICAgYWx0S2V5ID0gZmFsc2U7CisgICAgbWV0YUtleSA9IGZhbHNlOwogICAgIG5vdElt cGxlbWVudGVkKCk7CiAjZW5kaWYKIH0K