75256 2011-12-27 08:12:52 -0800 [Qt] Make the inputMethodEvent set or confirm the composition. 2011-12-27 19:16:53 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kenneth kenneth hausmann kling tonikitoo webkit.review.bot zoltan oldest_to_newest 527369 0 kenneth 2011-12-27 08:12:52 -0800 SSIA 527370 1 120591 kenneth 2011-12-27 08:14:00 -0800 Created attachment 120591 Patch 527372 2 120591 cshu 2011-12-27 08:21:18 -0800 Comment on attachment 120591 Patch No tests? 527379 3 kenneth 2011-12-27 09:22:06 -0800 (In reply to comment #2) > (From update of attachment 120591 [details]) > No tests? There is a lot more needed before all of this is fully working. Everything in WebCore is already tested by layout tests, but we need to find out how to test this properly from our API side, especially as most issues we had so far were related to the fact that we never do sync calls. Also, all the input method support is not final in Qt5 yet. 527519 4 120591 cshu 2011-12-27 17:56:36 -0800 Comment on attachment 120591 Patch Good luck, man. 527528 5 120591 webkit.review.bot 2011-12-27 19:16:48 -0800 Comment on attachment 120591 Patch Clearing flags on attachment: 120591 Committed r103753: <http://trac.webkit.org/changeset/103753> 527529 6 webkit.review.bot 2011-12-27 19:16:53 -0800 All reviewed patches have been landed. Closing bug. 120591 2011-12-27 08:14:00 -0800 2011-12-27 19:16:48 -0800 Patch 0001-Qt-Make-the-inputMethodEvent-set-or-confirm-the-comp.patch text/plain 3047 kenneth RnJvbSAwYmMxZTA3MTAzNmU1YjExOGQ0YjBjZGE1YjgzODM0MmMxMjAzZThiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiA8a2VubmV0aEB3 ZWJraXQub3JnPgpEYXRlOiBUdWUsIDI3IERlYyAyMDExIDE3OjEzOjE3ICswMTAwClN1YmplY3Q6 IFtQQVRDSF0gW1F0XSBNYWtlIHRoZSBpbnB1dE1ldGhvZEV2ZW50IHNldCBvciBjb25maXJtIHRo ZSBjb21wb3NpdGlvbgogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1 MjU2CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiogVUlQcm9jZXNzL3F0L1F0V2ViUGFn ZUV2ZW50SGFuZGxlci5jcHA6CihRdFdlYlBhZ2VFdmVudEhhbmRsZXI6OmlucHV0TWV0aG9kRXZl bnQpOgotLS0KIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgICAxMCArKysrKysrKysrCiAuLi4vV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdl RXZlbnRIYW5kbGVyLmNwcCB8ICAgMTYgKysrKysrKysrKystLS0tLQogMiBmaWxlcyBjaGFuZ2Vk LCAyMSBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBkODZmZTc5 Li4zYjA4ZTRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTItMjcgIEtlbm5l dGggUm9oZGUgQ2hyaXN0aWFuc2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFtR dF0gTWFrZSB0aGUgaW5wdXRNZXRob2RFdmVudCBzZXQgb3IgY29uZmlybSB0aGUgY29tcG9zaXRp b24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1MjU2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvcXQvUXRXZWJQYWdlRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFF0V2ViUGFnZUV2 ZW50SGFuZGxlcjo6aW5wdXRNZXRob2RFdmVudCk6CisKIDIwMTEtMTItMjAgIEFuZGVycyBDYXJs c3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgU2Nyb2xsYWJsZUFyZWE6 OmNvbnRlbnRzUmVzaXplZCBhbmQgaGF2ZSBpdCBjYWxsIHRoZSBzY3JvbGwgYW5pbWF0b3IKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VFdmVudEhhbmRs ZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZUV2ZW50SGFuZGxl ci5jcHAKaW5kZXggYTAzMDVkMS4uZDAxOTY4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL3F0L1F0V2ViUGFnZUV2ZW50SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZUV2ZW50SGFuZGxlci5jcHAKQEAgLTMyMSw2ICszMjEs OSBAQCB2b2lkIFF0V2ViUGFnZUV2ZW50SGFuZGxlcjo6aW5wdXRNZXRob2RFdmVudChRSW5wdXRN ZXRob2RFdmVudCogZXYpCiAgICAgUVN0cmluZyBjb21taXQgPSBldi0+Y29tbWl0U3RyaW5nKCk7 CiAgICAgUVN0cmluZyBjb21wb3NpdGlvbiA9IGV2LT5wcmVlZGl0U3RyaW5nKCk7CiAKKyAgICBp bnQgcmVwbGFjZW1lbnRTdGFydCA9IGV2LT5yZXBsYWNlbWVudFN0YXJ0KCk7CisgICAgaW50IHJl cGxhY2VtZW50TGVuZ3RoID0gZXYtPnJlcGxhY2VtZW50TGVuZ3RoKCk7CisKICAgICAvLyBOT1RF OiBXZSBtaWdodCB3YW50IHRvIGhhbmRsZSBldmVudHMgb2Ygb25lIGNoYXIgYXMgc3BlY2lhbAog ICAgIC8vIGFuZCByZXNlbmQgdGhlbSBhcyBrZXkgZXZlbnRzIHRvIG1ha2Ugd2ViIHNpdGUgY29t cGxldGlvbiB3b3JrLgogCkBAIC0zNjEsMTcgKzM2NCwyMCBAQCB2b2lkIFF0V2ViUGFnZUV2ZW50 SGFuZGxlcjo6aW5wdXRNZXRob2RFdmVudChRSW5wdXRNZXRob2RFdmVudCogZXYpCiAgICAgICAg ICAgICAgICAgc2VsZWN0aW9uU3RhcnQgPSBhdHRyLnN0YXJ0OwogICAgICAgICAgICAgICAgIHNl bGVjdGlvbkxlbmd0aCA9IGF0dHIubGVuZ3RoOwogCi0gICAgICAgICAgICAgICAgQVNTRVJUX1VO VVNFRChzZWxlY3Rpb25TdGFydCwgc2VsZWN0aW9uU3RhcnQgPj0gMCk7Ci0gICAgICAgICAgICAg ICAgQVNTRVJUX1VOVVNFRChzZWxlY3Rpb25MZW5ndGgsIHNlbGVjdGlvbkxlbmd0aCA+PSAwKTsK KyAgICAgICAgICAgICAgICBBU1NFUlQoc2VsZWN0aW9uU3RhcnQgPj0gMCk7CisgICAgICAgICAg ICAgICAgQVNTRVJUKHNlbGVjdGlvbkxlbmd0aCA+PSAwKTsKICAgICAgICAgICAgICAgICBicmVh azsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCi0gICAgICAgIC8vIEZJWE1FOiBDb25maXJt IHRoZSBjb21wb3NpdGlvbiBoZXJlLgorICAgICAgICBtX3dlYlBhZ2VQcm94eS0+Y29uZmlybUNv bXBvc2l0aW9uKGNvbW1pdCwgc2VsZWN0aW9uU3RhcnQsIHNlbGVjdGlvbkxlbmd0aCk7CiAgICAg fSBlbHNlIHsKLSAgICAgICAgQVNTRVJUX1VOVVNFRChjdXJzb3JQb3NpdGlvbldpdGhpbkNvbXBv c2l0aW9uLCBjdXJzb3JQb3NpdGlvbldpdGhpbkNvbXBvc2l0aW9uID49IDApOworICAgICAgICBB U1NFUlQoY3Vyc29yUG9zaXRpb25XaXRoaW5Db21wb3NpdGlvbiA+PSAwKTsKKyAgICAgICAgQVNT RVJUKHJlcGxhY2VtZW50U3RhcnQgPj0gMCk7CiAKLSAgICAgICAgLy8gRklYTUU6IFNldCB0aGUg Y29tcG9zaXRpb24gaGVyZS4KKyAgICAgICAgbV93ZWJQYWdlUHJveHktPnNldENvbXBvc2l0aW9u KGNvbXBvc2l0aW9uLCB1bmRlcmxpbmVzLAorICAgICAgICAgICAgY3Vyc29yUG9zaXRpb25XaXRo aW5Db21wb3NpdGlvbiwgY3Vyc29yUG9zaXRpb25XaXRoaW5Db21wb3NpdGlvbiwKKyAgICAgICAg ICAgIHJlcGxhY2VtZW50U3RhcnQsIHJlcGxhY2VtZW50TGVuZ3RoKTsKICAgICB9CiAKICAgICBl di0+YWNjZXB0KCk7Ci0tIAoxLjcuNC4xCgo=