75245 2011-12-27 04:21:05 -0800 Web Inspector: Scripts panel tabbed editor does not reopen closed tabs. 2011-12-27 08:23:43 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 527326 0 vsevik 2011-12-27 04:21:05 -0800 Scripts panel tabbed editor does not reopen closed tabs. 527328 1 120576 vsevik 2011-12-27 04:27:20 -0800 Created attachment 120576 Patch 527329 2 120576 apavlov 2011-12-27 04:37:42 -0800 Comment on attachment 120576 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120576&action=review > Source/WebCore/inspector/front-end/TabbedPane.js:126 > + var event = {tabId: id, view: tab.view, isUserGesture: userGesture}; we typically separate object contents by spaces inside braces: { tabId: ... userGesture } - I remember getting a similar comment from Joe Pecoraro. 527367 3 120576 pfeldman 2011-12-27 08:06:54 -0800 Comment on attachment 120576 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120576&action=review >> Source/WebCore/inspector/front-end/TabbedPane.js:126 >> + var event = {tabId: id, view: tab.view, isUserGesture: userGesture}; > > we typically separate object contents by spaces inside braces: { tabId: ... userGesture } - I remember getting a similar comment from Joe Pecoraro. var eventData = { ... } (it'll be event.data, not event). 527374 4 vsevik 2011-12-27 08:23:43 -0800 Committed r103710: <http://trac.webkit.org/changeset/103710> 120576 2011-12-27 04:27:20 -0800 2011-12-27 08:06:54 -0800 Patch bug-75245-20111227162717.patch text/plain 4417 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzNzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWRlZTlmYzU2ZGFiODY0 NjllN2M4YjQ4MDZjZmIyY2E0NzY1ZTI0NS4uZTliMjczNDhkMTYwMmIxYWUyMWNhZTc2N2U4YjE1 ZmI4Mzk4NDdjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTEyLTI3ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFNjcmlwdHMgcGFuZWwgdGFiYmVkIGVkaXRvciBkb2VzIG5vdCByZW9wZW4gY2xvc2VkIHRh YnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTI0 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrSXRlbVZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuTmV0d29ya0l0ZW1WaWV3KToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RhYmJl ZEVkaXRvckNvbnRhaW5lci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UYWJiZWRFZGl0b3JD b250YWluZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRhYmJlZEVkaXRvckNvbnRhaW5lci5w cm90b3R5cGUuX3RhYkNsb3NlZCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9UYWJi ZWRQYW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRhYmJlZFBhbmUucHJvdG90eXBlLmNs b3NlVGFiKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UYWJiZWRQYW5lLnByb3RvdHlwZS5zZWxl Y3RUYWIpOgorCiAyMDExLTEyLTI2ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENyZWF0ZSB0YWJiZWQgZWRpdG9yIGZvciBz Y3JpcHRzIHBhbmVsLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9OZXR3b3JrSXRlbVZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL05ldHdvcmtJdGVtVmlldy5qcwppbmRleCA4MzE0MzAyY2NhZTk1YTM0ZTJjNTI0ZTIxOTMw MjQxMDZmNzc0NDkxLi41YWFlYjQxNjRlZWU0ZDYzZmYwMmEyNTdkNTg4ZmI0YzkwNGQ1OWE4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtJdGVt Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtJ dGVtVmlldy5qcwpAQCAtNTcsNyArNTcsNyBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya0l0ZW1WaWV3 ID0gZnVuY3Rpb24ocmVzb3VyY2UpCiAgICAgICAgIHRoaXMuYXBwZW5kVGFiKCJ0aW1pbmciLCBX ZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlRpbWluZyIpLCB0aW1pbmdWaWV3KTsKICAgICB9CiAKLSAg ICB0aGlzLmFkZEV2ZW50TGlzdGVuZXIoInRhYi1zZWxlY3RlZCIsIHRoaXMuX3RhYlNlbGVjdGVk LCB0aGlzKTsKKyAgICB0aGlzLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlRhYmJlZFBh bmUuRXZlbnRUeXBlcy5UYWJTZWxlY3RlZCwgdGhpcy5fdGFiU2VsZWN0ZWQsIHRoaXMpOwogfQog CiBXZWJJbnNwZWN0b3IuTmV0d29ya0l0ZW1WaWV3LnByb3RvdHlwZSA9IHsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGFiYmVkRWRpdG9yQ29udGFpbmVy LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UYWJiZWRFZGl0b3JDb250 YWluZXIuanMKaW5kZXggZTFhOGUxZDNkNjcxMDIwZTA0ZDYzNDFmODgxNDE5ZmE5NzU3MTExNS4u YTUzM2RkMzAzOGNjZjhkZTRkNmJhNDhlOWE1OTdkYjE5MzEyN2NiOSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UYWJiZWRFZGl0b3JDb250YWluZXIuanMK KysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UYWJiZWRFZGl0b3JDb250 YWluZXIuanMKQEAgLTM2LDYgKzM2LDggQEAgV2ViSW5zcGVjdG9yLlRhYmJlZEVkaXRvckNvbnRh aW5lciA9IGZ1bmN0aW9uKCkKICAgICB0aGlzLl90YWJiZWRQYW5lLmNsb3NlYWJsZVRhYnMgPSB0 cnVlOwogICAgIHRoaXMuX3RhYmJlZFBhbmUuZWxlbWVudC5pZCA9ICJzY3JpcHRzLWVkaXRvci1j b250YWluZXItdGFiYmVkLXBhbmUiOwogCisgICAgdGhpcy5fdGFiYmVkUGFuZS5hZGRFdmVudExp c3RlbmVyKFdlYkluc3BlY3Rvci5UYWJiZWRQYW5lLkV2ZW50VHlwZXMuVGFiQ2xvc2VkLCB0aGlz Ll90YWJDbG9zZWQsIHRoaXMpOworCiAgICAgdGhpcy5fdGl0bGVzID0gbmV3IE1hcCgpOwogICAg IHRoaXMuX3RhYklkcyA9IG5ldyBNYXAoKTsgIAogfQpAQCAtOTAsMTEgKzkyLDE4IEBAIFdlYklu c3BlY3Rvci5UYWJiZWRFZGl0b3JDb250YWluZXIucHJvdG90eXBlID0gewogICAgIHsKICAgICAg ICAgdmFyIHRhYklkID0gdGhpcy5fdGFiSWRzLmdldChzb3VyY2VGcmFtZSk7CiAgICAgICAgIAot ICAgICAgICBpZiAodGFiSWQpIHsKKyAgICAgICAgaWYgKHRhYklkKQogICAgICAgICAgICAgdGhp cy5fdGFiYmVkUGFuZS5jbG9zZVRhYih0YWJJZCk7Ci0gICAgICAgICAgICB0aGlzLl90YWJJZHMu cmVtb3ZlKHNvdXJjZUZyYW1lKTsKLSAgICAgICAgICAgIHRoaXMuX3RpdGxlcy5yZW1vdmUoc291 cmNlRnJhbWUpOwotICAgICAgICB9CisgICAgfSwKKworICAgIC8qKgorICAgICAqIEBwYXJhbSB7 RXZlbnR9IGV2ZW50CisgICAgICovCisgICAgX3RhYkNsb3NlZDogZnVuY3Rpb24oZXZlbnQpCisg ICAgeworICAgICAgICB2YXIgc291cmNlRnJhbWUgPSAvKiogQHR5cGUge1dlYkluc3BlY3Rvci5V SVNvdXJjZUNvZGV9ICovIGV2ZW50LmRhdGEudmlldzsKKyAgICAgICAgdGhpcy5fdGFiSWRzLnJl bW92ZShzb3VyY2VGcmFtZSk7CisgICAgICAgIHRoaXMuX3RpdGxlcy5yZW1vdmUoc291cmNlRnJh bWUpOwogICAgIH0sCiAKICAgICAvKioKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvVGFiYmVkUGFuZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvVGFiYmVkUGFuZS5qcwppbmRleCBmMzQ5YTYzNDMwODZjZmUwNTVjODE2YjBjNWEy MmJkNWJjNGIxZjFhLi5lNzEzNjhiMTEyMTk4OGY2YThmNzU5Y2Y5OWY3MjQ3YWY1ZDRiYTE5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RhYmJlZFBhbmUu anMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UYWJiZWRQYW5lLmpz CkBAIC00OCw2ICs0OCwxMSBAQCBXZWJJbnNwZWN0b3IuVGFiYmVkUGFuZSA9IGZ1bmN0aW9uKCkK ICAgICB0aGlzLl9kcm9wRG93bkJ1dHRvbiA9IHRoaXMuX2NyZWF0ZURyb3BEb3duQnV0dG9uKCk7 CiB9CiAKK1dlYkluc3BlY3Rvci5UYWJiZWRQYW5lLkV2ZW50VHlwZXMgPSB7CisgICAgVGFiU2Vs ZWN0ZWQ6ICJUYWJTZWxlY3RlZCIsCisgICAgVGFiQ2xvc2VkOiAiVGFiQ2xvc2VkIgorfQorCiBX ZWJJbnNwZWN0b3IuVGFiYmVkUGFuZS5wcm90b3R5cGUgPSB7CiAgICAgLyoqCiAgICAgICogQHR5 cGUge1dlYkluc3BlY3Rvci5WaWV3fQpAQCAtMTE4LDYgKzEyMyw4IEBAIFdlYkluc3BlY3Rvci5U YWJiZWRQYW5lLnByb3RvdHlwZSA9IHsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgdGhpcy5f dXBkYXRlVGFiRWxlbWVudHMoKTsKIAorICAgICAgICB2YXIgZXZlbnQgPSB7dGFiSWQ6IGlkLCB2 aWV3OiB0YWIudmlldywgaXNVc2VyR2VzdHVyZTogdXNlckdlc3R1cmV9OworICAgICAgICB0aGlz LmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuVGFiYmVkUGFuZS5FdmVudFR5 cGVzLlRhYkNsb3NlZCwgZXZlbnQpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9LAogCkBA IC0xNDksNyArMTU2LDcgQEAgV2ViSW5zcGVjdG9yLlRhYmJlZFBhbmUucHJvdG90eXBlID0gewog ICAgICAgICB0aGlzLl91cGRhdGVUYWJFbGVtZW50cygpOwogICAgICAgICAKICAgICAgICAgdmFy IGV2ZW50ID0ge3RhYklkOiBpZCwgdmlldzogdGFiLnZpZXcsIGlzVXNlckdlc3R1cmU6IHVzZXJH ZXN0dXJlfTsKLSAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoInRhYi1zZWxl Y3RlZCIsIGV2ZW50KTsKKyAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2Vi SW5zcGVjdG9yLlRhYmJlZFBhbmUuRXZlbnRUeXBlcy5UYWJTZWxlY3RlZCwgZXZlbnQpOwogICAg ICAgICByZXR1cm4gdHJ1ZTsKICAgICB9LAogCg==