75231 2011-12-26 16:27:43 -0800 Fail to throw in strict mode on assign to read only static properties 2011-12-26 20:57:07 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough webkit.review.bot oldest_to_newest 527242 0 barraclough 2011-12-26 16:27:43 -0800 Attempting to put to a readonly property should throw in strict mode, but we fail to do so for properties in static tables (e.g. values on Number, RegExp constructors). and static values in symbol tables of the variable objects (e.g. the global object's "undefined" property). 527243 1 120560 barraclough 2011-12-26 16:31:22 -0800 Created attachment 120560 Fix 527244 2 webkit.review.bot 2011-12-26 16:33:00 -0800 Attachment 120560 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/JavaScriptCore/ChangeLog:9: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Source/JavaScriptCore/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Source/JavaScriptCore/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 3 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style. 527269 3 barraclough 2011-12-26 20:57:07 -0800 Fixed in r103697 120560 2011-12-26 16:31:22 -0800 2011-12-26 16:59:53 -0800 Fix 75231.patch text/plain 15231 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAzNjkyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBA CisyMDExLTEyLTI2ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzUyMzEK KyAgICAgICAgRmFpbCB0byB0aHJvdyBpbiBzdHJpY3QgbW9kZSBvbiBhc3NpZ24gdG8gcmVhZCBv bmx5IHN0YXRpYyBwcm9wZXJ0aWVzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlcmUgYXJlIHRocmVlIGJ1Z3MgaGVyZToKKyAgICAgICAgKiBzeW1i b2xUYWJsZVB1dCBzaG91bGQgdGhyb3cgZm9yIHN0cmljdCBtb2RlIGFjY2Vzc2VzLgorICAgICAg ICAqIGxvb2t1cFB1dCBzaG91bGQgdGhyb3cgZm9yIHN0cmljdCBtb2RlIGFjY2Vzc2VzLgorICAg ICAgICAqIE51bWJlckNvbnN0cnVjdG9yIHNob3VsZCBvdmVycmlkZSBwdXQgdG8gY2FsbCBsb29r dXBQdXQsIHRvIHRyYXAgYXNzaWdubWVudCB0byByZWFkb25seSBwcm9wZXJ0aWVzLgorCisgICAg ICAgICogcnVudGltZS9KU0FjdGl2YXRpb24uY3BwOgorICAgICAgICAoSlNDOjpKU0FjdGl2YXRp b246OnN5bWJvbFRhYmxlUHV0KToKKyAgICAgICAgKEpTQzo6SlNBY3RpdmF0aW9uOjpwdXQpOgor ICAgICAgICAqIHJ1bnRpbWUvSlNBY3RpdmF0aW9uLmg6CisgICAgICAgICogcnVudGltZS9KU0ds b2JhbE9iamVjdC5jcHA6CisgICAgICAgIChKU0M6OkpTR2xvYmFsT2JqZWN0OjpwdXQpOgorICAg ICAgICAqIHJ1bnRpbWUvSlNTdGF0aWNTY29wZU9iamVjdC5jcHA6CisgICAgICAgIChKU0M6OkpT U3RhdGljU2NvcGVPYmplY3Q6OnB1dCk6CisgICAgICAgICogcnVudGltZS9KU1ZhcmlhYmxlT2Jq ZWN0Lmg6CisgICAgICAgIChKU0M6OkpTVmFyaWFibGVPYmplY3Q6OnN5bWJvbFRhYmxlUHV0KToK KyAgICAgICAgKiBydW50aW1lL0xvb2t1cC5oOgorICAgICAgICAoSlNDOjpsb29rdXBQdXQpOgor ICAgICAgICAqIHJ1bnRpbWUvTnVtYmVyQ29uc3RydWN0b3IuY3BwOgorICAgICAgICAoSlNDOjpO dW1iZXJDb25zdHJ1Y3Rvcjo6cHV0KToKKyAgICAgICAgKiBydW50aW1lL051bWJlckNvbnN0cnVj dG9yLmg6CisKIDIwMTEtMTItMjYgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBw bGUuY29tPgogCiAgICAgICAgIEZpeCBtaXNzLWNvbW1pdCBvZiB1dGY4IGNoYW5nZS4KSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQWN0aXZhdGlvbi5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBY3RpdmF0aW9uLmNwcAkocmV2 aXNpb24gMTAzNjczKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBY3RpdmF0 aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTcsMTUgKzk3LDE5IEBAIGlubGluZSBib29sIEpT QWN0aXZhdGlvbjo6c3ltYm9sVGFibGVHZXQKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotaW5saW5l IGJvb2wgSlNBY3RpdmF0aW9uOjpzeW1ib2xUYWJsZVB1dChKU0dsb2JhbERhdGEmIGdsb2JhbERh dGEsIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSwgSlNWYWx1ZSB2YWx1ZSkKK2lubGlu ZSBib29sIEpTQWN0aXZhdGlvbjo6c3ltYm9sVGFibGVQdXQoRXhlY1N0YXRlKiBleGVjLCBjb25z dCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUsIEpTVmFsdWUgdmFsdWUsIGJvb2wgc2hvdWxkVGhy b3cpCiB7CisgICAgSlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRhID0gZXhlYy0+Z2xvYmFsRGF0YSgp OwogICAgIEFTU0VSVCghSGVhcDo6aGVhcCh2YWx1ZSkgfHwgSGVhcDo6aGVhcCh2YWx1ZSkgPT0g SGVhcDo6aGVhcCh0aGlzKSk7CiAgICAgCiAgICAgU3ltYm9sVGFibGVFbnRyeSBlbnRyeSA9IHN5 bWJvbFRhYmxlKCkuaW5saW5lR2V0KHByb3BlcnR5TmFtZS5pbXBsKCkpOwogICAgIGlmIChlbnRy eS5pc051bGwoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIGlmIChlbnRyeS5pc1JlYWRP bmx5KCkpCisgICAgaWYgKGVudHJ5LmlzUmVhZE9ubHkoKSkgeworICAgICAgICBpZiAoc2hvdWxk VGhyb3cpCisgICAgICAgICAgICB0aHJvd1R5cGVFcnJvcihleGVjLCBTdHJpY3RNb2RlUmVhZG9u bHlQcm9wZXJ0eVdyaXRlRXJyb3IpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CiAgICAg aWYgKGVudHJ5LmdldEluZGV4KCkgPj0gbV9udW1DYXB0dXJlZFZhcnMpCiAgICAgICAgIHJldHVy biBmYWxzZTsKIApAQCAtMTczLDcgKzE3Nyw3IEBAIHZvaWQgSlNBY3RpdmF0aW9uOjpwdXQoSlND ZWxsKiBjZWxsLCBFeGUKICAgICBKU0FjdGl2YXRpb24qIHRoaXNPYmplY3QgPSBqc0Nhc3Q8SlNB Y3RpdmF0aW9uKj4oY2VsbCk7CiAgICAgQVNTRVJUKCFIZWFwOjpoZWFwKHZhbHVlKSB8fCBIZWFw OjpoZWFwKHZhbHVlKSA9PSBIZWFwOjpoZWFwKHRoaXNPYmplY3QpKTsKIAotICAgIGlmICh0aGlz T2JqZWN0LT5zeW1ib2xUYWJsZVB1dChleGVjLT5nbG9iYWxEYXRhKCksIHByb3BlcnR5TmFtZSwg dmFsdWUpKQorICAgIGlmICh0aGlzT2JqZWN0LT5zeW1ib2xUYWJsZVB1dChleGVjLCBwcm9wZXJ0 eU5hbWUsIHZhbHVlLCBzbG90LmlzU3RyaWN0TW9kZSgpKSkKICAgICAgICAgcmV0dXJuOwogCiAg ICAgLy8gV2UgZG9uJ3QgY2FsbCB0aHJvdWdoIHRvIEpTT2JqZWN0IGJlY2F1c2UgX19wcm90b19f IGFuZCBnZXR0ZXIvc2V0dGVyIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNBY3RpdmF0aW9uLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNBY3RpdmF0aW9uLmgJKHJldmlzaW9uIDEwMzY3MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0pTQWN0aXZhdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC04Myw3ICs4Myw3 IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBib29sIHN5bWJvbFRhYmxlR2V0KGNvbnN0IElk ZW50aWZpZXImLCBQcm9wZXJ0eVNsb3QmKTsKICAgICAgICAgYm9vbCBzeW1ib2xUYWJsZUdldChj b25zdCBJZGVudGlmaWVyJiwgUHJvcGVydHlEZXNjcmlwdG9yJik7CiAgICAgICAgIGJvb2wgc3lt Ym9sVGFibGVHZXQoY29uc3QgSWRlbnRpZmllciYsIFByb3BlcnR5U2xvdCYsIGJvb2wmIHNsb3RJ c1dyaXRlYWJsZSk7Ci0gICAgICAgIGJvb2wgc3ltYm9sVGFibGVQdXQoSlNHbG9iYWxEYXRhJiwg Y29uc3QgSWRlbnRpZmllciYsIEpTVmFsdWUpOworICAgICAgICBib29sIHN5bWJvbFRhYmxlUHV0 KEV4ZWNTdGF0ZSosIGNvbnN0IElkZW50aWZpZXImLCBKU1ZhbHVlLCBib29sIHNob3VsZFRocm93 KTsKICAgICAgICAgYm9vbCBzeW1ib2xUYWJsZVB1dFdpdGhBdHRyaWJ1dGVzKEpTR2xvYmFsRGF0 YSYsIGNvbnN0IElkZW50aWZpZXImLCBKU1ZhbHVlLCB1bnNpZ25lZCBhdHRyaWJ1dGVzKTsKIAog ICAgICAgICBzdGF0aWMgSlNWYWx1ZSBhcmd1bWVudHNHZXR0ZXIoRXhlY1N0YXRlKiwgSlNWYWx1 ZSwgY29uc3QgSWRlbnRpZmllciYpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNHbG9iYWxPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmNwcAkocmV2aXNpb24gMTAzNjczKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xNDgsNyArMTQ4LDcgQEAgdm9pZCBKU0dsb2JhbE9iamVjdDo6cHV0KEpTQ2VsbCogY2Vs bCwgRQogICAgIEpTR2xvYmFsT2JqZWN0KiB0aGlzT2JqZWN0ID0ganNDYXN0PEpTR2xvYmFsT2Jq ZWN0Kj4oY2VsbCk7CiAgICAgQVNTRVJUKCFIZWFwOjpoZWFwKHZhbHVlKSB8fCBIZWFwOjpoZWFw KHZhbHVlKSA9PSBIZWFwOjpoZWFwKHRoaXNPYmplY3QpKTsKIAotICAgIGlmICh0aGlzT2JqZWN0 LT5zeW1ib2xUYWJsZVB1dChleGVjLT5nbG9iYWxEYXRhKCksIHByb3BlcnR5TmFtZSwgdmFsdWUp KQorICAgIGlmICh0aGlzT2JqZWN0LT5zeW1ib2xUYWJsZVB1dChleGVjLCBwcm9wZXJ0eU5hbWUs IHZhbHVlLCBzbG90LmlzU3RyaWN0TW9kZSgpKSkKICAgICAgICAgcmV0dXJuOwogICAgIEpTVmFy aWFibGVPYmplY3Q6OnB1dCh0aGlzT2JqZWN0LCBleGVjLCBwcm9wZXJ0eU5hbWUsIHZhbHVlLCBz bG90KTsKIH0KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU3RhdGljU2Nv cGVPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTU3RhdGljU2NvcGVPYmplY3QuY3BwCShyZXZpc2lvbiAxMDM2NzMpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9KU1N0YXRpY1Njb3BlT2JqZWN0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNzIsNyArNzIsNyBAQCB2b2lkIEpTU3RhdGljU2NvcGVPYmplY3Q6OnB1dChKU0NlbGwq IGNlCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICB9Ci0gICAgaWYgKHRoaXNP YmplY3QtPnN5bWJvbFRhYmxlUHV0KGV4ZWMtPmdsb2JhbERhdGEoKSwgcHJvcGVydHlOYW1lLCB2 YWx1ZSkpCisgICAgaWYgKHRoaXNPYmplY3QtPnN5bWJvbFRhYmxlUHV0KGV4ZWMsIHByb3BlcnR5 TmFtZSwgdmFsdWUsIHNsb3QuaXNTdHJpY3RNb2RlKCkpKQogICAgICAgICByZXR1cm47CiAgICAg CiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU1ZhcmlhYmxlT2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNWYXJpYWJsZU9iamVjdC5oCShyZXZpc2lvbiAxMDM2NzMpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1ZhcmlhYmxlT2JqZWN0LmgJKHdvcmtpbmcg Y29weSkKQEAgLTkwLDcgKzkwLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIGJvb2wgc3lt Ym9sVGFibGVHZXQoY29uc3QgSWRlbnRpZmllciYsIFByb3BlcnR5U2xvdCYpOwogICAgICAgICBi b29sIHN5bWJvbFRhYmxlR2V0KGNvbnN0IElkZW50aWZpZXImLCBQcm9wZXJ0eURlc2NyaXB0b3Im KTsKICAgICAgICAgYm9vbCBzeW1ib2xUYWJsZUdldChjb25zdCBJZGVudGlmaWVyJiwgUHJvcGVy dHlTbG90JiwgYm9vbCYgc2xvdElzV3JpdGVhYmxlKTsKLSAgICAgICAgYm9vbCBzeW1ib2xUYWJs ZVB1dChKU0dsb2JhbERhdGEmLCBjb25zdCBJZGVudGlmaWVyJiwgSlNWYWx1ZSk7CisgICAgICAg IGJvb2wgc3ltYm9sVGFibGVQdXQoRXhlY1N0YXRlKiwgY29uc3QgSWRlbnRpZmllciYsIEpTVmFs dWUsIGJvb2wgc2hvdWxkVGhyb3cpOwogICAgICAgICBib29sIHN5bWJvbFRhYmxlUHV0V2l0aEF0 dHJpYnV0ZXMoSlNHbG9iYWxEYXRhJiwgY29uc3QgSWRlbnRpZmllciYsIEpTVmFsdWUsIHVuc2ln bmVkIGF0dHJpYnV0ZXMpOwogCiAgICAgICAgIFN5bWJvbFRhYmxlKiBtX3N5bWJvbFRhYmxlOyAv LyBNYXBzIG5hbWUgLT4gb2Zmc2V0IGZyb20gInIiIGluIHJlZ2lzdGVyIGZpbGUuCkBAIC0xMTks MTUgKzExOSwxOSBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAg IH0KIAotICAgIGlubGluZSBib29sIEpTVmFyaWFibGVPYmplY3Q6OnN5bWJvbFRhYmxlUHV0KEpT R2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSwgY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lLCBK U1ZhbHVlIHZhbHVlKQorICAgIGlubGluZSBib29sIEpTVmFyaWFibGVPYmplY3Q6OnN5bWJvbFRh YmxlUHV0KEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lLCBK U1ZhbHVlIHZhbHVlLCBib29sIHNob3VsZFRocm93KQogICAgIHsKKyAgICAgICAgSlNHbG9iYWxE YXRhJiBnbG9iYWxEYXRhID0gZXhlYy0+Z2xvYmFsRGF0YSgpOwogICAgICAgICBBU1NFUlQoIUhl YXA6OmhlYXAodmFsdWUpIHx8IEhlYXA6OmhlYXAodmFsdWUpID09IEhlYXA6OmhlYXAodGhpcykp OwogCiAgICAgICAgIFN5bWJvbFRhYmxlRW50cnkgZW50cnkgPSBzeW1ib2xUYWJsZSgpLmlubGlu ZUdldChwcm9wZXJ0eU5hbWUuaW1wbCgpKTsKICAgICAgICAgaWYgKGVudHJ5LmlzTnVsbCgpKQog ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgICAgICBpZiAoZW50cnkuaXNSZWFkT25seSgp KQorICAgICAgICBpZiAoZW50cnkuaXNSZWFkT25seSgpKSB7CisgICAgICAgICAgICBpZiAoc2hv dWxkVGhyb3cpCisgICAgICAgICAgICAgICAgdGhyb3dUeXBlRXJyb3IoZXhlYywgU3RyaWN0TW9k ZVJlYWRvbmx5UHJvcGVydHlXcml0ZUVycm9yKTsKICAgICAgICAgICAgIHJldHVybiB0cnVlOwor ICAgICAgICB9CiAgICAgICAgIHJlZ2lzdGVyQXQoZW50cnkuZ2V0SW5kZXgoKSkuc2V0KGdsb2Jh bERhdGEsIHRoaXMsIHZhbHVlKTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTG9va3VwLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTG9va3VwLmgJKHJldmlzaW9uIDEwMzY3MykKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0xvb2t1cC5oCSh3b3JraW5nIGNvcHkpCkBA IC0zNDgsMTAgKzM0OCwxMCBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgKiBpcyBmb3VuZCBpdCBz ZXRzIHRoZSB2YWx1ZSBhbmQgcmV0dXJucyB0cnVlLCBlbHNlIGl0IHJldHVybnMgZmFsc2UuCiAg ICAgICovCiAgICAgdGVtcGxhdGUgPGNsYXNzIFRoaXNJbXA+Ci0gICAgaW5saW5lIGJvb2wgbG9v a3VwUHV0KEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lLCBK U1ZhbHVlIHZhbHVlLCBjb25zdCBIYXNoVGFibGUqIHRhYmxlLCBUaGlzSW1wKiB0aGlzT2JqKQor ICAgIGlubGluZSBib29sIGxvb2t1cFB1dChFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IElkZW50aWZp ZXImIHByb3BlcnR5TmFtZSwgSlNWYWx1ZSB2YWx1ZSwgY29uc3QgSGFzaFRhYmxlKiB0YWJsZSwg VGhpc0ltcCogdGhpc09iaiwgYm9vbCBzaG91bGRUaHJvdyA9IGZhbHNlKQogICAgIHsKICAgICAg ICAgY29uc3QgSGFzaEVudHJ5KiBlbnRyeSA9IHRhYmxlLT5lbnRyeShleGVjLCBwcm9wZXJ0eU5h bWUpOwotCisgICAgICAgIAogICAgICAgICBpZiAoIWVudHJ5KQogICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwogCkBAIC0zNjAsNiArMzYwLDggQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgICAg ICB0aGlzT2JqLT5wdXREaXJlY3QoZXhlYy0+Z2xvYmFsRGF0YSgpLCBwcm9wZXJ0eU5hbWUsIHZh bHVlKTsKICAgICAgICAgZWxzZSBpZiAoIShlbnRyeS0+YXR0cmlidXRlcygpICYgUmVhZE9ubHkp KQogICAgICAgICAgICAgZW50cnktPnByb3BlcnR5UHV0dGVyKCkoZXhlYywgdGhpc09iaiwgdmFs dWUpOworICAgICAgICBlbHNlIGlmIChzaG91bGRUaHJvdykKKyAgICAgICAgICAgIHRocm93VHlw ZUVycm9yKGV4ZWMsIFN0cmljdE1vZGVSZWFkb25seVByb3BlcnR5V3JpdGVFcnJvcik7CiAKICAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQpAQCAtMzczLDcgKzM3NSw3IEBAIG5hbWVzcGFjZSBK U0MgewogICAgIHRlbXBsYXRlIDxjbGFzcyBUaGlzSW1wLCBjbGFzcyBQYXJlbnRJbXA+CiAgICAg aW5saW5lIHZvaWQgbG9va3VwUHV0KEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgSWRlbnRpZmllciYg cHJvcGVydHlOYW1lLCBKU1ZhbHVlIHZhbHVlLCBjb25zdCBIYXNoVGFibGUqIHRhYmxlLCBUaGlz SW1wKiB0aGlzT2JqLCBQdXRQcm9wZXJ0eVNsb3QmIHNsb3QpCiAgICAgewotICAgICAgICBpZiAo IWxvb2t1cFB1dDxUaGlzSW1wPihleGVjLCBwcm9wZXJ0eU5hbWUsIHZhbHVlLCB0YWJsZSwgdGhp c09iaikpCisgICAgICAgIGlmICghbG9va3VwUHV0PFRoaXNJbXA+KGV4ZWMsIHByb3BlcnR5TmFt ZSwgdmFsdWUsIHRhYmxlLCB0aGlzT2JqLCBzbG90LmlzU3RyaWN0TW9kZSgpKSkKICAgICAgICAg ICAgIFBhcmVudEltcDo6cHV0KHRoaXNPYmosIGV4ZWMsIHByb3BlcnR5TmFtZSwgdmFsdWUsIHNs b3QpOyAvLyBub3QgZm91bmQ6IGZvcndhcmQgdG8gcGFyZW50CiAgICAgfQogCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9OdW1iZXJDb25zdHJ1Y3Rvci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTnVtYmVyQ29uc3RydWN0b3IuY3Bw CShyZXZpc2lvbiAxMDM2NzMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9OdW1i ZXJDb25zdHJ1Y3Rvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgzLDYgKzgzLDExIEBAIGJvb2wg TnVtYmVyQ29uc3RydWN0b3I6OmdldE93blByb3BlcnR5RGUKICAgICByZXR1cm4gZ2V0U3RhdGlj VmFsdWVEZXNjcmlwdG9yPE51bWJlckNvbnN0cnVjdG9yLCBJbnRlcm5hbEZ1bmN0aW9uPihleGVj LCBFeGVjU3RhdGU6Om51bWJlckNvbnN0cnVjdG9yVGFibGUoZXhlYyksIGpzQ2FzdDxOdW1iZXJD b25zdHJ1Y3Rvcio+KG9iamVjdCksIHByb3BlcnR5TmFtZSwgZGVzY3JpcHRvcik7CiB9CiAKK3Zv aWQgTnVtYmVyQ29uc3RydWN0b3I6OnB1dChKU0NlbGwqIGNlbGwsIEV4ZWNTdGF0ZSogZXhlYywg Y29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lLCBKU1ZhbHVlIHZhbHVlLCBQdXRQcm9wZXJ0 eVNsb3QmIHNsb3QpCit7CisgICAgbG9va3VwUHV0PE51bWJlckNvbnN0cnVjdG9yLCBJbnRlcm5h bEZ1bmN0aW9uPihleGVjLCBwcm9wZXJ0eU5hbWUsIHZhbHVlLCBFeGVjU3RhdGU6Om51bWJlckNv bnN0cnVjdG9yVGFibGUoZXhlYyksIGpzQ2FzdDxOdW1iZXJDb25zdHJ1Y3Rvcio+KGNlbGwpLCBz bG90KTsKK30KKwogc3RhdGljIEpTVmFsdWUgbnVtYmVyQ29uc3RydWN0b3JOYU5WYWx1ZShFeGVj U3RhdGUqLCBKU1ZhbHVlLCBjb25zdCBJZGVudGlmaWVyJikKIHsKICAgICByZXR1cm4ganNOYU4o KTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL051bWJlckNvbnN0cnVjdG9y LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTnVtYmVyQ29u c3RydWN0b3IuaAkocmV2aXNpb24gMTAzNjczKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvTnVtYmVyQ29uc3RydWN0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtMzgsNiArMzgsOCBA QCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIHJldHVybiBjb25zdHJ1Y3RvcjsKICAgICAg ICAgfQogCisgICAgICAgIHN0YXRpYyB2b2lkIHB1dChKU0NlbGwqLCBFeGVjU3RhdGUqLCBjb25z dCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUsIEpTVmFsdWUsIFB1dFByb3BlcnR5U2xvdCYpOwor CiAgICAgICAgIHN0YXRpYyBib29sIGdldE93blByb3BlcnR5U2xvdChKU0NlbGwqLCBFeGVjU3Rh dGUqLCBjb25zdCBJZGVudGlmaWVyJiwgUHJvcGVydHlTbG90Jik7CiAgICAgICAgIHN0YXRpYyBi b29sIGdldE93blByb3BlcnR5RGVzY3JpcHRvcihKU09iamVjdCosIEV4ZWNTdGF0ZSosIGNvbnN0 IElkZW50aWZpZXImLCBQcm9wZXJ0eURlc2NyaXB0b3ImKTsKICAgICAgICAgSlNWYWx1ZSBnZXRW YWx1ZVByb3BlcnR5KEV4ZWNTdGF0ZSosIGludCB0b2tlbikgY29uc3Q7CkluZGV4OiBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZp c2lvbiAxMDM2OTIpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxOSBAQAorMjAxMS0xMi0yNiAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3Vn aEBhcHBsZS5jb20+CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTc1MjMxCisgICAgICAgIEZhaWwgdG8gdGhyb3cgaW4gc3RyaWN0IG1vZGUgb24gYXNz aWduIHRvIHJlYWQgb25seSBzdGF0aWMgcHJvcGVydGllcworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIHRlc3QgY2FzZXMgLyB1cGRhdGVkIG5v dy1wYXNzaW5nIHJlc3VsdHMuCisKKyAgICAgICAgKiBmYXN0L2pzL21vemlsbGEvc3RyaWN0LzE1 LjEwLjctZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvanMvc2NyaXB0LXRlc3RzL3N0cmlj dC1yZWFkb25seS1zdGF0aWNzLmpzOiBBZGRlZC4KKyAgICAgICAgKHRlc3RXaW5kb3dVbmRlZmlu ZWQpOgorICAgICAgICAodGVzdE51bWJlck1BWF9WQUxVRSk6CisgICAgICAgICogZmFzdC9qcy9z dHJpY3QtcmVhZG9ubHktc3RhdGljcy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZh c3QvanMvc3RyaWN0LXJlYWRvbmx5LXN0YXRpY3MuaHRtbDogQWRkZWQuCisKIDIwMTEtMTItMjYg IERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIENoZWNrIGluIGV4cGVj dGVkIGZhaWx1cmVzIGZvciBhIGNvdXBsZSBvZiB0ZXN0cy4KSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvanMvc3RyaWN0LXJlYWRvbmx5LXN0YXRpY3MtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2Zhc3QvanMvc3RyaWN0LXJlYWRvbmx5LXN0YXRpY3MtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9zdHJpY3QtcmVhZG9ubHktc3Rh dGljcy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTEgQEAKK1RoaXMgdGVz dHMgdGhhdCBhIGFzc2lnbmluZyB0byBhIHJlYWRvbmx5IHByb3BlcnR5IGluIGEgc3RhdGljIG9y IHN5bWJvbCB0YWJsZSB0aHJvd3MgaW4gc3RyaWN0IG1vZGUuCisKK09uIHN1Y2Nlc3MsIHlvdSB3 aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENP TVBMRVRFIi4KKworCitQQVNTIHRlc3RXaW5kb3dVbmRlZmluZWQoKSBpcyB0cnVlCitQQVNTIHRl c3ROdW1iZXJNQVhfVkFMVUUoKSBpcyB0cnVlCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0 cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9zdHJpY3Qt cmVhZG9ubHktc3RhdGljcy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMv c3RyaWN0LXJlYWRvbmx5LXN0YXRpY3MuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2Zhc3QvanMvc3RyaWN0LXJlYWRvbmx5LXN0YXRpY3MuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSwxMCBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4i PgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvanMtdGVzdC1wcmUuanMi Pjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0ic2NyaXB0LXRlc3RzL3N0 cmljdC1yZWFkb25seS1zdGF0aWNzLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJj ZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExh eW91dFRlc3RzL2Zhc3QvanMvbW96aWxsYS9zdHJpY3QvMTUuMTAuNy1leHBlY3RlZC50eHQKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9tb3ppbGxhL3N0cmljdC8xNS4xMC43LWV4 cGVjdGVkLnR4dAkocmV2aXNpb24gMTAzNjczKQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9tb3pp bGxhL3N0cmljdC8xNS4xMC43LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSwyMiAr MSwyMiBAQAotRkFJTCAndXNlIHN0cmljdCc7IHZhciByID0gL2Zvby87IHIuc291cmNlID0gImJh ciI7IHIuc291cmNlIHNob3VsZCB0aHJvdyBhbiBpbnN0YW5jZSBvZiBUeXBlRXJyb3IKK1BBU1Mg J3VzZSBzdHJpY3QnOyB2YXIgciA9IC9mb28vOyByLnNvdXJjZSA9ICJiYXIiOyByLnNvdXJjZSB0 aHJldyBleGNlcHRpb24gb2YgdHlwZSBUeXBlRXJyb3IuCiBQQVNTIHZhciByID0gL2Zvby87IHIu c291cmNlID0gImJhciI7IHIuc291cmNlIGlzICJmb28iCiBQQVNTIHRydWUgPT09IHRydWUKIFBB U1MgJ3VzZSBzdHJpY3QnOyB2YXIgciA9IC9mb28vOyBkZWxldGUgci5zb3VyY2UgdGhyZXcgZXhj ZXB0aW9uIG9mIHR5cGUgVHlwZUVycm9yLgogUEFTUyB2YXIgciA9IC9mb28vOyBkZWxldGUgci5z b3VyY2UgaXMgZmFsc2UKIFBBU1MgdHJ1ZSA9PT0gdHJ1ZQotRkFJTCAndXNlIHN0cmljdCc7IHZh ciByID0gL2Zvby87IHIuZ2xvYmFsID0gdHJ1ZTsgci5nbG9iYWwgc2hvdWxkIHRocm93IGFuIGlu c3RhbmNlIG9mIFR5cGVFcnJvcgorUEFTUyAndXNlIHN0cmljdCc7IHZhciByID0gL2Zvby87IHIu Z2xvYmFsID0gdHJ1ZTsgci5nbG9iYWwgdGhyZXcgZXhjZXB0aW9uIG9mIHR5cGUgVHlwZUVycm9y LgogUEFTUyB2YXIgciA9IC9mb28vOyByLmdsb2JhbCA9IHRydWU7IHIuZ2xvYmFsIGlzIGZhbHNl CiBQQVNTIHRydWUgPT09IHRydWUKIFBBU1MgJ3VzZSBzdHJpY3QnOyB2YXIgciA9IC9mb28vOyBk ZWxldGUgci5nbG9iYWwgdGhyZXcgZXhjZXB0aW9uIG9mIHR5cGUgVHlwZUVycm9yLgogUEFTUyB2 YXIgciA9IC9mb28vOyBkZWxldGUgci5nbG9iYWwgaXMgZmFsc2UKIFBBU1MgdHJ1ZSA9PT0gdHJ1 ZQotRkFJTCAndXNlIHN0cmljdCc7IHZhciByID0gL2Zvby87IHIuaWdub3JlQ2FzZSA9IHRydWU7 IHIuaWdub3JlQ2FzZSBzaG91bGQgdGhyb3cgYW4gaW5zdGFuY2Ugb2YgVHlwZUVycm9yCitQQVNT ICd1c2Ugc3RyaWN0JzsgdmFyIHIgPSAvZm9vLzsgci5pZ25vcmVDYXNlID0gdHJ1ZTsgci5pZ25v cmVDYXNlIHRocmV3IGV4Y2VwdGlvbiBvZiB0eXBlIFR5cGVFcnJvci4KIFBBU1MgdmFyIHIgPSAv Zm9vLzsgci5pZ25vcmVDYXNlID0gdHJ1ZTsgci5pZ25vcmVDYXNlIGlzIGZhbHNlCiBQQVNTIHRy dWUgPT09IHRydWUKIFBBU1MgJ3VzZSBzdHJpY3QnOyB2YXIgciA9IC9mb28vOyBkZWxldGUgci5p Z25vcmVDYXNlIHRocmV3IGV4Y2VwdGlvbiBvZiB0eXBlIFR5cGVFcnJvci4KIFBBU1MgdmFyIHIg PSAvZm9vLzsgZGVsZXRlIHIuaWdub3JlQ2FzZSBpcyBmYWxzZQogUEFTUyB0cnVlID09PSB0cnVl Ci1GQUlMICd1c2Ugc3RyaWN0JzsgdmFyIHIgPSAvZm9vLzsgci5tdWx0aWxpbmUgPSB0cnVlOyBy Lm11bHRpbGluZSBzaG91bGQgdGhyb3cgYW4gaW5zdGFuY2Ugb2YgVHlwZUVycm9yCitQQVNTICd1 c2Ugc3RyaWN0JzsgdmFyIHIgPSAvZm9vLzsgci5tdWx0aWxpbmUgPSB0cnVlOyByLm11bHRpbGlu ZSB0aHJldyBleGNlcHRpb24gb2YgdHlwZSBUeXBlRXJyb3IuCiBQQVNTIHZhciByID0gL2Zvby87 IHIubXVsdGlsaW5lID0gdHJ1ZTsgci5tdWx0aWxpbmUgaXMgZmFsc2UKIFBBU1MgdHJ1ZSA9PT0g dHJ1ZQogUEFTUyAndXNlIHN0cmljdCc7IHZhciByID0gL2Zvby87IGRlbGV0ZSByLm11bHRpbGlu ZSB0aHJldyBleGNlcHRpb24gb2YgdHlwZSBUeXBlRXJyb3IuCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2pzL3NjcmlwdC10ZXN0cy9zdHJpY3QtcmVhZG9ubHktc3RhdGljcy5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9zdHJpY3QtcmVhZG9ubHktc3Rh dGljcy5qcwkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3Rz L3N0cmljdC1yZWFkb25seS1zdGF0aWNzLmpzCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI4IEBA CitkZXNjcmlwdGlvbigKKyJUaGlzIHRlc3RzIHRoYXQgYSBhc3NpZ25pbmcgdG8gYSByZWFkb25s eSBwcm9wZXJ0eSBpbiBhIHN0YXRpYyBvciBzeW1ib2wgdGFibGUgdGhyb3dzIGluIHN0cmljdCBt b2RlLiIKKyk7CisKK2Z1bmN0aW9uIHRlc3RXaW5kb3dVbmRlZmluZWQoKQoreworICAgICJ1c2Ug c3RyaWN0IjsKKyAgICB0cnkgeworICAgICAgICAgd2luZG93LnVuZGVmaW5lZCA9IDQyOworICAg IH0gY2F0Y2ggKGUpIHsKKyAgICAgICAgcmV0dXJuIGUgaW5zdGFuY2VvZiBUeXBlRXJyb3I7Cisg ICAgfQorICAgIHJldHVybiBmYWxzZTsKK30KKworZnVuY3Rpb24gdGVzdE51bWJlck1BWF9WQUxV RSgpCit7CisgICAgInVzZSBzdHJpY3QiOworICAgIHRyeSB7CisgICAgICAgICBOdW1iZXIuTUFY X1ZBTFVFID0gNDI7CisgICAgfSBjYXRjaCAoZSkgeworICAgICAgICByZXR1cm4gZSBpbnN0YW5j ZW9mIFR5cGVFcnJvcjsKKyAgICB9CisgICAgcmV0dXJuIGZhbHNlOworfQorCitzaG91bGRCZVRy dWUoJ3Rlc3RXaW5kb3dVbmRlZmluZWQoKScpOworc2hvdWxkQmVUcnVlKCd0ZXN0TnVtYmVyTUFY X1ZBTFVFKCknKTsK