75204 2011-12-25 09:08:51 -0800 Change CSS canvas code that does HashMap get/set to use the more efficient add idiom 2011-12-25 11:03:36 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72477 1 darin darin webkit.review.bot oldest_to_newest 527057 0 darin 2011-12-25 09:08:51 -0800 Change CSS canvas code that does HashMap get/set to use the more efficient add idiom 527058 1 120511 darin 2011-12-25 09:10:10 -0800 Created attachment 120511 Patch 527059 2 darin 2011-12-25 09:10:58 -0800 While working on bug 72477, I stumbled on this easy-to-improve call site. 527060 3 120511 mitz 2011-12-25 09:14:16 -0800 Comment on attachment 120511 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120511&action=review > Source/WebCore/ChangeLog:9 > + (WebCore::Document::getCSSCanvasContext): Change local variable name of element to Did you mean “of result”? 527061 4 120511 darin 2011-12-25 09:21:12 -0800 Comment on attachment 120511 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120511&action=review >> Source/WebCore/ChangeLog:9 >> + (WebCore::Document::getCSSCanvasContext): Change local variable name of element to > > Did you mean “of result”? Sorry I was unclear. But I meant of element as in "of the element", the variable has always held an element, it was just named result. 527066 5 120511 webkit.review.bot 2011-12-25 11:03:32 -0800 Comment on attachment 120511 Patch Clearing flags on attachment: 120511 Committed r103671: <http://trac.webkit.org/changeset/103671> 527067 6 webkit.review.bot 2011-12-25 11:03:36 -0800 All reviewed patches have been landed. Closing bug. 120511 2011-12-25 09:10:10 -0800 2011-12-25 11:03:32 -0800 Patch bug-75204-20111225091009.patch text/plain 2179 darin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzY3MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDExLTEyLTI1ICBEYXJpbiBB ZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBDaGFuZ2UgQ1NTIGNhbnZhcyBjb2Rl IHRoYXQgZG9lcyBIYXNoTWFwIGdldC9zZXQgdG8gdXNlIHRoZSBtb3JlIGVmZmljaWVudCBhZGQg aWRpb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1 MjA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBk b20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmdldENTU0NhbnZh c0NvbnRleHQpOiBDaGFuZ2UgbG9jYWwgdmFyaWFibGUgbmFtZSBvZiBlbGVtZW50IHRvCisgICAg ICAgIGVsZW1lbnQ7IGl0J3Mgbm90IHRoZSBmdW5jdGlvbiByZXN1bHQsIHNvIG5vdCBnb29kIHRv IG5hbWUgaXQgcmVzdWx0LgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmdldENTU0NhbnZh c0VsZW1lbnQpOiBVc2UgYWRkIGluc3RlYWQgb2YgZ2V0L3NldCBzbyB3ZSBvbmx5IGRvCisgICAg ICAgIG9uZSBoYXNoIHRhYmxlIGxvb2t1cC4KKwogMjAxMS0xMi0yNCAgQW5kcmVhcyBLbGluZyAg PGF3ZXNvbWVrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQ1NTRWxlbWVudFN0eWxlRGVjbGFy YXRpb25zIHNob3VsZCBuZXZlciBtb3ZlIGJldHdlZW4gZWxlbWVudHMuCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDEwMzY2OSkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ2NzQsMjEgKzQ2NzQsMTkgQEAgdm9pZCBE b2N1bWVudDo6ZGV0YWNoUmFuZ2UoUmFuZ2UqIHJhbmdlKQogCiBDYW52YXNSZW5kZXJpbmdDb250 ZXh0KiBEb2N1bWVudDo6Z2V0Q1NTQ2FudmFzQ29udGV4dChjb25zdCBTdHJpbmcmIHR5cGUsIGNv bnN0IFN0cmluZyYgbmFtZSwgaW50IHdpZHRoLCBpbnQgaGVpZ2h0KQogewotICAgIEhUTUxDYW52 YXNFbGVtZW50KiByZXN1bHQgPSBnZXRDU1NDYW52YXNFbGVtZW50KG5hbWUpOwotICAgIGlmICgh cmVzdWx0KQorICAgIEhUTUxDYW52YXNFbGVtZW50KiBlbGVtZW50ID0gZ2V0Q1NTQ2FudmFzRWxl bWVudChuYW1lKTsKKyAgICBpZiAoIWVsZW1lbnQpCiAgICAgICAgIHJldHVybiAwOwotICAgIHJl c3VsdC0+c2V0U2l6ZShJbnRTaXplKHdpZHRoLCBoZWlnaHQpKTsKLSAgICByZXR1cm4gcmVzdWx0 LT5nZXRDb250ZXh0KHR5cGUpOworICAgIGVsZW1lbnQtPnNldFNpemUoSW50U2l6ZSh3aWR0aCwg aGVpZ2h0KSk7CisgICAgcmV0dXJuIGVsZW1lbnQtPmdldENvbnRleHQodHlwZSk7CiB9CiAKIEhU TUxDYW52YXNFbGVtZW50KiBEb2N1bWVudDo6Z2V0Q1NTQ2FudmFzRWxlbWVudChjb25zdCBTdHJp bmcmIG5hbWUpCiB7Ci0gICAgUmVmUHRyPEhUTUxDYW52YXNFbGVtZW50PiByZXN1bHQgPSBtX2Nz c0NhbnZhc0VsZW1lbnRzLmdldChuYW1lKS5nZXQoKTsKLSAgICBpZiAoIXJlc3VsdCkgewotICAg ICAgICByZXN1bHQgPSBIVE1MQ2FudmFzRWxlbWVudDo6Y3JlYXRlKHRoaXMpOwotICAgICAgICBt X2Nzc0NhbnZhc0VsZW1lbnRzLnNldChuYW1lLCByZXN1bHQpOwotICAgIH0KLSAgICByZXR1cm4g cmVzdWx0LmdldCgpOworICAgIFJlZlB0cjxIVE1MQ2FudmFzRWxlbWVudD4mIGVsZW1lbnQgPSBt X2Nzc0NhbnZhc0VsZW1lbnRzLmFkZChuYW1lLCAwKS5maXJzdC0+c2Vjb25kOworICAgIGlmICgh ZWxlbWVudCkKKyAgICAgICAgZWxlbWVudCA9IEhUTUxDYW52YXNFbGVtZW50OjpjcmVhdGUodGhp cyk7CisgICAgcmV0dXJuIGVsZW1lbnQuZ2V0KCk7CiB9CiAKIHZvaWQgRG9jdW1lbnQ6OmluaXRE TlNQcmVmZXRjaCgpCg==