75200 2011-12-24 19:38:36 -0800 REGRESSION (r90797): Full screen video HUD cannot be dragged horizontally 2012-01-06 10:28:53 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED data:text/html,%3cvideo%20src=%22http://movies.apple.com/movies/us/apple/ipoditunes/2007/touch/ads/apple_ipodtouch_touch_r640-9cie.mov%22%20controls%3E InRadar, Regression P1 Normal --- 1 mitz jer.noble dglazkov jer.noble macpherson webkit.review.bot oldest_to_newest 527042 0 mitz 2011-12-24 19:38:36 -0800 To reproduce, navigate to the URL, click the full screen button in the video controls to enter full screen mode, then try to drag the full screen HUD around the screen. The HUD only moves vertically but stays centered. This was caused by <http://trac.webkit.org/r90797>. 527043 1 mitz 2011-12-24 19:39:00 -0800 <rdar://problem/10625200> 530634 2 121331 jer.noble 2012-01-05 14:30:44 -0800 Created attachment 121331 Patch 530803 3 121331 eric.carlson 2012-01-05 17:11:38 -0800 Comment on attachment 121331 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121331&action=review r=me, although I would rather you use mediaControlsElement() if possible. > LayoutTests/fullscreen/video-controls-drag.html:19 > + panel = internals.shadowRoot(video).firstChild.firstChild; Ick, why hard code the position of the element in the shadow DOM instead of looking it up by name? 530862 4 jer.noble 2012-01-05 18:25:45 -0800 (In reply to comment #3) > (From update of attachment 121331 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=121331&action=review > > r=me, although I would rather you use mediaControlsElement() if possible. > > > LayoutTests/fullscreen/video-controls-drag.html:19 > > + panel = internals.shadowRoot(video).firstChild.firstChild; > > Ick, why hard code the position of the element in the shadow DOM instead of looking it up by name? I copied it from an existing test, and discovered mediaControlsElement() in between this patch, and the one for bug #75650. :-D I'll change this to use mediaControlsElement. Thanks! 530982 5 121331 webkit.review.bot 2012-01-06 01:18:26 -0800 Comment on attachment 121331 Patch Attachment 121331 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11146268 New failing tests: fullscreen/video-controls-drag.html 531147 6 jer.noble 2012-01-06 10:28:53 -0800 Committed r104301: <http://trac.webkit.org/changeset/104301> 121331 2012-01-05 14:30:44 -0800 2012-01-06 01:18:26 -0800 Patch bug-75200-20120105143043.patch text/plain 6827 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzMwZGQ4YjJkZjgyMjZi NTIxMzAxMjgwZGFmMDM0NWU3YzM3Mzk0YS4uNjgxZjFhOTg1YTRjY2Y5ZjMwOGVlM2IwNDBjZWY0 ZjdhZWNhODlkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTAxLTA1ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHI5MDc5 Nyk6IEZ1bGwgc2NyZWVuIHZpZGVvIEhVRCBjYW5ub3QgYmUgZHJhZ2dlZCBob3Jpem9udGFsbHkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1MjAwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZnVs bHNjcmVlbi92aWRlby1jb250cm9scy1kcmFnLmh0bWwKKworICAgICAgICBUaGUgIWltcG9ydGFu dCBydWxlcyBpbiBmdWxsc2NyZWVuUXVpY2tUaW1lLmNzcyBhcmUgb3ZlcnJpZGluZyB0aGUgc3R5 bGVzIGFkZGVkIGJ5IHRoZSAKKyAgICAgICAgZHJhZyBvcGVyYXRpb24gaW4gTWVkaWFDb250cm9s RWxlbWVudHMuY3BwLiAgR2l2ZSB0aGUgcGFuZWwgYSAiZHJhZ2dlZCIgY2xhc3MgaW4gc2V0UG9z aXRpb24KKyAgICAgICAgKGNsZWFyaW5nIGl0IGluIHJlc2V0UG9zaXRpb24pIHRoYXQgYWxsb3dz IHRoZSAhaW1wb3J0YW50IHJ1bGVzIHRvIGFwcGx5IG9ubHkgd2hlbiB0aGUgCisgICAgICAgIHBh bmVsIGlzIG5vdCBkcmFnZ2VkLgorCisgICAgICAgICogY3NzL2Z1bGxzY3JlZW5RdWlja1RpbWUu Y3NzOgorICAgICAgICAodmlkZW86LXdlYmtpdC1mdWxsLXNjcmVlbjo6LXdlYmtpdC1tZWRpYS1j b250cm9scy1wYW5lbCk6CisgICAgICAgICh2aWRlbzotd2Via2l0LWZ1bGwtc2NyZWVuOjotd2Vi a2l0LW1lZGlhLWNvbnRyb2xzLXBhbmVsOm5vdCguZHJhZ2dlZCkpOgorICAgICAgICAqIGh0bWwv c2hhZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh Q29udHJvbFBhbmVsRWxlbWVudDo6c2V0UG9zaXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFDb250cm9sUGFuZWxFbGVtZW50OjpyZXNldFBvc2l0aW9uKToKKwogMjAxMS0xMi0xOSAgSm9z aHVhIEJlbGwgIDxqc2JlbGxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEluZGV4ZWREQiBtdWx0 aXBsZSBjYWxscyB0byB0cmFuc2FjdGlvbi5vYmplY3RTdG9yZShuYW1lKSBzaG91bGQgcmV0dXJu IHRoZSBzYW1lIGluc3RhbmNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvZnVsbHNj cmVlblF1aWNrVGltZS5jc3MgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvZnVsbHNjcmVlblF1aWNrVGlt ZS5jc3MKaW5kZXggYTU1NTk3NjhkZWM4YTY4ZWI0OTZjNTUwNDFkNmE1NjE0M2FkMjVjYy4uZWEx ZWJkNmVjZDQxZDY5MGQwMzM2YjE1M2E4YjE2ZmNmOGZjMzJlMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvY3NzL2Z1bGxzY3JlZW5RdWlja1RpbWUuY3NzCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9mdWxsc2NyZWVuUXVpY2tUaW1lLmNzcwpAQCAtMjksOSArMjksNiBAQCB2aWRlbzotd2Vi a2l0LWZ1bGwtc2NyZWVuOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXBhbmVsIHsKICAgICAtd2Vi a2l0LWJveC1wYWNrOiBlbmQgIWltcG9ydGFudDsKICAgICAtd2Via2l0LWFwcGVhcmFuY2U6IG5v bmUgIWltcG9ydGFudDsKIAotICAgIGJvdHRvbTogNTBweCAhaW1wb3J0YW50OwotICAgIGxlZnQ6 IDUwJSAhaW1wb3J0YW50OwotICAgIG1hcmdpbi1sZWZ0OiAtMjIwcHggIWltcG9ydGFudDsKICAg ICBwYWRkaW5nOiAxMnB4IDAgMCAxMHB4ICFpbXBvcnRhbnQ7CiAgICAgd2lkdGg6IDQzMHB4ICFp bXBvcnRhbnQ7CiAgICAgaGVpZ2h0OiA0OHB4ICFpbXBvcnRhbnQ7CkBAIC01OCw2ICs1NSwxMiBA QCB2aWRlbzotd2Via2l0LWZ1bGwtc2NyZWVuOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXBhbmVs IHsKICAgICAtd2Via2l0LXRyYW5zaXRpb246IG9wYWNpdHkgMC4zcyBsaW5lYXIgIWltcG9ydGFu dDsKIH0KIAordmlkZW86LXdlYmtpdC1mdWxsLXNjcmVlbjo6LXdlYmtpdC1tZWRpYS1jb250cm9s cy1wYW5lbDpub3QoLmRyYWdnZWQpIHsKKyAgICBib3R0b206IDUwcHggIWltcG9ydGFudDsKKyAg ICBsZWZ0OiA1MCUgIWltcG9ydGFudDsKKyAgICBtYXJnaW4tbGVmdDogLTIyMHB4ICFpbXBvcnRh bnQ7Cit9CisKIHZpZGVvOi13ZWJraXQtYW5pbWF0aW5nLWZ1bGwtc2NyZWVuLXRyYW5zaXRpb246 Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtcGFuZWwgewogICAgIG9wYWNpdHk6IDAgISBpbXBvcnRh bnQ7CiAgICAgLXdlYmtpdC10cmFuc2l0aW9uOiBvcGFjaXR5IDAgISBpbXBvcnRhbnQ7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAK aW5kZXggYTFkYjdhYTFhNGVlZDMyNGNjZWZjMGExYmNhNDNmYzc1ODM2OWNmZC4uNDVmZjE2ZGYx MzM4NmVkM2FhYzc5ZmUxZmM0YzA5MjI0YWYwNDY1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcApAQCAtMzQsNiArMzQsNyBA QAogCiAjaW5jbHVkZSAiQ1NTU3R5bGVTZWxlY3Rvci5oIgogI2luY2x1ZGUgIkNTU1ZhbHVlS2V5 d29yZHMuaCIKKyNpbmNsdWRlICJET01Ub2tlbkxpc3QuaCIKICNpbmNsdWRlICJFdmVudE5hbWVz LmgiCiAjaW5jbHVkZSAiRmxvYXRDb252ZXJzaW9uLmgiCiAjaW5jbHVkZSAiRnJhbWUuaCIKQEAg LTE4NSw2ICsxODYsOSBAQCB2b2lkIE1lZGlhQ29udHJvbFBhbmVsRWxlbWVudDo6c2V0UG9zaXRp b24oY29uc3QgTGF5b3V0UG9pbnQmIHBvc2l0aW9uKQogICAgIHN0eWxlLT5zZXRQcm9wZXJ0eShD U1NQcm9wZXJ0eVRvcCwgdG9wLCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1BYKTsKICAgICBzdHls ZS0+c2V0UHJvcGVydHkoQ1NTUHJvcGVydHlNYXJnaW5MZWZ0LCAwLjAsIENTU1ByaW1pdGl2ZVZh bHVlOjpDU1NfUFgpOwogICAgIHN0eWxlLT5zZXRQcm9wZXJ0eShDU1NQcm9wZXJ0eU1hcmdpblRv cCwgMC4wLCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1BYKTsKKworICAgIEV4Y2VwdGlvbkNvZGUg aWdub3JlZDsKKyAgICBjbGFzc0xpc3QoKS0+YWRkKCJkcmFnZ2VkIiwgaWdub3JlZCk7CiB9CiAK IHZvaWQgTWVkaWFDb250cm9sUGFuZWxFbGVtZW50OjpyZXNldFBvc2l0aW9uKCkKQEAgLTE5NSw2 ICsxOTksOSBAQCB2b2lkIE1lZGlhQ29udHJvbFBhbmVsRWxlbWVudDo6cmVzZXRQb3NpdGlvbigp CiAgICAgc3R5bGUtPnJlbW92ZVByb3BlcnR5KENTU1Byb3BlcnR5VG9wKTsKICAgICBzdHlsZS0+ cmVtb3ZlUHJvcGVydHkoQ1NTUHJvcGVydHlNYXJnaW5MZWZ0KTsKICAgICBzdHlsZS0+cmVtb3Zl UHJvcGVydHkoQ1NTUHJvcGVydHlNYXJnaW5Ub3ApOworCisgICAgRXhjZXB0aW9uQ29kZSBpZ25v cmVkOworICAgIGNsYXNzTGlzdCgpLT5yZW1vdmUoImRyYWdnZWQiLCBpZ25vcmVkKTsKIH0KIAog dm9pZCBNZWRpYUNvbnRyb2xQYW5lbEVsZW1lbnQ6Om1ha2VPcGFxdWUoKQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQ3ODY1 NzA0NmVlNGZhN2YxMmVhZTAzYjE0YjRhOTVlMWM2ZmRjZWQuLmVjMDRhZTEzNzlmMzhiM2QwNjkw MzBkZTU5YjdlNTIwMGRkYWIyM2IgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wMS0wNSAg SmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChy OTA3OTcpOiBGdWxsIHNjcmVlbiB2aWRlbyBIVUQgY2Fubm90IGJlIGRyYWdnZWQgaG9yaXpvbnRh bGx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTIw MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZnVs bHNjcmVlbi92aWRlby1jb250cm9scy1kcmFnLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAg ICogZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1kcmFnLmh0bWw6IEFkZGVkLgorCiAyMDExLTEy LTE5ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJlYmFzZWxp bmUgcmVzdWx0cyBmcm9tIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 NDg3MApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1jb250cm9scy1k cmFnLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8tY29udHJvbHMt ZHJhZy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzYxOTVmMTNjOTYyY2ExZmMzOGEzNzVhYzk1 YmE5ZGFjYmNlY2E4OAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4v dmlkZW8tY29udHJvbHMtZHJhZy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw3IEBACitUaGlzIHRl c3RzIHRoYXQgdGhlIHZpZGVvIGVsZW1lbnQncyBjb250cm9scyBhcmUgZHJhZ2dhYmxlIGluIGZ1 bGwgc2NyZWVuLiBQcmVzcyBhbnkga2V5IHRvIGNvbnRpbnVlLgorCitFVkVOVCh3ZWJraXRmdWxs c2NyZWVuY2hhbmdlKQorRVhQRUNURUQgKGVuZEJveC5sZWZ0IC0gc3RhcnRCb3gubGVmdCA9PSAn MTUnKSBPSworRVhQRUNURUQgKGVuZEJveC50b3AgLSBzdGFydEJveC50b3AgPT0gJzE1JykgT0sK K0VORCBPRiBURVNUCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8t Y29udHJvbHMtZHJhZy5odG1sIGIvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1jb250cm9s cy1kcmFnLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNTM4NjQ1MjU2N2I0ZjAzMGVhMzdlZmMwMzc3NDE4ZjE5 MjYyMjYwZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8t Y29udHJvbHMtZHJhZy5odG1sCkBAIC0wLDAgKzEsNDAgQEAKKzxib2R5PgorICAgIDxwPlRoaXMg dGVzdHMgdGhhdCB0aGUgdmlkZW8gZWxlbWVudCdzIGNvbnRyb2xzIGFyZSBkcmFnZ2FibGUgaW4g ZnVsbCBzY3JlZW4uICBQcmVzcyBhbnkga2V5IHRvIGNvbnRpbnVlLjwvcD4KKyAgICA8dmlkZW8g aWQ9InZpZGVvIiB3aWR0aD0iMzAwIiBjb250cm9scz48L3ZpZGVvPgorICAgIDxzY3JpcHQgc3Jj PSJmdWxsLXNjcmVlbi10ZXN0LmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0PgorICAgICAgICB2 YXIgdmlkZW8gPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndmlkZW8nKTsKKyAgICAgICAgdmFy IHNoYWRvd1Jvb3Q7CisgICAgICAgIHZhciBwYW5lbDsKKyAgICAgICAgdmFyIHN0YXJ0Qm94Owor ICAgICAgICB2YXIgZW5kQm94OworCisgICAgICAgIHZhciBmdWxsc2NyZWVuQ2hhbmdlZCA9IGZ1 bmN0aW9uKGV2ZW50KQorICAgICAgICB7CisgICAgICAgICAgICBpZiAoY2FsbGJhY2spCisgICAg ICAgICAgICAgICAgY2FsbGJhY2soZXZlbnQpCisgICAgICAgIH07CisgICAgICAgIHdhaXRGb3JF dmVudChkb2N1bWVudCwgJ3dlYmtpdGZ1bGxzY3JlZW5jaGFuZ2UnLCBmdW5jdGlvbigpIHsKKyAg ICAgICAgICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKSB7CisgICAgICAgICAgICAgICAgcGFuZWwg PSBpbnRlcm5hbHMuc2hhZG93Um9vdCh2aWRlbykuZmlyc3RDaGlsZC5maXJzdENoaWxkOworICAg ICAgICAgICAgICAgIHN0YXJ0Qm94ID0gaW50ZXJuYWxzLmJvdW5kaW5nQm94KHBhbmVsKTsKKwor ICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHN0YXJ0Qm94LmxlZnQgKyA1 LCBzdGFydEJveC50b3AgKyA1KTsKKyAgICAgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZURv d24oKTsKKworICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHN0YXJ0Qm94 LmxlZnQgKyAyMCwgc3RhcnRCb3gudG9wICsgMjApOworICAgICAgICAgICAgICAgIGV2ZW50U2Vu ZGVyLm1vdXNlVXAoKTsKKworICAgICAgICAgICAgICAgIGVuZEJveCA9IGludGVybmFscy5ib3Vu ZGluZ0JveChwYW5lbCk7CisKKyAgICAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoImVuZEJveC5s ZWZ0IC0gc3RhcnRCb3gubGVmdCIsIDE1KTsKKyAgICAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQo ImVuZEJveC50b3AgLSBzdGFydEJveC50b3AiLCAxNSk7CisgICAgICAgICAgICAgICAgZW5kVGVz dCgpOworICAgICAgICAgICAgfQorICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIGxv Z1Jlc3VsdChmYWxzZSwgIndpbmRvdy5pbnRlcm5hbHMgPT0gdW5kZWZpbmVkIik7CisgICAgICAg IH0pOworCisgICAgICAgIHJ1bldpdGhLZXlEb3duKGZ1bmN0aW9uKCl7dmlkZW8ud2Via2l0UmVx dWVzdEZ1bGxTY3JlZW4oKX0pOworICAgIDwvc2NyaXB0PgorPC9ib2R5Pgo=