75197 2011-12-24 12:04:19 -0800 Add unittests for the Python parser of prepare-ChangeLog 2011-12-25 00:10:41 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73531 1 haraken haraken darin ddkilzer rniwa webkit.review.bot oldest_to_newest 527010 0 haraken 2011-12-24 12:04:19 -0800 We should add unittests for the Python parser (i.e. get_function_line_ranges_for_python()) of prepare-ChangeLog. 527016 1 120502 haraken 2011-12-24 12:28:38 -0800 Created attachment 120502 Patch 527019 2 webkit.review.bot 2011-12-24 12:31:46 -0800 Attachment 120502 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/prepare-..." exit_code: 1 Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:1: missing whitespace around operator [pep8/E225] [5] Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:2: indentation is not a multiple of four [pep8/E111] [5] Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:2: missing whitespace around operator [pep8/E225] [5] Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:2: whitespace before '(' [pep8/E211] [5] Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:3: indentation is not a multiple of four [pep8/E111] [5] Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 46, in <module> sys.exit(CheckWebKitStyle().main()) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/main.py", line 154, in main patch_checker.check(patch) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/patchreader.py", line 66, in check self._text_file_reader.process_file(file_path=path, line_numbers=line_numbers) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file self._processor.process(lines, file_path, **kwargs) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 817, in process checker.check(lines) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checkers/python.py", line 56, in check errors = checker.check_all() File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pep8.py", line 911, in check_all self.check_logical() File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pep8.py", line 874, in check_logical result = self.run_check(check, argument_names) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pep8.py", line 808, in run_check return check(*arguments) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pep8.py", line 464, in missing_whitespace_around_operator if ((prev_type != tokenize.OP or prev_text in '}])') and not TypeError: 'in <string>' requires string as left operand, not NoneType If any of these errors are false positives, please file a bug against check-webkit-style. 527045 3 haraken 2011-12-25 00:09:55 -0800 Committed r103667: <http://trac.webkit.org/changeset/103667> 120502 2011-12-24 12:28:38 -0800 2011-12-25 00:10:41 -0800 Patch bug-75197-20111225052837.patch text/plain 5498 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzNjU1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTk1M2E3YTYxZDBhY2RiYzA5ZjA3M2UxY2I3NDY3MDcx Yzk2M2JiZS4uYzY0MTUxZWQyMDgyMWY2NWNlODY3ZmUzZDMzYzIyZGQ4OTBkYjg0YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMx IEBACisyMDExLTEyLTI0ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBBZGQgdW5pdHRlc3RzIGZvciB0aGUgUHl0aG9uIHBhcnNlciBvZiBwcmVwYXJlLUNo YW5nZUxvZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzUxOTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBw eXRob25fdW5pdHRlc3RzLnB5IGlzIHRoZSB1bml0dGVzdCBmb3IgZ2V0X2Z1bmN0aW9uX2xpbmVf cmFuZ2VzX2Zvcl9weXRob24oKQorICAgICAgICBvZiBwcmVwYXJlLUNoYW5nZUxvZy4gVGhlIHVu aXR0ZXN0IGp1c3QgY29udGFpbnMgY2xhc3NlcyBhbmQgZGVmcyB0aGF0IGFyZSBub3QgbmVzdGVk LgorICAgICAgICBUaGlzIGlzIGJlY2F1c2UgdGhlIGN1cnJlbnQgcHl0aG9uIHBhcnNlciBpcyB3 cm9uZywgYW5kIGl0IGNhbm5vdCBjb3JyZWN0bHkgcGFyc2UgbmVzdGVkCisgICAgICAgIGNsYXNz ZXMgYW5kIGRlZnMgKGV2ZW4gb25lIGRlZiBpbiBhIGNsYXNzKSwgbm9yIGNsYXNzIGluaGVyaXRh bmNlLgorICAgICAgICBXZSB3aWxsIGZpeCBpdCBpbiBhbm90aGVyIHBhdGNoLgorCisgICAgICAg ICogU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZzoKKyAgICAgICAgKGdldF9mdW5jdGlvbl9saW5l X3Jhbmdlc19mb3JfcHl0aG9uKTogSWdub3JlcyBjb21tZW50IGxpbmVzIHRoYXQgc3RhcnRzIGZy b20gIy4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHBlcmwvcHJlcGFyZS1DaGFuZ2VMb2dfdW5p dHRlc3QvcGFyc2VyX3VuaXR0ZXN0cy5wbDoKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHBlcmwv cHJlcGFyZS1DaGFuZ2VMb2dfdW5pdHRlc3QvcmVzb3VyY2VzL3B5dGhvbl91bml0dGVzdHMtZXhw ZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHBlcmwvcHJlcGFyZS1D aGFuZ2VMb2dfdW5pdHRlc3QvcmVzb3VyY2VzL3B5dGhvbl91bml0dGVzdHMucHk6IEFkZGVkLgor ICAgICAgICAoZnVuYzEpOgorICAgICAgICAoZnVuYzIpOgorICAgICAgICAoZnVuYzMpOgorICAg ICAgICAoZnVuY0luc2lkZUNvbW1lbnQpOgorICAgICAgICAoZnVuYzQpOgorICAgICAgICAoZnVu YzUpOgorICAgICAgICAoZnVuYzYpOgorICAgICAgICAoZnVuY092ZXJsb2FkZWQpOgorICAgICAg ICAoQ2xhc3MxKToKKwogMjAxMS0xMi0yMyAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUHJvdmlkZSBvcHRpb24gdG8gZGlzYWJsZSBNYWMgT1MgMTAuNyBhcHBs aWNhdGlvbiByZXN1bWUgd2hlbiB1c2luZwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9wcmVw YXJlLUNoYW5nZUxvZyBiL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKaW5kZXggYjJm MDdlZjk1ODlkMDFkOTY3N2Y3YjNkOWQzYzE0OTlhMzQ2NTJhZS4uNjY2MDJlN2E2YWRmNjliMDUy N2NkMjFjNzNhYTMxM2MyMzcwMTIzMiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9wcmVwYXJl LUNoYW5nZUxvZworKysgYi9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCkBAIC0xMzE5 LDcgKzEzMTksNyBAQCBzdWIgZ2V0X2Z1bmN0aW9uX2xpbmVfcmFuZ2VzX2Zvcl9weXRob24oJCQp CiAKICAgICBteSBAc2NvcGVTdGFjayA9ICh7IGxpbmUgPT4gMCwgaW5kZW50ID0+IC0xLCBuYW1l ID0+IHVuZGVmIH0pOwogICAgIHdoaWxlICg8JGZpbGVIYW5kbGU+KSB7Ci0gICAgICAgIG5leHQg dW5sZXNzIC9eKFxzKikoXFMuKikkLzsKKyAgICAgICAgbmV4dCB1bmxlc3MgL14oXHMqKShbXiNd LiopJC87CiAgICAgICAgIG15ICRpbmRlbnQgPSBsZW5ndGggJDE7CiAgICAgICAgIG15ICRyZXN0 ID0gJDI7CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9wcmVwYXJlLUNo YW5nZUxvZ191bml0dGVzdC9wYXJzZXJfdW5pdHRlc3RzLnBsIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRwZXJsL3ByZXBhcmUtQ2hhbmdlTG9nX3VuaXR0ZXN0L3BhcnNlcl91bml0dGVzdHMucGwKaW5k ZXggMTJiNzI1ZWExZGI0MzA3M2RiOTA2NjBmMjQ1ODlmZDY2N2JkODY4My4uYTgyNjc2NTQzMDg4 MWM0OWY2YzJhYmE3ZTFkZTE2MGQzMWI1YTMzZCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRwZXJsL3ByZXBhcmUtQ2hhbmdlTG9nX3VuaXR0ZXN0L3BhcnNlcl91bml0dGVzdHMucGwK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL3ByZXBhcmUtQ2hhbmdlTG9nX3VuaXR0ZXN0 L3BhcnNlcl91bml0dGVzdHMucGwKQEAgLTMyLDcgKzMyLDggQEAgdXNlIFRlc3Q6Ok1vcmU7CiB1 c2UgbGliIEZpbGU6OlNwZWMtPmNhdGRpcigkRmluZEJpbjo6QmluLCAiLi4iKTsKIHVzZSBMb2Fk QXNNb2R1bGUgcXcoUHJlcGFyZUNoYW5nZUxvZyBwcmVwYXJlLUNoYW5nZUxvZyk7CiAKLW15ICV0 ZXN0RmlsZXMgPSAoInBlcmxfdW5pdHRlc3RzLnBsIiA9PiAicGVybCIpOworbXkgJXRlc3RGaWxl cyA9ICgicGVybF91bml0dGVzdHMucGwiID0+ICJwZXJsIiwKKyAgICAgICAgICAgICAgICAgInB5 dGhvbl91bml0dGVzdHMucHkiID0+ICJweXRob24iKTsKIAogbXkgJHJlc2V0UmVzdWx0czsKIEdl dE9wdGlvbnMoJ3Jlc2V0LXJlc3VsdHMnID0+IFwkcmVzZXRSZXN1bHRzKTsKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9wcmVwYXJlLUNoYW5nZUxvZ191bml0dGVzdC9yZXNv dXJjZXMvcHl0aG9uX3VuaXR0ZXN0cy1leHBlY3RlZC50eHQgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHBlcmwvcHJlcGFyZS1DaGFuZ2VMb2dfdW5pdHRlc3QvcmVzb3VyY2VzL3B5dGhvbl91bml0dGVz dHMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmM3YzhmZTY1ZWM1NjA1ZmU1YjY1MjMyNDcyOTlj MWNkMjI2ZGQ1YWEKLS0tIC9kZXYvbnVsbAorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwv cHJlcGFyZS1DaGFuZ2VMb2dfdW5pdHRlc3QvcmVzb3VyY2VzL3B5dGhvbl91bml0dGVzdHMtZXhw ZWN0ZWQudHh0CkBAIC0wLDAgKzEsNTIgQEAKK1sKKyAgWworICAgICcyMCcsCisgICAgJzIwJywK KyAgICAnZnVuYzEnCisgIF0sCisgIFsKKyAgICAnMjInLAorICAgICcyMycsCisgICAgJ2Z1bmMy JworICBdLAorICBbCisgICAgJzI1JywKKyAgICAnMjcnLAorICAgICdmdW5jMycKKyAgXSwKKyAg WworICAgICczMScsCisgICAgJzMyJywKKyAgICAnZnVuYzQnCisgIF0sCisgIFsKKyAgICAnMzQn LAorICAgICczNScsCisgICAgJ2Z1bmM1JworICBdLAorICBbCisgICAgJzM3JywKKyAgICAnNDAn LAorICAgICdmdW5jNicKKyAgXSwKKyAgWworICAgICc0MicsCisgICAgJzQzJywKKyAgICAnZnVu Y092ZXJsb2FkZWQnCisgIF0sCisgIFsKKyAgICAnNDUnLAorICAgICc0NicsCisgICAgJ2Z1bmNP dmVybG9hZGVkJworICBdLAorICBbCisgICAgJzQ4JywKKyAgICAnNDknLAorICAgICdmdW5jT3Zl cmxvYWRlZCcKKyAgXSwKKyAgWworICAgICc1MScsCisgICAgJzUyJywKKyAgICAnQ2xhc3MxJwor ICBdCitdCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvcHJlcGFyZS1DaGFu Z2VMb2dfdW5pdHRlc3QvcmVzb3VyY2VzL3B5dGhvbl91bml0dGVzdHMucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHBlcmwvcHJlcGFyZS1DaGFuZ2VMb2dfdW5pdHRlc3QvcmVzb3VyY2VzL3B5dGhv bl91bml0dGVzdHMucHkKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDY1NjcwY2QxN2U4YWU2NzllZDk1NjMyZDM2MTI5 NDI3ZWZkYTFlYwotLS0gL2Rldi9udWxsCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9w cmVwYXJlLUNoYW5nZUxvZ191bml0dGVzdC9yZXNvdXJjZXMvcHl0aG9uX3VuaXR0ZXN0cy5weQpA QCAtMCwwICsxLDUzIEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDExIEdvb2dsZSBJbmMuICBB bGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAqIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJl OyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKKyAqIG1vZGlmeSBpdCB1bmRlciB0aGUg dGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCisgKiBMaWNlbnNlIGFzIHB1 Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAqIHZlcnNp b24gMiBvZiB0aGUgTGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lv bi4KKyAqCisgKiBUaGlzIGxpYnJhcnkgaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBp dCB3aWxsIGJlIHVzZWZ1bCwKKyAqIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBl dmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisgKiBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVT UyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlIEdOVQorICogTGlicmFyeSBHZW5l cmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisgKgorICogWW91IHNob3VsZCBo YXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMgTGlj ZW5zZQorICogYWxvbmcgd2l0aCB0aGlzIGxpYnJhcnk7IHNlZSB0aGUgZmlsZSBDT1BZSU5HLkxJ Qi4gIElmIG5vdCwgd3JpdGUgdG8KKyAqIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIElu Yy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3IsCisgKiBCb3N0b24sIE1BIDAyMTEw LTEzMDEsIFVTQS4KKyAqLworCitkZWYgZnVuYzEoKToKKworZGVmIGZ1bmMyKCk6CisgICAgcmV0 dXJuCisKK2RlZiBmdW5jMygpOgorICAgICMgY29tbWVudAorICAgIHJldHVybgorCisjIGRlZiBm dW5jSW5zaWRlQ29tbWVudCgpOgorCitkZWYgZnVuYzQoYSk6CisgICAgcmV0dXJuCisKK2RlZiBm dW5jNShhLCBiLCBjKToKKyAgICByZXR1cm4KKworZGVmIGZ1bmM2KGEsIGIsIFwKKyAgICAgICAg ICBjLCBkIFwKKyAgICAgICAgICAsIGUsIGYpOgorICAgIHJldHVybgorCitkZWYgZnVuY092ZXJs b2FkZWQoYSk6CisgICAgcmV0dXJuCisKK2RlZiBmdW5jT3ZlcmxvYWRlZChhLCBiKToKKyAgICBy ZXR1cm4KKworZGVmIGZ1bmNPdmVybG9hZGVkKGEsIGIsIGM9MTAwKToKKyAgICByZXR1cm4KKwor Y2xhc3MgQ2xhc3MxOgorICAgIHBhc3MKKwo=