75168 2011-12-23 03:40:50 -0800 [TexMap][QT] The fragment shader in OpenGL ES2 requires the default precision qualifier. 2011-12-27 15:37:47 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dongseong.hwang webkit-unassigned noam webkit.review.bot oldest_to_newest 526811 0 dongseong.hwang 2011-12-23 03:40:50 -0800 Some device supporting GLES2 will crash during compiling the TexMap fragment shader. 526812 1 120453 dongseong.hwang 2011-12-23 03:42:51 -0800 Created attachment 120453 patch 527473 2 120453 noam 2011-12-27 15:02:29 -0800 Comment on attachment 120453 patch Please add "No new functionality so no new tests" to changelogs when applicable (like here). 527474 3 120453 noam 2011-12-27 15:03:31 -0800 Comment on attachment 120453 patch View in context: https://bugs.webkit.org/attachment.cgi?id=120453&action=review > Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:317 > +#define OES2_FRAGMENT_SHADER_DEFAULT_PRECISION > #else > #define OES2_PRECISION_DEFINITIONS > +#define OES2_FRAGMENT_SHADER_DEFAULT_PRECISION \ > + "precision mediump float; \n" Can't you just add it to the OES2_PRECISION_DEFINITIONS define instead of creating a new one? 527475 4 120453 dongseong.hwang 2011-12-27 15:05:31 -0800 Comment on attachment 120453 patch View in context: https://bugs.webkit.org/attachment.cgi?id=120453&action=review >> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:317 >> + "precision mediump float; \n" > > Can't you just add it to the OES2_PRECISION_DEFINITIONS define instead of creating a new one? It is because Vertex shader does not need the default precision qualifier. 527477 5 noam 2011-12-27 15:10:45 -0800 (In reply to comment #4) > (From update of attachment 120453 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120453&action=review > > >> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:317 > >> + "precision mediump float; \n" > > > > Can't you just add it to the OES2_PRECISION_DEFINITIONS define instead of creating a new one? > > It is because Vertex shader does not need the default precision qualifier. Ah, ok. Please update the changelog (see previous comment) and I'll r+ it! 527480 6 120620 dongseong.hwang 2011-12-27 15:17:30 -0800 Created attachment 120620 patch 527486 7 120620 webkit.review.bot 2011-12-27 15:37:42 -0800 Comment on attachment 120620 patch Clearing flags on attachment: 120620 Committed r103735: <http://trac.webkit.org/changeset/103735> 527487 8 webkit.review.bot 2011-12-27 15:37:47 -0800 All reviewed patches have been landed. Closing bug. 120453 2011-12-23 03:42:51 -0800 2011-12-27 15:17:30 -0800 patch 0001-TexMap-QT-The-fragment-shader-in-OpenGL-ES2-requires.patch text/plain 3148 dongseong.hwang RnJvbSBhODI5MTU2ODIxZTBkMjQwYjQ0ZTk4NTNjNzUwN2E0ZjQ3ZmY2ODQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIdWFuZyBEb25nc3VuZyA8bHV4dGVsbGFAY29tcGFueTEwMC5u ZXQ+CkRhdGU6IEZyaSwgMjMgRGVjIDIwMTEgMjA6MzU6MDAgKzA5MDAKU3ViamVjdDogW1BBVENI XSBbVGV4TWFwXVtRVF0gVGhlIGZyYWdtZW50IHNoYWRlciBpbiBPcGVuR0wgRVMyIHJlcXVpcmVz IHRoZQogZGVmYXVsdCBwcmVjaXNpb24gcXVhbGlmaWVyLgogaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc1MTY4CgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMSArKysrKysrKysrKwogLi4uL3BsYXRmb3Jt L2dyYXBoaWNzL29wZW5nbC9UZXh0dXJlTWFwcGVyR0wuY3BwICAgfCAgICA2ICsrKysrKwogMiBm aWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCBjYzViOGU1Li4wMTQ2ZjJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEt MTItMjMgIEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CisKKyAgICAg ICAgW1RleE1hcF1bUVRdIFRoZSBmcmFnbWVudCBzaGFkZXIgaW4gT3BlbkdMIEVTMiByZXF1aXJl cyB0aGUgZGVmYXVsdCBwcmVjaXNpb24KKyAgICAgICAgcXVhbGlmaWVyLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzUxNjgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29w ZW5nbC9UZXh0dXJlTWFwcGVyR0wuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBl ckdMOjppbml0aWFsaXplU2hhZGVycyk6CisKIDIwMTEtMTItMjMgIFRvbSBTZXBleiAgPHRzZXBl ekBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgWFNMVC1jcmVhdGVkIEhUTUwgZG9jdW1lbnRzIGRv IG5vdCBpbmhlcml0IGNvbnRlbnQtc2VjdXJpdHktcG9saWN5IGZyb20gb3JpZ2luYWxseSBsb2Fk ZWQgWE1MLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3Bl bmdsL1RleHR1cmVNYXBwZXJHTC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9vcGVuZ2wvVGV4dHVyZU1hcHBlckdMLmNwcAppbmRleCBhYzUwNzUwLi5mMmJlMjZmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvVGV4dHVyZU1h cHBlckdMLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wv VGV4dHVyZU1hcHBlckdMLmNwcApAQCAtMzEwLDEyICszMTAsMTYgQEAgdm9pZCBUZXh0dXJlTWFw cGVyR0w6OmluaXRpYWxpemVTaGFkZXJzKCkKICNpZm5kZWYgVEVYTUFQX09QRU5HTF9FU18yCiAj ZGVmaW5lIE9FUzJfUFJFQ0lTSU9OX0RFRklOSVRJT05TIFwKICAgICAiI2RlZmluZSBsb3dwXG4j ZGVmaW5lIGhpZ2hwXG4iCisjZGVmaW5lIE9FUzJfRlJBR01FTlRfU0hBREVSX0RFRkFVTFRfUFJF Q0lTSU9OCiAjZWxzZQogI2RlZmluZSBPRVMyX1BSRUNJU0lPTl9ERUZJTklUSU9OUworI2RlZmlu ZSBPRVMyX0ZSQUdNRU5UX1NIQURFUl9ERUZBVUxUX1BSRUNJU0lPTiBcCisgICAgInByZWNpc2lv biBtZWRpdW1wIGZsb2F0OyBcbiIKICNlbmRpZgogCiAgICAgY29uc3QgY2hhciogZnJhZ21lbnRT aGFkZXJTb3VyY2VPcGFjaXR5QW5kTWFzayA9CiAgICAgICAgICAgICBPRVMyX1BSRUNJU0lPTl9E RUZJTklUSU9OUworICAgICAgICAgICAgT0VTMl9GUkFHTUVOVF9TSEFERVJfREVGQVVMVF9QUkVD SVNJT04KICIgICAgICAgICAgICAgICB1bmlmb3JtIHNhbXBsZXIyRCBTb3VyY2VUZXh0dXJlLCBN YXNrVGV4dHVyZTsgICAgICAgICAgICAgICAgICAgICAgIFxuIgogIiAgICAgICAgICAgICAgIHVu aWZvcm0gbG93cCBmbG9hdCBPcGFjaXR5OyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgXG4iCiAiICAgICAgICAgICAgICAgdmFyeWluZyBoaWdocCB2ZWMyIE91dFRleENv b3JkU291cmNlLCBPdXRUZXhDb29yZE1hc2s7ICAgICAgICAgICAgICBcbiIKQEAgLTM0MSw2ICsz NDUsNyBAQCB2b2lkIFRleHR1cmVNYXBwZXJHTDo6aW5pdGlhbGl6ZVNoYWRlcnMoKQogCiAgICAg Y29uc3QgY2hhciogZnJhZ21lbnRTaGFkZXJTb3VyY2VTaW1wbGUgPQogICAgICAgICAgICAgT0VT Ml9QUkVDSVNJT05fREVGSU5JVElPTlMKKyAgICAgICAgICAgIE9FUzJfRlJBR01FTlRfU0hBREVS X0RFRkFVTFRfUFJFQ0lTSU9OCiAiICAgICAgICAgICAgICAgdW5pZm9ybSBzYW1wbGVyMkQgU291 cmNlVGV4dHVyZTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcbiIKICIgICAg ICAgICAgICAgICB1bmlmb3JtIGxvd3AgZmxvYXQgT3BhY2l0eTsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIFxuIgogIiAgICAgICAgICAgICAgIHZhcnlpbmcgaGlnaHAg dmVjMiBPdXRUZXhDb29yZFNvdXJjZTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXG4i CkBAIC0zNjIsNiArMzY3LDcgQEAgdm9pZCBUZXh0dXJlTWFwcGVyR0w6OmluaXRpYWxpemVTaGFk ZXJzKCkKICIgICAgICAgICAgICAgICB9ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBcbiI7CiAKICAgICBjb25zdCBjaGFyKiBmcmFnbWVu dFNoYWRlclNvdXJjZUNsaXAgPQorICAgICAgICAgICAgT0VTMl9GUkFHTUVOVF9TSEFERVJfREVG QVVMVF9QUkVDSVNJT04KICIgICAgICAgICAgICAgICB2b2lkIG1haW4odm9pZCkgeyBnbF9GcmFn Q29sb3IgPSB2ZWM0KDAuMCwgMC4wLCAwLjAsIDAuMCk7IH0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICI7CiAKICAgICBjb25zdCBjaGFyKiB2ZXJ0ZXhTaGFkZXJTb3VyY2VDbGlwID0K LS0gCjEuNy41LjQKCg== 120620 2011-12-27 15:17:30 -0800 2011-12-27 15:37:42 -0800 patch 0001-TexMap-QT-The-fragment-shader-in-OpenGL-ES2-requires.patch text/plain 3199 dongseong.hwang RnJvbSBmN2MxODU3ZmZkZmI2NzYwNjAzZTAxZmE1NDkyOWMyZmFmNmRkODZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIdWFuZyBEb25nc3VuZyA8bHV4dGVsbGFAY29tcGFueTEwMC5u ZXQ+CkRhdGU6IEZyaSwgMjMgRGVjIDIwMTEgMjA6MzU6MDAgKzA5MDAKU3ViamVjdDogW1BBVENI XSBbVGV4TWFwXVtRVF0gVGhlIGZyYWdtZW50IHNoYWRlciBpbiBPcGVuR0wgRVMyIHJlcXVpcmVz IHRoZQogZGVmYXVsdCBwcmVjaXNpb24gcXVhbGlmaWVyLgogaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTc1MTY4CgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiAuLi4vcGxhdGZv cm0vZ3JhcGhpY3Mvb3BlbmdsL1RleHR1cmVNYXBwZXJHTC5jcHAgICB8ICAgIDYgKysrKysrCiAy IGZpbGVzIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IGNjNWI4ZTUuLjM0YzQ3OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAx MS0xMi0yMyAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KKworICAg ICAgICBbVGV4TWFwXVtRVF0gVGhlIGZyYWdtZW50IHNoYWRlciBpbiBPcGVuR0wgRVMyIHJlcXVp cmVzIHRoZSBkZWZhdWx0IHByZWNpc2lvbgorICAgICAgICBxdWFsaWZpZXIuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTE2OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyBmdW5jdGlvbmFsaXR5 IHNvIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9U ZXh0dXJlTWFwcGVyR0wuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBlckdMOjpp bml0aWFsaXplU2hhZGVycyk6CisKIDIwMTEtMTItMjMgIFRvbSBTZXBleiAgPHRzZXBlekBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgWFNMVC1jcmVhdGVkIEhUTUwgZG9jdW1lbnRzIGRvIG5vdCBp bmhlcml0IGNvbnRlbnQtc2VjdXJpdHktcG9saWN5IGZyb20gb3JpZ2luYWxseSBsb2FkZWQgWE1M LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL1Rl eHR1cmVNYXBwZXJHTC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVu Z2wvVGV4dHVyZU1hcHBlckdMLmNwcAppbmRleCBhYzUwNzUwLi5mMmJlMjZmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvVGV4dHVyZU1hcHBlckdM LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvVGV4dHVy ZU1hcHBlckdMLmNwcApAQCAtMzEwLDEyICszMTAsMTYgQEAgdm9pZCBUZXh0dXJlTWFwcGVyR0w6 OmluaXRpYWxpemVTaGFkZXJzKCkKICNpZm5kZWYgVEVYTUFQX09QRU5HTF9FU18yCiAjZGVmaW5l IE9FUzJfUFJFQ0lTSU9OX0RFRklOSVRJT05TIFwKICAgICAiI2RlZmluZSBsb3dwXG4jZGVmaW5l IGhpZ2hwXG4iCisjZGVmaW5lIE9FUzJfRlJBR01FTlRfU0hBREVSX0RFRkFVTFRfUFJFQ0lTSU9O CiAjZWxzZQogI2RlZmluZSBPRVMyX1BSRUNJU0lPTl9ERUZJTklUSU9OUworI2RlZmluZSBPRVMy X0ZSQUdNRU5UX1NIQURFUl9ERUZBVUxUX1BSRUNJU0lPTiBcCisgICAgInByZWNpc2lvbiBtZWRp dW1wIGZsb2F0OyBcbiIKICNlbmRpZgogCiAgICAgY29uc3QgY2hhciogZnJhZ21lbnRTaGFkZXJT b3VyY2VPcGFjaXR5QW5kTWFzayA9CiAgICAgICAgICAgICBPRVMyX1BSRUNJU0lPTl9ERUZJTklU SU9OUworICAgICAgICAgICAgT0VTMl9GUkFHTUVOVF9TSEFERVJfREVGQVVMVF9QUkVDSVNJT04K ICIgICAgICAgICAgICAgICB1bmlmb3JtIHNhbXBsZXIyRCBTb3VyY2VUZXh0dXJlLCBNYXNrVGV4 dHVyZTsgICAgICAgICAgICAgICAgICAgICAgIFxuIgogIiAgICAgICAgICAgICAgIHVuaWZvcm0g bG93cCBmbG9hdCBPcGFjaXR5OyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgXG4iCiAiICAgICAgICAgICAgICAgdmFyeWluZyBoaWdocCB2ZWMyIE91dFRleENvb3JkU291 cmNlLCBPdXRUZXhDb29yZE1hc2s7ICAgICAgICAgICAgICBcbiIKQEAgLTM0MSw2ICszNDUsNyBA QCB2b2lkIFRleHR1cmVNYXBwZXJHTDo6aW5pdGlhbGl6ZVNoYWRlcnMoKQogCiAgICAgY29uc3Qg Y2hhciogZnJhZ21lbnRTaGFkZXJTb3VyY2VTaW1wbGUgPQogICAgICAgICAgICAgT0VTMl9QUkVD SVNJT05fREVGSU5JVElPTlMKKyAgICAgICAgICAgIE9FUzJfRlJBR01FTlRfU0hBREVSX0RFRkFV TFRfUFJFQ0lTSU9OCiAiICAgICAgICAgICAgICAgdW5pZm9ybSBzYW1wbGVyMkQgU291cmNlVGV4 dHVyZTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcbiIKICIgICAgICAgICAg ICAgICB1bmlmb3JtIGxvd3AgZmxvYXQgT3BhY2l0eTsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIFxuIgogIiAgICAgICAgICAgICAgIHZhcnlpbmcgaGlnaHAgdmVjMiBP dXRUZXhDb29yZFNvdXJjZTsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXG4iCkBAIC0z NjIsNiArMzY3LDcgQEAgdm9pZCBUZXh0dXJlTWFwcGVyR0w6OmluaXRpYWxpemVTaGFkZXJzKCkK ICIgICAgICAgICAgICAgICB9ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBcbiI7CiAKICAgICBjb25zdCBjaGFyKiBmcmFnbWVudFNoYWRl clNvdXJjZUNsaXAgPQorICAgICAgICAgICAgT0VTMl9GUkFHTUVOVF9TSEFERVJfREVGQVVMVF9Q UkVDSVNJT04KICIgICAgICAgICAgICAgICB2b2lkIG1haW4odm9pZCkgeyBnbF9GcmFnQ29sb3Ig PSB2ZWM0KDAuMCwgMC4wLCAwLjAsIDAuMCk7IH0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICI7CiAKICAgICBjb25zdCBjaGFyKiB2ZXJ0ZXhTaGFkZXJTb3VyY2VDbGlwID0KLS0gCjEu Ny41LjQKCg==