75145 2011-12-22 15:49:46 -0800 Run tests in serial on SnowLeopard to avoid CFURLCache crashes 2012-02-02 19:03:40 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser eric abarth dpranke eric ojan ossy rniwa simon.fraser webkit.review.bot oldest_to_newest 526592 0 simon.fraser 2011-12-22 15:49:46 -0800 CFURLCache seems to have issues when lots of processes are hitting the same cache. We should run the tests in serial on SnowLeopard to avoid this. See bug 75131 526605 1 eric 2011-12-22 16:07:48 -0800 Sad times. I assume there is a radar about the crash? Or I guess one isn't needed since SL is history now... Do you know if only some of the tests crash? Can we run just those in serial? 526612 2 simon.fraser 2011-12-22 16:10:27 -0800 I was crashing just running fast/ There is a radar. 548073 3 eric 2012-02-02 12:49:27 -0800 mac.py: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py Should override default_child_processes: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py#L166 to be 1 on SnowLeopard if it detects that this bug is present (or I guess always if the bug is always present). Alternatively, Mac.__init__ could use set_default("child_processes", 1) like it does for batch_size. I'm not really sure which is cleaner. 548107 4 dpranke 2012-02-02 13:10:40 -0800 overridding default_child_processes would be the recommended way to do it. 548189 5 125196 eric 2012-02-02 15:17:56 -0800 Created attachment 125196 Patch 548192 6 125198 eric 2012-02-02 15:26:08 -0800 Created attachment 125198 Patch for landing 548346 7 125198 webkit.review.bot 2012-02-02 19:03:33 -0800 Comment on attachment 125198 Patch for landing Clearing flags on attachment: 125198 Committed r106616: <http://trac.webkit.org/changeset/106616> 548347 8 webkit.review.bot 2012-02-02 19:03:40 -0800 All reviewed patches have been landed. Closing bug. 125196 2012-02-02 15:17:56 -0800 2012-02-02 15:26:04 -0800 Patch bug-75145-20120202151754.patch text/plain 2702 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NTkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWRjNzEyNDJhMWI3NzQ4MGQzY2I5ZTBmMDNmNjY3NDVl YzNjMWNhMi4uNDVkNDZlYTkzOTg1Yjc1NjMyYWM0NzYzYzNlYTdiZDY3NWE3YTNkZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTAyLTAyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAg ICBSdW4gdGVzdHMgaW4gc2VyaWFsIG9uIFNub3dMZW9wYXJkIHRvIGF2b2lkIENGVVJMQ2FjaGUg Y3Jhc2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzUxNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5OgorICAgICAgICAoTWFj UG9ydC5kZWZhdWx0X2NoaWxkX3Byb2Nlc3Nlcyk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9tYWNfdW5pdHRlc3QucHk6CisgICAgICAgICh0ZXN0X29wZXJh dGluZ19zeXN0ZW0pOgorICAgICAgICAodGVzdF9kZWZhdWx0X2NoaWxkX3Byb2Nlc3Nlcyk6CisK IDIwMTItMDItMDIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICBucnd0IHNob3VsZG4ndCBibG93IHVwIHdoZW4gdGhlcmUgYXJlIGVycm9ycyBpbiB0ZXN0X2V4 cGVjdGF0aW9ucy50eHQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvbWFjLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9tYWMucHkKaW5kZXggZTIzZmI4MmNjNzEzMDYwZWMxMTZkZjgzMjRhYjRjNjdlZDA1NzNh YS4uN2NhODI1MmNkNzA3ZTQwZmMwMTY4ZTI2ZjVlYzliYjA3NGIzZTI1NyAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMucHkKKysrIGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMucHkKQEAgLTg3LDYgKzg3 LDEyIEBAIGNsYXNzIE1hY1BvcnQoQXBwbGVQb3J0KToKICAgICBkZWYgaXNfY3Jhc2hfcmVwb3J0 ZXIoc2VsZiwgcHJvY2Vzc19uYW1lKToKICAgICAgICAgcmV0dXJuIHJlLnNlYXJjaChyJ1JlcG9y dENyYXNoJywgcHJvY2Vzc19uYW1lKQogCisgICAgZGVmIGRlZmF1bHRfY2hpbGRfcHJvY2Vzc2Vz KHNlbGYpOgorICAgICAgICBpZiBzZWxmLmlzX3Nub3dsZW9wYXJkKCk6CisgICAgICAgICAgICBf bG9nLmVycm9yKCJDYW5ub3QgcnVuIHRlc3RzIGluIHBhcmFsbGVsIG9uIFNub3cgTGVvcGFyZCBk dWUgdG8gcmRhcjovL3Byb2JsZW0vMTA2MjE1MjUuIikKKyAgICAgICAgICAgIHJldHVybiAxCisg ICAgICAgIHJldHVybiBzdXBlcihNYWNQb3J0LCBzZWxmKS5kZWZhdWx0X2NoaWxkX3Byb2Nlc3Nl cygpCisKICAgICBkZWYgX2J1aWxkX2phdmFfdGVzdF9zdXBwb3J0KHNlbGYpOgogICAgICAgICBq YXZhX3Rlc3RzX3BhdGggPSBzZWxmLl9maWxlc3lzdGVtLmpvaW4oc2VsZi5sYXlvdXRfdGVzdHNf ZGlyKCksICJqYXZhIikKICAgICAgICAgYnVpbGRfamF2YSA9IFsiL3Vzci9iaW4vbWFrZSIsICIt QyIsIGphdmFfdGVzdHNfcGF0aF0KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvbWFjX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9tYWNfdW5pdHRlc3QucHkKaW5kZXggNDNhODAwODM5ZDMyYzBh OWI5NDJkNGVmYjBkMTA4YTUyNDAwMjQxZi4uZjViZWU0NTc5YThjNzQ3YzU0ZDBiYzVhMThmMGQ2 ZmUzZTIxMTA2MiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9tYWNfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9tYWNfdW5pdHRlc3QucHkKQEAgLTE2NiwzICsxNjYsMTIgQEAgamF2YS8K IAogICAgIGRlZiB0ZXN0X29wZXJhdGluZ19zeXN0ZW0oc2VsZik6CiAgICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWwoJ21hYycsIHNlbGYubWFrZV9wb3J0KCkub3BlcmF0aW5nX3N5c3RlbSgpKQorCisg ICAgZGVmIHRlc3RfZGVmYXVsdF9jaGlsZF9wcm9jZXNzZXMoc2VsZik6CisgICAgICAgIHBvcnQg PSBzZWxmLm1ha2VfcG9ydChwb3J0X25hbWU9J21hYy1saW9uJykKKyAgICAgICAgIyBNb2NrUGxh dGZvcm1JbmZvIG9ubHkgaGFzIDIgbW9jayBjb3Jlcy4gIFRoZSBpbXBvcnRhbnQgcGFydCBpcyB0 aGF0IDIgPiAxLgorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHBvcnQuZGVmYXVsdF9jaGlsZF9w cm9jZXNzZXMoKSwgMikKKworICAgICAgICAjIFNub3dMZW9wYXJkIGhhcyBhIENGTmV0d29yayBi dWcgd2hpY2ggY2F1c2VzIGNyYXNoZXMgaWYgd2UgZXhlY3V0ZSBtb3JlIHRoYW4gb25lIGNvcHkg b2YgRFJUIGF0IG9uY2UuCisgICAgICAgIHBvcnQgPSBzZWxmLm1ha2VfcG9ydChwb3J0X25hbWU9 J21hYy1zbm93bGVvcGFyZCcpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocG9ydC5kZWZhdWx0 X2NoaWxkX3Byb2Nlc3NlcygpLCAxKQo= 125198 2012-02-02 15:26:08 -0800 2012-02-02 19:03:33 -0800 Patch for landing bug-75145-20120202152607.patch text/plain 2916 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTA2NTkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWRjNzEyNDJhMWI3NzQ4MGQzY2I5ZTBmMDNmNjY3NDVl YzNjMWNhMi4uZTczYzg0NjA4MmU3ZTk0ZjQ1NDg1ZjQwMjI0NmQyYWZiMzAzMzI3ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTAyLTAyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAg ICBSdW4gdGVzdHMgaW4gc2VyaWFsIG9uIFNub3dMZW9wYXJkIHRvIGF2b2lkIENGVVJMQ2FjaGUg Y3Jhc2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzUxNDUKKworICAgICAgICBSZXZpZXdlZCBieSBEaXJrIFByYW5rZS4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbWFjLnB5OgorICAgICAgICAoTWFjUG9y dC5kZWZhdWx0X2NoaWxkX3Byb2Nlc3Nlcyk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9tYWNfdW5pdHRlc3QucHk6CisgICAgICAgICh0ZXN0X29wZXJhdGlu Z19zeXN0ZW0pOgorICAgICAgICAodGVzdF9kZWZhdWx0X2NoaWxkX3Byb2Nlc3Nlcyk6CisKIDIw MTItMDItMDIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICBu cnd0IHNob3VsZG4ndCBibG93IHVwIHdoZW4gdGhlcmUgYXJlIGVycm9ycyBpbiB0ZXN0X2V4cGVj dGF0aW9ucy50eHQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvbWFjLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9tYWMucHkKaW5kZXggZTIzZmI4MmNjNzEzMDYwZWMxMTZkZjgzMjRhYjRjNjdlZDA1NzNhYS4u MjAyZjJkZTJhNjlhNTlkMDdhNzViZjYzNGQ3N2Q2NWRjMzgyMmEwZCAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMucHkKQEAgLTg3LDYgKzg3LDEy IEBAIGNsYXNzIE1hY1BvcnQoQXBwbGVQb3J0KToKICAgICBkZWYgaXNfY3Jhc2hfcmVwb3J0ZXIo c2VsZiwgcHJvY2Vzc19uYW1lKToKICAgICAgICAgcmV0dXJuIHJlLnNlYXJjaChyJ1JlcG9ydENy YXNoJywgcHJvY2Vzc19uYW1lKQogCisgICAgZGVmIGRlZmF1bHRfY2hpbGRfcHJvY2Vzc2VzKHNl bGYpOgorICAgICAgICBpZiBzZWxmLmlzX3Nub3dsZW9wYXJkKCk6CisgICAgICAgICAgICBfbG9n Lndhcm4oIkNhbm5vdCBydW4gdGVzdHMgaW4gcGFyYWxsZWwgb24gU25vdyBMZW9wYXJkIGR1ZSB0 byByZGFyOi8vcHJvYmxlbS8xMDYyMTUyNS4iKQorICAgICAgICAgICAgcmV0dXJuIDEKKyAgICAg ICAgcmV0dXJuIHN1cGVyKE1hY1BvcnQsIHNlbGYpLmRlZmF1bHRfY2hpbGRfcHJvY2Vzc2VzKCkK KwogICAgIGRlZiBfYnVpbGRfamF2YV90ZXN0X3N1cHBvcnQoc2VsZik6CiAgICAgICAgIGphdmFf dGVzdHNfcGF0aCA9IHNlbGYuX2ZpbGVzeXN0ZW0uam9pbihzZWxmLmxheW91dF90ZXN0c19kaXIo KSwgImphdmEiKQogICAgICAgICBidWlsZF9qYXZhID0gWyIvdXNyL2Jpbi9tYWtlIiwgIi1DIiwg amF2YV90ZXN0c19wYXRoXQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9tYWNfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L21hY191bml0dGVzdC5weQppbmRleCA0M2E4MDA4MzlkMzJjMGE5Yjk0 MmQ0ZWZiMGQxMDhhNTI0MDAyNDFmLi5iZGVmOTgwYmRjNGQ3NzQxNWZiMjdiOTBhZDcxYmIyZGI1 MTU4MWY1IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L21hY191bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L21hY191bml0dGVzdC5weQpAQCAtMTY2LDMgKzE2NiwxNCBAQCBqYXZhLwogCiAg ICAgZGVmIHRlc3Rfb3BlcmF0aW5nX3N5c3RlbShzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRF cXVhbCgnbWFjJywgc2VsZi5tYWtlX3BvcnQoKS5vcGVyYXRpbmdfc3lzdGVtKCkpCisKKyAgICBk ZWYgdGVzdF9kZWZhdWx0X2NoaWxkX3Byb2Nlc3NlcyhzZWxmKToKKyAgICAgICAgcG9ydCA9IHNl bGYubWFrZV9wb3J0KHBvcnRfbmFtZT0nbWFjLWxpb24nKQorICAgICAgICAjIE1vY2tQbGF0Zm9y bUluZm8gb25seSBoYXMgMiBtb2NrIGNvcmVzLiAgVGhlIGltcG9ydGFudCBwYXJ0IGlzIHRoYXQg MiA+IDEuCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocG9ydC5kZWZhdWx0X2NoaWxkX3Byb2Nl c3NlcygpLCAyKQorCisgICAgICAgICMgU25vd0xlb3BhcmQgaGFzIGEgQ0ZOZXR3b3JrIGJ1ZyB3 aGljaCBjYXVzZXMgY3Jhc2hlcyBpZiB3ZSBleGVjdXRlIG1vcmUgdGhhbiBvbmUgY29weSBvZiBE UlQgYXQgb25jZS4KKyAgICAgICAgcG9ydCA9IHNlbGYubWFrZV9wb3J0KHBvcnRfbmFtZT0nbWFj LXNub3dsZW9wYXJkJykKKyAgICAgICAgZXhwZWN0ZWRfbG9ncyA9ICJDYW5ub3QgcnVuIHRlc3Rz IGluIHBhcmFsbGVsIG9uIFNub3cgTGVvcGFyZCBkdWUgdG8gcmRhcjovL3Byb2JsZW0vMTA2MjE1 MjUuXG4iCisgICAgICAgIGNoaWxkX3Byb2Nlc3NlcyA9IE91dHB1dENhcHR1cmUoKS5hc3NlcnRf b3V0cHV0cyhzZWxmLCBwb3J0LmRlZmF1bHRfY2hpbGRfcHJvY2Vzc2VzLCAoKSwgZXhwZWN0ZWRf bG9ncz1leHBlY3RlZF9sb2dzKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGNoaWxkX3Byb2Nl c3NlcywgMSkK