75130 2011-12-22 15:01:06 -0800 Crash and incorrect behavior when switching between hardware and software CSS filters 2011-12-22 17:09:11 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cmarrin cmarrin dino simon.fraser oldest_to_newest 526550 0 cmarrin 2011-12-22 15:01:06 -0800 Open the attached test case and rollover any image. The image will switch to using hardware filters and you may see a slight change in the image. Now roll off and you will crash. Crash is happening in RenderLayer.cpp around 2791 because m_filter is NULL and gets dereferenced. I tried adding a check for a null pointer to the enclosing if statement and that caused the crash to go away, but then rolling off the image caused it to not have a filter at all. It should revert to the software filter. 526617 1 120401 cmarrin 2011-12-22 16:14:08 -0800 Created attachment 120401 Test case showing bug 526641 2 120410 cmarrin 2011-12-22 16:48:12 -0800 Created attachment 120410 Patch 526644 3 120410 simon.fraser 2011-12-22 16:55:43 -0800 Comment on attachment 120410 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120410&action=review > LayoutTests/css3/filters/crash-hw-sw-switch-expected.txt:1 > + It would be nice if the expected output were "This test should not crash" or some such. 526653 4 cmarrin 2011-12-22 17:09:11 -0800 Committed r103597: <http://trac.webkit.org/changeset/103597> 120401 2011-12-22 16:14:08 -0800 2011-12-22 16:14:08 -0800 Test case showing bug crash-hw-sw-switch.html text/html 552 cmarrin PCFET0NUWVBFIGh0bWw+CjwhLS0gVGVzdCBwYXNzZXMgaWYgZG9lc24ndCBjcmFzaC4gLS0+Cjxz dHlsZT4KLnN3IHsKICAgIC13ZWJraXQtZmlsdGVyOiBibHVyKDRweCk7Cn0KLmh3IHsKICAgIC13 ZWJraXQtZmlsdGVyOiBibHVyKDNweCk7CiAgICAtd2Via2l0LXRyYW5zZm9ybTp0cmFuc2xhdGVa KDApOwp9Cjwvc3R5bGU+CjxpbWcgY2xhc3M9J3N3JyBzcmM9InJlc291cmNlcy9yZWZlcmVuY2Uu cG5nIj4KPHNjcmlwdD4KICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAg ICAgd2luZG93LmxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQodHJ1ZSk7CiAgICAvLyBm b3JjZSBhIGxheW91dAogICAgZG9jdW1lbnQuYm9keS5vZmZzZXRUb3A7CiAgICB2YXIgaW1nID0g ZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ2ltZycpWzBdOwogICAgaW1nLmNsYXNzTmFt ZSA9ICdodyc7CiAgICAvLyBmb3JjZSBhIGxheW91dAogICAgZG9jdW1lbnQuYm9keS5vZmZzZXRU b3A7CiAgICBpbWcuY2xhc3NOYW1lID0gJ3N3JzsKPC9zY3JpcHQ+ 120410 2011-12-22 16:48:12 -0800 2011-12-22 16:55:43 -0800 Patch bug-75130-20111222164810.patch text/plain 4582 cmarrin U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzNTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDAwNzEzNzcyZTBmOTU3 NjU1YTcyZTU3NmUxYzdmOTFlYTBlYWU1Yy4uZjVmODBmMjg4NWM3NmFiZWQ4MWFlYjU4ZjFiZDYy MDY1Mzk2MzRkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDExLTEyLTIyICBDaHJp cyBNYXJyaW4gIDxjbWFycmluQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCBhbmQgaW5jb3Jy ZWN0IGJlaGF2aW9yIHdoZW4gc3dpdGNoaW5nIGJldHdlZW4gaGFyZHdhcmUgYW5kIHNvZnR3YXJl IENTUyBmaWx0ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03NTEzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRlc3Q6IGNzczMvZmlsdGVycy9jcmFzaC1ody1zdy1zd2l0Y2guaHRtbAorCisgICAgICAg IEJhY2tpbmcgc3RvcmUgb24gbGF5ZXIgZ2V0cyBmaXhlZCB1cCAoYWRkZWQgb3IgcmVtb3ZlZCkg YWZ0ZXIgc3R5bGUgY2hhbmdlIGlzIGV2YWx1YXRlZAorICAgICAgICBzbyB0aGUgc3RhdGUgb2Yg dGhlIG1fZmlsdGVyIHZhcmlhYmxlIG1pZ2h0IG5vdCBtYXRjaCB0aGUgY3VycmVudCBmaWx0ZXIg c3RhdGUuIEFkZGVkCisgICAgICAgIHVwZGF0ZU9yUmVtb3ZlRmlsdGVyRWZmZWN0KCkgY2FsbCB0 byBlbnN1cmVCYWNraW5nKCkgYW5kIGNsZWFyQmFja2luZygpIHRvIGdldCB0aGUKKyAgICAgICAg bV9maWx0ZXIgcHJvcGVydHkgaW4gdGhlIHJpZ2h0IHN0YXRlLiBBbHNvIGFkZGVkIGFuIEFTU0VS VCgpIHdoZXJlIHRoZSBjcmFzaCB3YXMKKyAgICAgICAgb2NjdXJpbmcuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6 OnBhaW50TGF5ZXIpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmVuc3VyZUJhY2tp bmcpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmNsZWFyQmFja2luZyk6CisKIDIw MTEtMTItMjIgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAgICAgICAgIE5h bWVkTm9kZU1hcDogR2V0IHJpZCBvZiBkZWNsQ291bnQoKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IGFiODljZWVmNGJmYWE4M2Y4ZmIwZWFjNmViYzc5NDIx MmZhNDQ4N2YuLjNmOWVhZDI4YWRiMWNiNDkzNzY0MTc4NGFkZTAwNGRkZjg3MmYyMDggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtMjc4Niw2ICsyNzg2LDgg QEAgdm9pZCBSZW5kZXJMYXllcjo6cGFpbnRMYXllcihSZW5kZXJMYXllciogcm9vdExheWVyLCBH cmFwaGljc0NvbnRleHQqIHAsCiAgICAgCiAjaWYgRU5BQkxFKENTU19GSUxURVJTKQogICAgIGlm IChwYWludHNXaXRoRmlsdGVycygpICYmICEocGFpbnRGbGFncyAmIFBhaW50TGF5ZXJBcHBsaWVk RmlsdGVycykpIHsKKyAgICAgICAgQVNTRVJUKG1fZmlsdGVyKTsKKyAgICAgICAgCiAgICAgICAg IC8vIFVwZGF0ZSB0aGUgZmlsdGVyJ3MgaW1hZ2UgaWYgbmVjZXNzYXJ5LgogICAgICAgICAvLyBU aGUgZmlsdGVyIGlzIGFsd2F5cyBidWlsdCBhdCB0aGlzIHBvaW50LgogICAgICAgICBMYXlvdXRS ZWN0IGZpbHRlclJlY3QgPSB0cmFuc3BhcmVuY3lDbGlwQm94KHRoaXMsIHJvb3RMYXllciwgcGFp bnRCZWhhdmlvcik7CkBAIC0zOTQxLDYgKzM5NDMsMTAgQEAgUmVuZGVyTGF5ZXJCYWNraW5nKiBS ZW5kZXJMYXllcjo6ZW5zdXJlQmFja2luZygpCiAgICAgaWYgKCFtX2JhY2tpbmcpIHsKICAgICAg ICAgbV9iYWNraW5nID0gYWRvcHRQdHIobmV3IFJlbmRlckxheWVyQmFja2luZyh0aGlzKSk7CiAg ICAgICAgIGNvbXBvc2l0b3IoKS0+bGF5ZXJCZWNhbWVDb21wb3NpdGVkKHRoaXMpOworCisjaWYg RU5BQkxFKENTU19GSUxURVJTKQorICAgICAgICB1cGRhdGVPclJlbW92ZUZpbHRlckVmZmVjdCgp OworI2VuZGlmCiAgICAgfQogICAgIHJldHVybiBtX2JhY2tpbmcuZ2V0KCk7CiB9CkBAIC0zOTUw LDYgKzM5NTYsMTEgQEAgdm9pZCBSZW5kZXJMYXllcjo6Y2xlYXJCYWNraW5nKCkKICAgICBpZiAo bV9iYWNraW5nICYmICFyZW5kZXJlcigpLT5kb2N1bWVudEJlaW5nRGVzdHJveWVkKCkpCiAgICAg ICAgIGNvbXBvc2l0b3IoKS0+bGF5ZXJCZWNhbWVOb25Db21wb3NpdGVkKHRoaXMpOwogICAgIG1f YmFja2luZy5jbGVhcigpOworCisjaWYgRU5BQkxFKENTU19GSUxURVJTKQorICAgIHVwZGF0ZU9y UmVtb3ZlRmlsdGVyRWZmZWN0KCk7CisjZW5kaWYKKyAgICAKIH0KIAogYm9vbCBSZW5kZXJMYXll cjo6aGFzQ29tcG9zaXRlZE1hc2soKSBjb25zdApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDBhOGRjZDI3ZjcwOTYwMDY2MTUy N2NkMTg5OWJjMWE0NmZkYTNjNzIuLjljYzg1NzdlNjMzYzA2YWE1ZGYyYzZiYTk0YzE0NGNlMzQ3 Y2NlM2YgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0xMi0yMiAgQ2hyaXMgTWFycmluICA8 Y21hcnJpbkBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggYW5kIGluY29ycmVjdCBiZWhhdmlv ciB3aGVuIHN3aXRjaGluZyBiZXR3ZWVuIGhhcmR3YXJlIGFuZCBzb2Z0d2FyZSBDU1MgZmlsdGVy cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzUxMzAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNzczMv ZmlsdGVycy9jcmFzaC1ody1zdy1zd2l0Y2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBjc3MzL2ZpbHRlcnMvY3Jhc2gtaHctc3ctc3dpdGNoLmh0bWw6IEFkZGVkLgorCiAyMDExLTEy LTIyICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IFRhYmJlZFBhbmUgc2hvdWxkIHN1cHBvcnQgY2xvc2VhYmxlIHRhYnMsIGhp ZGluZyB0YWJzIGludG8gZHJvcCBkb3duIG1lbnUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9j c3MzL2ZpbHRlcnMvY3Jhc2gtaHctc3ctc3dpdGNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2NzczMvZmlsdGVycy9jcmFzaC1ody1zdy1zd2l0Y2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjhiMTM3ODkxNzkxZmU5NjkyN2FkNzhlNjRiMGFhZDdiZGVkMDhiZGMKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9jc3MzL2ZpbHRlcnMvY3Jhc2gtaHctc3ctc3dpdGNoLWV4cGVjdGVk LnR4dApAQCAtMCwwICsxIEBACisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvZmlsdGVy cy9jcmFzaC1ody1zdy1zd2l0Y2guaHRtbCBiL0xheW91dFRlc3RzL2NzczMvZmlsdGVycy9jcmFz aC1ody1zdy1zd2l0Y2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40YmQwNWE5ODdkNzZjY2Y4MmJlMzAxYzA1 ZTczZTg3MWY5MzdiMDJlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvY3NzMy9maWx0 ZXJzL2NyYXNoLWh3LXN3LXN3aXRjaC5odG1sCkBAIC0wLDAgKzEsMjMgQEAKKzwhRE9DVFlQRSBo dG1sPgorPCEtLSBUZXN0IHBhc3NlcyBpZiBkb2Vzbid0IGNyYXNoLiAtLT4KKzxzdHlsZT4KKy5z dyB7CisgICAgLXdlYmtpdC1maWx0ZXI6IGJsdXIoNHB4KTsKK30KKy5odyB7CisgICAgLXdlYmtp dC1maWx0ZXI6IGJsdXIoM3B4KTsKKyAgICAtd2Via2l0LXRyYW5zZm9ybTp0cmFuc2xhdGVaKDAp OworfQorPC9zdHlsZT4KKzxpbWcgY2xhc3M9J3N3JyBzcmM9InJlc291cmNlcy9yZWZlcmVuY2Uu cG5nIj4KKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAg ICAgICAgd2luZG93LmxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQodHJ1ZSk7CisgICAg Ly8gZm9yY2UgYSBsYXlvdXQKKyAgICBkb2N1bWVudC5ib2R5Lm9mZnNldFRvcDsKKyAgICB2YXIg aW1nID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ2ltZycpWzBdOworICAgIGltZy5j bGFzc05hbWUgPSAnaHcnOworICAgIC8vIGZvcmNlIGEgbGF5b3V0CisgICAgZG9jdW1lbnQuYm9k eS5vZmZzZXRUb3A7CisgICAgaW1nLmNsYXNzTmFtZSA9ICdzdyc7Cis8L3NjcmlwdD4KXCBObyBu ZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==