75110 2011-12-22 12:13:54 -0800 [Chromium] fast/filesystem/op-restricted-chars.html fails on Windows 2012-03-12 10:42:54 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa ericu ericu levin oldest_to_newest 526428 0 rniwa 2011-12-22 12:13:54 -0800 fast/filesystem/op-restricted-chars.html is failing on Windows because you can't have : in filenames on Windows: * Running: RestrictedChars PASS Succeeded: "/".getFile("a<b") PASS Succeeded: "/".getFile("a>b") FAIL Got unexpected error 1 while "/".getFile("a:b") FAIL Got error 1 PASS successfullyParsed is true TEST COMPLETE http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Ffilesystem%2Fop-restricted-chars.html 526571 1 ericu 2011-12-22 15:22:06 -0800 Arg. This doesn't hit the disk with that name; it must be having a problem with the file_util library. 529602 2 ericu 2012-01-04 10:30:44 -0800 (In reply to comment #1) > Arg. This doesn't hit the disk with that name; it must be having a problem with the file_util library. Actually, Windows doesn't allow < or > either, but those are passing. I'll dig in as soon as I can get my Windows dev setup up to date. 552604 3 ericu 2012-02-08 16:23:42 -0800 I tracked it down. It's because the file name starts with "a:", so when we call BaseName on it [in Chromium code, not WebKit], it thinks that's a drive name and pulls it off. So the test would have passed if it were "aa:b", but "a:b" fails. Most likely I'll need to add an option to BaseName to ignore drive letters when used on paths that aren't really system paths. 573176 4 130682 ericu 2012-03-07 13:29:52 -0800 Created attachment 130682 Patch 573177 5 ericu 2012-03-07 13:31:29 -0800 The bug was fixed in http://codereview.chromium.org/9370045. You can see that it was successful at http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Ffilesystem%2Fop-restricted-chars.html. 576260 6 ericu 2012-03-12 10:42:54 -0700 Committed r110444: <http://trac.webkit.org/changeset/110444> 130682 2012-03-07 13:29:52 -0800 2012-03-07 20:22:06 -0800 Patch bug-75110-20120307132951.patch text/plain 1488 ericu U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMDk0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjQxY2U5ZmNmY2E5MjY1M2NiM2E0 YjFkNTQxY2YxMzc0ZmY1MmE0Yy4uZTdjYWY3MTE2ODgyNjY3ZGU3OTcyN2VkMWM2NDk4NDc3MGVh YTg5YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTA3ICBFcmljIFVocmhhbmUgIDxl cmljdUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBmYXN0L2ZpbGVzeXN0ZW0v b3AtcmVzdHJpY3RlZC1jaGFycy5odG1sIGZhaWxzIG9uIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1MTEwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIGV4cGVjdGF0aW9uIG5vdyB0 aGF0IGl0J3MgZml4ZWQuCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3Rh dGlvbnMudHh0OgorCiAyMDEyLTAzLTA3ICBTdGVwaGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gVW5yZXZpZXdlZCBnYXJkZW5pbmcuCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9u cy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50 eHQKaW5kZXggMTNmYWZkMDg3MDM4ZTcyODY4ODlhMDljODAxMzlkOWNjOWVmNGIyNS4uOGNlNDIx NDc4OGVkYWIzNDZmZDg5YjNiZGEwMGNlMzhmOGQ3NzJmNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRl c3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAtMzUzMSw4ICsz NTMxLDYgQEAgQlVHV0s3NTExMSA6IGZhc3Qvd29ya2Vycy9zdG9yYWdlL3VzZS1zYW1lLWRhdGFi YXNlLWluLXBhZ2UtYW5kLXdvcmtlcnMuaHRtbCA9IFAKIEJVR1dLNzcxMzYgREVCVUcgOiBmYXN0 L3dvcmtlcnMvc3RvcmFnZS9pbnRlcnJ1cHQtZGF0YWJhc2UuaHRtbCA9IFBBU1MgQ1JBU0gKIEJV R1dLNzcxMzYgV0lOIFJFTEVBU0UgOiBmYXN0L3dvcmtlcnMvc3RvcmFnZS9pbnRlcnJ1cHQtZGF0 YWJhc2UuaHRtbCA9IFBBU1MgVElNRU9VVAogCi1CVUdXSzc1MTEwIFdJTiA6IGZhc3QvZmlsZXN5 c3RlbS9vcC1yZXN0cmljdGVkLWNoYXJzLmh0bWwgPSBURVhUCi0KIEJVR1dLNzUxNjEgOiBtZWRp YS92aWRlby1wb3N0ZXItYmxvY2tlZC1ieS13aWxsc2VuZHJlcXVlc3QuaHRtbCA9IFRFWFQKIAog QlVHV0s3NTM2NyA6IHN2Zy9jc3MvY29tcG9zaXRlLXNoYWRvdy1leGFtcGxlLmh0bWwgPSBQQVNT IFRFWFQK