75105 2011-12-22 11:44:27 -0800 Typo in error message: Unexpected token 'defualt' 2012-01-11 15:15:38 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED P2 Trivial --- 0 webkit girard girard oliver simon.fraser webkit.review.bot oldest_to_newest 526402 0 webkit 2011-12-22 11:44:27 -0800 Steps to reproduce: 1) Run narwhal with the JSC engine 2) console.log(default) Expected result: "SyntaxError: Unexpected token 'default'" Actual result: "SyntaxError: Unexpected token 'defualt'" I believe the constant is misdefined here: https://github.com/WebKit/webkit/blob/e5423c7a54883012264311e5cc5446fd0de2765a/Source/JavaScriptCore/parser/JSParser.cpp#L180 534247 1 122094 girard 2012-01-11 14:13:48 -0800 Created attachment 122094 Patch 534316 2 122094 webkit.review.bot 2012-01-11 15:15:34 -0800 Comment on attachment 122094 Patch Clearing flags on attachment: 122094 Committed r104750: <http://trac.webkit.org/changeset/104750> 534317 3 webkit.review.bot 2012-01-11 15:15:38 -0800 All reviewed patches have been landed. Closing bug. 122094 2012-01-11 14:13:48 -0800 2012-01-11 15:15:34 -0800 Patch bug-75105-20120111171346.patch text/plain 4533 girard U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0NzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj OGI0M2I0MWNmZjNjNTEwOWI4ZGI5ODJiMWQzZDZiOGM3ZTljZDJmLi4yMGUxNDJiNTBmNDYyZGJm MTI1NTRkM2Y5ZDExMWJlNzQ5MmY0OWVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMi0wMS0xMSAgRXVnZW5lIEdpcmFyZCAgPGdpcmFyZEBnb29nbGUuY29t PgorCisgICAgICAgIFR5cG8gaW4gZXJyb3IgbWVzc2FnZTogVW5leHBlY3RlZCB0b2tlbiAnZGVm dWFsdCcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1 MTA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw YXJzZXIvUGFyc2VyLmg6CisgICAgICAgIChKU0M6OlBhcnNlcjo6Z2V0VG9rZW5OYW1lKToKKwog MjAxMi0wMS0xMCAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8xMDY3Mzc5Mj4ganNjIHNob3VsZCBpbnN0YWxsIGRpcmVjdGx5IGluIHRvIHZl cnNpb25lZCBSZXNvdXJjZXMgc3ViZm9sZGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcGFyc2VyL1BhcnNlci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJz ZXIuaAppbmRleCBlZjE3NmYwMTRjNWZkY2M4NzRjNDMwNWU3YmUwODA1NGYzNGQ4MjI4Li5mM2Q5 NmZmM2VjOWUyY2U3YTcxMjdiYTgyZjRjOWM2MjRmYzA2NGM5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9wYXJzZXIvUGFyc2VyLmgKQEAgLTU1OSw3ICs1NTksNyBAQCBwcml2YXRlOgogICAgICAgICBj YXNlIENBU0U6IAogICAgICAgICAgICAgcmV0dXJuICJjYXNlIjsKICAgICAgICAgY2FzZSBERUZB VUxUOiAKLSAgICAgICAgICAgIHJldHVybiAiZGVmdWFsdCI7CisgICAgICAgICAgICByZXR1cm4g ImRlZmF1bHQiOwogICAgICAgICBjYXNlIEZPUjogCiAgICAgICAgICAgICByZXR1cm4gImZvciI7 CiAgICAgICAgIGNhc2UgTkVXOiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1OTE5NmE5NzVkZTNiYWMzZWU4ZWQxY2MwNjI1 NWU2ODgwNzMyYTU3Li5kM2IzOTUxNzIzZGQwY2I1MTk5NTk3ZGMwZDJlZWIxNGJkM2JlN2VlIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDEtMTEgIEV1Z2VuZSBHaXJhcmQgIDxnaXJhcmRA Z29vZ2xlLmNvbT4KKworICAgICAgICBUeXBvIGluIGVycm9yIG1lc3NhZ2U6IFVuZXhwZWN0ZWQg dG9rZW4gJ2RlZnVhbHQnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NTEwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogZmFzdC9qcy9yZXNlcnZlZC13b3Jkcy1hcy1wcm9wZXJ0eS1leHBlY3RlZC50eHQ6 CisKIDIwMTItMDEtMTEgIEpvZWwgV2ViYmVyICA8amd3QGdvb2dsZS5jb20+CiAKICAgICAgICAg SW1wbGVtZW50IHNldEN1cnJlbnRUaW1lKCkgYW5kIHBhdXNlQW5pbWF0aW9ucygpIG9uIFNWR1NW R0VsZW1lbnQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvanMvcmVzZXJ2ZWQtd29yZHMt YXMtcHJvcGVydHktZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNlcnZlZC13 b3Jkcy1hcy1wcm9wZXJ0eS1leHBlY3RlZC50eHQKaW5kZXggYzNmYjhkMWFhYjZhYTljY2FiZDBj ZmExOTkzMWQ1MzhjNGY5YWM4ZS4uYzdlY2E4MjEyNTcyNDI0N2Y2ZDM0Mzc2ODBiNTgyZDM2NzE1 ZTNjOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNlcnZlZC13b3Jkcy1hcy1w cm9wZXJ0eS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNlcnZlZC13 b3Jkcy1hcy1wcm9wZXJ0eS1leHBlY3RlZC50eHQKQEAgLTMwMSw4ICszMDEsOCBAQCBQQVNTIC9k ZWZhdWx0Ly50ZXN0KGZ1bmN0aW9uIGcoZGVmYXVsdCl7ICB9KSB0aHJldyBleGNlcHRpb24gU3lu dGF4RXJyb3I6IEV4cGVjdAogUEFTUyAoZnVuY3Rpb24oKXsvZGVmYXVsdC8udGVzdChmdW5jdGlv biBnKGRlZmF1bHQpeyAgfSl9KTsgdHJ1ZSB0aHJldyBleGNlcHRpb24gU3ludGF4RXJyb3I6IEV4 cGVjdGVkIGFuIGlkZW50aWZpZXIgYnV0IGZvdW5kICdkZWZhdWx0JyBpbnN0ZWFkLgogUEFTUyB0 cnl7fWNhdGNoKGRlZmF1bHQpe307IHRydWUgdGhyZXcgZXhjZXB0aW9uIFN5bnRheEVycm9yOiBF eHBlY3RlZCBhbiBpZGVudGlmaWVyIGJ1dCBmb3VuZCAnZGVmYXVsdCcgaW5zdGVhZC4KIFBBU1Mg KGZ1bmN0aW9uKCl7dHJ5e31jYXRjaChkZWZhdWx0KXt9OyB0cnVlfSk7IHRydWUgdGhyZXcgZXhj ZXB0aW9uIFN5bnRheEVycm9yOiBFeHBlY3RlZCBhbiBpZGVudGlmaWVyIGJ1dCBmb3VuZCAnZGVm YXVsdCcgaW5zdGVhZC4KLVBBU1MgZnVuY3Rpb24gZGVmYXVsdCgpeyAgfTsgdHJ1ZSB0aHJldyBl eGNlcHRpb24gU3ludGF4RXJyb3I6IFVuZXhwZWN0ZWQgdG9rZW4gJ2RlZnVhbHQnLgotUEFTUyAo ZnVuY3Rpb24oKXtmdW5jdGlvbiBkZWZhdWx0KCl7ICB9OyB0cnVlfSk7IHRydWUgdGhyZXcgZXhj ZXB0aW9uIFN5bnRheEVycm9yOiBVbmV4cGVjdGVkIHRva2VuICdkZWZ1YWx0Jy4KK1BBU1MgZnVu Y3Rpb24gZGVmYXVsdCgpeyAgfTsgdHJ1ZSB0aHJldyBleGNlcHRpb24gU3ludGF4RXJyb3I6IFVu ZXhwZWN0ZWQgdG9rZW4gJ2RlZmF1bHQnLgorUEFTUyAoZnVuY3Rpb24oKXtmdW5jdGlvbiBkZWZh dWx0KCl7ICB9OyB0cnVlfSk7IHRydWUgdGhyZXcgZXhjZXB0aW9uIFN5bnRheEVycm9yOiBVbmV4 cGVjdGVkIHRva2VuICdkZWZhdWx0Jy4KIFBBU1MgKHsgImRlZmF1bHQiOiA0MiB9LmRlZmF1bHQg PT09IDQyKSBpcyB0cnVlCiBQQVNTIChmdW5jdGlvbigpeyh7ICJkZWZhdWx0IjogNDIgfS5kZWZh dWx0ID09PSA0Mil9KTsgdHJ1ZSBpcyB0cnVlCiBQQVNTICh7IGRlZmF1bHQ6IDQyIH0uZGVmYXVs dCA9PT0gNDIpIGlzIHRydWUKQEAgLTMxOSw4ICszMTksOCBAQCBQQVNTICJ1c2Ugc3RyaWN0Ijsv ZGVmYXVsdC8udGVzdChmdW5jdGlvbiBnKGRlZmF1bHQpeyAidXNlIHN0cmljdCI7IH0pIHRocmV3 IGV4YwogUEFTUyAoZnVuY3Rpb24oKXsidXNlIHN0cmljdCI7L2RlZmF1bHQvLnRlc3QoZnVuY3Rp b24gZyhkZWZhdWx0KXsgInVzZSBzdHJpY3QiOyB9KX0pOyB0cnVlIHRocmV3IGV4Y2VwdGlvbiBT eW50YXhFcnJvcjogRXhwZWN0ZWQgYW4gaWRlbnRpZmllciBidXQgZm91bmQgJ2RlZmF1bHQnIGlu c3RlYWQuCiBQQVNTICJ1c2Ugc3RyaWN0Ijt0cnl7fWNhdGNoKGRlZmF1bHQpe307IHRydWUgdGhy ZXcgZXhjZXB0aW9uIFN5bnRheEVycm9yOiBFeHBlY3RlZCBhbiBpZGVudGlmaWVyIGJ1dCBmb3Vu ZCAnZGVmYXVsdCcgaW5zdGVhZC4KIFBBU1MgKGZ1bmN0aW9uKCl7InVzZSBzdHJpY3QiO3RyeXt9 Y2F0Y2goZGVmYXVsdCl7fTsgdHJ1ZX0pOyB0cnVlIHRocmV3IGV4Y2VwdGlvbiBTeW50YXhFcnJv cjogRXhwZWN0ZWQgYW4gaWRlbnRpZmllciBidXQgZm91bmQgJ2RlZmF1bHQnIGluc3RlYWQuCi1Q QVNTICJ1c2Ugc3RyaWN0IjtmdW5jdGlvbiBkZWZhdWx0KCl7ICJ1c2Ugc3RyaWN0IjsgfTsgdHJ1 ZSB0aHJldyBleGNlcHRpb24gU3ludGF4RXJyb3I6IFVuZXhwZWN0ZWQgdG9rZW4gJ2RlZnVhbHQn LgotUEFTUyAoZnVuY3Rpb24oKXsidXNlIHN0cmljdCI7ZnVuY3Rpb24gZGVmYXVsdCgpeyAidXNl IHN0cmljdCI7IH07IHRydWV9KTsgdHJ1ZSB0aHJldyBleGNlcHRpb24gU3ludGF4RXJyb3I6IFVu ZXhwZWN0ZWQgdG9rZW4gJ2RlZnVhbHQnLgorUEFTUyAidXNlIHN0cmljdCI7ZnVuY3Rpb24gZGVm YXVsdCgpeyAidXNlIHN0cmljdCI7IH07IHRydWUgdGhyZXcgZXhjZXB0aW9uIFN5bnRheEVycm9y OiBVbmV4cGVjdGVkIHRva2VuICdkZWZhdWx0Jy4KK1BBU1MgKGZ1bmN0aW9uKCl7InVzZSBzdHJp Y3QiO2Z1bmN0aW9uIGRlZmF1bHQoKXsgInVzZSBzdHJpY3QiOyB9OyB0cnVlfSk7IHRydWUgdGhy ZXcgZXhjZXB0aW9uIFN5bnRheEVycm9yOiBVbmV4cGVjdGVkIHRva2VuICdkZWZhdWx0Jy4KIFBB U1MgInVzZSBzdHJpY3QiOyh7ICJkZWZhdWx0IjogNDIgfS5kZWZhdWx0ID09PSA0MikgaXMgdHJ1 ZQogUEFTUyAoZnVuY3Rpb24oKXsidXNlIHN0cmljdCI7KHsgImRlZmF1bHQiOiA0MiB9LmRlZmF1 bHQgPT09IDQyKX0pOyB0cnVlIGlzIHRydWUKIFBBU1MgInVzZSBzdHJpY3QiOyh7IGRlZmF1bHQ6 IDQyIH0uZGVmYXVsdCA9PT0gNDIpIGlzIHRydWUK