75089 2011-12-22 07:40:35 -0800 Access-Control-Request-Headers values should be lowercase 2012-01-18 15:22:05 -0800 1 1 1 Unclassified WebKit XML 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bzbarsky webkit-unassigned abarth ap japhet joethomas me ukai webkit.review.bot yuzo oldest_to_newest 526252 0 bzbarsky 2011-12-22 07:40:35 -0800 Spec says: If author request headers is not empty include an Access-Control-Request-Headers header with as header field value a comma-separated list of the header field names from author request headers in lexicographical order, each converted to ASCII lowercase (even when one or more are a simple header). That's not what WebKit does, apparently. See thread starting http://lists.w3.org/Archives/Public/public-webapps/2011OctDec/1672.html This is causing a certain amount of author confusion, especially since other UAs get this right. 526362 1 ap 2011-12-22 10:50:07 -0800 Julian disagrees with this spec provision: <https://www.w3.org/Bugs/Public/show_bug.cgi?id=15312>. Seems OK to change WebKit behavior, although that should really make no difference, as servers must do case insensitive comparison anyway. 536867 2 122708 joethomas 2012-01-16 20:52:25 -0800 Created attachment 122708 Patch1 + No new tests, as servers must do case-insensitive comparison. Just wondering what kind of regression test can be added for this? 536891 3 ap 2012-01-16 22:20:47 -0800 We have our own server for testing, so it should be possible to make it verify this. 536957 4 122708 abarth 2012-01-17 01:22:25 -0800 Comment on attachment 122708 Patch1 This should be testable. If you look in the LayoutTests/http/tests directory, you should find some perl or PHP scripts that run on the test server. They can see the case sensitive version of Access-Control-Request-Headers. 537518 5 122853 joethomas 2012-01-17 18:05:33 -0800 Created attachment 122853 Patch2 Added test case to verify that server receives the Access-Control-Request-Headers in lowercase. Also verified it using the IP logs captured with Wireshark. 537542 6 122853 ap 2012-01-17 18:37:48 -0800 Comment on attachment 122853 Patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=122853&action=review > LayoutTests/http/tests/xmlhttprequest/resources/access-control-preflight-request-header-lowercase.php:14 > + if (strcasecmp($_SERVER["HTTP_X_CUSTOM_HEADER"], "fooBAR") == 0) I'm not sure what the point of this case insensitive comparison is. 537584 7 122864 joethomas 2012-01-17 20:08:31 -0800 Created attachment 122864 patch3 537585 8 joethomas 2012-01-17 20:09:40 -0800 (In reply to comment #6) > (From update of attachment 122853 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=122853&action=review > > > LayoutTests/http/tests/xmlhttprequest/resources/access-control-preflight-request-header-lowercase.php:14 > > + if (strcasecmp($_SERVER["HTTP_X_CUSTOM_HEADER"], "fooBAR") == 0) > > I'm not sure what the point of this case insensitive comparison is. No specific reason. I changed this to if (isset($_SERVER["HTTP_X_CUSTOM_HEADER"])) 537606 9 122864 ap 2012-01-17 21:00:09 -0800 Comment on attachment 122864 patch3 Thank you. 537625 10 122864 webkit.review.bot 2012-01-17 22:06:23 -0800 Comment on attachment 122864 patch3 Clearing flags on attachment: 122864 Committed r105242: <http://trac.webkit.org/changeset/105242> 538190 11 122853 joethomas 2012-01-18 14:43:17 -0800 Comment on attachment 122853 Patch2 making patch2 obsolete 538240 12 ap 2012-01-18 15:22:05 -0800 Commit queue did not close this bug, but it doesn't appear that there is anything else to do here. 122708 2012-01-16 20:52:25 -0800 2012-01-17 18:05:33 -0800 Patch1 patch1 text/plain 1716 joethomas SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTEyMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAxLTE2ICBKb2UgVGhv bWFzICA8am9ldGhvbWFzQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzUwODkKKyAgICAgICAgQWNjZXNzLUNvbnRyb2wtUmVx dWVzdC1IZWFkZXJzIHZhbHVlIHNob3VsZCBiZSBsb3dlcmNhc2UKKworICAgICAgICBBY2Nlc3Mt Q29udHJvbC1SZXF1ZXN0LUhlYWRlcnMgaXMgdXNlZCB3aGVuIGlzc3VpbmcgYSBwcmVmbGlnaHQg cmVxdWVzdCB0byBsZXQgdGhlIHNlcnZlciBrbm93CisgICAgICAgIHdoYXQgSFRUUCBoZWFkZXJz IHdpbGwgYmUgdXNlZCB3aGVuIHRoZSBhY3R1YWwgcmVxdWVzdCBpcyBtYWRlLgorICAgICAgICBB cyBwZXIgdGhlIFczQyBzcGVjaWZpY2F0aW9uLCBBY2Nlc3MtQ29udHJvbC1SZXF1ZXN0LUhlYWRl cnMgdmFsdWUgc2hvdWxkIGJlIHNldCBpbiBsb3dlcmNhc2UKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGFzIHNlcnZlcnMgbXVz dCBkbyBjYXNlLWluc2Vuc2l0aXZlIGNvbXBhcmlzb24KKworICAgICAgICAqIGxvYWRlci9Dcm9z c09yaWdpbkFjY2Vzc0NvbnRyb2wuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlQWNjZXNz Q29udHJvbFByZWZsaWdodFJlcXVlc3QpOiBBY2Nlc3MtQ29udHJvbC1SZXF1ZXN0LUhlYWRlcnMg dmFsdWUgaXMgc2V0IHRvIGxvd2VyY2FzZQorCiAyMDEyLTAxLTE2ICBIYXlhdG8gSXRvICA8aGF5 YXRvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbXBsZW1lbnQgbXVsdGlwbGUgQVRfVEFSR0VU IGV2ZW50IGRpc3BhdGNoaW5nIGluIHJlZ2FyZCB0byBzaGFkb3cgdHJlZS4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2xvYWRlci9Dcm9zc09yaWdpbkFjY2Vzc0NvbnRyb2wuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Dcm9zc09yaWdpbkFjY2Vzc0NvbnRyb2wuY3BwCShy ZXZpc2lvbiAxMDUxMjMpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvQ3Jvc3NPcmlnaW5BY2Nl c3NDb250cm9sLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI2LDcgKzEyNiw3IEBAIFJlc291cmNl UmVxdWVzdCBjcmVhdGVBY2Nlc3NDb250cm9sUHJlZmwKICAgICAgICAgICAgIGhlYWRlckJ1ZmZl ci5hcHBlbmQoaXQtPmZpcnN0KTsKICAgICAgICAgfQogCi0gICAgICAgIHByZWZsaWdodFJlcXVl c3Quc2V0SFRUUEhlYWRlckZpZWxkKCJBY2Nlc3MtQ29udHJvbC1SZXF1ZXN0LUhlYWRlcnMiLCBo ZWFkZXJCdWZmZXIudG9TdHJpbmcoKSk7CisgICAgICAgIHByZWZsaWdodFJlcXVlc3Quc2V0SFRU UEhlYWRlckZpZWxkKCJBY2Nlc3MtQ29udHJvbC1SZXF1ZXN0LUhlYWRlcnMiLCBoZWFkZXJCdWZm ZXIudG9TdHJpbmcoKS5sb3dlcigpKTsKICAgICB9CiAKICAgICByZXR1cm4gcHJlZmxpZ2h0UmVx dWVzdDsK 122853 2012-01-17 18:05:33 -0800 2012-01-18 14:43:17 -0800 Patch2 patch2 text/plain 5920 joethomas SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTIyMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAxLTE3ICBKb2UgVGhv bWFzICA8am9ldGhvbWFzQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzUwODkKKyAgICAgICAgQWNjZXNzLUNvbnRyb2wtUmVx dWVzdC1IZWFkZXJzIHZhbHVlIHNob3VsZCBiZSBsb3dlcmNhc2UKKworICAgICAgICBBY2Nlc3Mt Q29udHJvbC1SZXF1ZXN0LUhlYWRlcnMgaXMgdXNlZCB3aGVuIGlzc3VpbmcgYSBwcmVmbGlnaHQg cmVxdWVzdCB0byBsZXQgdGhlIHNlcnZlciBrbm93CisgICAgICAgIHRoZSBIVFRQIGhlYWRlcnMg dGhhdCB3aWxsIGJlIHVzZWQgd2hlbiB0aGUgYWN0dWFsIHJlcXVlc3QgaXMgbWFkZS4KKyAgICAg ICAgQXMgcGVyIHRoZSBXM0Mgc3BlY2lmaWNhdGlvbiwgQWNjZXNzLUNvbnRyb2wtUmVxdWVzdC1I ZWFkZXJzIHZhbHVlIHNob3VsZCBiZSBzZXQgaW4gbG93ZXJjYXNlLgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGh0dHAvdGVzdHMveG1saHR0 cHJlcXVlc3QvYWNjZXNzLWNvbnRyb2wtcHJlZmxpZ2h0LXJlcXVlc3QtaGVhZGVyLWxvd2VyY2Fz ZS5odG1sCisKKyAgICAgICAgKiBsb2FkZXIvQ3Jvc3NPcmlnaW5BY2Nlc3NDb250cm9sLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZUFjY2Vzc0NvbnRyb2xQcmVmbGlnaHRSZXF1ZXN0KTog c2V0dGluZyBBY2Nlc3MtQ29udHJvbC1SZXF1ZXN0LUhlYWRlcnMgdmFsdWUgdG8gbG93ZXJjYXNl CisKIDIwMTItMDEtMTcgIENhaW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xp dmVpcmFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBVaW50OENsYW1wZWRBcnJheSBzdXBwb3J0 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvQ3Jvc3NPcmlnaW5BY2Nlc3NDb250cm9sLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvQ3Jvc3NPcmlnaW5BY2Nlc3ND b250cm9sLmNwcAkocmV2aXNpb24gMTA1MTIzKQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL0Ny b3NzT3JpZ2luQWNjZXNzQ29udHJvbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNiw3ICsxMjYs NyBAQCBSZXNvdXJjZVJlcXVlc3QgY3JlYXRlQWNjZXNzQ29udHJvbFByZWZsCiAgICAgICAgICAg ICBoZWFkZXJCdWZmZXIuYXBwZW5kKGl0LT5maXJzdCk7CiAgICAgICAgIH0KIAotICAgICAgICBw cmVmbGlnaHRSZXF1ZXN0LnNldEhUVFBIZWFkZXJGaWVsZCgiQWNjZXNzLUNvbnRyb2wtUmVxdWVz dC1IZWFkZXJzIiwgaGVhZGVyQnVmZmVyLnRvU3RyaW5nKCkpOworICAgICAgICBwcmVmbGlnaHRS ZXF1ZXN0LnNldEhUVFBIZWFkZXJGaWVsZCgiQWNjZXNzLUNvbnRyb2wtUmVxdWVzdC1IZWFkZXJz IiwgaGVhZGVyQnVmZmVyLnRvU3RyaW5nKCkubG93ZXIoKSk7CiAgICAgfQogCiAgICAgcmV0dXJu IHByZWZsaWdodFJlcXVlc3Q7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDUyMjApCisrKyBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wMS0x NyAgSm9lIFRob21hcyAgPGpvZXRob21hc0Btb3Rvcm9sYS5jb20+CisKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1MDg5CisgICAgICAgIEFjY2Vzcy1D b250cm9sLVJlcXVlc3QtSGVhZGVycyB2YWx1ZSBzaG91bGQgYmUgbG93ZXJjYXNlCisKKyAgICAg ICAgQWRkZWQgdGVzdCB0byB2ZXJpZnkgdGhhdCB0aGUgQWNjZXNzLUNvbnRyb2wtUmVxdWVzdC1I ZWFkZXJzIHZhbHVlIGlzIHNlbnQgaW4gbG93ZXJjYXNlLgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9h Y2Nlc3MtY29udHJvbC1wcmVmbGlnaHQtcmVxdWVzdC1oZWFkZXItbG93ZXJjYXNlLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9hY2Nlc3Mt Y29udHJvbC1wcmVmbGlnaHQtcmVxdWVzdC1oZWFkZXItbG93ZXJjYXNlLmh0bWw6IEFkZGVkLgor ICAgICAgICAqIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvcmVzb3VyY2VzL2FjY2Vzcy1jb250 cm9sLXByZWZsaWdodC1yZXF1ZXN0LWhlYWRlci1sb3dlcmNhc2UucGhwOiBBZGRlZC4KKwogMjAx Mi0wMS0xNyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZWR1Y2UgdGhlIG51bWJlciBvZiBjb21wb3NpdGluZyB0ZXN0IGZhaWx1cmVzCkluZGV4OiBM YXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2FjY2Vzcy1jb250cm9sLXByZWZs aWdodC1yZXF1ZXN0LWhlYWRlci1sb3dlcmNhc2UtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvYWNjZXNzLWNvbnRyb2wtcHJl ZmxpZ2h0LXJlcXVlc3QtaGVhZGVyLWxvd2VyY2FzZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2FjY2Vzcy1jb250cm9s LXByZWZsaWdodC1yZXF1ZXN0LWhlYWRlci1sb3dlcmNhc2UtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQpAQCAtMCwwICsxLDMgQEAKK1Rlc3QgZm9yIGJ1ZyA3NTA4OTogQWNjZXNzLUNvbnRyb2wt UmVxdWVzdC1IZWFkZXJzIHZhbHVlcyBzaG91bGQgYmUgbG93ZXJjYXNlLgorCitQQVNTCkluZGV4 OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2FjY2Vzcy1jb250cm9sLXBy ZWZsaWdodC1yZXF1ZXN0LWhlYWRlci1sb3dlcmNhc2UuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L2FjY2Vzcy1jb250cm9sLXByZWZsaWdo dC1yZXF1ZXN0LWhlYWRlci1sb3dlcmNhc2UuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvYWNjZXNzLWNvbnRyb2wtcHJlZmxpZ2h0LXJl cXVlc3QtaGVhZGVyLWxvd2VyY2FzZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMzIEBA Cis8aHRtbD4KKzxib2R5PgorPHA+VGVzdCBmb3IgYnVnIDc1MDg5OiBBY2Nlc3MtQ29udHJvbC1S ZXF1ZXN0LUhlYWRlcnMgdmFsdWVzIHNob3VsZCBiZSBsb3dlcmNhc2UuPC9wPgorPHNjcmlwdD4K K2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5kdW1wQXNUZXh0KCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9u ZSgpOworfQorCitmdW5jdGlvbiBzZW5kUmVxdWVzdCgpCit7CisgICAgdmFyIHhociA9IG5ldyBY TUxIdHRwUmVxdWVzdDsKKyAgICB4aHIub3BlbigiR0VUIiwgImh0dHA6Ly9sb2NhbGhvc3Q6ODAw MC94bWxodHRwcmVxdWVzdC9yZXNvdXJjZXMvYWNjZXNzLWNvbnRyb2wtcHJlZmxpZ2h0LXJlcXVl c3QtaGVhZGVyLWxvd2VyY2FzZS5waHAiKTsKKyAgICB4aHIuc2V0UmVxdWVzdEhlYWRlcigiWC1D dXN0b20tSGVhZGVyIiwgImZvb2JhciIpOworICAgIHhoci5vbmVycm9yID0gZnVuY3Rpb24oKSB7 CisgICAgICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5v ZGUoIkZBSUw6IG9uZXJyb3IgY2FsbGVkIikpOworICAgICAgICBpZiAod2luZG93LmxheW91dFRl c3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9u ZSgpOworICAgIH0KKworICAgIHhoci5vbnJlYWR5c3RhdGVjaGFuZ2U9ZnVuY3Rpb24oKSB7Cisg ICAgICAgIGlmICh4aHIucmVhZHlTdGF0ZT09NCkgeworICAgICAgICAgICAgZG9jdW1lbnQuYm9k eS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSh4aHIucmVzcG9uc2VUZXh0KSk7 CisgICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAg ICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICAgICAgfQorICAg IH0KKyAgICB4aHIuc2VuZCgpOworfQorc2VuZFJlcXVlc3QoKTsKKzwvc2NyaXB0PgorPC9ib2R5 PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9y ZXNvdXJjZXMvYWNjZXNzLWNvbnRyb2wtcHJlZmxpZ2h0LXJlcXVlc3QtaGVhZGVyLWxvd2VyY2Fz ZS5waHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVz dC9yZXNvdXJjZXMvYWNjZXNzLWNvbnRyb2wtcHJlZmxpZ2h0LXJlcXVlc3QtaGVhZGVyLWxvd2Vy Y2FzZS5waHAJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHBy ZXF1ZXN0L3Jlc291cmNlcy9hY2Nlc3MtY29udHJvbC1wcmVmbGlnaHQtcmVxdWVzdC1oZWFkZXIt bG93ZXJjYXNlLnBocAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxOSBAQAorPD9waHAKK3JlcXVp cmVfb25jZSAnLi4vLi4vcmVzb3VyY2VzL3BvcnRhYmlsaXR5TGF5ZXIucGhwJzsKKworaGVhZGVy KCJBY2Nlc3MtQ29udHJvbC1BbGxvdy1PcmlnaW46ICoiKTsKK2hlYWRlcigiQWNjZXNzLUNvbnRy b2wtTWF4LUFnZTogMCIpOworCitpZiAoJF9TRVJWRVJbIlJFUVVFU1RfTUVUSE9EIl0gPT0gIk9Q VElPTlMiKSB7CisgICAgLy8gU3BsaXQgdGhlIEFjY2Vzcy1Db250cm9sLVJlcXVlc3QtaGVhZGVy IHZhbHVlIGJhc2VkIG9uIHRoZSB0b2tlbi4KKyAgICAkYWNjZXNzQ29udHJvbFJlcXVlc3RIZWFk ZXJWYWx1ZXMgPSBleHBsb2RlKCIsICIsICRfU0VSVkVSWyJIVFRQX0FDQ0VTU19DT05UUk9MX1JF UVVFU1RfSEVBREVSUyJdKTsKKyAgICBpZiAoaW5fYXJyYXkoIngtY3VzdG9tLWhlYWRlciIsICRh Y2Nlc3NDb250cm9sUmVxdWVzdEhlYWRlclZhbHVlcykpIC8vIENhc2Utc2Vuc2l0aXZlIGNvbXBh cmlzb24gdG8gbWFrZSBzdXJlIHRoYXQgYnJvd3NlciBzZW5kcyB0aGUgdmFsdWUgaW4gbG93ZXJj YXNlLgorICAgICAgICBoZWFkZXIoIkFjY2Vzcy1Db250cm9sLUFsbG93LUhlYWRlcnM6IFgtQ3Vz dG9tLUhlYWRlciIpOyAgLy8gQWRkICJBY2Nlc3MtQ29udHJvbC1BbGxvdy1IZWFkZXJzOiBYLUN1 c3RvbS1IZWFkZXIiIHRvICJPUFRJT05TIiByZXNwb25zZS4KKworfSBlbHNlIGlmICgkX1NFUlZF UlsiUkVRVUVTVF9NRVRIT0QiXSA9PSAiR0VUIikgeworICAgIGlmIChzdHJjYXNlY21wKCRfU0VS VkVSWyJIVFRQX1hfQ1VTVE9NX0hFQURFUiJdLCAiZm9vQkFSIikgPT0gMCkKKyAgICAgICAgZWNo byAiUEFTUyI7CisgICAgZWxzZQorICAgICAgICBlY2hvICJGQUlMIjsKK30KKz8+Cg== 122864 2012-01-17 20:08:31 -0800 2012-01-17 22:06:23 -0800 patch3 patch3 text/plain 6007 joethomas SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTIzNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAxLTE3ICBKb2UgVGhv bWFzICA8am9ldGhvbWFzQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzUwODkKKyAgICAgICAgQWNjZXNzLUNvbnRyb2wtUmVx dWVzdC1IZWFkZXJzIHZhbHVlIHNob3VsZCBiZSBsb3dlcmNhc2UKKworICAgICAgICBBY2Nlc3Mt Q29udHJvbC1SZXF1ZXN0LUhlYWRlcnMgaXMgdXNlZCB3aGVuIGlzc3VpbmcgYSBwcmVmbGlnaHQg cmVxdWVzdCB0byBsZXQgdGhlIHNlcnZlciBrbm93CisgICAgICAgIHRoZSBIVFRQIGhlYWRlcnMg dGhhdCB3aWxsIGJlIHVzZWQgd2hlbiB0aGUgYWN0dWFsIHJlcXVlc3QgaXMgbWFkZS4KKyAgICAg ICAgQXMgcGVyIHRoZSBXM0Mgc3BlY2lmaWNhdGlvbiwgQWNjZXNzLUNvbnRyb2wtUmVxdWVzdC1I ZWFkZXJzIHZhbHVlIHNob3VsZCBiZSBzZXQgaW4gbG93ZXJjYXNlLgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IGh0dHAvdGVzdHMveG1saHR0 cHJlcXVlc3QvYWNjZXNzLWNvbnRyb2wtcHJlZmxpZ2h0LXJlcXVlc3QtaGVhZGVyLWxvd2VyY2Fz ZS5odG1sCisKKyAgICAgICAgKiBsb2FkZXIvQ3Jvc3NPcmlnaW5BY2Nlc3NDb250cm9sLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZUFjY2Vzc0NvbnRyb2xQcmVmbGlnaHRSZXF1ZXN0KTog c2V0dGluZyBBY2Nlc3MtQ29udHJvbC1SZXF1ZXN0LUhlYWRlcnMgdmFsdWUgdG8gbG93ZXJjYXNl CisKIDIwMTItMDEtMTcgIE1hdHRoZXcgRGVsYW5leSAgPG1kZWxhbmV5QGFwcGxlLmNvbT4KIAog ICAgICAgICBPbiBwb3N0LUxpb24gcmVsZWFzZXMsIHByZXNlcnZlIHRoZSBMaW9uIGJlaGF2aW9y IHdoZXJlIFdlYktpdCBleHBsaWNpdGx5IGNhbGxzIC1zZXRHZW9tZXRyeUZsaXBwZWQgb24gdGhl IGhvc3RpbmcgbGF5ZXIgZm9yIGFwcGxpY2F0aW9ucyB0aGF0IHdlcmUgbGlua2VkIG9uIExpb24g b3IgZWFybGllci4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Dcm9zc09yaWdpbkFjY2Vz c0NvbnRyb2wuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Dcm9zc09y aWdpbkFjY2Vzc0NvbnRyb2wuY3BwCShyZXZpc2lvbiAxMDUxMjMpCisrKyBTb3VyY2UvV2ViQ29y ZS9sb2FkZXIvQ3Jvc3NPcmlnaW5BY2Nlc3NDb250cm9sLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTI2LDcgKzEyNiw3IEBAIFJlc291cmNlUmVxdWVzdCBjcmVhdGVBY2Nlc3NDb250cm9sUHJlZmwK ICAgICAgICAgICAgIGhlYWRlckJ1ZmZlci5hcHBlbmQoaXQtPmZpcnN0KTsKICAgICAgICAgfQog Ci0gICAgICAgIHByZWZsaWdodFJlcXVlc3Quc2V0SFRUUEhlYWRlckZpZWxkKCJBY2Nlc3MtQ29u dHJvbC1SZXF1ZXN0LUhlYWRlcnMiLCBoZWFkZXJCdWZmZXIudG9TdHJpbmcoKSk7CisgICAgICAg IHByZWZsaWdodFJlcXVlc3Quc2V0SFRUUEhlYWRlckZpZWxkKCJBY2Nlc3MtQ29udHJvbC1SZXF1 ZXN0LUhlYWRlcnMiLCBoZWFkZXJCdWZmZXIudG9TdHJpbmcoKS5sb3dlcigpKTsKICAgICB9CiAK ICAgICByZXR1cm4gcHJlZmxpZ2h0UmVxdWVzdDsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwNTIzNykK KysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTAxLTE3ICBKb2UgVGhvbWFzICA8am9ldGhvbWFzQG1vdG9yb2xhLmNvbT4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzUwODkKKyAgICAg ICAgQWNjZXNzLUNvbnRyb2wtUmVxdWVzdC1IZWFkZXJzIHZhbHVlIHNob3VsZCBiZSBsb3dlcmNh c2UKKworICAgICAgICBBZGRlZCB0ZXN0IHRvIHZlcmlmeSB0aGF0IHRoZSBBY2Nlc3MtQ29udHJv bC1SZXF1ZXN0LUhlYWRlcnMgdmFsdWUgaXMgc2VudCBpbiBsb3dlcmNhc2UuCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3htbGh0 dHByZXF1ZXN0L2FjY2Vzcy1jb250cm9sLXByZWZsaWdodC1yZXF1ZXN0LWhlYWRlci1sb3dlcmNh c2UtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL3htbGh0dHByZXF1 ZXN0L2FjY2Vzcy1jb250cm9sLXByZWZsaWdodC1yZXF1ZXN0LWhlYWRlci1sb3dlcmNhc2UuaHRt bDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9yZXNvdXJjZXMv YWNjZXNzLWNvbnRyb2wtcHJlZmxpZ2h0LXJlcXVlc3QtaGVhZGVyLWxvd2VyY2FzZS5waHA6IEFk ZGVkLgorCiAyMDEyLTAxLTE3ICBQaGlsaXAgUm9nZXJzICA8cGRyQGdvb2dsZS5jb20+CiAKICAg ICAgICAgRml4IGdldEJCb3ggZm9yIHBlcnBlbmRpY3VsYXIgcGF0aHMKSW5kZXg6IExheW91dFRl c3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvYWNjZXNzLWNvbnRyb2wtcHJlZmxpZ2h0LXJl cXVlc3QtaGVhZGVyLWxvd2VyY2FzZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9hY2Nlc3MtY29udHJvbC1wcmVmbGlnaHQt cmVxdWVzdC1oZWFkZXItbG93ZXJjYXNlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvYWNjZXNzLWNvbnRyb2wtcHJlZmxp Z2h0LXJlcXVlc3QtaGVhZGVyLWxvd2VyY2FzZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsMyBAQAorVGVzdCBmb3IgYnVnIDc1MDg5OiBBY2Nlc3MtQ29udHJvbC1SZXF1ZXN0 LUhlYWRlcnMgdmFsdWVzIHNob3VsZCBiZSBsb3dlcmNhc2UuCisKK1BBU1MKSW5kZXg6IExheW91 dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvYWNjZXNzLWNvbnRyb2wtcHJlZmxpZ2h0 LXJlcXVlc3QtaGVhZGVyLWxvd2VyY2FzZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvYWNjZXNzLWNvbnRyb2wtcHJlZmxpZ2h0LXJlcXVl c3QtaGVhZGVyLWxvd2VyY2FzZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy94bWxodHRwcmVxdWVzdC9hY2Nlc3MtY29udHJvbC1wcmVmbGlnaHQtcmVxdWVzdC1o ZWFkZXItbG93ZXJjYXNlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzMgQEAKKzxodG1s PgorPGJvZHk+Cis8cD5UZXN0IGZvciBidWcgNzUwODk6IEFjY2Vzcy1Db250cm9sLVJlcXVlc3Qt SGVhZGVycyB2YWx1ZXMgc2hvdWxkIGJlIGxvd2VyY2FzZS48L3A+Cis8c2NyaXB0PgoraWYgKHdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1 bXBBc1RleHQoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cit9 CisKK2Z1bmN0aW9uIHNlbmRSZXF1ZXN0KCkKK3sKKyAgICB2YXIgeGhyID0gbmV3IFhNTEh0dHBS ZXF1ZXN0OworICAgIHhoci5vcGVuKCJHRVQiLCAiaHR0cDovL2xvY2FsaG9zdDo4MDAwL3htbGh0 dHByZXF1ZXN0L3Jlc291cmNlcy9hY2Nlc3MtY29udHJvbC1wcmVmbGlnaHQtcmVxdWVzdC1oZWFk ZXItbG93ZXJjYXNlLnBocCIpOworICAgIHhoci5zZXRSZXF1ZXN0SGVhZGVyKCJYLUN1c3RvbS1I ZWFkZXIiLCAiZm9vYmFyIik7CisgICAgeGhyLm9uZXJyb3IgPSBmdW5jdGlvbigpIHsKKyAgICAg ICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgiRkFJ TDogb25lcnJvciBjYWxsZWQiKSk7CisgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIpCisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7Cisg ICAgfQorCisgICAgeGhyLm9ucmVhZHlzdGF0ZWNoYW5nZT1mdW5jdGlvbigpIHsKKyAgICAgICAg aWYgKHhoci5yZWFkeVN0YXRlPT00KSB7CisgICAgICAgICAgICBkb2N1bWVudC5ib2R5LmFwcGVu ZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKHhoci5yZXNwb25zZVRleHQpKTsKKyAgICAg ICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICAgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgICAgICB9CisgICAgfQorICAg IHhoci5zZW5kKCk7Cit9CitzZW5kUmVxdWVzdCgpOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0 bWw+CkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3Jlc291cmNl cy9hY2Nlc3MtY29udHJvbC1wcmVmbGlnaHQtcmVxdWVzdC1oZWFkZXItbG93ZXJjYXNlLnBocAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3Jlc291 cmNlcy9hY2Nlc3MtY29udHJvbC1wcmVmbGlnaHQtcmVxdWVzdC1oZWFkZXItbG93ZXJjYXNlLnBo cAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qv cmVzb3VyY2VzL2FjY2Vzcy1jb250cm9sLXByZWZsaWdodC1yZXF1ZXN0LWhlYWRlci1sb3dlcmNh c2UucGhwCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE5IEBACis8P3BocAorcmVxdWlyZV9vbmNl ICcuLi8uLi9yZXNvdXJjZXMvcG9ydGFiaWxpdHlMYXllci5waHAnOworCitoZWFkZXIoIkFjY2Vz cy1Db250cm9sLUFsbG93LU9yaWdpbjogKiIpOworaGVhZGVyKCJBY2Nlc3MtQ29udHJvbC1NYXgt QWdlOiAwIik7CisKK2lmICgkX1NFUlZFUlsiUkVRVUVTVF9NRVRIT0QiXSA9PSAiT1BUSU9OUyIp IHsKKyAgICAvLyBTcGxpdCB0aGUgQWNjZXNzLUNvbnRyb2wtUmVxdWVzdC1oZWFkZXIgdmFsdWUg YmFzZWQgb24gdGhlIHRva2VuLgorICAgICRhY2Nlc3NDb250cm9sUmVxdWVzdEhlYWRlclZhbHVl cyA9IGV4cGxvZGUoIiwgIiwgJF9TRVJWRVJbIkhUVFBfQUNDRVNTX0NPTlRST0xfUkVRVUVTVF9I RUFERVJTIl0pOworICAgIGlmIChpbl9hcnJheSgieC1jdXN0b20taGVhZGVyIiwgJGFjY2Vzc0Nv bnRyb2xSZXF1ZXN0SGVhZGVyVmFsdWVzKSkgLy8gQ2FzZS1zZW5zaXRpdmUgY29tcGFyaXNvbiB0 byBtYWtlIHN1cmUgdGhhdCBicm93c2VyIHNlbmRzIHRoZSB2YWx1ZSBpbiBsb3dlcmNhc2UuCisg ICAgICAgIGhlYWRlcigiQWNjZXNzLUNvbnRyb2wtQWxsb3ctSGVhZGVyczogWC1DdXN0b20tSGVh ZGVyIik7ICAvLyBBZGQgIkFjY2Vzcy1Db250cm9sLUFsbG93LUhlYWRlcnM6IFgtQ3VzdG9tLUhl YWRlciIgdG8gIk9QVElPTlMiIHJlc3BvbnNlLgorCit9IGVsc2UgaWYgKCRfU0VSVkVSWyJSRVFV RVNUX01FVEhPRCJdID09ICJHRVQiKSB7CisgICAgaWYgKGlzc2V0KCRfU0VSVkVSWyJIVFRQX1hf Q1VTVE9NX0hFQURFUiJdKSkKKyAgICAgICAgZWNobyAiUEFTUyI7CisgICAgZWxzZQorICAgICAg ICBlY2hvICJGQUlMIjsKK30KKz8+Cg==