75075 2011-12-22 02:27:37 -0800 Fix debug build with assertions disabled 2012-01-02 01:23:49 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P3 Normal --- 1 kbalazs kbalazs japhet webkit.review.bot oldest_to_newest 526112 0 kbalazs 2011-12-22 02:27:37 -0800 An ASSERT_DISABLED=1 debug build can be useful if you have an assert but you want to debug another issue, or you are interested weather the behaviour is rigth even if the assert fails. So, let's fix the build with in this configuration. 526116 1 120292 kbalazs 2011-12-22 02:33:04 -0800 Created attachment 120292 Patch 528442 2 120292 kbalazs 2012-01-02 01:23:37 -0800 Comment on attachment 120292 Patch Landed in r103570 120292 2011-12-22 02:33:04 -0800 2012-01-02 01:23:37 -0800 Patch bug-75075-20111222113302.patch text/plain 5352 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzNTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 MDUwZWIzOGRkNjE4MTU5ZTExNDQ5OWQ5MTFiOGJlOWJhYmY3YWI2Li45YzZlODk1NzRhYWFlZGJk OGJjNzNjOGNhNGM4NTcxOTI0YWFlNGU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMS0xMi0yMiAgQmFsYXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5v cmc+CisKKyAgICAgICAgRml4IGRlYnVnIGJ1aWxkIHdpdGggYXNzZXJ0aW9ucyBkaXNhYmxlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzUwNzUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGVjayB3aGV0 aGVyIGFzc2VydGlvbnMgYXJlIGRpc2FibGVkIGluc3RlYWQgb2YgTkRFQlVHCisgICAgICAgIHdo ZXJlIGFwcHJvcHJpYXRlIHRvIGF2b2lkICJkZWZpbmVkIGJ1dCBub3QgdXNlZCIgd2FybmluZ3Mu CisKKyAgICAgICAgKiB3dGYvRGF0ZU1hdGguY3BwOgorICAgICAgICAoV1RGOjppbml0aWFsaXpl RGF0ZXMpOgorCiAyMDExLTEyLTIxICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAK ICAgICAgICAgT1MgWCBidWlsZCBmaXggYWZ0ZXIgcjEwMzQ4OC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2NWM0 MDIxMjZhNTg4M2FkYjkzOWI0OWIwZmZlZmQxNjA2ZWI0OWMwLi40NzU0ZTU1M2JiNjFiZTliYzZl MDI5MzFhYTU3Yzc3MTZkZjZiY2JlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEt MTItMjIgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgorCisgICAgICAgIEZp eCBkZWJ1ZyBidWlsZCB3aXRoIGFzc2VydGlvbnMgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1MDc1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgd2hldGhlciBhc3NlcnRpb25zIGFy ZSBkaXNhYmxlZCBpbnN0ZWFkIG9mIE5ERUJVRworICAgICAgICB3aGVyZSBhcHByb3ByaWF0ZSB0 byBhdm9pZCAiZGVmaW5lZCBidXQgbm90IHVzZWQiIHdhcm5pbmdzLgorCisgICAgICAgIE5vIGNo YW5nZSBpbiBiZWhhdmlvdXIgc28gbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogbG9hZGVyL2Nh Y2hlL01lbW9yeUNhY2hlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lbW9yeUNhY2hlOjppbnNl cnRJbkxSVUxpc3QpOgorICAgICAgICAoV2ViQ29yZTo6TWVtb3J5Q2FjaGU6OnJlbW92ZUZyb21M aXZlRGVjb2RlZFJlc291cmNlc0xpc3QpOgorICAgICAgICAoV2ViQ29yZTo6TWVtb3J5Q2FjaGU6 Omluc2VydEluTGl2ZURlY29kZWRSZXNvdXJjZXNMaXN0KToKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmxheW91dEJs b2NrQ2hpbGQpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJMYXllcjo6dXBkYXRlTGF5ZXJQb3NpdGlvbnMpOgorCiAyMDExLTEy LTIyICBQZXRlciBSeWJpbiAgPHBldGVyLnJ5YmluQGdtYWlsLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBDb2RlR2VuZXJhdG9ySW5zcGVjdG9yLnB5OiBnZW5lcmF0ZSBhbm9ueW1vdXMg dHlwZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0RhdGVNYXRoLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvRGF0ZU1hdGguY3BwCmluZGV4IDA0ZmU4MDVh NmI1MDBmYzc2YWI5ZDhkNWJkZmEwZWUyNzIxMjNmZTMuLjliZTM0OGE4NjNiNzNhNjRiZjcxOTYy M2UwMTEzMjlkODJiY2Q0ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYv RGF0ZU1hdGguY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvRGF0ZU1hdGguY3Bw CkBAIC00NDgsNyArNDQ4LDcgQEAgZG91YmxlIGNhbGN1bGF0ZURTVE9mZnNldChkb3VibGUgbXMs IGRvdWJsZSB1dGNPZmZzZXQpCiAKIHZvaWQgaW5pdGlhbGl6ZURhdGVzKCkKIHsKLSNpZm5kZWYg TkRFQlVHCisjaWYgIUFTU0VSVF9ESVNBQkxFRAogICAgIHN0YXRpYyBib29sIGFscmVhZHlJbml0 aWFsaXplZDsKICAgICBBU1NFUlQoIWFscmVhZHlJbml0aWFsaXplZCk7CiAgICAgYWxyZWFkeUlu aXRpYWxpemVkID0gdHJ1ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNo ZS9NZW1vcnlDYWNoZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvTWVtb3J5Q2Fj aGUuY3BwCmluZGV4IDM0NDNlZGFlM2ZiOWVlYTc2ZmFkYzYzN2RiNDg1YTUyYmQyNmYxYzguLjBh YjhhYmYyYzgzZmM4ZjlmODY0OTUxZjc2MmI5OThkZjc3OGU5NWEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9NZW1vcnlDYWNoZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvbG9hZGVyL2NhY2hlL01lbW9yeUNhY2hlLmNwcApAQCAtNDgxLDcgKzQ4MSw3IEBAIHZvaWQg TWVtb3J5Q2FjaGU6Omluc2VydEluTFJVTGlzdChDYWNoZWRSZXNvdXJjZSogcmVzb3VyY2UpCiAg ICAgaWYgKCFyZXNvdXJjZS0+bV9uZXh0SW5BbGxSZXNvdXJjZXNMaXN0KQogICAgICAgICBsaXN0 LT5tX3RhaWwgPSByZXNvdXJjZTsKICAgICAgICAgCi0jaWZuZGVmIE5ERUJVRworI2lmICFBU1NF UlRfRElTQUJMRUQKICAgICAvLyBWZXJpZnkgdGhhdCB3ZSBhcmUgaW4gbm93IGluIHRoZSBsaXN0 IGxpa2Ugd2Ugc2hvdWxkIGJlLgogICAgIGxpc3QgPSBscnVMaXN0Rm9yKHJlc291cmNlKTsKICAg ICBib29sIGZvdW5kID0gZmFsc2U7CkBAIC01NDcsNyArNTQ3LDcgQEAgdm9pZCBNZW1vcnlDYWNo ZTo6cmVtb3ZlRnJvbUxpdmVEZWNvZGVkUmVzb3VyY2VzTGlzdChDYWNoZWRSZXNvdXJjZSogcmVz b3VyY2UpCiAgICAgICAgIHJldHVybjsKICAgICByZXNvdXJjZS0+bV9pbkxpdmVEZWNvZGVkUmVz b3VyY2VzTGlzdCA9IGZhbHNlOwogCi0jaWZuZGVmIE5ERUJVRworI2lmICFBU1NFUlRfRElTQUJM RUQKICAgICAvLyBWZXJpZnkgdGhhdCB3ZSBhcmUgaW4gZmFjdCBpbiB0aGlzIGxpc3QuCiAgICAg Ym9vbCBmb3VuZCA9IGZhbHNlOwogICAgIGZvciAoQ2FjaGVkUmVzb3VyY2UqIGN1cnJlbnQgPSBt X2xpdmVEZWNvZGVkUmVzb3VyY2VzLm1faGVhZDsgY3VycmVudDsgY3VycmVudCA9IGN1cnJlbnQt Pm1fbmV4dEluTGl2ZVJlc291cmNlc0xpc3QpIHsKQEAgLTU5Myw3ICs1OTMsNyBAQCB2b2lkIE1l bW9yeUNhY2hlOjppbnNlcnRJbkxpdmVEZWNvZGVkUmVzb3VyY2VzTGlzdChDYWNoZWRSZXNvdXJj ZSogcmVzb3VyY2UpCiAgICAgaWYgKCFyZXNvdXJjZS0+bV9uZXh0SW5MaXZlUmVzb3VyY2VzTGlz dCkKICAgICAgICAgbV9saXZlRGVjb2RlZFJlc291cmNlcy5tX3RhaWwgPSByZXNvdXJjZTsKICAg ICAgICAgCi0jaWZuZGVmIE5ERUJVRworI2lmICFBU1NFUlRfRElTQUJMRUQKICAgICAvLyBWZXJp ZnkgdGhhdCB3ZSBhcmUgaW4gbm93IGluIHRoZSBsaXN0IGxpa2Ugd2Ugc2hvdWxkIGJlLgogICAg IGJvb2wgZm91bmQgPSBmYWxzZTsKICAgICBmb3IgKENhY2hlZFJlc291cmNlKiBjdXJyZW50ID0g bV9saXZlRGVjb2RlZFJlc291cmNlcy5tX2hlYWQ7IGN1cnJlbnQ7IGN1cnJlbnQgPSBjdXJyZW50 LT5tX25leHRJbkxpdmVSZXNvdXJjZXNMaXN0KSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckJsb2NrLmNwcAppbmRleCBhZWFiZTFlNmEwODExY2UyYmQwZmRkYzExYWRmNmJiYTg1MTlh ZWUyLi43YmE2YzZhNjAwNWM0NDNhOWZiMWE0M2YxNThhNTliYzQ5ZWQ3ZWMxIDEwMDc1NQotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKQEAgLTIwNDMsNyArMjA0Myw3IEBAIHZv aWQgUmVuZGVyQmxvY2s6OmxheW91dEJsb2NrQ2hpbGQoUmVuZGVyQm94KiBjaGlsZCwgTWFyZ2lu SW5mbyYgbWFyZ2luSW5mbywgTGF5CiAgICAgTGF5b3V0UmVjdCBvbGRSZWN0KGNoaWxkLT54KCks IGNoaWxkLT55KCkgLCBjaGlsZC0+d2lkdGgoKSwgY2hpbGQtPmhlaWdodCgpKTsKICAgICBMYXlv dXRVbml0IG9sZExvZ2ljYWxUb3AgPSBsb2dpY2FsVG9wRm9yQ2hpbGQoY2hpbGQpOwogCi0jaWZu ZGVmIE5ERUJVRworI2lmICFBU1NFUlRfRElTQUJMRUQKICAgICBMYXlvdXRTaXplIG9sZExheW91 dERlbHRhID0gdmlldygpLT5sYXlvdXREZWx0YSgpOwogI2VuZGlmCiAgICAgLy8gR28gYWhlYWQg YW5kIHBvc2l0aW9uIHRoZSBjaGlsZCBhcyB0aG91Z2ggaXQgZGlkbid0IGNvbGxhcHNlIHdpdGgg dGhlIHRvcC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IGFi ODljZWVmNGJmYWE4M2Y4ZmIwZWFjNmViYzc5NDIxMmZhNDQ4N2YuLmQ1NWNhOWRkZTM0YWI0ZGUz MjI2NzYyZmQ2MTE2NTBjYTZjNDZjZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyLmNwcApAQCAtMzEwLDcgKzMxMCw3IEBAIExheW91dFBvaW50IFJlbmRlckxheWVyOjpj b21wdXRlT2Zmc2V0RnJvbVJvb3QoYm9vbCYgaGFzTGF5ZXJPZmZzZXQpIGNvbnN0CiAKIHZvaWQg UmVuZGVyTGF5ZXI6OnVwZGF0ZUxheWVyUG9zaXRpb25zKExheW91dFBvaW50KiBvZmZzZXRGcm9t Um9vdCwgVXBkYXRlTGF5ZXJQb3NpdGlvbnNGbGFncyBmbGFncykKIHsKLSNpZm5kZWYgTkRFQlVH CisjaWYgIUFTU0VSVF9ESVNBQkxFRAogICAgIGlmIChvZmZzZXRGcm9tUm9vdCkgewogICAgICAg ICBib29sIGhhc0xheWVyT2Zmc2V0OwogICAgICAgICBMYXlvdXRQb2ludCBjb21wdXRlZE9mZnNl dEZyb21Sb290ID0gY29tcHV0ZU9mZnNldEZyb21Sb290KGhhc0xheWVyT2Zmc2V0KTsK