75073 2011-12-22 01:33:30 -0800 [EFL] Remove duplicate code and remove entry after freeing the matrix. 2011-12-27 21:14:17 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 jungjik.lee webkit-unassigned gyuyoung.kim gyuyoung.kim hyuki.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 526096 0 jungjik.lee 2011-12-22 01:33:30 -0800 Remove duplicate ewk_tile_unused_cache_freeze call and reorder function call. eina_matrixsparse_free(entry->matrix) should be called before removing the entry from inlist. Because entry count is decreased after calling eina_matrixsparce_free in _ewk_tile_matrix_cell_free. 526098 1 120288 jungjik.lee 2011-12-22 01:36:25 -0800 Created attachment 120288 proposal patch Proposal patch 526111 2 120288 gyuyoung.kim 2011-12-22 02:27:26 -0800 Comment on attachment 120288 proposal patch LGTM. But, please use C++ type casting instead of C casting. For example, static_cast<Eina_Inlist*> 526132 3 jungjik.lee 2011-12-22 02:49:49 -0800 (In reply to comment #2) > (From update of attachment 120288 [details]) > LGTM. But, please use C++ type casting instead of C casting. For example, static_cast<Eina_Inlist*> I've tried to change it to C++ style, but it can not be compiled. 526149 4 gyuyoung.kim 2011-12-22 03:21:36 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 120288 [details] [details]) > > LGTM. But, please use C++ type casting instead of C casting. For example, static_cast<Eina_Inlist*> > > I've tried to change it to C++ style, but it can not be compiled. I succeed to build using "reinterpret_cast<Eina_Inlist*>(entry)" 526157 5 120303 jungjik.lee 2011-12-22 03:32:01 -0800 Created attachment 120303 fix type cast fix C++ style type cast. 526159 6 jungjik.lee 2011-12-22 03:32:46 -0800 (In reply to comment #5) > Created an attachment (id=120303) [details] > fix type cast > > fix C++ style type cast. reinterpret_cast works. good! 526160 7 120288 gyuyoung.kim 2011-12-22 03:35:07 -0800 Comment on attachment 120288 proposal patch If you submit new patch, please set obsolete to previous patch. 526698 8 120303 gyuyoung.kim 2011-12-22 19:25:36 -0800 Comment on attachment 120303 fix type cast Informal r+ on my side. 527250 9 hyuki.kim 2011-12-26 18:00:14 -0800 LGTM too. This patch seems to fix below error message. ERR<32424>:Ewk_Tiled_Backing_Store /home/hyuki/webkit/WebKit/Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp:116 527548 10 120303 webkit.review.bot 2011-12-27 21:14:12 -0800 Comment on attachment 120303 fix type cast Clearing flags on attachment: 120303 Committed r103756: <http://trac.webkit.org/changeset/103756> 527549 11 webkit.review.bot 2011-12-27 21:14:17 -0800 All reviewed patches have been landed. Closing bug. 120288 2011-12-22 01:36:25 -0800 2011-12-22 03:35:07 -0800 proposal patch proposal.patch text/plain 1775 jungjik.lee ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBjNGQ0ZmM2Li5hNjY2NDQ1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMTItMjEgIEp1bmdKaWsgTGVlICA8anVuZ2ppay5sZWVAc2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUmVtb3ZlIGR1cGxpY2F0ZSBjb2RlIGFuZCByZW1v dmUgZW50cnkgYWZ0ZXIgZnJlZWluZyB0aGUgbWF0cml4LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzUwNzMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgZHVwbGljYXRlIGV3a190aWxlX3VudXNl ZF9jYWNoZV9mcmVlemUgY29kZS4KKyAgICAgICAgRW50cnkgbWF0cml4IHNob3VsZCBmcmVlIGZp cnN0IGJlZm9yZSByZW1vdmluZyBlbnRyeSBpbiBpbmxpc3QsCisgICAgICAgIGJlY2F1c2UgaW4g ZWluYV9tYXRyaXhzcGFyY2VfZnJlZSBjYWxsYmFjayBlbnRyeSBwb2ludGVyIGlzIHJlZmVyZW5j ZWQgdG8gZGVjcmVhc2UgdGhlIHJlZmVyZW5jZSBjb3VudC4KKworICAgICAgICAqIGV3ay9ld2tf dGlsZWRfbWF0cml4LmNwcDoKKyAgICAgICAgKGV3a190aWxlX21hdHJpeF9mcmVlKToKKwogMjAx MS0xMi0yMSAgTWljaGHFgiBQYWt1xYJhIHZlbCBSdXRrYSAgPG0ucGFrdWxhQHNhbXN1bmcuY29t PgogCiAgICAgICAgIFtFRkxdIEFkZCAnU2VsZWN0IEFsbCcgb3B0aW9uIHRvIGNvbnRleHQgbWVu dXMgaW4gV2ViS2l0LUVGTC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf dGlsZWRfbWF0cml4LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbWF0cml4 LmNwcAppbmRleCA2OTIzNmI1Li43MTQ2OGRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Vm bC9ld2svZXdrX3RpbGVkX21hdHJpeC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a190aWxlZF9tYXRyaXguY3BwCkBAIC0yOTcsMTMgKzI5NywxMiBAQCB2b2lkIGV3a190aWxlX21h dHJpeF9mcmVlKEV3a19UaWxlX01hdHJpeCogdGlsZU1hdHJpeCkKICNlbmRpZgogCiAgICAgRUlO QV9TQUZFVFlfT05fTlVMTF9SRVRVUk4odGlsZU1hdHJpeCk7Ci0gICAgZXdrX3RpbGVfdW51c2Vk X2NhY2hlX2ZyZWV6ZSh0aWxlTWF0cml4LT50aWxpZVVudXNlZENhY2hlKTsKIAogICAgIGV3a190 aWxlX3VudXNlZF9jYWNoZV9mcmVlemUodGlsZU1hdHJpeC0+dGlsaWVVbnVzZWRDYWNoZSk7CiAg ICAgZXdrX3RpbGVfbWF0cml4X2ludmFsaWRhdGUodGlsZU1hdHJpeCk7CiAgICAgZW50cnkgPSBF SU5BX0lOTElTVF9DT05UQUlORVJfR0VUKHRpbGVNYXRyaXgtPm1hdHJpY2VzLCBFd2tfVGlsZV9N YXRyaXhfRW50cnkpOwotICAgIHRpbGVNYXRyaXgtPm1hdHJpY2VzID0gZWluYV9pbmxpc3RfcmVt b3ZlKHRpbGVNYXRyaXgtPm1hdHJpY2VzLCAoRWluYV9Jbmxpc3QgKillbnRyeSk7CiAgICAgZWlu YV9tYXRyaXhzcGFyc2VfZnJlZShlbnRyeS0+bWF0cml4KTsKKyAgICB0aWxlTWF0cml4LT5tYXRy aWNlcyA9IGVpbmFfaW5saXN0X3JlbW92ZSh0aWxlTWF0cml4LT5tYXRyaWNlcywgKEVpbmFfSW5s aXN0ICopZW50cnkpOwogICAgIGZyZWUoZW50cnkpOwogICAgIHRpbGVNYXRyaXgtPm1hdHJpY2Vz ID0gMDsKIAo= 120303 2011-12-22 03:32:01 -0800 2011-12-27 21:14:12 -0800 fix type cast second.patch text/plain 1792 jungjik.lee ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBjNGQ0ZmM2Li5hNjY2NDQ1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMTItMjEgIEp1bmdKaWsgTGVlICA8anVuZ2ppay5sZWVAc2Ft c3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gUmVtb3ZlIGR1cGxpY2F0ZSBjb2RlIGFuZCByZW1v dmUgZW50cnkgYWZ0ZXIgZnJlZWluZyB0aGUgbWF0cml4LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzUwNzMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgZHVwbGljYXRlIGV3a190aWxlX3VudXNl ZF9jYWNoZV9mcmVlemUgY29kZS4KKyAgICAgICAgRW50cnkgbWF0cml4IHNob3VsZCBmcmVlIGZp cnN0IGJlZm9yZSByZW1vdmluZyBlbnRyeSBpbiBpbmxpc3QsCisgICAgICAgIGJlY2F1c2UgaW4g ZWluYV9tYXRyaXhzcGFyY2VfZnJlZSBjYWxsYmFjayBlbnRyeSBwb2ludGVyIGlzIHJlZmVyZW5j ZWQgdG8gZGVjcmVhc2UgdGhlIHJlZmVyZW5jZSBjb3VudC4KKworICAgICAgICAqIGV3ay9ld2tf dGlsZWRfbWF0cml4LmNwcDoKKyAgICAgICAgKGV3a190aWxlX21hdHJpeF9mcmVlKToKKwogMjAx MS0xMi0yMSAgTWljaGHFgiBQYWt1xYJhIHZlbCBSdXRrYSAgPG0ucGFrdWxhQHNhbXN1bmcuY29t PgogCiAgICAgICAgIFtFRkxdIEFkZCAnU2VsZWN0IEFsbCcgb3B0aW9uIHRvIGNvbnRleHQgbWVu dXMgaW4gV2ViS2l0LUVGTC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf dGlsZWRfbWF0cml4LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbWF0cml4 LmNwcAppbmRleCA2OTIzNmI1Li40M2U3Njc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Vm bC9ld2svZXdrX3RpbGVkX21hdHJpeC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a190aWxlZF9tYXRyaXguY3BwCkBAIC0yOTcsMTMgKzI5NywxMiBAQCB2b2lkIGV3a190aWxlX21h dHJpeF9mcmVlKEV3a19UaWxlX01hdHJpeCogdGlsZU1hdHJpeCkKICNlbmRpZgogCiAgICAgRUlO QV9TQUZFVFlfT05fTlVMTF9SRVRVUk4odGlsZU1hdHJpeCk7Ci0gICAgZXdrX3RpbGVfdW51c2Vk X2NhY2hlX2ZyZWV6ZSh0aWxlTWF0cml4LT50aWxpZVVudXNlZENhY2hlKTsKIAogICAgIGV3a190 aWxlX3VudXNlZF9jYWNoZV9mcmVlemUodGlsZU1hdHJpeC0+dGlsaWVVbnVzZWRDYWNoZSk7CiAg ICAgZXdrX3RpbGVfbWF0cml4X2ludmFsaWRhdGUodGlsZU1hdHJpeCk7CiAgICAgZW50cnkgPSBF SU5BX0lOTElTVF9DT05UQUlORVJfR0VUKHRpbGVNYXRyaXgtPm1hdHJpY2VzLCBFd2tfVGlsZV9N YXRyaXhfRW50cnkpOwotICAgIHRpbGVNYXRyaXgtPm1hdHJpY2VzID0gZWluYV9pbmxpc3RfcmVt b3ZlKHRpbGVNYXRyaXgtPm1hdHJpY2VzLCAoRWluYV9Jbmxpc3QgKillbnRyeSk7CiAgICAgZWlu YV9tYXRyaXhzcGFyc2VfZnJlZShlbnRyeS0+bWF0cml4KTsKKyAgICB0aWxlTWF0cml4LT5tYXRy aWNlcyA9IGVpbmFfaW5saXN0X3JlbW92ZSh0aWxlTWF0cml4LT5tYXRyaWNlcywgcmVpbnRlcnBy ZXRfY2FzdDxFaW5hX0lubGlzdCo+KGVudHJ5KSk7CiAgICAgZnJlZShlbnRyeSk7CiAgICAgdGls ZU1hdHJpeC0+bWF0cmljZXMgPSAwOwogCg==