75064 2011-12-21 21:47:58 -0800 TestWebKitAPI: initialize the main thread before running tests 2012-01-04 11:26:25 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 ddkilzer ddkilzer aroben sam webkit.review.bot oldest_to_newest 525991 0 ddkilzer 2011-12-21 21:47:58 -0800 Currently TestWebKitAPI doesn't initialize the main thread before running any tests. This can lead to assertion failures in Debug builds when calling (for example) WebCore::UTF8Encoding() in a test. 525996 1 120271 ddkilzer 2011-12-21 21:55:10 -0800 Created attachment 120271 Patch v1 526017 2 ddkilzer 2011-12-21 22:27:31 -0800 Here's an example stack trace of such a crash: Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x00000000bbadbeef VM Regions Near 0xbbadbeef: --> __TEXT 0000000105fe7000-00000001060fd000 [ 1112K] r-x/rwx SM=COW /Volumes/VOLUME/* Application Specific Information: objc[49579]: garbage collection is OFF Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x000000010792e203 WTF::isMainThread() + 195 (MainThreadMac.mm:144) 1 com.apple.WebCore 0x00000001098a3efd _ZN7WebCoreL22buildBaseTextCodecMapsEv + 13 (TextEncodingRegistry.cpp:213) 2 com.apple.WebCore 0x00000001098a3e2a WebCore::atomicCanonicalTextEncodingName(char const*) + 74 (TextEncodingRegistry.cpp:338) 3 com.apple.WebCore 0x00000001098a2c21 WebCore::TextEncoding::TextEncoding(char const*) + 33 (TextEncoding.cpp:55) 4 com.apple.WebCore 0x00000001098a2bed WebCore::TextEncoding::TextEncoding(char const*) + 29 (TextEncoding.cpp:58) 5 com.apple.WebCore 0x00000001098a3598 WebCore::UTF8Encoding() + 40 (TextEncoding.cpp:250) 6 com.apple.WebCore 0x000000010928e7b4 WebCore::decodeURLEscapeSequences(WTF::String const&) + 36 (KURL.cpp:919) 7 com.apple.WebCore 0x000000010928e77a WebCore::KURL::host() const + 90 (KURL.cpp:586) 8 TestWebKitAPI 0x0000000106073fbf TestWebKitAPI::WebCore_KURLConstCharConstructor_Test::TestBody() + 2015 (KURL.cpp:54) 9 TestWebKitAPI 0x000000010607e7ca testing::Test::Run() + 154 10 TestWebKitAPI 0x000000010607f0cd testing::internal::TestInfoImpl::Run() + 189 11 TestWebKitAPI 0x000000010607f8fd testing::TestCase::Run() + 205 12 TestWebKitAPI 0x00000001060849e9 testing::internal::UnitTestImpl::RunAllTests() + 793 13 TestWebKitAPI 0x00000001060846c9 testing::UnitTest::Run() + 25 14 TestWebKitAPI 0x0000000105fe9870 TestWebKitAPI::TestsController::run(int, char**) + 48 (TestsController.cpp:51) 15 TestWebKitAPI 0x0000000105fe96e9 main + 121 (main.mm:35) 16 TestWebKitAPI 0x0000000105fe8ca4 start + 52 526275 3 120271 webkit.review.bot 2011-12-22 08:41:42 -0800 Comment on attachment 120271 Patch v1 Clearing flags on attachment: 120271 Committed r103546: <http://trac.webkit.org/changeset/103546> 526276 4 webkit.review.bot 2011-12-22 08:41:46 -0800 All reviewed patches have been landed. Closing bug. 527073 5 sam 2011-12-25 12:31:38 -0800 I am not sure I like this solution. Since one of the goals of this test runner is to test that the API works (and you wouldn't use this internal method when using API) this won't be testing if we forget to initialize threading for some API calls. Perhaps we can install some sort of helper for WebCore / JavaScriptCore internals tests that does the initialization only for them. 529616 6 ddkilzer 2012-01-04 11:02:01 -0800 (In reply to comment #5) > I am not sure I like this solution. Since one of the goals of this test runner is to test that the API works (and you wouldn't use this internal method when using API) this won't be testing if we forget to initialize threading for some API calls. > > Perhaps we can install some sort of helper for WebCore / JavaScriptCore internals tests that does the initialization only for them. That's a great point. I will back out this change and use a setup/helper function for the WebCore tests I'm writing. 529635 7 ddkilzer 2012-01-04 11:26:25 -0800 (In reply to comment #6) > (In reply to comment #5) > > I am not sure I like this solution. Since one of the goals of this test runner is to test that the API works (and you wouldn't use this internal method when using API) this won't be testing if we forget to initialize threading for some API calls. > > > > Perhaps we can install some sort of helper for WebCore / JavaScriptCore internals tests that does the initialization only for them. > > That's a great point. I will back out this change and use a setup/helper function for the WebCore tests I'm writing. Backed out in r104050: <http://trac.webkit.org/changeset/104050> Marking this bug as RESOLVED/WONTFIX. 120271 2011-12-21 21:55:10 -0800 2011-12-22 08:41:42 -0800 Patch v1 bug-75064-20111221215509.patch text/plain 1592 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyMzQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGY3M2Q2MDM2MDkwYjExNjE5YmZiZDY4MWE4YWM5ODc2 ZTAxYWE1Zi4uZDE5MGZmNzQ2ZjJhZmExODk2MzBlZDFmMTZjMzI4OTIyODlkZmUzNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDExLTEyLTIxICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgVGVzdFdlYktpdEFQSTogaW5pdGlhbGl6ZSB0aGUgbWFpbiB0aHJlYWQgYmVmb3JlIHJ1 bm5pbmcgdGVzdHMKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvNzUwNjQ+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJ L1Rlc3RzQ29udHJvbGxlci5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpUZXN0c0NvbnRy b2xsZXI6OlRlc3RzQ29udHJvbGxlcik6IENhbGwKKyAgICAgICAgV1RGOjppbml0aWFsaXplTWFp blRocmVhZCgpIHRvIHByZXZlbnQgYXNzZXJ0aW9ucyBpbiBEZWJ1ZworICAgICAgICBidWlsZHMu CisKIDIwMTEtMTItMDggIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29t PgogCiAgICAgICAgIFtRdF0gV2ViS2l0VGVzdFJ1bm5lciBjcmFzaGVzIHdpdGggZGVidWcgYnVp bGRzCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzQ29udHJvbGxlci5jcHAg Yi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzQ29udHJvbGxlci5jcHAKaW5kZXggMjlkY2M3MTRl M2UyYWNjYTBlZjJjM2Q4M2FkZmM4ZjA0ZDU2NGNmMS4uOTU1ODM4ZmI5ZDM5ODE1ZGVmODMxOTBh YmExYzg1M2ZiNmFlM2IyNyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0c0Nv bnRyb2xsZXIuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHNDb250cm9sbGVyLmNw cApAQCAtMjYsNiArMjYsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlRlc3Rz Q29udHJvbGxlci5oIgogCisjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4KICNpbmNsdWRlIDx3 dGYvVGhyZWFkaW5nLmg+CiAKIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJIHsKQEAgLTM4LDYgKzM5 LDggQEAgVGVzdHNDb250cm9sbGVyJiBUZXN0c0NvbnRyb2xsZXI6OnNoYXJlZCgpCiAKIFRlc3Rz Q29udHJvbGxlcjo6VGVzdHNDb250cm9sbGVyKCkKIHsKKyAgICBXVEY6OmluaXRpYWxpemVNYWlu VGhyZWFkKCk7CisKICAgICAvLyBGSVhNRTogV2UgY3VycmVudGx5IGluaXRpYWxpemUgdGhyZWFk aW5nIGhlcmUgdG8gYXZvaWQgYXNzZXJ0aW9uIGZhaWx1cmVzIGZyb20KICAgICAvLyB0aGUgVGhy ZWFkUmVzdHJpY3Rpb25WZXJpZmllciAtIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02NjExMgogICAgIC8vIFdlIHNob3VsZCBtYWtlIHN1cmUgdGhhdCBhbGwgb2JqZWN0 cyB0ZXN0ZWQgZWl0aGVyIGluaXRpYWxpemUgdGhyZWFkaW5nIG9yIGluaGVyaXQgZnJvbQo=