75052 2011-12-21 16:20:23 -0800 AX: aria-describedby should not be part of AXDescription (should be a part of AXHelp) 2011-12-22 09:04:46 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach bdakin webkit.review.bot oldest_to_newest 525791 0 cfleizach 2011-12-21 16:20:23 -0800 aria-describedby is said to provide "extra detail" about an object and is related to help or hints. It is certainly not meant to be used as part of the AXDescription. I think it should be combined into helpText() http://www.w3.org/TR/wai-aria/states_and_properties#aria-describedby 525804 1 cfleizach 2011-12-21 16:24:54 -0800 rdar://10616042 525818 2 120238 cfleizach 2011-12-21 16:31:09 -0800 Created attachment 120238 patch 525823 3 webkit.review.bot 2011-12-21 16:34:23 -0800 Attachment 120238 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Inform the scrolling coordinator when scrollbar layers come and go Using index info to reconstruct a base tree... <stdin>:474806: trailing whitespace. [Chromium] DatabaseTrackerChromium: iterating DatabaseSet races with Database disposal on worker thread <stdin>:474827: trailing whitespace. Nothing to test, just removing redundant code. Correct behavior tested by <stdin>:475346: trailing whitespace. warning: 3 lines add whitespace errors. Falling back to patching base and 3-way merge... warning: too many files (created: 167519 deleted: 3), skipping inexact rename detection Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/chromium/test_expectations.txt CONFLICT (content): Merge conflict in LayoutTests/platform/chromium/test_expectations.txt Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Auto-merging Source/WebCore/page/ScrollingCoordinator.h CONFLICT (content): Merge conflict in Source/WebCore/page/ScrollingCoordinator.h Auto-merging Source/WebCore/page/mac/ScrollingCoordinatorMac.mm CONFLICT (content): Merge conflict in Source/WebCore/page/mac/ScrollingCoordinatorMac.mm Auto-merging Source/WebCore/platform/ScrollView.cpp Auto-merging Source/WebCore/rendering/RenderLayerCompositor.cpp CONFLICT (content): Merge conflict in Source/WebCore/rendering/RenderLayerCompositor.cpp Auto-merging Source/WebKit2/ChangeLog CONFLICT (content): Merge conflict in Source/WebKit2/ChangeLog Auto-merging Tools/ChangeLog CONFLICT (content): Merge conflict in Tools/ChangeLog Auto-merging Tools/Scripts/build-webkit Auto-merging Tools/Scripts/webkitdirs.pm CONFLICT (content): Merge conflict in Tools/Scripts/webkitdirs.pm Failed to merge in the changes. Patch failed at 0001 Inform the scrolling coordinator when scrollbar layers come and go When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 158. If any of these errors are false positives, please file a bug against check-webkit-style. 526293 4 cfleizach 2011-12-22 09:04:46 -0800 http://trac.webkit.org/changeset/103548 120238 2011-12-21 16:31:09 -0800 2011-12-21 17:37:47 -0800 patch patch.txt text/plain 4233 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzQ3MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDExLTEyLTIxICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IGFyaWEtZGVzY3Jp YmVkYnkgc2hvdWxkIG5vdCBiZSBwYXJ0IG9mIEFYRGVzY3JpcHRpb24gKHNob3VsZCBiZSBhIHBh cnQgb2YgQVhIZWxwKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzUwNTIKKworICAgICAgICBBY2NvcmRpbmcgdG8gdGhlIEFSSUEgc3BlYywgYXJpYS1k ZXNjcmliZWRieSBpcyBhIG1vcmUgZGV0YWlsZWQgZGVzY3JpcHRpb24gdGhhdCBpcyBha2luIHRv IGhlbHAsIHJhdGhlcgorICAgICAgICB0aGFuIGEgZGVzY3JpcHRpb24gZGVzY3JpYmluZyB0aGUg YWN0dWFsIG9iamVjdC4KKworICAgICAgICBBcyBzdWNoLCBpdCBtYWtlcyBtb3JlIHNlbnNlIGZv ciB0aGlzIGF0dHJpYnV0ZSB0byBiZSBleHBvc2VkIHVuZGVyIGhlbHAgdGV4dC4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0OjpoZWxwVGV4dCk6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0OjphcmlhQWNjZXNzaWJpbGl0eURlc2NyaXB0aW9uKToKKwogMjAx MS0xMi0yMSAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQXV0 b21hdGUgZWxlbWVudHMnIHJlZ2lzdHJhdGlvbiBhcyBkb2N1bWVudCBuYW1lZEl0ZW0vZXh0cmFO YW1lZEl0ZW0uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlSZW5kZXJPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAJKHJldmlzaW9uIDEwMzQ2NykKKysr IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTk5NSw2ICs5OTUsMTAgQEAKICAgICBpZiAoIWFyaWFIZWxw LmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIGFyaWFIZWxwOwogICAgIAorICAgIFN0cmluZyBk ZXNjcmliZWRCeSA9IGFyaWFEZXNjcmliZWRCeUF0dHJpYnV0ZSgpOworICAgIGlmICghZGVzY3Jp YmVkQnkuaXNFbXB0eSgpKQorICAgICAgICByZXR1cm4gZGVzY3JpYmVkQnk7CisgICAgCiAgICAg Zm9yIChSZW5kZXJPYmplY3QqIGN1cnIgPSBtX3JlbmRlcmVyOyBjdXJyOyBjdXJyID0gY3Vyci0+ cGFyZW50KCkpIHsKICAgICAgICAgaWYgKGN1cnItPm5vZGUoKSAmJiBjdXJyLT5ub2RlKCktPmlz SFRNTEVsZW1lbnQoKSkgewogICAgICAgICAgICAgY29uc3QgQXRvbWljU3RyaW5nJiBzdW1tYXJ5 ID0gc3RhdGljX2Nhc3Q8RWxlbWVudCo+KGN1cnItPm5vZGUoKSktPmdldEF0dHJpYnV0ZShzdW1t YXJ5QXR0cik7CkBAIC0xMzgwLDEwICsxMzg0LDYgQEAKICAgICBpZiAoIWFyaWFMYWJlbC5pc0Vt cHR5KCkpCiAgICAgICAgIHJldHVybiBhcmlhTGFiZWw7CiAgICAgCi0gICAgU3RyaW5nIGFyaWFE ZXNjcmlwdGlvbiA9IGFyaWFEZXNjcmliZWRCeUF0dHJpYnV0ZSgpOwotICAgIGlmICghYXJpYURl c2NyaXB0aW9uLmlzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuIGFyaWFEZXNjcmlwdGlvbjsKLSAg ICAKICAgICByZXR1cm4gU3RyaW5nKCk7CiB9CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzQ3MykK KysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDExLTEyLTIxICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAg ICAgICAgQVg6IGFyaWEtZGVzY3JpYmVkYnkgc2hvdWxkIG5vdCBiZSBwYXJ0IG9mIEFYRGVzY3Jp cHRpb24gKHNob3VsZCBiZSBhIHBhcnQgb2YgQVhIZWxwKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzUwNTIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXJpYS1kZXNjcmliZWRi eS1vbi1pbnB1dC5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2Fy aWEtZGVzY3JpYmVkYnktb24taW5wdXQtZXhwZWN0ZWQudHh0OgorCiAyMDExLTEyLTIxICBTY290 dCBGcmFua2xpbiAgPHNjb3R0ZnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBF cmljIENhcmxzb24uCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2FyaWEtZGVzY3Jp YmVkYnktb24taW5wdXQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmls aXR5L2FyaWEtZGVzY3JpYmVkYnktb24taW5wdXQuaHRtbAkocmV2aXNpb24gMTAzNDY3KQorKysg TGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9hcmlhLWRlc2NyaWJlZGJ5LW9uLWlucHV0Lmh0bWwJ KHdvcmtpbmcgY29weSkKQEAgLTE1LDcgKzE1LDcgQEAKICAgICAgICAgICAgIHZhciBsYWJlbGVk SXRlbSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0aW1lIik7CiAgICAgICAgICAgICBsYWJl bGVkSXRlbS5mb2N1cygpOwogICAgICAgICAgICAgdmFyIHJlc3VsdCA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJyZXN1bHQiKTsKLSAgICAgICAgICAgIHJlc3VsdC5pbm5lclRleHQgPSAiXG5U aGUgYWNjZXNzaWJpbGl0eSBkZXNjcmlwdGlvbiBpcyBcIiIgKyBhY2Nlc3NpYmlsaXR5Q29udHJv bGxlci5mb2N1c2VkRWxlbWVudC5kZXNjcmlwdGlvbiArICJcIiI7CisgICAgICAgICAgICByZXN1 bHQuaW5uZXJUZXh0ID0gIlxuVGhlIGFjY2Vzc2liaWxpdHkgZGVzY3JpcHRpb24gaXMgXCIiICsg YWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQuaGVscFRleHQgKyAiXCIiOwog ICAgICAgICB9CiAgICAgPC9zY3JpcHQ+CiA8L2JvZHk+CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9hcmlhLWRlc2NyaWJlZGJ5LW9uLWlucHV0LWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0 eS9hcmlhLWRlc2NyaWJlZGJ5LW9uLWlucHV0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTAzNDY3 KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvYXJpYS1kZXNjcmli ZWRieS1vbi1pbnB1dC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw0IEBA CiBUaGlzIGNvbXB1dGVyIHdpbGwgc2VsZi1kZXN0cnVjdCBpbiAgIG1pbnV0ZXMuCiBBbGxvd3Mg eW91IHRvIHNwZWNpZnkgdGhlIG51bWJlciBvZiBtaW51dGVzIGFmdGVyIHdoaWNoIHRoZSBjb21w dXRlciB3aWxsIHNlbGYtZGVzdHJ1Y3QuCiAKLVRoZSBhY2Nlc3NpYmlsaXR5IGRlc2NyaXB0aW9u IGlzICJBWERlc2NyaXB0aW9uOiBBbGxvd3MgeW91IHRvIHNwZWNpZnkgdGhlIG51bWJlciBvZiBt aW51dGVzIGFmdGVyIHdoaWNoIHRoZSBjb21wdXRlciB3aWxsIHNlbGYtZGVzdHJ1Y3QuIgorVGhl IGFjY2Vzc2liaWxpdHkgZGVzY3JpcHRpb24gaXMgIkFYSGVscDogQWxsb3dzIHlvdSB0byBzcGVj aWZ5IHRoZSBudW1iZXIgb2YgbWludXRlcyBhZnRlciB3aGljaCB0aGUgY29tcHV0ZXIgd2lsbCBz ZWxmLWRlc3RydWN0LiIK