75025 2011-12-21 12:00:03 -0800 ManualTests HTML template should be simplified 2011-12-22 02:24:02 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jalkut webkit-unassigned abarth ap darin ojan rniwa webkit.review.bot oldest_to_newest 525423 0 jalkut 2011-12-21 12:00:03 -0800 During review for my patch in bug 74775, Ryosuke Niwa suggested some edits to the ManualTests HTML, which had originated in template.html. https://bugs.webkit.org/show_bug.cgi?id=74775#c9 Specifically, to use an HTML5 style doctype and opening block, and to remove the empty head section. 525426 1 120208 jalkut 2011-12-21 12:01:41 -0800 Created attachment 120208 Patch for the recommended changes to the template file 525434 2 rniwa 2011-12-21 12:04:44 -0800 Could you set r? and cq? flags? They indicate that the patch is up for review and you want it be landed respectively. 525451 3 jalkut 2011-12-21 12:15:32 -0800 (In reply to comment #2) > Could you set r? and cq? flags? They indicate that the patch is up for review and you want it be landed respectively. To set those flags after the fact do I essentially have to re-attach and obsolete? 525453 4 120208 jalkut 2011-12-21 12:16:11 -0800 Comment on attachment 120208 Patch for the recommended changes to the template file Add review and commit-queue flags 526109 5 120208 webkit.review.bot 2011-12-22 02:23:58 -0800 Comment on attachment 120208 Patch for the recommended changes to the template file Clearing flags on attachment: 120208 Committed r103508: <http://trac.webkit.org/changeset/103508> 526110 6 webkit.review.bot 2011-12-22 02:24:02 -0800 All reviewed patches have been landed. Closing bug. 120208 2011-12-21 12:01:41 -0800 2011-12-22 02:23:58 -0800 Patch for the recommended changes to the template file SimplifyTemplate.patch text/plain 979 jalkut SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzQy NikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDExLTEy LTIxICBEYW5pZWwgSmFsa3V0ICA8amFsa3V0QHJlZC1zd2VhdGVyLmNvbT4KKworICAgICAgICBN YW51YWxUZXN0cyBIVE1MIHRlbXBsYXRlIHNob3VsZCBiZSBzaW1wbGlmaWVkCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NTAyNQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTWFudWFsVGVzdHMvdGVtcGxh dGUuaHRtbDoKKwogMjAxMS0xMi0yMSAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgQWRkIENNYWtlIG9wdGlvbiB0byBvbmx5IGJ1aWxkIEphdmFTY3JpcHRDb3Jl CkluZGV4OiBNYW51YWxUZXN0cy90ZW1wbGF0ZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIE1hbnVhbFRl c3RzL3RlbXBsYXRlLmh0bWwJKHJldmlzaW9uIDEwMzQyNikKKysrIE1hbnVhbFRlc3RzL3RlbXBs YXRlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTEsOCArMSw1IEBACi08IURPQ1RZUEUgSFRNTCBQ VUJMSUMgIi0vL1czQy8vRFREIEhUTUwgNC4wMS8vRU4iCi0gICAgICAgICJodHRwOi8vd3d3Lncz Lm9yZy9UUi9odG1sNC9zdHJpY3QuZHRkIj4KLTxodG1sIGxhbmc9ImVuIj4KLTxoZWFkPgotPC9o ZWFkPgorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KIDxib2R5PgogPHA+PGI+QlVHIElEOjwvYj4g PGEgaHJlZj0iQnVnIFVSTCBIZXJlIj5CdWcgSUQgTnVtYmVyIEhlcmU8L2E+IEJ1ZyBUaXRsZSBI ZXJlPC9wPgogCg==