75018 2011-12-21 11:20:17 -0800 Don't recreate scrollbar layers whenever the frame view size changes 2012-01-05 10:53:44 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72078 1 andersca andersca enne jamesr rniwa simon.fraser webkit.review.bot oldest_to_newest 525363 0 andersca 2011-12-21 11:20:17 -0800 Don't recreate scrollbar layers whenever the frame view size changes 525371 1 120197 andersca 2011-12-21 11:24:56 -0800 Created attachment 120197 Patch 525376 2 webkit.review.bot 2011-12-21 11:25:54 -0800 Attachment 120197 did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource It seems that I cannot create a rebase-apply directory, and I wonder if you are in the middle of patch application or another rebase. If that is not the case, please rm -fr /mnt/git/webkit-style-queue/.git/rebase-apply and run me again. I am stopping in case you still have something valuable there. rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 158. If any of these errors are false positives, please file a bug against check-webkit-style. 525378 3 120197 simon.fraser 2011-12-21 11:26:42 -0800 Comment on attachment 120197 Patch You should fix m_layerForScrollCorner too. 525379 4 andersca 2011-12-21 11:29:07 -0800 Committed r103419: <http://trac.webkit.org/changeset/103419> 525533 5 jamesr 2011-12-21 13:40:28 -0800 Looks good to me too, thanks for fixing this! 526334 6 rniwa 2011-12-22 10:03:57 -0800 It appears that this patch caused compositing/iframes/scrolling-iframe.html to fail on Chromium: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Fiframes%2Fscrolling-iframe.html 526350 7 jamesr 2011-12-22 10:34:11 -0800 It looks like it just flipped the order of the horizontal and vertical scrollbar layers in the GraphicsLayer tree on this test, so it just needs a rebaseline. 526354 8 rniwa 2011-12-22 10:39:13 -0800 (In reply to comment #7) > It looks like it just flipped the order of the horizontal and vertical scrollbar layers in the GraphicsLayer tree on this test, so it just needs a rebaseline. Yeah, we just figured that out. Will do rebaseline in a minute. 120197 2011-12-21 11:24:56 -0800 2011-12-21 11:26:42 -0800 Patch bug-75018-20111221112509.patch text/plain 2991 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzNDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzRiZGNjYTllNDYyZGFi MWNkOTgyOGI4OTQyNTIwNTZhNWZiNjM4Mi4uMGM0MGY4N2JlZjc5ZTY4YzliMDQ2MjgxOTgwZWU0 NDI2YmY0OTBlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTEyLTIxICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgcmVjcmVh dGUgc2Nyb2xsYmFyIGxheWVycyB3aGVuZXZlciB0aGUgZnJhbWUgdmlldyBzaXplIGNoYW5nZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc1MDE4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxh eWVyQ29tcG9zaXRvcjo6dXBkYXRlT3ZlcmZsb3dDb250cm9sc0xheWVycyk6CisKIDIwMTEtMTIt MjAgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBbRXh0ZW5zaW9uIEFQSV0gcmVmYWN0b3IgZXh0ZW5zaW9uIEFQSSBidWlsZCBj b2RlLCBleHBvc2UgZXhwZXJpbWVudGFsIEFQSXMgY29uZGl0aW9uYWxseSBpbiBjaHJvbWl1bQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRv ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNw cAppbmRleCBiMmVkYmYyNjgxODdhZjBjZDdlZmQ0NmU2NWExNzExN2NjYjJkZjgxLi43ODdmOTgz OWIxNDBjNWJhYjVjMjZiNmZkZGU1OWM3MDE0Yjg4YTFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcApAQCAtMTcwMiwxMiArMTcw MiwxNCBAQCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6dXBkYXRlT3ZlcmZsb3dDb250cm9s c0xheWVycygpCiAjZW5kaWYKIAogICAgIGlmIChyZXF1aXJlc0hvcml6b250YWxTY3JvbGxiYXJM YXllcigpKSB7Ci0gICAgICAgIG1fbGF5ZXJGb3JIb3Jpem9udGFsU2Nyb2xsYmFyID0gR3JhcGhp Y3NMYXllcjo6Y3JlYXRlKHRoaXMpOwotI2lmbmRlZiBOREVCVUcKLSAgICAgICAgbV9sYXllckZv ckhvcml6b250YWxTY3JvbGxiYXItPnNldE5hbWUoImhvcml6b250YWwgc2Nyb2xsYmFyIik7Ci0j ZW5kaWYKLSAgICAgICAgbV9vdmVyZmxvd0NvbnRyb2xzSG9zdExheWVyLT5hZGRDaGlsZChtX2xh eWVyRm9ySG9yaXpvbnRhbFNjcm9sbGJhci5nZXQoKSk7Ci0gICAgICAgIGxheWVyc0NoYW5nZWQg PSB0cnVlOworICAgICAgICBpZiAoIW1fbGF5ZXJGb3JIb3Jpem9udGFsU2Nyb2xsYmFyKSB7Cisg ICAgICAgICAgICBtX2xheWVyRm9ySG9yaXpvbnRhbFNjcm9sbGJhciA9IEdyYXBoaWNzTGF5ZXI6 OmNyZWF0ZSh0aGlzKTsKKyAgICAjaWZuZGVmIE5ERUJVRworICAgICAgICAgICAgbV9sYXllckZv ckhvcml6b250YWxTY3JvbGxiYXItPnNldE5hbWUoImhvcml6b250YWwgc2Nyb2xsYmFyIik7Cisg ICAgI2VuZGlmCisgICAgICAgICAgICBtX292ZXJmbG93Q29udHJvbHNIb3N0TGF5ZXItPmFkZENo aWxkKG1fbGF5ZXJGb3JIb3Jpem9udGFsU2Nyb2xsYmFyLmdldCgpKTsKKyAgICAgICAgICAgIGxh eWVyc0NoYW5nZWQgPSB0cnVlOworICAgICAgICB9CiAgICAgfSBlbHNlIGlmIChtX2xheWVyRm9y SG9yaXpvbnRhbFNjcm9sbGJhcikgewogICAgICAgICBtX2xheWVyRm9ySG9yaXpvbnRhbFNjcm9s bGJhci0+cmVtb3ZlRnJvbVBhcmVudCgpOwogICAgICAgICBtX2xheWVyRm9ySG9yaXpvbnRhbFNj cm9sbGJhciA9IG51bGxwdHI7CkBAIC0xNzE1LDEyICsxNzE3LDE0IEBAIHZvaWQgUmVuZGVyTGF5 ZXJDb21wb3NpdG9yOjp1cGRhdGVPdmVyZmxvd0NvbnRyb2xzTGF5ZXJzKCkKICAgICB9CiAKICAg ICBpZiAocmVxdWlyZXNWZXJ0aWNhbFNjcm9sbGJhckxheWVyKCkpIHsKLSAgICAgICAgbV9sYXll ckZvclZlcnRpY2FsU2Nyb2xsYmFyID0gR3JhcGhpY3NMYXllcjo6Y3JlYXRlKHRoaXMpOwotI2lm bmRlZiBOREVCVUcKLSAgICAgICAgbV9sYXllckZvclZlcnRpY2FsU2Nyb2xsYmFyLT5zZXROYW1l KCJ2ZXJ0aWNhbCBzY3JvbGxiYXIiKTsKLSNlbmRpZgotICAgICAgICBtX292ZXJmbG93Q29udHJv bHNIb3N0TGF5ZXItPmFkZENoaWxkKG1fbGF5ZXJGb3JWZXJ0aWNhbFNjcm9sbGJhci5nZXQoKSk7 Ci0gICAgICAgIGxheWVyc0NoYW5nZWQgPSB0cnVlOworICAgICAgICBpZiAoIW1fbGF5ZXJGb3JW ZXJ0aWNhbFNjcm9sbGJhcikgeworICAgICAgICAgICAgbV9sYXllckZvclZlcnRpY2FsU2Nyb2xs YmFyID0gR3JhcGhpY3NMYXllcjo6Y3JlYXRlKHRoaXMpOworICAgICNpZm5kZWYgTkRFQlVHCisg ICAgICAgICAgICBtX2xheWVyRm9yVmVydGljYWxTY3JvbGxiYXItPnNldE5hbWUoInZlcnRpY2Fs IHNjcm9sbGJhciIpOworICAgICNlbmRpZgorICAgICAgICAgICAgbV9vdmVyZmxvd0NvbnRyb2xz SG9zdExheWVyLT5hZGRDaGlsZChtX2xheWVyRm9yVmVydGljYWxTY3JvbGxiYXIuZ2V0KCkpOwor ICAgICAgICAgICAgbGF5ZXJzQ2hhbmdlZCA9IHRydWU7CisgICAgICAgIH0KICAgICB9IGVsc2Ug aWYgKG1fbGF5ZXJGb3JWZXJ0aWNhbFNjcm9sbGJhcikgewogICAgICAgICBtX2xheWVyRm9yVmVy dGljYWxTY3JvbGxiYXItPnJlbW92ZUZyb21QYXJlbnQoKTsKICAgICAgICAgbV9sYXllckZvclZl cnRpY2FsU2Nyb2xsYmFyID0gbnVsbHB0cjsK