<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>75003</bug_id>
          
          <creation_ts>2011-12-21 03:17:17 -0800</creation_ts>
          <short_desc>[Qt] When building QtWebKit with the -ltcg configure option then it will fail to build</short_desc>
          <delta_ts>2012-01-12 00:28:33 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P3</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>andy.shaw</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>benjamin</cc>
    
    <cc>pierre.rossi</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>525207</commentid>
    <comment_count>0</comment_count>
      <attachid>120165</attachid>
    <who name="">andy.shaw</who>
    <bug_when>2011-12-21 03:17:17 -0800</bug_when>
    <thetext>Created attachment 120165
Fix for the build issue

The reason it fails is because -GL is still specified for the compile options which is still there despite lines in WebCore.pri removing this from the flags.  The reason being because it did not remove it from the right set of flags.

Patch attached fixes this so it is removed from the right set of flags.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>525212</commentid>
    <comment_count>1</comment_count>
      <attachid>120167</attachid>
    <who name="">andy.shaw</who>
    <bug_when>2011-12-21 03:50:53 -0800</bug_when>
    <thetext>Created attachment 120167
Patch against trunk</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>533882</commentid>
    <comment_count>2</comment_count>
      <attachid>120167</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2012-01-11 07:33:02 -0800</bug_when>
    <thetext>Comment on attachment 120167
Patch against trunk

rs=me but the patch will have to be applied manually because it&apos;s missing the Tools/ directory prefix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>534363</commentid>
    <comment_count>3</comment_count>
    <who name="Pierre Rossi">pierre.rossi</who>
    <bug_when>2012-01-11 16:05:19 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 120167 [details])
&gt; rs=me but the patch will have to be applied manually because it&apos;s missing the Tools/ directory prefix.

...and things had moved back to Source/WebCore in the meantime ;)

Landed in r104758</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>534551</commentid>
    <comment_count>4</comment_count>
    <who name="">andy.shaw</who>
    <bug_when>2012-01-11 21:17:39 -0800</bug_when>
    <thetext>Thanks!  Will this be included in Qt 4.8.1 as it is a build fix?  If so then I will not push it to the internal group of patches we have for Qt Commercial 4.8.1.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>534620</commentid>
    <comment_count>5</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2012-01-12 00:28:33 -0800</bug_when>
    <thetext>Hi Andy, nice to see you here :)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>120165</attachid>
            <date>2011-12-21 03:17:17 -0800</date>
            <delta_ts>2011-12-21 03:50:53 -0800</delta_ts>
            <desc>Fix for the build issue</desc>
            <filename>patch.diff</filename>
            <type>text/plain</type>
            <size>537</size>
            <attacher>andy.shaw</attacher>
            
              <data encoding="base64">LS0tIGEvc3JjLzNyZHBhcnR5L3dlYmtpdC9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnByaQorKysg
Yi9zcmMvM3JkcGFydHkvd2Via2l0L1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJpCkBAIC0zMDQs
OCArMzA0LDggQEAgd2luMzItKiB7CiAKICMgUmVtb3ZlIHdob2xlIHByb2dyYW0gb3B0aW1pemF0
aW9ucyBkdWUgdG8gbWlzY29tcGlsYXRpb25zCiB3aW4zMi1tc3ZjMjAwNXx3aW4zMi1tc3ZjMjAw
OHx3aW4zMi1tc3ZjMjAxMHx3aW5jZSo6ewotICAgIFFNQUtFX0NGTEFHU19SRUxFQVNFIC09IC1H
TAotICAgIFFNQUtFX0NYWEZMQUdTX1JFTEVBU0UgLT0gLUdMCisgICAgUU1BS0VfQ0ZMQUdTX0xU
Q0cgLT0gLUdMCisgICAgUU1BS0VfQ1hYRkxBR1NfTFRDRyAtPSAtR0wKIAogICAgICMgRGlzYWJs
ZSBpbmNyZW1lbnRhbCBsaW5raW5nIGZvciB3aW5kb3dzIDMyYml0IE9TIGRlYnVnIGJ1aWxkIGFz
IFdlYktpdCBpcyBzbyBiaWcKICAgICAjIHRoYXQgbGlua2VyIGZhaWxlcyB0byBsaW5rIGluY3Jl
bWVudGFsbHkgaW4gZGVidWcgbW9kZS4K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>120167</attachid>
            <date>2011-12-21 03:50:53 -0800</date>
            <delta_ts>2012-01-11 07:33:02 -0800</delta_ts>
            <desc>Patch against trunk</desc>
            <filename>patch.diff</filename>
            <type>text/plain</type>
            <size>1204</size>
            <attacher>andy.shaw</attacher>
            
              <data encoding="base64">SW5kZXg6IHFtYWtlL21rc3BlY3MvZmVhdHVyZXMvd2ViY29yZS5wcmYKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g
cW1ha2UvbWtzcGVjcy9mZWF0dXJlcy93ZWJjb3JlLnByZgkocmV2aXNpb24gMTAyNDUwKQorKysg
cW1ha2UvbWtzcGVjcy9mZWF0dXJlcy93ZWJjb3JlLnByZgkod29ya2luZyBjb3B5KQpAQCAtMjM2
LDggKzIzNiw4IEBACiAKICMgUmVtb3ZlIHdob2xlIHByb2dyYW0gb3B0aW1pemF0aW9ucyBkdWUg
dG8gbWlzY29tcGlsYXRpb25zCiB3aW4zMi1tc3ZjMjAwNXx3aW4zMi1tc3ZjMjAwOHx3aW4zMi1t
c3ZjMjAxMHx3aW5jZSo6ewotICAgIFFNQUtFX0NGTEFHU19SRUxFQVNFIC09IC1HTAotICAgIFFN
QUtFX0NYWEZMQUdTX1JFTEVBU0UgLT0gLUdMCisgICAgUU1BS0VfQ0ZMQUdTX0xUQ0cgLT0gLUdM
CisgICAgUU1BS0VfQ1hYRkxBR1NfTFRDRyAtPSAtR0wKIAogICAgICMgRGlzYWJsZSBpbmNyZW1l
bnRhbCBsaW5raW5nIGZvciB3aW5kb3dzIDMyYml0IE9TIGRlYnVnIGJ1aWxkIGFzIFdlYktpdCBp
cyBzbyBiaWcKICAgICAjIHRoYXQgbGlua2VyIGZhaWxlcyB0byBsaW5rIGluY3JlbWVudGFsbHkg
aW4gZGVidWcgbW9kZS4KSW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJ
KHJldmlzaW9uIDEwMzQwMikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx
LDEyIEBACisyMDExLTEyLTIxICBTaGF3IEFuZHkgIDxhbmR5LnNoYXdAZGlnaWEuY29tPgorCisg
ICAgICAgIEZpeCBidWlsZCBpc3N1ZSBvbiBXaW5kb3dzIHdoZW4gUXQgaXMgY29uZmlndXJlZCB3
aXRoIC1sdGNnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD03NTAwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
ICogcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy93ZWJjb3JlLnByZjoKKwogMjAxMS0xMi0yMSAgS2Vu
dGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW4gcHJlcGFyZS1D
aGFuZ2VMb2csIHJlcGxhY2UgY29uc3RhbnQgZ2xvYmFsIHZhcmlhYmxlcyB3aXRoICJ1c2UgY29u
c3RhbnQiCg==
</data>
<flag name="review"
          id="120353"
          type_id="1"
          status="+"
          setter="hausmann"
    />
    <flag name="commit-queue"
          id="122707"
          type_id="3"
          status="-"
          setter="hausmann"
    />
          </attachment>
      

    </bug>

</bugzilla>