74990 2011-12-20 21:15:49 -0800 Rename WTF_INLINE, JS_INLINE to HIDDEN_INLINE 2011-12-26 17:23:26 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72855 1 morrita morrita kevino mrowe webkit.review.bot oldest_to_newest 525077 0 morrita 2011-12-20 21:15:49 -0800 As bdash@ mentioned at Bug 72855, JS_INLINE is annoying and confusing name. It's for marking functions to be hidden. So it should be renamed "HIDDEN_INLINE". * This is more intention revealing name than WTF_INLINE/JS_INLINE and its appearance is aligned to ALWAYS_INLINE. * We'll use the name even outside WTF so prefixing as WTF could be misleading. Its definition doesn't change depending on the build target. 525078 1 120136 morrita 2011-12-20 21:22:07 -0800 Created attachment 120136 Patch 525420 2 kevino 2011-12-21 11:58:42 -0800 Bug filed about the EWS bot traceback problem: https://bugs.webkit.org/show_bug.cgi?id=75024 FWIW, last I checked it while it was working, all the bots except Win and Mac had run, and all passed, so we just need to know if this passes Mac and Win. 527214 3 120136 darin 2011-12-26 07:22:55 -0800 Comment on attachment 120136 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120136&action=review > Source/JavaScriptCore/wtf/ExportMacros.h:88 > +#define HIDDEN_INLINE WTF_EXPORT_HIDDEN inline Most of our WTF macros use a namespacing prefix such as WTF_ or JS_ to avoid conflicting with macros from other libraries. There are some exceptions like ALWAYS_INLINE, but I am concerned about future conflicts. 527218 4 kevino 2011-12-26 08:40:31 -0800 (In reply to comment #3) > (From update of attachment 120136 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120136&action=review > > > Source/JavaScriptCore/wtf/ExportMacros.h:88 > > +#define HIDDEN_INLINE WTF_EXPORT_HIDDEN inline > > Most of our WTF macros use a namespacing prefix such as WTF_ or JS_ to avoid conflicting with macros from other libraries. There are some exceptions like ALWAYS_INLINE, but I am concerned about future conflicts. I thought about this as well, but I can see the argument that using WTF_ as a prefix here is problematic. Consider that WTF_EXPORT_PRIVATE and co. have different definitions based on if the WTF library is being built or linked. So I think that WTF_HIDDEN_INLINE would be naturally seen as a WTF-specific macro, in line with the other macros, rather than a project-wide one. I'm not sure how to tackle this, except maybe introducing a project-wide macro prefix? I do think, though, that whatever approach we take should be consistent with ALWAYS_INLINE and similar macros, so that there's a clear policy for future macros of a project-wide nature to use. 527219 5 120136 webkit.review.bot 2011-12-26 08:41:03 -0800 Comment on attachment 120136 Patch Clearing flags on attachment: 120136 Committed r103688: <http://trac.webkit.org/changeset/103688> 527220 6 webkit.review.bot 2011-12-26 08:41:07 -0800 All reviewed patches have been landed. Closing bug. 527245 7 morrita 2011-12-26 17:23:26 -0800 > Most of our WTF macros use a namespacing prefix such as WTF_ or JS_ to avoid conflicting with macros from other libraries. There are some exceptions like ALWAYS_INLINE, but I am concerned about future conflicts. Although I understand this concern, I think HIDDEN_INLINE is verbose enough to avoid future conflict. 120136 2011-12-20 21:22:07 -0800 2011-12-26 08:41:03 -0800 Patch bug-74990-20111221142204.patch text/plain 1638 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy MGY3YTNhOWUyY2Q5OWFlNTc5ZmQ4Mzc3MTRkYjRmYTUwYjdhZDU4Li4zNWQ5MzFjOTA4MDZlMzI2 NWRhMjg3ODAwODE2NGIwNWQzZDQ5YWFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMS0xMi0yMCAgSGFqaW1lIE1vcnJpdGEgIDxtb3JyaXRhQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmVuYW1lIFdURl9JTkxJTkUsIEpTX0lOTElORSB0byBISURERU5fSU5M SU5FCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDk5 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVu dGltZS9KU0V4cG9ydE1hY3Jvcy5oOiBSZW1vdmVkIEpTX0lOTElORQorICAgICAgICAqIHd0Zi9F eHBvcnRNYWNyb3MuaDogUmVuYW1lZCBXVEZfSU5MSU5FIHRvIEhJRERFTl9JTkxJTkUKKwogMjAx MS0xMi0yMCAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAg ICAgICAgSlNDIHNoZWxsIHNob3VsZCBhY2NlcHQgdXRmOCBpbnB1dC4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTRXhwb3J0TWFjcm9zLmggYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9KU0V4cG9ydE1hY3Jvcy5oCmluZGV4IDU3MTJhZmY2NTk3MjUz M2NiMjU1MTRjMTEwY2U4ZDdhYjJhZjYwZjcuLjg4NDgwNWY4NmI4NTI5MGFhYmQwYzc5ZDBmYTg4 YjkwNjE1MDVjNjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT RXhwb3J0TWFjcm9zLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNFeHBv cnRNYWNyb3MuaApAQCAtNzAsNiArNzAsNCBAQAogCiAjZW5kaWYgLy8gVVNFKEVYUE9SVF9NQUNS T1MpCiAKLSNkZWZpbmUgSlNfSU5MSU5FIEpTX0VYUE9SVF9ISURERU4gaW5saW5lCi0KICNlbmRp ZiAvLyBKU0V4cG9ydE1hY3Jvc19oCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL0V4cG9ydE1hY3Jvcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9FeHBvcnRNYWNy b3MuaAppbmRleCBiOTEzYjY2NjAxMjdhNTEzNDRlYjFmOTE4ZTRmMDA4NTJiNmZmZmU5Li5hNmIz YmNlNWFmM2QzZGUwM2RjZTBiN2NjMjc3NDA3ZTc3MzQxMDdmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvd3RmL0V4cG9ydE1hY3Jvcy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS93dGYvRXhwb3J0TWFjcm9zLmgKQEAgLTg0LDYgKzg0LDcgQEAKICNlbmRpZgogCiAjZGVm aW5lIFdURl9FWFBPUlRfSElEREVOIFdURl9ISURERU4KLSNkZWZpbmUgV1RGX0lOTElORSBXVEZf RVhQT1JUX0hJRERFTiBpbmxpbmUKKworI2RlZmluZSBISURERU5fSU5MSU5FIFdURl9FWFBPUlRf SElEREVOIGlubGluZQogCiAjZW5kaWYgLy8gRXhwb3J0TWFjcm9zX2gK