74983 2011-12-20 17:44:24 -0800 Extract WinCE CMake arguments from build-webkit into separate function 2011-12-21 11:09:53 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 74979 74985 1 dbates dbates gyuyoung.kim leandro paroga rakuco rwlbuis tonikitoo oldest_to_newest 525013 0 dbates 2011-12-20 17:44:24 -0800 Towards adding support to only build JavaScriptCore for the WinCE port using script Tools/Script/build-jsc, we need to extract the WinCE CMake argument from build-webkit into a separate function so that we can call this function when passing the CMake arguments to webkitdirs::buildCMakeProjectOrExit() from within Tools/Script/build-{webkit, jsc}. 525023 1 120129 dbates 2011-12-20 17:59:42 -0800 Created attachment 120129 Patch 525172 2 120129 paroga 2011-12-21 00:55:10 -0800 Comment on attachment 120129 Patch what about changing this a "additional cmake arguments" function. Maby some other port need some additonal variables for the port too? otherwise LGTM 525331 3 120193 dbates 2011-12-21 10:33:50 -0800 Created attachment 120193 Patch Added function webkitdirs::cmakeBasedPortArguments() and moved WinCE-specific CMake arguments into it. Also, use cmakeBasedPortArguments() when constructing the the list of CMake arguments for the EFL port. Currently, cmakeBasedPortArguments() returns the empty list for the EFL port. 525347 4 120193 rwlbuis 2011-12-21 11:00:53 -0800 Comment on attachment 120193 Patch Looks good. 525351 5 120193 dbates 2011-12-21 11:09:47 -0800 Comment on attachment 120193 Patch Clearing flags on attachment: 120193 Committed r103418: <http://trac.webkit.org/changeset/103418> 525352 6 dbates 2011-12-21 11:09:53 -0800 All reviewed patches have been landed. Closing bug. 120129 2011-12-20 17:59:42 -0800 2011-12-21 10:33:50 -0800 Patch Bug74983.patch text/plain 2262 dbates SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwMzM3OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDExLTEyLTIwICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0Lm9yZz4K KworICAgICAgICBFeHRyYWN0IFdpbkNFIENNYWtlIGFyZ3VtZW50cyBmcm9tIGJ1aWxkLXdlYmtp dCBpbnRvIHNlcGFyYXRlIGZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03NDk4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRvd2FyZHMgYWRkaW5nIHN1cHBvcnQgZm9yIHVzaW5nIFRvb2xzL1Nj cmlwdHMvYnVpbGQtanNjIGZvciB0aGUgV2luQ0UgcG9ydCwgZXh0cmFjdCB0aGUKKyAgICAgICAg V2luQ0Utc3BlY2lmaWMgQ01ha2UgYXJndW1lbnQgZnJvbSBUb29scy9TY3JpcHRzL2J1aWxkLXdl YmtpdCBpbnRvIHdlYmtpdGRpcnM6OmNtYWtlQXJnc0ZvcldpbkNFKCkuCisgICAgICAgIFRoaXMg d2lsbCBhbGxvdyB1cyB0byBnZXQgdGhlIFdpbkNFLXNwZWNpZmljIENNYWtlIGFyZ3VtZW50IGlu IFRvb2xzL1NjcmlwdHMvYnVpbGQtanNjIHNvCisgICAgICAgIHRoYXQgd2UgY2FuIHBhc3MgaXQg dG8gdGhlIENNYWtlIGJ1aWxkIHN5c3RlbSB3aGVuIGJ1aWxkaW5nIEphdmFTY3JpcHRDb3JlLgor CisgICAgICAgICogU2NyaXB0cy9idWlsZC13ZWJraXQ6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXRkaXJzLnBtOgorICAgICAgICAoY21ha2VBcmdzRm9yV2luQ0UpOiBBZGRlZC4KKwogMjAxMS0x Mi0yMCAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBucnd0 OiByZW5hbWUgZmllbGQgcmVmZXJlbmNlcyBmcm9tIF9mcyB0byBfZmlsZXN5c3RlbQpJbmRleDog VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9i dWlsZC13ZWJraXQJKHJldmlzaW9uIDEwMzM1OSkKKysrIFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Vi a2l0CSh3b3JraW5nIGNvcHkpCkBAIC02MzIsNyArNjMyLDcgQEAgaWYgKGlzRWZsKCkpIHsKIH0K IAogaWYgKGlzV2luQ0UoKSkgewotICAgIGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0KCRjbGVhbiwg IldpbkNFIiwgJHByZWZpeFBhdGgsICRtYWtlQXJncywgKCItRENNQUtFX1dJTkNFX1NESz1cIlNU QU5EQVJEU0RLXzUwMCAoQVJNVjRJKVwiIiwgY01ha2VBcmdzRnJvbUZlYXR1cmVzKCkpLCAkY21h a2VBcmdzKTsKKyAgICBidWlsZENNYWtlUHJvamVjdE9yRXhpdCgkY2xlYW4sICJXaW5DRSIsICRw cmVmaXhQYXRoLCAkbWFrZUFyZ3MsIChjbWFrZUFyZ3NGb3JXaW5DRSgpLCBjTWFrZUFyZ3NGcm9t RmVhdHVyZXMoKSksICRjbWFrZUFyZ3MpOwogfQogCiBpZiAoaXNCbGFja0JlcnJ5KCkpIHsKSW5k ZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL3dlYmtpdGRpcnMucG0JKHJldmlzaW9uIDEwMzM1OSkKKysrIFRvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQkod29ya2luZyBjb3B5KQpAQCAtNTMsNiArNTMsNyBAQCBCRUdJTiB7CiAgICAg ICAgJmJsYWNrYmVycnlUYXJnZXRBcmNoaXRlY3R1cmUKICAgICAgICAmY2hkaXJXZWJLaXQKICAg ICAgICAmY2hlY2tGcmFtZXdvcmtzCisgICAgICAgJmNtYWtlQXJnc0ZvcldpbkNFCiAgICAgICAg JmN1cnJlbnRTVk5SZXZpc2lvbgogICAgICAgICZkZWJ1Z1NhZmFyaQogICAgICAgICZwYXNzZWRD b25maWd1cmF0aW9uCkBAIC04NzksNiArODgwLDExIEBAIHN1YiBibGFja2JlcnJ5VGFyZ2V0QXJj aGl0ZWN0dXJlKCkKICAgICAgICAgICAgICJidVN1ZmZpeCIgPT4gJGJ1U3VmZml4KTsKIH0KIAor c3ViIGNtYWtlQXJnc0ZvcldpbkNFKCkKK3sKKyAgICByZXR1cm4gKCItRENNQUtFX1dJTkNFX1NE Sz1cIlNUQU5EQVJEU0RLXzUwMCAoQVJNVjRJKVwiIik7Cit9CisKIHN1YiBkZXRlcm1pbmVJc0Vm bCgpCiB7CiAgICAgcmV0dXJuIGlmIGRlZmluZWQoJGlzRWZsKTsK 120193 2011-12-21 10:33:50 -0800 2011-12-21 11:09:47 -0800 Patch Bug74983_1.patch text/plain 2757 dbates SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwMzQxMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDExLTEyLTIxICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0Lm9yZz4K KworICAgICAgICBFeHRyYWN0IFdpbkNFIENNYWtlIGFyZ3VtZW50cyBmcm9tIGJ1aWxkLXdlYmtp dCBpbnRvIHNlcGFyYXRlIGZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03NDk4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRvd2FyZHMgYWRkaW5nIHN1cHBvcnQgZm9yIHVzaW5nIFRvb2xzL1Nj cmlwdHMvYnVpbGQtanNjIGZvciB0aGUgV2luQ0UgcG9ydCwgZXh0cmFjdCB0aGUKKyAgICAgICAg V2luQ0Utc3BlY2lmaWMgQ01ha2UgYXJndW1lbnQgZnJvbSBUb29scy9TY3JpcHRzL2J1aWxkLXdl YmtpdCBpbnRvIHdlYmtpdGRpcnM6OmNtYWtlQmFzZWRQb3J0QXJndW1lbnRzKCkuCisgICAgICAg IFRoaXMgd2lsbCBhbGxvdyB1cyB0byBnZXQgdGhlIFdpbkNFLXNwZWNpZmljIENNYWtlIGFyZ3Vt ZW50IGluIFRvb2xzL1NjcmlwdHMvYnVpbGQtanNjIHNvCisgICAgICAgIHRoYXQgd2UgY2FuIHBh c3MgaXQgdG8gdGhlIENNYWtlIGJ1aWxkIHN5c3RlbSB3aGVuIGJ1aWxkaW5nIEphdmFTY3JpcHRD b3JlLgorCisgICAgICAgICogU2NyaXB0cy9idWlsZC13ZWJraXQ6CisgICAgICAgICogU2NyaXB0 cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoY21ha2VCYXNlZFBvcnRBcmd1bWVudHMpOiBBZGRl ZC4KKwogMjAxMS0xMi0yMSAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgSW4gcHJlcGFyZS1DaGFuZ2VMb2csIHJlcGxhY2UgY29uc3RhbnQgZ2xvYmFsIHZh cmlhYmxlcyB3aXRoICJ1c2UgY29uc3RhbnQiCkluZGV4OiBUb29scy9TY3JpcHRzL2J1aWxkLXdl YmtpdAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAkocmV2aXNpb24g MTAzMzU5KQorKysgVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQJKHdvcmtpbmcgY29weSkKQEAg LTYyOCwxMSArNjI4LDExIEBAIGlmIChpc0Nocm9taXVtKCkpIHsKIGlmIChpc0VmbCgpKSB7CiAg ICAgIyBCeSBkZWZhdWx0IHdlIGJ1aWxkIHVzaW5nIGFsbCBvZiB0aGUgYXZhaWxhYmxlIENQVXMu CiAgICAgJG1ha2VBcmdzIC49ICgkbWFrZUFyZ3MgPyAiICIgOiAiIikgLiAiLWoiIC4gbnVtYmVy T2ZDUFVzKCkgaWYgJG1ha2VBcmdzICF+IC8talxzKlxkKy87Ci0gICAgYnVpbGRDTWFrZVByb2pl Y3RPckV4aXQoJGNsZWFuLCAiRWZsIiwgJHByZWZpeFBhdGgsICRtYWtlQXJncywgY01ha2VBcmdz RnJvbUZlYXR1cmVzKCksICRjbWFrZUFyZ3MpOworICAgIGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0 KCRjbGVhbiwgIkVmbCIsICRwcmVmaXhQYXRoLCAkbWFrZUFyZ3MsIChjbWFrZUJhc2VkUG9ydEFy Z3VtZW50cygpLCBjTWFrZUFyZ3NGcm9tRmVhdHVyZXMoKSksICRjbWFrZUFyZ3MpOwogfQogCiBp ZiAoaXNXaW5DRSgpKSB7Ci0gICAgYnVpbGRDTWFrZVByb2plY3RPckV4aXQoJGNsZWFuLCAiV2lu Q0UiLCAkcHJlZml4UGF0aCwgJG1ha2VBcmdzLCAoIi1EQ01BS0VfV0lOQ0VfU0RLPVwiU1RBTkRB UkRTREtfNTAwIChBUk1WNEkpXCIiLCBjTWFrZUFyZ3NGcm9tRmVhdHVyZXMoKSksICRjbWFrZUFy Z3MpOworICAgIGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0KCRjbGVhbiwgIldpbkNFIiwgJHByZWZp eFBhdGgsICRtYWtlQXJncywgKGNtYWtlQmFzZWRQb3J0QXJndW1lbnRzKCksIGNNYWtlQXJnc0Zy b21GZWF0dXJlcygpKSwgJGNtYWtlQXJncyk7CiB9CiAKIGlmIChpc0JsYWNrQmVycnkoKSkgewpJ bmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gMTAzMzU5KQorKysgVG9vbHMvU2NyaXB0cy93 ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC01Myw2ICs1Myw3IEBAIEJFR0lOIHsKICAg ICAgICAmYmxhY2tiZXJyeVRhcmdldEFyY2hpdGVjdHVyZQogICAgICAgICZjaGRpcldlYktpdAog ICAgICAgICZjaGVja0ZyYW1ld29ya3MKKyAgICAgICAmY21ha2VCYXNlZFBvcnRBcmd1bWVudHMK ICAgICAgICAmY3VycmVudFNWTlJldmlzaW9uCiAgICAgICAgJmRlYnVnU2FmYXJpCiAgICAgICAg JnBhc3NlZENvbmZpZ3VyYXRpb24KQEAgLTE4MzgsNiArMTgzOSwxMiBAQCBzdWIgYnVpbGRDTWFr ZVByb2plY3RPckV4aXQoJCQkJEApCiAgICAgZXhpdCgkcmV0dXJuQ29kZSkgaWYgJHJldHVybkNv ZGU7CiB9CiAKK3N1YiBjbWFrZUJhc2VkUG9ydEFyZ3VtZW50cygpCit7CisgICAgcmV0dXJuICgn LURDTUFLRV9XSU5DRV9TREs9IlNUQU5EQVJEU0RLXzUwMCAoQVJNVjRJKSInKSBpZiBpc1dpbkNF KCk7CisgICAgcmV0dXJuICgpOworfQorCiBzdWIgcHJvbXB0VXNlcgogewogICAgIG15ICgkcHJv bXB0LCAkZGVmYXVsdCkgPSBAXzsK