74979 2011-12-20 17:11:43 -0800 Add CMake option to only build JavaScriptCore 2011-12-21 11:05:47 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 74981 74983 74985 1 dbates dbates gyuyoung.kim leandro paroga rakuco oldest_to_newest 524987 0 dbates 2011-12-20 17:11:43 -0800 Towards implementing support for building JavaScriptCore using Tools/Scripts/build-jsc, add a CMake option to only build JavaScriptCore. 524997 1 120121 dbates 2011-12-20 17:21:01 -0800 Created attachment 120121 Patch I thought to add a ENABLE_WEBCORE variable to enable/disable building WebCore similar to the existing variables ENABLE_WEBKIT and ENABLE_WEBKIT2. I then added a CMake option called ONLY_BUILD_JAVASCRIPTCORE that when defined sets ENABLE_WEB{CORE, KIT, KIT2} to Off. I am open to suggestions. 525339 2 120121 rwlbuis 2011-12-21 10:47:51 -0800 Comment on attachment 120121 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120121&action=review LGTM, please fix the default value thing before landing. > CMakeLists.txt:15 > + SET(ENABLE_WEBCORE On) Better to give ENABLE_WEBCORE the default value on. 525348 3 dbates 2011-12-21 11:05:47 -0800 Committed r103417: <http://trac.webkit.org/changeset/103417> 120121 2011-12-20 17:21:01 -0800 2011-12-21 10:47:51 -0800 Patch Bug74979.patch text/plain 3224 dbates SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzM2 OSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDExLTEy LTIwICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0Lm9yZz4KKworICAgICAgICBBZGQgQ01h a2Ugb3B0aW9uIHRvIG9ubHkgYnVpbGQgSmF2YVNjcmlwdENvcmUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0OTc5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVG93YXJkcyBhZGRpbmcgQ01ha2Ugc3VwcG9y dCB0byBzY3JpcHQgVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MsIGFkZCBhIENNYWtlCisgICAgICAg IG9wdGlvbiB0byBvbmx5IGJ1aWxkIEphdmFTY3JpcHRDb3JlLgorCisgICAgICAgICogQ01ha2VM aXN0cy50eHQ6IERlZmluZWQgRU5BQkxFX1dFQkNPUkUgdG8gYnVpbGQgV2ViQ29yZS4gSWYgdGhl IG9wdGlvbgorICAgICAgICBPTkxZX0JVSUxEX0pBVkFTQ1JJUFRDT1JFIGlzIHNwZWNpZmllZCB0 aGVuIGRvbid0IGJ1aWxkIFdlYkNvcmUsIFdlYktpdCwgb3IgV2ViS2l0Mi4KKyAgICAgICAgKiBT b3VyY2UvQ01ha2VMaXN0cy50eHQ6CisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdEZTLmNt YWtlOgorCiAyMDExLTEyLTIwICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBlbWFjczogdW5yZXZpZXdlZC4gYWRkIHNldHRpbmdzIGZvciBlZGl0aW5n IGpzIGZpbGVzLgpJbmRleDogQ01ha2VMaXN0cy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gQ01ha2VMaXN0 cy50eHQJKHJldmlzaW9uIDEwMzM1OSkKKysrIENNYWtlTGlzdHMudHh0CSh3b3JraW5nIGNvcHkp CkBAIC0xMiw5ICsxMiwxNyBAQCBFTkRJRiAoKQogIyBEZWZhdWx0IGxpYnJhcnkgdHlwZQogIyAt LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLQogSUYgKE5PVCBFTkFCTEVfV0VCS0lUIEFORCBOT1QgRU5BQkxF X1dFQktJVDIpCisgICAgU0VUKEVOQUJMRV9XRUJDT1JFIE9uKQogICAgIFNFVChFTkFCTEVfV0VC S0lUIE9uKQogRU5ESUYgKCkKIAorT1BUSU9OKE9OTFlfQlVJTERfSkFWQVNDUklQVENPUkUgIm9u bHkgYnVpbGQgSmF2YVNjcmlwdENvcmUiKQorSUYgKE9OTFlfQlVJTERfSkFWQVNDUklQVENPUkUp CisgICAgU0VUKEVOQUJMRV9XRUJDT1JFIE9mZikKKyAgICBTRVQoRU5BQkxFX1dFQktJVCBPZmYp CisgICAgU0VUKEVOQUJMRV9XRUJLSVQyIE9mZikKK0VORElGICgpCisKIFNFVChKQVZBU0NSSVBU Q09SRV9ESVIgIiR7Q01BS0VfU09VUkNFX0RJUn0vU291cmNlL0phdmFTY3JpcHRDb3JlIikKIFNF VChXRUJDT1JFX0RJUiAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UvV2ViQ29yZSIpCiBTRVQo V0VCS0lUX0RJUiAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UvV2ViS2l0IikKSW5kZXg6IFNv dXJjZS9DTWFrZUxpc3RzLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvQ01ha2VMaXN0cy50eHQJ KHJldmlzaW9uIDEwMzM1OSkKKysrIFNvdXJjZS9DTWFrZUxpc3RzLnR4dAkod29ya2luZyBjb3B5 KQpAQCAtMiw3ICsyLDEwIEBACiAjIEFkZCBtb2R1bGUgZGlyZWN0b3JpZXMKICMgLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0KIEFERF9TVUJESVJFQ1RPUlkoSmF2YVNjcmlwdENvcmUpCi1BRERfU1VCRElS RUNUT1JZKFdlYkNvcmUpCisKK0lGIChFTkFCTEVfV0VCQ09SRSkKKyAgICBBRERfU1VCRElSRUNU T1JZKFdlYkNvcmUpCitFTkRJRiAoKQogCiBJRiAoRU5BQkxFX1dFQktJVCkKICAgICBBRERfU1VC RElSRUNUT1JZKFdlYktpdCkKQEAgLTE3LDcgKzIwLDEwIEBAIEVORElGICgpCiAjIC0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tCiBXRUJLSVRfU0VUX0VYVFJBX0NPTVBJTEVSX0ZMQUdTKCR7V1RGX0xJQlJB UllfTkFNRX0pCiBXRUJLSVRfU0VUX0VYVFJBX0NPTVBJTEVSX0ZMQUdTKCR7SmF2YVNjcmlwdENv cmVfTElCUkFSWV9OQU1FfSkKLVdFQktJVF9TRVRfRVhUUkFfQ09NUElMRVJfRkxBR1MoJHtXZWJD b3JlX0xJQlJBUllfTkFNRX0pCisKK0lGIChFTkFCTEVfV0VCQ09SRSkKKyAgICBXRUJLSVRfU0VU X0VYVFJBX0NPTVBJTEVSX0ZMQUdTKCR7V2ViQ29yZV9MSUJSQVJZX05BTUV9KQorRU5ESUYgKCkK IAogSUYgKEVOQUJMRV9XRUJLSVQpCiAgICAgV0VCS0lUX1NFVF9FWFRSQV9DT01QSUxFUl9GTEFH Uygke1dlYktpdF9MSUJSQVJZX05BTUV9KQpJbmRleDogU291cmNlL2NtYWtlL1dlYktpdEZTLmNt YWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9jbWFrZS9XZWJLaXRGUy5jbWFrZQkocmV2aXNpb24g MTAzMzU5KQorKysgU291cmNlL2NtYWtlL1dlYktpdEZTLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBA IC0xLDggKzEsMTEgQEAKLUZJTEUoTUFLRV9ESVJFQ1RPUlkgJHtERVJJVkVEX1NPVVJDRVNfV0VC Q09SRV9ESVJ9KQogRklMRShNQUtFX0RJUkVDVE9SWSAke0RFUklWRURfU09VUkNFU19KQVZBU0NS SVBUQ09SRV9ESVJ9KQogRklMRShNQUtFX0RJUkVDVE9SWSAke0NNQUtFX0JJTkFSWV9ESVJ9L1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lKQogRklMRShNQUtFX0RJUkVDVE9SWSAke0NNQUtF X0JJTkFSWV9ESVJ9L1Byb2dyYW1zKQogCitJRiAoRU5BQkxFX1dFQkNPUkUpCisgICAgRklMRShN QUtFX0RJUkVDVE9SWSAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0pCitFTkRJRiAoKQor CiBJRiAoRU5BQkxFX1dFQktJVDIpCiAgICAgRklMRShNQUtFX0RJUkVDVE9SWSAke0RFUklWRURf U09VUkNFU19XRUJLSVQyX0RJUn0pCiBFTkRJRiAoKQo=