74977 2011-12-20 17:04:14 -0800 [Coverity] Address some uninit constructor issues in WebCore/dom 2012-01-11 12:42:18 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gbillock gbillock groby macpherson webkit.review.bot oldest_to_newest 524977 0 gbillock 2011-12-20 17:04:14 -0800 [Coverity] Address some uninit constructor issues in WebCore/dom 524980 1 120117 gbillock 2011-12-20 17:05:31 -0800 Created attachment 120117 Patch 525800 2 120117 ap 2011-12-21 16:22:04 -0800 Comment on attachment 120117 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120117&action=review > Source/WebCore/dom/DeviceMotionData.cpp:79 > + , m_interval(0.0) Please, no ".0". > Source/WebCore/dom/DeviceOrientation.cpp:48 > + , m_alpha(0.0) > + , m_beta(0.0) > + , m_gamma(0.0) Ditto. 526281 3 120326 gbillock 2011-12-22 08:49:35 -0800 Created attachment 120326 Patch 526283 4 120117 gbillock 2011-12-22 08:51:46 -0800 Comment on attachment 120117 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120117&action=review >> Source/WebCore/dom/DeviceMotionData.cpp:79 >> + , m_interval(0.0) > > Please, no ".0". Done >> Source/WebCore/dom/DeviceOrientation.cpp:48 >> + , m_gamma(0.0) > > Ditto. Done. 529694 5 gbillock 2012-01-04 13:15:03 -0800 Any further comments on this patch? 534149 6 120326 webkit.review.bot 2012-01-11 12:42:14 -0800 Comment on attachment 120326 Patch Clearing flags on attachment: 120326 Committed r104734: <http://trac.webkit.org/changeset/104734> 534150 7 webkit.review.bot 2012-01-11 12:42:18 -0800 All reviewed patches have been landed. Closing bug. 120117 2011-12-20 17:05:31 -0800 2011-12-22 08:51:46 -0800 Patch bug-74977-20111220170529.patch text/plain 2499 gbillock U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWVjMTc4Nzg3N2U2N2U2 ZjhkODAxY2NjNzYzYmJiMjdhNzE5OGIxYi4uZWMzMzI3ZWM5NDkyMGNlZGZlMjJmYTgyYzkzYzEz NGNlMTVmNTZiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTEyLTIwICBHcmVn IEJpbGxvY2sgIDxnYmlsbG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFtDb3Zlcml0eV0gQWRk cmVzcyBzb21lIHVuaW5pdCBjb25zdHJ1Y3RvciBpc3N1ZXMgaW4gV2ViQ29yZS9kb20KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0OTc3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjc3MvU2VsZWN0b3JD aGVja2VyLmg6CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3RvckNoZWNrZXI6OlBhcmVudFN0YWNr RnJhbWU6OlBhcmVudFN0YWNrRnJhbWUpOgorICAgICAgICAqIGRvbS9EZXZpY2VNb3Rpb25EYXRh LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRldmljZU1vdGlvbkRhdGE6OkRldmljZU1vdGlvbkRh dGEpOgorICAgICAgICAqIGRvbS9EZXZpY2VPcmllbnRhdGlvbi5jcHA6CisgICAgICAgIChXZWJD b3JlOjpEZXZpY2VPcmllbnRhdGlvbjo6RGV2aWNlT3JpZW50YXRpb24pOgorCiAyMDExLTEyLTEy ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk LCByb2xsaW5nIG91dCByMTAyNjQ4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL1Nl bGVjdG9yQ2hlY2tlci5oIGIvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5oCmlu ZGV4IDc2MGJhNTIwN2JlNTc0YzVkZmU4YTlhMDRiOTcwMGU0ZDBjZGYyOGQuLjg5MTZlMDBjYzkw ODU2ZTI3MzliMDllZjA4MmZhMGZhMWVkYjBhZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9TZWxlY3RvckNoZWNrZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JD aGVja2VyLmgKQEAgLTExMiw3ICsxMTIsNyBAQCBwcml2YXRlOgogICAgIG11dGFibGUgSGFzaFNl dDxMaW5rSGFzaCwgTGlua0hhc2hIYXNoPiBtX2xpbmtzQ2hlY2tlZEZvclZpc2l0ZWRTdGF0ZTsK IAogICAgIHN0cnVjdCBQYXJlbnRTdGFja0ZyYW1lIHsKLSAgICAgICAgUGFyZW50U3RhY2tGcmFt ZSgpIHsgfQorICAgICAgICBQYXJlbnRTdGFja0ZyYW1lKCkgOiBlbGVtZW50KDApIHsgfQogICAg ICAgICBQYXJlbnRTdGFja0ZyYW1lKEVsZW1lbnQqIGVsZW1lbnQpIDogZWxlbWVudChlbGVtZW50 KSB7IH0KICAgICAgICAgRWxlbWVudCogZWxlbWVudDsKICAgICAgICAgVmVjdG9yPHVuc2lnbmVk LCA0PiBpZGVudGlmaWVySGFzaGVzOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0Rl dmljZU1vdGlvbkRhdGEuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RldmljZU1vdGlvbkRhdGEu Y3BwCmluZGV4IDczNDRjMWNjYTQwNzUzZmExNDMzYmVkM2Y4ZjUzY2Q0NmFjYjVmMGYuLmNkMTky OWViZDQ3Y2M0NjZlZThiMWQ4NzFmYTVjNDYwM2I1N2QwY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9EZXZpY2VNb3Rpb25EYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RGV2aWNlTW90aW9uRGF0YS5jcHAKQEAgLTc2LDYgKzc2LDcgQEAgUGFzc1JlZlB0cjxEZXZpY2VN b3Rpb25EYXRhPiBEZXZpY2VNb3Rpb25EYXRhOjpjcmVhdGUoUGFzc1JlZlB0cjxBY2NlbGVyYXRp b24+IGEKIAogRGV2aWNlTW90aW9uRGF0YTo6RGV2aWNlTW90aW9uRGF0YSgpCiAgICAgOiBtX2Nh blByb3ZpZGVJbnRlcnZhbChmYWxzZSkKKyAgICAsIG1faW50ZXJ2YWwoMC4wKQogewogfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRGV2aWNlT3JpZW50YXRpb24uY3BwIGIvU291 cmNlL1dlYkNvcmUvZG9tL0RldmljZU9yaWVudGF0aW9uLmNwcAppbmRleCBmMWMyOGIxMGQwYWYx YWYxYTllZjVhMDQ1NDE3MDVkNTMxOWJhNGQ2Li5jMzllMmRiMGM0YzlmY2RiNjZhMDRhZWEwNzQ1 ZGQyZTRhNWMwOTVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRGV2aWNlT3JpZW50 YXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9EZXZpY2VPcmllbnRhdGlvbi5jcHAK QEAgLTQzLDYgKzQzLDkgQEAgRGV2aWNlT3JpZW50YXRpb246OkRldmljZU9yaWVudGF0aW9uKCkK ICAgICA6IG1fY2FuUHJvdmlkZUFscGhhKGZhbHNlKQogICAgICwgbV9jYW5Qcm92aWRlQmV0YShm YWxzZSkKICAgICAsIG1fY2FuUHJvdmlkZUdhbW1hKGZhbHNlKQorICAgICwgbV9hbHBoYSgwLjAp CisgICAgLCBtX2JldGEoMC4wKQorICAgICwgbV9nYW1tYSgwLjApCiB7CiB9CiAK 120326 2011-12-22 08:49:35 -0800 2012-01-11 12:42:14 -0800 Patch bug-74977-20111222084934.patch text/plain 2522 gbillock U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMzk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTk0N2M2ZjNjYmExNzFi N2ExYWJhMWU0MmUzOGIwZGQxYmQ5ZjgxNS4uZjJmMWRkNDQzZGUyZDJlNWFkYzFhOWFlZTEzZTIz YTczNDc3OWZkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTEyLTIwICBHcmVn IEJpbGxvY2sgIDxnYmlsbG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFtDb3Zlcml0eV0gQWRk cmVzcyBzb21lIHVuaW5pdCBjb25zdHJ1Y3RvciBpc3N1ZXMgaW4gV2ViQ29yZS9kb20KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0OTc3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjc3MvU2VsZWN0b3JD aGVja2VyLmg6CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3RvckNoZWNrZXI6OlBhcmVudFN0YWNr RnJhbWU6OlBhcmVudFN0YWNrRnJhbWUpOgorICAgICAgICAqIGRvbS9EZXZpY2VNb3Rpb25EYXRh LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRldmljZU1vdGlvbkRhdGE6OkRldmljZU1vdGlvbkRh dGEpOgorICAgICAgICAqIGRvbS9EZXZpY2VPcmllbnRhdGlvbi5jcHA6CisgICAgICAgIChXZWJD b3JlOjpEZXZpY2VPcmllbnRhdGlvbjo6RGV2aWNlT3JpZW50YXRpb24pOgorCiAyMDExLTEyLTIx ICBNYXR0IEZhbGtlbmhhZ2VuICA8ZmFsa2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQg YWxsIElDVSBsYW5ndWFnZXMgdG8gTG9jYWxlVG9TY3JpcHRNYXBwaW5nRGVmYXVsdC5jcHAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXIuaCBiL1NvdXJjZS9X ZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXIuaAppbmRleCA0OGE2ZDliYThhYTQxZmZmYTVkZDkx NGU2MTkyYmFiOGZlNzg0NzM1Li4yZDk3MmE1NTJjMTI2NDY2YjZiNWU3MzMyYWFkZjBmNjJmOTlm ZmEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU2VsZWN0b3JDaGVja2VyLmgKKysr IGIvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5oCkBAIC0xMTIsNyArMTEyLDcg QEAgcHJpdmF0ZToKICAgICBtdXRhYmxlIEhhc2hTZXQ8TGlua0hhc2gsIExpbmtIYXNoSGFzaD4g bV9saW5rc0NoZWNrZWRGb3JWaXNpdGVkU3RhdGU7CiAKICAgICBzdHJ1Y3QgUGFyZW50U3RhY2tG cmFtZSB7Ci0gICAgICAgIFBhcmVudFN0YWNrRnJhbWUoKSB7IH0KKyAgICAgICAgUGFyZW50U3Rh Y2tGcmFtZSgpIDogZWxlbWVudCgwKSB7IH0KICAgICAgICAgUGFyZW50U3RhY2tGcmFtZShFbGVt ZW50KiBlbGVtZW50KSA6IGVsZW1lbnQoZWxlbWVudCkgeyB9CiAgICAgICAgIEVsZW1lbnQqIGVs ZW1lbnQ7CiAgICAgICAgIFZlY3Rvcjx1bnNpZ25lZCwgND4gaWRlbnRpZmllckhhc2hlczsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9EZXZpY2VNb3Rpb25EYXRhLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9EZXZpY2VNb3Rpb25EYXRhLmNwcAppbmRleCA3MzQ0YzFjY2E0MDc1M2Zh MTQzM2JlZDNmOGY1M2NkNDZhY2I1ZjBmLi40NDFjODBkMTYzMWNiZDc2MjU0MGFkZWFjZTExNmQx Nzc3YjAzMTNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRGV2aWNlTW90aW9uRGF0 YS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RldmljZU1vdGlvbkRhdGEuY3BwCkBAIC03 Niw2ICs3Niw3IEBAIFBhc3NSZWZQdHI8RGV2aWNlTW90aW9uRGF0YT4gRGV2aWNlTW90aW9uRGF0 YTo6Y3JlYXRlKFBhc3NSZWZQdHI8QWNjZWxlcmF0aW9uPiBhCiAKIERldmljZU1vdGlvbkRhdGE6 OkRldmljZU1vdGlvbkRhdGEoKQogICAgIDogbV9jYW5Qcm92aWRlSW50ZXJ2YWwoZmFsc2UpCisg ICAgLCBtX2ludGVydmFsKDApCiB7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9EZXZpY2VPcmllbnRhdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRGV2aWNlT3JpZW50 YXRpb24uY3BwCmluZGV4IGYxYzI4YjEwZDBhZjFhZjFhOWVmNWEwNDU0MTcwNWQ1MzE5YmE0ZDYu LmEyOGY3ZTlkMzczYWYyYmM2ZTA4MDIyMjRmZjk0NjMzYzNkMDVmYzYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9EZXZpY2VPcmllbnRhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvZG9tL0RldmljZU9yaWVudGF0aW9uLmNwcApAQCAtNDMsNiArNDMsOSBAQCBEZXZpY2VPcmll bnRhdGlvbjo6RGV2aWNlT3JpZW50YXRpb24oKQogICAgIDogbV9jYW5Qcm92aWRlQWxwaGEoZmFs c2UpCiAgICAgLCBtX2NhblByb3ZpZGVCZXRhKGZhbHNlKQogICAgICwgbV9jYW5Qcm92aWRlR2Ft bWEoZmFsc2UpCisgICAgLCBtX2FscGhhKDApCisgICAgLCBtX2JldGEoMCkKKyAgICAsIG1fZ2Ft bWEoMCkKIHsKIH0KIAo=