74969 2011-12-20 15:50:53 -0800 Remove non-threadsafe pattern in DOMFilePath.cpp 2011-12-21 16:34:14 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 62813 P2 Normal --- 74666 1 levin ericu dimich ericu kinuko oldest_to_newest 524905 0 levin 2011-12-20 15:50:53 -0800 This api is used in Workers on multiple threads. Therefore it shouldn't have a non-threadsafe structures in a static. 524929 1 120108 levin 2011-12-20 16:14:34 -0800 Created attachment 120108 Patch 524932 2 levin 2011-12-20 16:20:34 -0800 Just adding Eric and Kinuko as a fyi. 524949 3 120108 dimich 2011-12-20 16:30:28 -0800 Comment on attachment 120108 Patch The RegularExpression class does not look like threadsafe one... I only looked briefly though, but if you look and it is in fact threadsafe, please feel free to add some note and re-flip R? 525821 4 levin 2011-12-21 16:34:14 -0800 *** This bug has been marked as a duplicate of bug 62813 *** 120108 2011-12-20 16:14:34 -0800 2011-12-20 16:47:39 -0800 Patch bug-74969-20111220161433.patch text/plain 2749 levin U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyOTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGRiMDIwNDUyMjgzMmJi OGQzMTAzNjJmZWU5ZjVhY2MyYzJmM2EyMi4uOTNlOWE3ODM5MmUwYjM4YWQ5ZmUyNzRjYmViMGY2 OGUwMjQ1ODM5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTEyLTIwICBEYXZp ZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgbm9uLXRocmVh ZHNhZmUgcGF0dGVybiBpbiBET01GaWxlUGF0aC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0OTY5CisKKyAgICAgICAgVGhlIHRlc3QgaXMgY29t aW5nIGluIGJ1ZyA3NDY2NiwgYnV0IG1vcmUgZml4ZXMKKyAgICAgICAgbmVlZCB0byBsYW5kIGZv ciB0aGUgdGVzdCB0byB3b3JrLgorCisgICAgICAgICogZmlsZWFwaS9ET01GaWxlUGF0aC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpET01GaWxlUGF0aDo6aXNWYWxpZFBhdGgpOiBSZW1vdmUgREVG SU5FX1NUQVRJQ19MT0NBTAorICAgICAgICBzaW5jZSB0aGlzIGZ1bmN0aW9uIG1heSBiZSBjYWxs ZWQgb24gbXVsdGlwbGUgdGhyZWFkcyBhdCBvbmNlIGFuZAorICAgICAgICB0aGUgc3RhdGljIHZh cmlhYmxlIGlzIG5vdCB0aHJlYWRzYWZlLiBJJ3ZlIGNvbmZpcm1lZCB0aGF0IHRoaXMKKyAgICAg ICAgZnVuY3Rpb24gaXNuJ3QgY29uc2lkZXJlZCBwZXJmIGNyaXRpY2FsIGZvciBub3cgYW5kIHRo aXMgY29kZSB3aWxsCisgICAgICAgIGxpa2VseSBjaGFuZ2UgYW55d2F5IGluIHRoZSBuZWFyIGZ1 dHVyZS4KKwogMjAxMS0xMi0xNSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwMjgyOS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2ZpbGVhcGkvRE9NRmlsZVBhdGguY3BwIGIvU291cmNlL1dlYkNvcmUvZmls ZWFwaS9ET01GaWxlUGF0aC5jcHAKaW5kZXggMWUwZDc4ODlkN2U2NTIxNjFhYjc5NzllNDczN2Ix ZTdjZDA4YTY1Yy4uNTFiYjk1NWYwYjEyYTdmMDZjODdkMTI3NGRiZWNlOGRjYzZlNDMyZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9ET01GaWxlUGF0aC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZmlsZWFwaS9ET01GaWxlUGF0aC5jcHAKQEAgLTEyNyw4ICsxMjcsOCBAQCBi b29sIERPTUZpbGVQYXRoOjppc1ZhbGlkUGF0aChjb25zdCBTdHJpbmcmIHBhdGgpCiAgICAgICAg ICAgICByZXR1cm4gZmFsc2U7CiAKICAgICAvLyBVbmFsbG93ZWQgbmFtZXMuCi0gICAgREVGSU5F X1NUQVRJQ19MT0NBTChSZWd1bGFyRXhwcmVzc2lvbiwgdW5hbGxvd2VkTmFtZXNSZWdFeHAxLCAo IigvfF4pKENPTnxQUk58QVVYfE5VTCkoW1xcLi9dfCQpIiwgVGV4dENhc2VJbnNlbnNpdGl2ZSkp OwotICAgIERFRklORV9TVEFUSUNfTE9DQUwoUmVndWxhckV4cHJlc3Npb24sIHVuYWxsb3dlZE5h bWVzUmVnRXhwMiwgKCIoL3xeKShDT018TFBUKVsxLTldKFtcXC4vXXwkKSIsIFRleHRDYXNlSW5z ZW5zaXRpdmUpKTsKKyAgICBSZWd1bGFyRXhwcmVzc2lvbiB1bmFsbG93ZWROYW1lc1JlZ0V4cDEo IigvfF4pKENPTnxQUk58QVVYfE5VTCkoW1xcLi9dfCQpIiwgVGV4dENhc2VJbnNlbnNpdGl2ZSk7 CisgICAgUmVndWxhckV4cHJlc3Npb24gdW5hbGxvd2VkTmFtZXNSZWdFeHAyKCIoL3xeKShDT018 TFBUKVsxLTldKFtcXC4vXXwkKSIsIFRleHRDYXNlSW5zZW5zaXRpdmUpOwogCiAgICAgaWYgKHVu YWxsb3dlZE5hbWVzUmVnRXhwMS5tYXRjaChwYXRoKSA+PSAwKQogICAgICAgICByZXR1cm4gZmFs c2U7CkBAIC0xMzYsMTQgKzEzNiwxNCBAQCBib29sIERPTUZpbGVQYXRoOjppc1ZhbGlkUGF0aChj b25zdCBTdHJpbmcmIHBhdGgpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIC8vIE5hbWVz IG11c3Qgbm90IGVuZCB3aXRoIHBlcmlvZCBvciB3aGl0ZXNwYWNlLgotICAgIERFRklORV9TVEFU SUNfTE9DQUwoUmVndWxhckV4cHJlc3Npb24sIGVuZGluZ1JlZ0V4cCwgKCJbXFwuXFxzXSgvfCQp IiwgVGV4dENhc2VJbnNlbnNpdGl2ZSkpOworICAgIFJlZ3VsYXJFeHByZXNzaW9uIGVuZGluZ1Jl Z0V4cCgiW1xcLlxcc10oL3wkKSIsIFRleHRDYXNlSW5zZW5zaXRpdmUpOwogCiAgICAgaWYgKGVu ZGluZ1JlZ0V4cC5tYXRjaChwYXRoKSA+PSAwKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAg ICAvLyBVbmFsbG93ZWQgY2hhcnM6ICdcJywgJzwnLCAnPicsICc6JywgJz8nLCAnKicsICciJywg J3wnCiAgICAgLy8gKFdlIGRvbid0IGNoZWNrICcvJyBoZXJlIGFzIHRoaXMgbWV0aG9kIHRha2Vz IHBhdGhzIGFzIGl0cyBhcmd1bWVudC4pCi0gICAgREVGSU5FX1NUQVRJQ19MT0NBTChSZWd1bGFy RXhwcmVzc2lvbiwgdW5hbGxvd2VkQ2hhcnNSZWdFeHAsICgiW1xcXFw8PjpcXD9cXCpcInxdIiwg VGV4dENhc2VJbnNlbnNpdGl2ZSkpOworICAgIFJlZ3VsYXJFeHByZXNzaW9uIHVuYWxsb3dlZENo YXJzUmVnRXhwKCJbXFxcXDw+OlxcP1xcKlwifF0iLCBUZXh0Q2FzZUluc2Vuc2l0aXZlKTsKIAog ICAgIGlmICh1bmFsbG93ZWRDaGFyc1JlZ0V4cC5tYXRjaChwYXRoKSA+PSAwKQogICAgICAgICBy ZXR1cm4gZmFsc2U7Cg==