74964 2011-12-20 15:19:07 -0800 requestAnimationFrame on Mac fires at 60fps even when drawing is much slower 2011-12-20 15:55:50 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser cmarrin levin+threading simon.fraser thorton webkit-bug-importer webkit.review.bot oldest_to_newest 524872 0 simon.fraser 2011-12-20 15:19:07 -0800 requestAnimationFrame on Mac will queue up notifications on the main thread even when the previous event is still being handled. That results in uneven rAF intervals (slow/fast/fast/fast/slow...) and untruths in framerate reporting. 524873 1 simon.fraser 2011-12-20 15:19:38 -0800 <rdar://problem/10607416> 524878 2 120098 simon.fraser 2011-12-20 15:27:25 -0800 Created attachment 120098 Patch 524912 3 simon.fraser 2011-12-20 15:55:50 -0800 http://trac.webkit.org/changeset/103361 120098 2011-12-20 15:27:25 -0800 2011-12-20 15:42:51 -0800 Patch bug-74964-20111220152724.patch text/plain 5168 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzdjYWVkZDMwMWJmNzZk OWFjMDhhZmI4ZGMxZmMzMWViNjVmNDkyMS4uZjNkZWZhNzA4MTQzYzkwOTlhNzc0MjYxYzk3NmFk NGNmNTBjYzJjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDExLTEyLTIwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIHJlcXVlc3RBbmlt YXRpb25GcmFtZSBvbiBNYWMgZmlyZXMgYXQgNjBmcHMgZXZlbiB3aGVuIGRyYXdpbmcgaXMgbXVj aCBzbG93ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc0OTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAor ICAgICAgICBPbiBNYWMgcmVxdWVzdEFuaW1hdGlvbkZyYW1lIHVzZXMgYSBDVkRpc3BsYXlMaW5r LCBzZW5kaW5nIG5vdGlmaWNhdGlvbnMKKyAgICAgICAgZnJvbSB0aGUgZGlzcGxheSBsaW5rIHRo cmVhZCB0byB0aGUgbWFpbiB0aHJlYWQgdGhhdCB0aGUgZGlzcGxheSBsaW5rIGZpcmVkLgorICAg ICAgICBIb3dldmVyLCB0aGVyZSB3YXMgbm8gdGhyb3R0bGluZyBvbiB0aGVzZSBub3RpZmljYXRp b25zOyBpZiBwcm9jZXNzaW5nIGFuIGV2ZW50CisgICAgICAgIHRvb2sgYSBsb25nIHRpbWUsIG5v dGlmaWNhdGlvbnMgd291bGQgcGlsZSB1cCwgYW5kIHRoZW4gZ2V0IGhhbmRsZWQgYWZ0ZXIKKyAg ICAgICAgdGhlIHNsb3cgZXZlbnQgY29tcGxldGVkLgorICAgICAgICAKKyAgICAgICAgVGhpcyB3 b3VsZCBjYXVzZSBKUyBhbmltYXRpb25zIHdoaWNoIGFuaW1hdGUgYnkgY2hhbmdpbmcgc3R5bGUg dG8gcmVwb3J0CisgICAgICAgIDYwZnBzIHdoZW4gdGhlaXIgZGlzcGxheSBmcmFtZXJhdGUgd2Fz IG11Y2ggbG93ZXIuCisgICAgICAgIAorICAgICAgICBGaXggYnkgdGhyb3R0bGluZyBub3RpZmlj YXRpb25zIGZyb20gdGhlIGRpc3BsYXkgbGluayB0aHJlYWQgdG8gdGhlIHdlYgorICAgICAgICB0 aHJlYWQ7IGlmIHRoZSBwcmV2aW91cyBldmVudCBoYXNuJ3QgY29tcGxldGVkIHlldCwgZG9uJ3Qg c2VuZCBhbnkgbmV3IG9uZXMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBzaW5jZSB0ZXN0aW5n IHRoaXMgcnVudGltZSBiZWhhdmlvciBpcyBoYXJkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvRGlzcGxheVJlZnJlc2hNb25pdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRpc3Bs YXlSZWZyZXNoTW9uaXRvcjo6RGlzcGxheVJlZnJlc2hNb25pdG9yKToKKyAgICAgICAgKFdlYkNv cmU6OkRpc3BsYXlSZWZyZXNoTW9uaXRvcjo6cmVmcmVzaERpc3BsYXlPbk1haW5UaHJlYWQpOgor ICAgICAgICAoV2ViQ29yZTo6RGlzcGxheVJlZnJlc2hNb25pdG9yOjpub3RpZnlDbGllbnRzKTog RmFjdG9yZWQgb3V0IG9mIHRoZQorICAgICAgICBzdGF0aWMgcmVmcmVzaERpc3BsYXlPbk1haW5U aHJlYWQgbWV0aG9kIHNvIHdlIGNhbiB1c2UgJ3RoaXMnLgorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvci5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL21hYy9EaXNwbGF5UmVmcmVzaE1vbml0b3JNYWMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RGlzcGxheVJlZnJlc2hNb25pdG9yOjpkaXNwbGF5TGlua0ZpcmVkKToKKwogMjAxMS0xMi0yMCAg SWFpbiBNZXJyaWNrICA8aHVza3lAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW51c2Vk IHBhcmFtZXRlciBmcm9tIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6cmVidWlsZENvbXBvc2l0aW5n TGF5ZXJUcmVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9E aXNwbGF5UmVmcmVzaE1vbml0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvRGlzcGxheVJlZnJlc2hNb25pdG9yLmNwcAppbmRleCAxZjdiMzdhOTQ4ZGVkYzc4OTRlZmVk NGExMzU0ZmFkYzM5OWY2YzIyLi4yM2MzZjcyNTE2NDRmNDI1NjkzMDBjN2E4YjU4MzJlY2Y4NmU2 NjVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9EaXNwbGF5 UmVmcmVzaE1vbml0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0Rpc3BsYXlSZWZyZXNoTW9uaXRvci5jcHAKQEAgLTU2LDYgKzU2LDcgQEAgRGlzcGxheVJlZnJl c2hNb25pdG9yOjpEaXNwbGF5UmVmcmVzaE1vbml0b3IoUGxhdGZvcm1EaXNwbGF5SUQgZGlzcGxh eUlEKQogICAgIDogbV90aW1lc3RhbXAoMCkKICAgICAsIG1fYWN0aXZlKHRydWUpCiAgICAgLCBt X3NjaGVkdWxlZChmYWxzZSkKKyAgICAsIG1fcHJldmlvdXNGcmFtZURvbmUodHJ1ZSkKICAgICAs IG1fZGlzcGxheUlEKGRpc3BsYXlJRCkKICNpZiBQTEFURk9STShNQUMpCiAgICAgLCBtX2Rpc3Bs YXlMaW5rKDApCkBAIC02NiwxOCArNjcsMjcgQEAgRGlzcGxheVJlZnJlc2hNb25pdG9yOjpEaXNw bGF5UmVmcmVzaE1vbml0b3IoUGxhdGZvcm1EaXNwbGF5SUQgZGlzcGxheUlEKQogdm9pZCBEaXNw bGF5UmVmcmVzaE1vbml0b3I6OnJlZnJlc2hEaXNwbGF5T25NYWluVGhyZWFkKHZvaWQqIGRhdGEp CiB7CiAgICAgRGlzcGxheVJlZnJlc2hNb25pdG9yKiBtb25pdG9yID0gc3RhdGljX2Nhc3Q8RGlz cGxheVJlZnJlc2hNb25pdG9yKj4oZGF0YSk7CisgICAgbW9uaXRvci0+bm90aWZ5Q2xpZW50cygp OworfQogCit2b2lkIERpc3BsYXlSZWZyZXNoTW9uaXRvcjo6bm90aWZ5Q2xpZW50cygpCit7CiAg ICAgZG91YmxlIHRpbWVzdGFtcDsKICAgICB7Ci0gICAgICAgIE11dGV4TG9ja2VyIGxvY2sobW9u aXRvci0+bV9tdXRleCk7Ci0gICAgICAgIG1vbml0b3ItPm1fc2NoZWR1bGVkID0gZmFsc2U7Ci0g ICAgICAgIHRpbWVzdGFtcCA9IG1vbml0b3ItPm1fdGltZXN0YW1wOworICAgICAgICBNdXRleExv Y2tlciBsb2NrKG1fbXV0ZXgpOworICAgICAgICBtX3NjaGVkdWxlZCA9IGZhbHNlOworICAgICAg ICB0aW1lc3RhbXAgPSBtX3RpbWVzdGFtcDsKICAgICB9CiAKLSAgICBmb3IgKHNpemVfdCBpID0g MDsgaSA8IG1vbml0b3ItPm1fY2xpZW50cy5zaXplKCk7ICsraSkKLSAgICAgICAgbW9uaXRvci0+ bV9jbGllbnRzW2ldLT5maXJlRGlzcGxheVJlZnJlc2hJZk5lZWRlZCh0aW1lc3RhbXApOworICAg IGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbV9jbGllbnRzLnNpemUoKTsgKytpKQorICAgICAgICBt X2NsaWVudHNbaV0tPmZpcmVEaXNwbGF5UmVmcmVzaElmTmVlZGVkKHRpbWVzdGFtcCk7CisKKyAg ICB7CisgICAgICAgIE11dGV4TG9ja2VyIGxvY2sobV9tdXRleCk7CisgICAgICAgIG1fcHJldmlv dXNGcmFtZURvbmUgPSB0cnVlOworICAgIH0KIH0KLSAKKwogRGlzcGxheVJlZnJlc2hNb25pdG9y TWFuYWdlciogRGlzcGxheVJlZnJlc2hNb25pdG9yTWFuYWdlcjo6c2hhcmVkTWFuYWdlcigpCiB7 CiAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChEaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyLCBt YW5hZ2VyLCAoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9EaXNwbGF5UmVmcmVzaE1vbml0b3IuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0Rpc3BsYXlSZWZyZXNoTW9uaXRvci5oCmluZGV4IDUwMzgwNzE1YTgxMzBjZTcxNjY0Y2Zi M2NmZmE4MDBlNTBiMjQ1ZDcuLjc5ZGYwZDE4ZjMyNGI5Y2E4NzIwNWYzMTEyZmNjMWU5NTc1MDRk OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Rpc3BsYXlS ZWZyZXNoTW9uaXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Rp c3BsYXlSZWZyZXNoTW9uaXRvci5oCkBAIC05Niw5ICs5NiwxMiBAQCBwdWJsaWM6CiAgICAgUGxh dGZvcm1EaXNwbGF5SUQgZGlzcGxheUlEKCkgY29uc3QgeyByZXR1cm4gbV9kaXNwbGF5SUQ7IH0K IAogcHJpdmF0ZToKKyAgICB2b2lkIG5vdGlmeUNsaWVudHMoKTsKKyAgICAKICAgICBkb3VibGUg bV90aW1lc3RhbXA7CiAgICAgYm9vbCBtX2FjdGl2ZTsKICAgICBib29sIG1fc2NoZWR1bGVkOwor ICAgIGJvb2wgbV9wcmV2aW91c0ZyYW1lRG9uZTsKICAgICBQbGF0Zm9ybURpc3BsYXlJRCBtX2Rp c3BsYXlJRDsKICAgICBEaXNwbGF5UmVmcmVzaE1vbml0b3JNYW5hZ2VyKiBtX21hbmFnZXI7CiAg ICAgTXV0ZXggbV9tdXRleDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL21hYy9EaXNwbGF5UmVmcmVzaE1vbml0b3JNYWMuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0Rpc3BsYXlSZWZyZXNoTW9uaXRvck1hYy5jcHAKaW5kZXgg YTI1OTA1MTQ5YzBmZDVkZDE4OTRlOGNmMzA2NmE1MDM1MmRiNjE2MC4uYjA4MzhlMTUzMDVlNzQ1 ODMzOTNlMThlOWEzZDJlZmUyYzQwNjRjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvbWFjL0Rpc3BsYXlSZWZyZXNoTW9uaXRvck1hYy5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0Rpc3BsYXlSZWZyZXNoTW9uaXRvck1h Yy5jcHAKQEAgLTg3LDkgKzg3LDExIEBAIGJvb2wgRGlzcGxheVJlZnJlc2hNb25pdG9yOjpyZXF1 ZXN0UmVmcmVzaENhbGxiYWNrKCkKIHZvaWQgRGlzcGxheVJlZnJlc2hNb25pdG9yOjpkaXNwbGF5 TGlua0ZpcmVkKGRvdWJsZSBub3dTZWNvbmRzLCBkb3VibGUgb3V0cHV0VGltZVNlY29uZHMpCiB7 CiAgICAgTXV0ZXhMb2NrZXIgbG9jayhtX211dGV4KTsKLSAgICBpZiAoIW1fc2NoZWR1bGVkKQor ICAgIGlmICghbV9zY2hlZHVsZWQgfHwgIW1fcHJldmlvdXNGcmFtZURvbmUpCiAgICAgICAgIHJl dHVybjsKIAorICAgIG1fcHJldmlvdXNGcmFtZURvbmUgPSBmYWxzZTsKKwogICAgIGRvdWJsZSB3 ZWJLaXROb3cgPSBjdXJyZW50VGltZSgpOwogICAgIG1fdGltZXN0YW1wID0gd2ViS2l0Tm93IC0g bm93U2Vjb25kcyArIG91dHB1dFRpbWVTZWNvbmRzOwogICAgIAo=