74963 2011-12-20 15:06:02 -0800 Don't crash on the second time VideoLayerChromium::createCCVideoLayer() is called 2011-12-20 17:09:32 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fischman fischman cc-bugs enne jamesr webkit.review.bot zmo oldest_to_newest 524858 0 fischman 2011-12-20 15:06:02 -0800 r103298 assumed that VideoLayerChromium would only create a CCVideoLayerImpl once, but that's wrong because the CC*LayerImpl tree can be dropped and recreated. Support this. 524861 1 120095 fischman 2011-12-20 15:08:23 -0800 Created attachment 120095 Patch 524864 2 120095 jamesr 2011-12-20 15:10:14 -0800 Comment on attachment 120095 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120095&action=review > Source/WebCore/platform/graphics/chromium/VideoLayerChromium.h:59 > + VideoFrameProvider* m_provider; would you mind adding a comment here indicating that this class should never dereference this pointer, but simply pass it on to the CCVideoLayerImpl ? 524896 3 120103 fischman 2011-12-20 15:45:47 -0800 Created attachment 120103 Patch 524897 4 fischman 2011-12-20 15:46:16 -0800 (In reply to comment #2) > (From update of attachment 120095 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120095&action=review > > > Source/WebCore/platform/graphics/chromium/VideoLayerChromium.h:59 > > + VideoFrameProvider* m_provider; > > would you mind adding a comment here indicating that this class should never dereference this pointer, but simply pass it on to the CCVideoLayerImpl ? Done. Thanks for the quick review. 524983 5 120103 webkit.review.bot 2011-12-20 17:09:28 -0800 Comment on attachment 120103 Patch Clearing flags on attachment: 120103 Committed r103370: <http://trac.webkit.org/changeset/103370> 524984 6 webkit.review.bot 2011-12-20 17:09:32 -0800 All reviewed patches have been landed. Closing bug. 120095 2011-12-20 15:08:23 -0800 2011-12-20 15:45:41 -0800 Patch bug-74963-20111220150821.patch text/plain 3385 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWFiY2Y5MTNiNDNhMDE2 OWVjNjliYzAwNmE5MmE1MTA3ZjQ0ZDliMS4uOTIzMzcwMjY2MzFkMThiMTEwZmFkZDkzNWYwMjI4 OTU4MDNjMmM1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTEyLTIwICBBbWkg RmlzY2htYW4gIDxmaXNjaG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRG9uJ3QgY3Jhc2gg b24gdGhlIHNlY29uZCB0aW1lIFZpZGVvTGF5ZXJDaHJvbWl1bTo6Y3JlYXRlQ0NWaWRlb0xheWVy KCkgaXMgY2FsbGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03NDk2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE1hbnVhbGx5IHRlc3RlZCBieSBmb3JjZS1kcm9wcGluZyB0aGUgbGF5ZXIgdHJlZSBpbiBD Q0xheWVyVHJlZUhvc3Q6OmRpZEJlY29tZUludmlzaWJsZU9uSW1wbFRocmVhZCgpLgorICAgICAg ICBDcmFzaGVkIGJlZm9yZSB0aGUgZml4LCBkb2Vzbid0IGNyYXNoIGFmdGVyLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVmlkZW9MYXllckNocm9taXVtLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlZpZGVvTGF5ZXJDaHJvbWl1bTo6VmlkZW9MYXllckNocm9taXVtKToK KyAgICAgICAgKFdlYkNvcmU6OlZpZGVvTGF5ZXJDaHJvbWl1bTo6flZpZGVvTGF5ZXJDaHJvbWl1 bSk6CisgICAgICAgIChXZWJDb3JlOjpWaWRlb0xheWVyQ2hyb21pdW06OmNyZWF0ZUNDTGF5ZXJJ bXBsKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9WaWRlb0xheWVyQ2hy b21pdW0uaDoKKwogMjAxMS0xMi0yMCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBn bWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwMzI5MS4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1ZpZGVv TGF5ZXJDaHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9WaWRlb0xheWVyQ2hyb21pdW0uY3BwCmluZGV4IDNlOGYxMjM5N2JhY2UyM2Y1ZDcxMWY4 NGFjMzIwYzI0NDRkOGYyNGUuLjBlMGZjYjY2NWI0MDQxMzQzZDNkZDFjZmM0YWY4MzM4YWE2NTBi OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L1ZpZGVvTGF5ZXJDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vVmlkZW9MYXllckNocm9taXVtLmNwcApAQCAtNDcsMjQgKzQ3LDE1IEBA IFZpZGVvTGF5ZXJDaHJvbWl1bTo6VmlkZW9MYXllckNocm9taXVtKENDTGF5ZXJEZWxlZ2F0ZSog ZGVsZWdhdGUsIFZpZGVvRnJhbWVQcm92CiAgICAgLCBtX3Byb3ZpZGVyKHByb3ZpZGVyKQogewog ICAgIEFTU0VSVChtX3Byb3ZpZGVyKTsKLSAgICBtX3Byb3ZpZGVyLT5zZXRWaWRlb0ZyYW1lUHJv dmlkZXJDbGllbnQodGhpcyk7CiB9CiAKIFZpZGVvTGF5ZXJDaHJvbWl1bTo6flZpZGVvTGF5ZXJD aHJvbWl1bSgpCiB7Ci0gICAgQVNTRVJUKCFtX3Byb3ZpZGVyKTsKIH0KIAogUGFzc1JlZlB0cjxD Q0xheWVySW1wbD4gVmlkZW9MYXllckNocm9taXVtOjpjcmVhdGVDQ0xheWVySW1wbCgpCiB7Ci0g ICAgUmVmUHRyPENDVmlkZW9MYXllckltcGw+IHJldCA9IENDVmlkZW9MYXllckltcGw6OmNyZWF0 ZShtX2xheWVySWQsIG1fcHJvdmlkZXIpOwotICAgIG1fcHJvdmlkZXIgPSAwOwotICAgIHJldHVy biByZXQ7Ci19Ci0KLXZvaWQgVmlkZW9MYXllckNocm9taXVtOjpzdG9wVXNpbmdQcm92aWRlcigp Ci17Ci0gICAgbV9wcm92aWRlciA9IDA7CisgICAgcmV0dXJuIENDVmlkZW9MYXllckltcGw6OmNy ZWF0ZShtX2xheWVySWQsIG1fcHJvdmlkZXIpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9W aWRlb0xheWVyQ2hyb21pdW0uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL1ZpZGVvTGF5ZXJDaHJvbWl1bS5oCmluZGV4IDkxOWVlODcwYzc0YmNjOTY4YTQxMGI0 ZDJmODQ5ZGRlYWI3ZTNkYjAuLjg4OTBiOWYxYjFkYzQyZDliMDY5ODMxM2VhNWQyNGJjZDNjMGJl NzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L1ZpZGVvTGF5ZXJDaHJvbWl1bS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL1ZpZGVvTGF5ZXJDaHJvbWl1bS5oCkBAIC0zNSwxNSArMzUsMTQgQEAKICNp ZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAKICNpbmNsdWRlICJMYXllckNocm9taXVt LmgiCi0jaW5jbHVkZSAiVmlkZW9GcmFtZVByb3ZpZGVyLmgiCiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAogY2xhc3MgQ0NWaWRlb0xheWVySW1wbDsKK2NsYXNzIFZpZGVvRnJhbWVQcm92aWRlcjsK IAogLy8gQSBMYXllciB0aGF0IGNvbnRhaW5zIGEgVmlkZW8gZWxlbWVudC4KLWNsYXNzIFZpZGVv TGF5ZXJDaHJvbWl1bSA6IHB1YmxpYyBMYXllckNocm9taXVtCi0gICAgICAgICAgICAgICAgICAg ICAgICAgLCBwdWJsaWMgVmlkZW9GcmFtZVByb3ZpZGVyOjpDbGllbnQgeworY2xhc3MgVmlkZW9M YXllckNocm9taXVtIDogcHVibGljIExheWVyQ2hyb21pdW0gewogcHVibGljOgogCiAgICAgc3Rh dGljIFBhc3NSZWZQdHI8VmlkZW9MYXllckNocm9taXVtPiBjcmVhdGUoQ0NMYXllckRlbGVnYXRl KiA9IDAsCkBAIC01NCwxMyArNTMsMTAgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCBib29sIGRy YXdzQ29udGVudCgpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KIAotICAgIC8vIFZpZGVvRnJhbWVQ cm92aWRlcjo6Q2xpZW50IGltcGxlbWVudGF0aW9uLgotICAgIHZpcnR1YWwgdm9pZCBzdG9wVXNp bmdQcm92aWRlcigpOwotCiBwcml2YXRlOgogICAgIFZpZGVvTGF5ZXJDaHJvbWl1bShDQ0xheWVy RGVsZWdhdGUqLCBWaWRlb0ZyYW1lUHJvdmlkZXIqKTsKIAotICAgIFZpZGVvRnJhbWVQcm92aWRl ciogbV9wcm92aWRlcjsgLy8gT25seSBwb3B1bGF0ZWQgYmV0d2VlbiBjb25zdHJ1Y3Rpb24gYW5k IGNyZWF0ZUNDTGF5ZXJJbXBsIGJlaW5nIGNhbGxlZC4KKyAgICBWaWRlb0ZyYW1lUHJvdmlkZXIq IG1fcHJvdmlkZXI7CiB9OwogCiB9Cg== 120103 2011-12-20 15:45:47 -0800 2011-12-20 17:09:28 -0800 Patch bug-74963-20111220154546.patch text/plain 3508 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWFiY2Y5MTNiNDNhMDE2 OWVjNjliYzAwNmE5MmE1MTA3ZjQ0ZDliMS4uOTIzMzcwMjY2MzFkMThiMTEwZmFkZDkzNWYwMjI4 OTU4MDNjMmM1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTEyLTIwICBBbWkg RmlzY2htYW4gIDxmaXNjaG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRG9uJ3QgY3Jhc2gg b24gdGhlIHNlY29uZCB0aW1lIFZpZGVvTGF5ZXJDaHJvbWl1bTo6Y3JlYXRlQ0NWaWRlb0xheWVy KCkgaXMgY2FsbGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03NDk2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE1hbnVhbGx5IHRlc3RlZCBieSBmb3JjZS1kcm9wcGluZyB0aGUgbGF5ZXIgdHJlZSBpbiBD Q0xheWVyVHJlZUhvc3Q6OmRpZEJlY29tZUludmlzaWJsZU9uSW1wbFRocmVhZCgpLgorICAgICAg ICBDcmFzaGVkIGJlZm9yZSB0aGUgZml4LCBkb2Vzbid0IGNyYXNoIGFmdGVyLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVmlkZW9MYXllckNocm9taXVtLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlZpZGVvTGF5ZXJDaHJvbWl1bTo6VmlkZW9MYXllckNocm9taXVtKToK KyAgICAgICAgKFdlYkNvcmU6OlZpZGVvTGF5ZXJDaHJvbWl1bTo6flZpZGVvTGF5ZXJDaHJvbWl1 bSk6CisgICAgICAgIChXZWJDb3JlOjpWaWRlb0xheWVyQ2hyb21pdW06OmNyZWF0ZUNDTGF5ZXJJ bXBsKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9WaWRlb0xheWVyQ2hy b21pdW0uaDoKKwogMjAxMS0xMi0yMCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBn bWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwMzI5MS4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1ZpZGVv TGF5ZXJDaHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9WaWRlb0xheWVyQ2hyb21pdW0uY3BwCmluZGV4IDNlOGYxMjM5N2JhY2UyM2Y1ZDcxMWY4 NGFjMzIwYzI0NDRkOGYyNGUuLjBlMGZjYjY2NWI0MDQxMzQzZDNkZDFjZmM0YWY4MzM4YWE2NTBi OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L1ZpZGVvTGF5ZXJDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vVmlkZW9MYXllckNocm9taXVtLmNwcApAQCAtNDcsMjQgKzQ3LDE1IEBA IFZpZGVvTGF5ZXJDaHJvbWl1bTo6VmlkZW9MYXllckNocm9taXVtKENDTGF5ZXJEZWxlZ2F0ZSog ZGVsZWdhdGUsIFZpZGVvRnJhbWVQcm92CiAgICAgLCBtX3Byb3ZpZGVyKHByb3ZpZGVyKQogewog ICAgIEFTU0VSVChtX3Byb3ZpZGVyKTsKLSAgICBtX3Byb3ZpZGVyLT5zZXRWaWRlb0ZyYW1lUHJv dmlkZXJDbGllbnQodGhpcyk7CiB9CiAKIFZpZGVvTGF5ZXJDaHJvbWl1bTo6flZpZGVvTGF5ZXJD aHJvbWl1bSgpCiB7Ci0gICAgQVNTRVJUKCFtX3Byb3ZpZGVyKTsKIH0KIAogUGFzc1JlZlB0cjxD Q0xheWVySW1wbD4gVmlkZW9MYXllckNocm9taXVtOjpjcmVhdGVDQ0xheWVySW1wbCgpCiB7Ci0g ICAgUmVmUHRyPENDVmlkZW9MYXllckltcGw+IHJldCA9IENDVmlkZW9MYXllckltcGw6OmNyZWF0 ZShtX2xheWVySWQsIG1fcHJvdmlkZXIpOwotICAgIG1fcHJvdmlkZXIgPSAwOwotICAgIHJldHVy biByZXQ7Ci19Ci0KLXZvaWQgVmlkZW9MYXllckNocm9taXVtOjpzdG9wVXNpbmdQcm92aWRlcigp Ci17Ci0gICAgbV9wcm92aWRlciA9IDA7CisgICAgcmV0dXJuIENDVmlkZW9MYXllckltcGw6OmNy ZWF0ZShtX2xheWVySWQsIG1fcHJvdmlkZXIpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9W aWRlb0xheWVyQ2hyb21pdW0uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL1ZpZGVvTGF5ZXJDaHJvbWl1bS5oCmluZGV4IDkxOWVlODcwYzc0YmNjOTY4YTQxMGI0 ZDJmODQ5ZGRlYWI3ZTNkYjAuLjNkOTMxNWVjOGIxNjE5M2VkOGNiYjA2NWVlMWZjNGY3YWE0OWY1 ZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L1ZpZGVvTGF5ZXJDaHJvbWl1bS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL1ZpZGVvTGF5ZXJDaHJvbWl1bS5oCkBAIC0zNSwxNSArMzUsMTQgQEAKICNp ZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAKICNpbmNsdWRlICJMYXllckNocm9taXVt LmgiCi0jaW5jbHVkZSAiVmlkZW9GcmFtZVByb3ZpZGVyLmgiCiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAogY2xhc3MgQ0NWaWRlb0xheWVySW1wbDsKK2NsYXNzIFZpZGVvRnJhbWVQcm92aWRlcjsK IAogLy8gQSBMYXllciB0aGF0IGNvbnRhaW5zIGEgVmlkZW8gZWxlbWVudC4KLWNsYXNzIFZpZGVv TGF5ZXJDaHJvbWl1bSA6IHB1YmxpYyBMYXllckNocm9taXVtCi0gICAgICAgICAgICAgICAgICAg ICAgICAgLCBwdWJsaWMgVmlkZW9GcmFtZVByb3ZpZGVyOjpDbGllbnQgeworY2xhc3MgVmlkZW9M YXllckNocm9taXVtIDogcHVibGljIExheWVyQ2hyb21pdW0gewogcHVibGljOgogCiAgICAgc3Rh dGljIFBhc3NSZWZQdHI8VmlkZW9MYXllckNocm9taXVtPiBjcmVhdGUoQ0NMYXllckRlbGVnYXRl KiA9IDAsCkBAIC01NCwxMyArNTMsMTEgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCBib29sIGRy YXdzQ29udGVudCgpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KIAotICAgIC8vIFZpZGVvRnJhbWVQ cm92aWRlcjo6Q2xpZW50IGltcGxlbWVudGF0aW9uLgotICAgIHZpcnR1YWwgdm9pZCBzdG9wVXNp bmdQcm92aWRlcigpOwotCiBwcml2YXRlOgogICAgIFZpZGVvTGF5ZXJDaHJvbWl1bShDQ0xheWVy RGVsZWdhdGUqLCBWaWRlb0ZyYW1lUHJvdmlkZXIqKTsKIAotICAgIFZpZGVvRnJhbWVQcm92aWRl ciogbV9wcm92aWRlcjsgLy8gT25seSBwb3B1bGF0ZWQgYmV0d2VlbiBjb25zdHJ1Y3Rpb24gYW5k IGNyZWF0ZUNDTGF5ZXJJbXBsIGJlaW5nIGNhbGxlZC4KKyAgICAvLyBUaGlzIHBvaW50ZXIgaXMg b25seSBmb3IgcGFzc2luZyB0byBDQ1ZpZGVvTGF5ZXJJbXBsJ3MgY29uc3RydWN0b3IuIEl0IHNo b3VsZCBuZXZlciBiZSBkZXJlZmVyZW5jZWQgYnkgdGhpcyBjbGFzcy4KKyAgICBWaWRlb0ZyYW1l UHJvdmlkZXIqIG1fcHJvdmlkZXI7CiB9OwogCiB9Cg==