74962 2011-12-20 15:03:38 -0800 [Chromium] NativeImageSkia should mark SkBitmaps as immutable 2012-01-05 16:44:33 -0800 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 junov junov dglazkov reed senorblanco webkit.review.bot oldest_to_newest 524856 0 junov 2011-12-20 15:03:38 -0800 Resized bitmaps, and bitmaps that are finished loading should be marked as immutable since their pixels will remain unchanged for the lifetime of the bitmap. Setting this flag enables optimizations in Skia. 524880 1 120099 junov 2011-12-20 15:32:58 -0800 Created attachment 120099 Patch 530611 2 120099 senorblanco 2012-01-05 14:03:23 -0800 Comment on attachment 120099 Patch OK. r=me 530775 3 120099 webkit.review.bot 2012-01-05 16:44:29 -0800 Comment on attachment 120099 Patch Clearing flags on attachment: 120099 Committed r104246: <http://trac.webkit.org/changeset/104246> 530776 4 webkit.review.bot 2012-01-05 16:44:33 -0800 All reviewed patches have been landed. Closing bug. 120099 2011-12-20 15:32:58 -0800 2012-01-05 16:44:29 -0800 Patch bug-74962-20111220183258.patch text/plain 5273 junov SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzM1NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDExLTEyLTIwICBKdXN0aW4g Tm92b3NhZCAgPGp1bm92QGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIE5hdGl2 ZUltYWdlU2tpYSBzaG91bGQgbWFyayBTa0JpdG1hcHMgYXMgaW1tdXRhYmxlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDk2MgorCisgICAgICAgIFJl bW92ZWQgbV9pc0RhdGFDb21wbGV0ZSBmcm9tIGNsYXNzIE5hdGl2ZUltYWdlU2tpYS4gSW5zdGVh ZCwgZGF0YQorICAgICAgICBjb21wbGV0ZW5lc3Mgd2lsbCBiZSB0cmFja2VkIHRocm91Z2ggU2tC aXRtYXA6OnNldEltbXV0YWJsZS8KKyAgICAgICAgaXNJbW11dGFibGUuICBUaGUgaW1tdXRhYmxl IHN0YXRlIHNpZ25pZmllcyB0aGF0IHRoZSBwaXhlbCBkYXRhCisgICAgICAgIHdpbGwgbm8gbG9u Z2VyIGNoYW5nZSBmb3IgdGhlIGxpZmV0aW1lIG9mIHRoZSBiaXRtYXAsIHdoaWNoIGNvcnJlc3Bv bmRzCisgICAgICAgIHRvIHRoZSBzZW1hbnRpYyBvZiB0aGUgb2xkIG1faXNEYXRhQ29tcGxldGUg bWVtYmVyLiBzZXRJbW11dGFibGUgaXMKKyAgICAgICAgYWxzbyBjYWxsZWQgb24gdGhlIGNhY2hl ZCByZXNpemVkIGJpdG1hcCwgc2luY2UgaXQgdG9vIGlzIGludmFyaWFudCBmb3IKKyAgICAgICAg aXRzIGxpZmUgdGltZS4gVGVtcG9yYXJ5IHJlc2l6ZWQgYml0bWFwcyBhcmUgYWxzbyBtYXJrZWQg YXMgaW1tdXRhYmxlCisgICAgICAgIHNpbmNlIHRoZXkgdGVjaG5pY2FsbHkgYXJlLgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3Mvc2tpYS9OYXRpdmVJbWFnZVNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmF0aXZl SW1hZ2VTa2lhOjpOYXRpdmVJbWFnZVNraWEpOgorICAgICAgICAoV2ViQ29yZTo6TmF0aXZlSW1h Z2VTa2lhOjpyZXNpemVkQml0bWFwKToKKyAgICAgICAgKFdlYkNvcmU6Ok5hdGl2ZUltYWdlU2tp YTo6c2hvdWxkQ2FjaGVSZXNhbXBsaW5nKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9z a2lhL05hdGl2ZUltYWdlU2tpYS5oOgorICAgICAgICAoV2ViQ29yZTo6TmF0aXZlSW1hZ2VTa2lh OjpzZXREYXRhQ29tcGxldGUpOgorICAgICAgICAoV2ViQ29yZTo6TmF0aXZlSW1hZ2VTa2lhOjpp c0RhdGFDb21wbGV0ZSk6CisKIDIwMTEtMTItMjAgIFNhaWxlc2ggQWdyYXdhbCA8c2FpbEBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgTWVyZ2UgU2Nyb2xsQW5pbWF0b3JDaHJvbWl1bU1hYy5tbSBi YWNrIHRvIFNjcm9sbEFuaW1hdG9yTWFjCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9za2lhL05hdGl2ZUltYWdlU2tpYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9OYXRpdmVJbWFnZVNraWEuY3BwCShyZXZpc2lv biAxMDMzNTMpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL05hdGl2 ZUltYWdlU2tpYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQzLDE1ICs0MywxMyBAQAogbmFtZXNw YWNlIFdlYkNvcmUgewogCiBOYXRpdmVJbWFnZVNraWE6Ok5hdGl2ZUltYWdlU2tpYSgpCi0gICAg OiBtX3Jlc2l6ZVJlcXVlc3RzKDApLAotICAgICAgbV9pc0RhdGFDb21wbGV0ZShmYWxzZSkKKyAg ICA6IG1fcmVzaXplUmVxdWVzdHMoMCkKIHsKIH0KIAogTmF0aXZlSW1hZ2VTa2lhOjpOYXRpdmVJ bWFnZVNraWEoY29uc3QgU2tCaXRtYXAmIG90aGVyKQogICAgIDogbV9pbWFnZShvdGhlciksCi0g ICAgICBtX3Jlc2l6ZVJlcXVlc3RzKDApLAotICAgICAgbV9pc0RhdGFDb21wbGV0ZShmYWxzZSkK KyAgICAgIG1fcmVzaXplUmVxdWVzdHMoMCkKIHsKIH0KIApAQCAtNzgsNyArNzYsNyBAQCBTa0Jp dG1hcCBOYXRpdmVJbWFnZVNraWE6OnJlc2l6ZWRCaXRtYXAoCiAgICAgVFJBQ0VfRVZFTlQoIk5h dGl2ZUltYWdlU2tpYTo6cmVzaXplZEJpdG1hcCIsIGNvbnN0X2Nhc3Q8TmF0aXZlSW1hZ2VTa2lh Kj4odGhpcyksIDApOwogI2VuZGlmCiAgICAgaWYgKCFoYXNSZXNpemVkQml0bWFwKHNyY1N1YnNl dCwgZGVzdFdpZHRoLCBkZXN0SGVpZ2h0KSkgewotICAgICAgICBib29sIHNob3VsZENhY2hlID0g bV9pc0RhdGFDb21wbGV0ZQorICAgICAgICBib29sIHNob3VsZENhY2hlID0gaXNEYXRhQ29tcGxl dGUoKQogICAgICAgICAgICAgJiYgc2hvdWxkQ2FjaGVSZXNhbXBsaW5nKHNyY1N1YnNldCwgZGVz dFdpZHRoLCBkZXN0SGVpZ2h0LCBkZXN0VmlzaWJsZVN1YnNldCk7CiAKICAgICAgICAgU2tCaXRt YXAgc3Vic2V0OwpAQCAtODksNiArODcsNyBAQCBTa0JpdG1hcCBOYXRpdmVJbWFnZVNraWE6OnJl c2l6ZWRCaXRtYXAoCiAjZW5kaWYKICAgICAgICAgICAgIC8vIEp1c3QgcmVzaXplIHRoZSB2aXNp YmxlIHN1YnNldCBhbmQgcmV0dXJuIGl0LgogICAgICAgICAgICAgU2tCaXRtYXAgcmVzaXplZElt YWdlID0gc2tpYTo6SW1hZ2VPcGVyYXRpb25zOjpSZXNpemUoc3Vic2V0LCBza2lhOjpJbWFnZU9w ZXJhdGlvbnM6OlJFU0laRV9MQU5DWk9TMywgZGVzdFdpZHRoLCBkZXN0SGVpZ2h0LCBkZXN0Vmlz aWJsZVN1YnNldCk7CisgICAgICAgICAgICByZXNpemVkSW1hZ2Uuc2V0SW1tdXRhYmxlKCk7CiAg ICAgICAgICAgICByZXR1cm4gcmVzaXplZEltYWdlOwogICAgICAgICB9IGVsc2UgewogI2lmIFBM QVRGT1JNKENIUk9NSVVNKQpAQCAtOTYsNiArOTUsNyBAQCBTa0JpdG1hcCBOYXRpdmVJbWFnZVNr aWE6OnJlc2l6ZWRCaXRtYXAoCiAjZW5kaWYKICAgICAgICAgICAgIG1fcmVzaXplZEltYWdlID0g c2tpYTo6SW1hZ2VPcGVyYXRpb25zOjpSZXNpemUoc3Vic2V0LCBza2lhOjpJbWFnZU9wZXJhdGlv bnM6OlJFU0laRV9MQU5DWk9TMywgZGVzdFdpZHRoLCBkZXN0SGVpZ2h0KTsKICAgICAgICAgfQor ICAgICAgICBtX3Jlc2l6ZWRJbWFnZS5zZXRJbW11dGFibGUoKTsKICAgICB9CiAKICAgICBTa0Jp dG1hcCB2aXNpYmxlQml0bWFwOwpAQCAtMTI0LDcgKzEyNCw3IEBAIGJvb2wgTmF0aXZlSW1hZ2VT a2lhOjpzaG91bGRDYWNoZVJlc2FtcGwKICAgICAvLyB0aGUgZnV0dXJlLCB3ZXJlIHdlIGtub3cg aG93IG11Y2ggb2YgdGhlIGZyYW1lIGhhcyBiZWVuIGRlY29kZWQsIHNvIHdoZW4KICAgICAvLyB3 ZSBpbmNyZW1lbnRhbGx5IGRyYXcgbW9yZSBvZiB0aGUgaW1hZ2UsIHdlIG9ubHkgaGF2ZSB0byBy ZXNhbXBsZSB0aGUKICAgICAvLyBwYXJ0cyB0aGF0IGFyZSBjaGFuZ2VkLgotICAgIGlmICghbV9p c0RhdGFDb21wbGV0ZSkKKyAgICBpZiAoIWlzRGF0YUNvbXBsZXRlKCkpCiAgICAgICAgIHJldHVy biBmYWxzZTsKIAogICAgIC8vIElmIHRoZSBkZXN0aW5hdGlvbiBiaXRtYXAgaXMgc21hbGwsIHdl J2xsIGFsd2F5cyBhbGxvdyBjYWNoaW5nLCBzaW5jZQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvc2tpYS9OYXRpdmVJbWFnZVNraWEuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL05hdGl2ZUltYWdlU2tpYS5oCShyZXZp c2lvbiAxMDMzNTMpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL05h dGl2ZUltYWdlU2tpYS5oCSh3b3JraW5nIGNvcHkpCkBAIC01NCwxMyArNTQsMTQgQEAgcHVibGlj OgogICAgIC8vIHJlc2l6ZWQgdmVyc2lvbiBpZiB0aGVyZSBpcyBvbmUuCiAgICAgaW50IGRlY29k ZWRTaXplKCkgY29uc3Q7CiAKLSAgICAvLyBTZXRzIHRoZSBkYXRhIGNvbXBsZXRlIGZsYWcuIFRo aXMgaXMgY2FsbGVkIGJ5IHRoZSBpbWFnZSBkZWNvZGVyIHdoZW4KLSAgICAvLyBhbGwgZGF0YSBp cyBjb21wbGV0ZSwgYW5kIHVzZWQgYnkgdXMgdG8ga25vdyB3aGV0aGVyIHdlIGNhbiBjYWNoZQot ICAgIC8vIHJlc2l6ZWQgaW1hZ2VzLgotICAgIHZvaWQgc2V0RGF0YUNvbXBsZXRlKCkgeyBtX2lz RGF0YUNvbXBsZXRlID0gdHJ1ZTsgfQorICAgIC8vIFNldHMgdGhlIGltbXV0YWJsZSBmbGFnIG9u IHRoZSBiaXRtYXAsIGluZGljYXRpbmcgdGhhdCB0aGUgaW1hZ2UgZGF0YQorICAgIC8vIHdpbGwg bm90IGJlIG1vZGlmaWVkIGFueSBmdXJ0aGVyLiBUaGlzIGlzIGNhbGxlZCBieSB0aGUgaW1hZ2Ug ZGVjb2RlcgorICAgIC8vIHdoZW4gYWxsIGRhdGEgaXMgY29tcGxldGUsIHVzZWQgYnkgdXMgdG8g a25vdyB3aGV0aGVyIHdlIGNhbiBjYWNoZQorICAgIC8vIHJlc2l6ZWQgaW1hZ2VzLCBhbmQgdXNl ZCBieSBTa2lhIGZvciB2YXJpb3VzIG9wdGltaXphdGlvbnMuCisgICAgdm9pZCBzZXREYXRhQ29t cGxldGUoKSB7IG1faW1hZ2Uuc2V0SW1tdXRhYmxlKCk7IH0KIAogICAgIC8vIFJldHVybnMgdHJ1 ZSBpZiB0aGUgZW50aXJlIGltYWdlIGhhcyBiZWVuIGRlY29kZWQuCi0gICAgYm9vbCBpc0RhdGFD b21wbGV0ZSgpIGNvbnN0IHsgcmV0dXJuIG1faXNEYXRhQ29tcGxldGU7IH0KKyAgICBib29sIGlz RGF0YUNvbXBsZXRlKCkgY29uc3QgeyByZXR1cm4gbV9pbWFnZS5pc0ltbXV0YWJsZSgpOyB9CiAK ICAgICAvLyBHZXQgcmVmZXJlbmNlIHRvIHRoZSBpbnRlcm5hbCBTa0JpdG1hcCByZXByZXNlbnRp bmcgdGhpcyBpbWFnZS4KICAgICBjb25zdCBTa0JpdG1hcCYgYml0bWFwKCkgY29uc3QgeyByZXR1 cm4gbV9pbWFnZTsgfQpAQCAtMTQxLDEwICsxNDIsNiBAQCBwcml2YXRlOgogICAgIC8vIGltYWdl IHJlc2l6ZXMuCiAgICAgbXV0YWJsZSBDYWNoZWRJbWFnZUluZm8gbV9jYWNoZWRJbWFnZUluZm87 CiAgICAgbXV0YWJsZSBpbnQgbV9yZXNpemVSZXF1ZXN0czsKLQotICAgIC8vIFNldCB0byB0cnVl IHdoZW4gdGhlIGRhdGEgaXMgY29tcGxldGUuIEJlZm9yZSB0aGUgZW50aXJlIGltYWdlIGhhcwot ICAgIC8vIGxvYWRlZCwgd2UgZG8gbm90IHdhbnQgdG8gY2FjaGUgYSByZXNpemUuCi0gICAgYm9v bCBtX2lzRGF0YUNvbXBsZXRlOwogfTsKIAogfQo=