74957 2011-12-20 14:35:25 -0800 wouldTaintOrigin m_cleanURLs cache grows very large when data urls used 2011-12-20 16:39:47 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 scottmg scottmg abarth kbr mdelaney7 webkit.review.bot oldest_to_newest 524838 0 scottmg 2011-12-20 14:35:25 -0800 Downstream discussion here: http://code.google.com/p/chromium/issues/detail?id=107408 Maybe excluding data urls from m_cleanURLs is a reasonable workaround? I assume they can't cause cross-origin problems anyway. 524840 1 120090 scottmg 2011-12-20 14:37:51 -0800 Created attachment 120090 Patch 524845 2 120090 kbr 2011-12-20 14:52:12 -0800 Comment on attachment 120090 Patch This looks fine to me. I can't see any way this could introduce a security hole given that SecurityOrigin::taintsCanvas() already has an early-out for data: URLs. r=me 524953 3 120090 webkit.review.bot 2011-12-20 16:39:43 -0800 Comment on attachment 120090 Patch Clearing flags on attachment: 120090 Committed r103366: <http://trac.webkit.org/changeset/103366> 524954 4 webkit.review.bot 2011-12-20 16:39:47 -0800 All reviewed patches have been landed. Closing bug. 120090 2011-12-20 14:37:51 -0800 2011-12-20 16:39:43 -0800 Patch bug-74957-20111220143749.patch text/plain 1465 scottmg U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTFkNmMyM2MwNmRmZWY0 ODgxMzUxMTcyNzcwMWE2YzYxMDdiYjcyOC4uYmM2MTc5NmIyZWY3OTU3YjZiODRjZWUxY2FiNWZi ZjcwYTVkYjFkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTEyLTIwICBTY290 dCBHcmFoYW0gIDxzY290dG1nQGNocm9taXVtLm9yZz4KKworICAgICAgICB3b3VsZFRhaW50T3Jp Z2luIG1fY2xlYW5VUkxzIGNhY2hlIGdyb3dzIHZlcnkgbGFyZ2Ugd2hlbiBkYXRhIHVybHMgdXNl ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ5NTcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMsIGJ1dCBtZW1vcnkgdXNhZ2Ugb2YgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDo6bV9jbGVh blVSTHMKKyAgICAgICAgaXMgcmVkdWNlZC4KKworICAgICAgICAqIGh0bWwvY2FudmFzL0NhbnZh c1JlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FudmFzUmVuZGVyaW5n Q29udGV4dDo6d291bGRUYWludE9yaWdpbik6CisKIDIwMTEtMTItMjAgIEFuZGVycyBDYXJsc3Nv biAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgU2Nyb2xsYWJsZUFyZWEgd3Jh cHBlcnMgZm9yIGEgYnVuY2ggb2YgU2Nyb2xsQW5pbWF0b3IgbWVtYmVyIGZ1bmN0aW9ucwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4 dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0 LmNwcAppbmRleCAwYWQ5YjBkNzRlYWE0MmE4ZDdlZWIyZGQ0ZmZlNTZiYzlmOGQ1Mzg2Li5iM2Yz ODdlYjdjMDhjNTllNjA5YzIzNjcxOWFmMGY0MTc3NWMxOGM5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0LmNwcApAQCAtOTUs NiArOTUsOSBAQCBib29sIENhbnZhc1JlbmRlcmluZ0NvbnRleHQ6OndvdWxkVGFpbnRPcmlnaW4o Y29uc3QgS1VSTCYgdXJsKQogICAgIGlmIChjYW52YXMoKS0+c2VjdXJpdHlPcmlnaW4oKS0+dGFp bnRzQ2FudmFzKHVybCkpCiAgICAgICAgIHJldHVybiB0cnVlOwogCisgICAgaWYgKHVybC5wcm90 b2NvbElzRGF0YSgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICBtX2NsZWFuVVJMcy5h ZGQodXJsLnN0cmluZygpKTsKICAgICByZXR1cm4gZmFsc2U7CiB9Cg==