74947 2011-12-20 11:53:01 -0800 [chromium] enable WPO for WebCore libs in official builds 2011-12-20 13:45:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony abarth jamesr thakis oldest_to_newest 524730 0 tony 2011-12-20 11:53:01 -0800 [chromium] enable WPO for WebCore libs in official builds 524731 1 120050 tony 2011-12-20 11:54:05 -0800 Created attachment 120050 Patch 524733 2 tony 2011-12-20 11:55:57 -0800 The optimize change won't do anything until http://codereview.chromium.org/8983002/ is landed and rolled into webkit. It's harmless until then. 524743 3 120050 jamesr 2011-12-20 12:03:13 -0800 Comment on attachment 120050 Patch RS=me 524745 4 120050 thakis 2011-12-20 12:04:15 -0800 Comment on attachment 120050 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120050&action=review lgtm > Source/WebCore/WebCore.gyp/WebCore.gyp:49 > + 'enable_wexit_time_destructors': 1, If this works, it's great. I hadn't tried building tests, so I don't know if there's anything left there. I guess the bots will tell you :-) 524747 5 120050 jamesr 2011-12-20 12:06:05 -0800 Comment on attachment 120050 Patch Resetting flag that Nico cleared 524752 6 tony 2011-12-20 12:15:22 -0800 (In reply to comment #4) > (From update of attachment 120050 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120050&action=review > > Source/WebCore/WebCore.gyp/WebCore.gyp:49 > > + 'enable_wexit_time_destructors': 1, > > If this works, it's great. I hadn't tried building tests, so I don't know if there's anything left there. > > I guess the bots will tell you :-) I re-ran gyp with this change (and clang=1) and verified that the generated .mk files have -Wexit-time-destructors. I'm assume if that if it works for enable_wexit_time_destructors, then it will also work for optimize. 524799 7 tony 2011-12-20 13:45:36 -0800 Committed r103348: <http://trac.webkit.org/changeset/103348> 120050 2011-12-20 11:54:05 -0800 2011-12-20 12:06:05 -0800 Patch bug-74947-20111220115423.patch text/plain 3522 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDk3MzcxMDlhOTc1YTAy MGFiODdiZmY3YmYyYmFjZDhjMmRiMTRkYy4uMjQ0MDA1MDBkNWJkM2NiNmY1MTE4OGZkM2JlNGE5 YjVmMjYxOGY1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDExLTEyLTIwICBUb255 IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgW2Nocm9taXVtXSBlbmFibGUg V1BPIGZvciBXZWJDb3JlIGxpYnMgaW4gb2ZmaWNpYWwgYnVpbGRzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDk0NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsc28gbW92ZSBlbmFibGVfd2V4aXRfdGlt ZV9kZXN0cnVjdG9ycyB0byB0aGUgdG9wIGxldmVsIHZhcmlhYmxlcworICAgICAgICBzbyB3ZSBk b24ndCBoYXZlIHRvIGFkZCBpdCB0byBhbGwgdGFyZ2V0cy4KKworICAgICAgICAqIFdlYkNvcmUu Z3lwL1dlYkNvcmUuZ3lwOgorCisyMDExLTEyLTIwICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1 bS5vcmc+CisKICAgICAgICAgUmVuZGVyU3R5bGU6OkluaGVyaXRlZEZsYWdzIGFuZCBSZW5kZXJT dHlsZTo6Tm9uSW5oZXJpdGVkRmxhZ3MgbWVtYmVycyBzaG91bGQgYmUgNCBieXRlIGFsaWduZWQK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0ODgwCiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwIGIvU291 cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKaW5kZXggODg2MjAzZDBhZDBkNzU3 MTJmMTEzZDhiODE4ZjczMzhjNWUzMjk4Mi4uNDIzOGNjNzhhNjVmZDlmZmVhNTYzMzcwMjI5NTAx OGFlY2FiMTZlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29y ZS5neXAKKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKQEAgLTQ1 LDYgKzQ1LDkgQEAKICAgICAjIGJpbmFyeSBhbmQgaW5jcmVhc2luZyB0aGUgc3BlZWQgb2YgZ2Ri LgogICAgICdlbmFibGVfc3ZnJSc6IDEsCiAKKyAgICAnb3B0aW1pemUnOiAnbWF4JywKKyAgICAn ZW5hYmxlX3dleGl0X3RpbWVfZGVzdHJ1Y3RvcnMnOiAxLAorCiAgICAgJ3dlYmNvcmVfaW5jbHVk ZV9kaXJzJzogWwogICAgICAgJy4uLycsCiAgICAgICAnLi4vLi4nLApAQCAtMTAyOSw3ICsxMDMy LDYgQEAKICAgICB7CiAgICAgICAndGFyZ2V0X25hbWUnOiAnd2ViY29yZV9iaW5kaW5ncycsCiAg ICAgICAndHlwZSc6ICdzdGF0aWNfbGlicmFyeScsCi0gICAgICAndmFyaWFibGVzJzogeyAnZW5h YmxlX3dleGl0X3RpbWVfZGVzdHJ1Y3RvcnMnOiAxLCB9LAogICAgICAgJ2hhcmRfZGVwZW5kZW5j eSc6IDEsCiAgICAgICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAnd2ViY29yZV9iaW5kaW5n c19zb3VyY2VzJywKQEAgLTEzNzgsNyArMTM4MCw2IEBACiAgICAgewogICAgICAgJ3RhcmdldF9u YW1lJzogJ3dlYmNvcmVfZG9tJywKICAgICAgICd0eXBlJzogJ3N0YXRpY19saWJyYXJ5JywKLSAg ICAgICd2YXJpYWJsZXMnOiB7ICdlbmFibGVfd2V4aXRfdGltZV9kZXN0cnVjdG9ycyc6IDEsIH0s CiAgICAgICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAnd2ViY29yZV9wcmVyZXF1aXNpdGVz JywKICAgICAgIF0sCkBAIC0xNDAxLDcgKzE0MDIsNiBAQAogICAgIHsKICAgICAgICd0YXJnZXRf bmFtZSc6ICd3ZWJjb3JlX2h0bWwnLAogICAgICAgJ3R5cGUnOiAnc3RhdGljX2xpYnJhcnknLAot ICAgICAgJ3ZhcmlhYmxlcyc6IHsgJ2VuYWJsZV93ZXhpdF90aW1lX2Rlc3RydWN0b3JzJzogMSwg fSwKICAgICAgICdkZXBlbmRlbmNpZXMnOiBbCiAgICAgICAgICd3ZWJjb3JlX3ByZXJlcXVpc2l0 ZXMnLAogICAgICAgXSwKQEAgLTE0MTYsNyArMTQxNiw2IEBACiAgICAgewogICAgICAgJ3Rhcmdl dF9uYW1lJzogJ3dlYmNvcmVfc3ZnJywKICAgICAgICd0eXBlJzogJ3N0YXRpY19saWJyYXJ5JywK LSAgICAgICd2YXJpYWJsZXMnOiB7ICdlbmFibGVfd2V4aXRfdGltZV9kZXN0cnVjdG9ycyc6IDEs IH0sCiAgICAgICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAnd2ViY29yZV9wcmVyZXF1aXNp dGVzJywKICAgICAgIF0sCkBAIC0xNDMxLDcgKzE0MzAsNiBAQAogICAgIHsKICAgICAgICd0YXJn ZXRfbmFtZSc6ICd3ZWJjb3JlX3BsYXRmb3JtJywKICAgICAgICd0eXBlJzogJ3N0YXRpY19saWJy YXJ5JywKLSAgICAgICd2YXJpYWJsZXMnOiB7ICdlbmFibGVfd2V4aXRfdGltZV9kZXN0cnVjdG9y cyc6IDEsIH0sCiAgICAgICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAnd2ViY29yZV9wcmVy ZXF1aXNpdGVzJywKICAgICAgIF0sCkBAIC0xNjk5LDcgKzE2OTcsNiBAQAogICAgIHsKICAgICAg ICd0YXJnZXRfbmFtZSc6ICd3ZWJjb3JlX2FybV9uZW9uJywKICAgICAgICd0eXBlJzogJ3N0YXRp Y19saWJyYXJ5JywKLSAgICAgICd2YXJpYWJsZXMnOiB7ICdlbmFibGVfd2V4aXRfdGltZV9kZXN0 cnVjdG9ycyc6IDEsIH0sCiAgICAgICAnZGVwZW5kZW5jaWVzJzogWwogICAgICAgICAnd2ViY29y ZV9wcmVyZXF1aXNpdGVzJywKICAgICAgIF0sCkBAIC0xNzI0LDcgKzE3MjEsNiBAQAogICAgIHsK ICAgICAgICd0YXJnZXRfbmFtZSc6ICd3ZWJjb3JlX3JlbmRlcmluZycsCiAgICAgICAndHlwZSc6 ICdzdGF0aWNfbGlicmFyeScsCi0gICAgICAndmFyaWFibGVzJzogeyAnZW5hYmxlX3dleGl0X3Rp bWVfZGVzdHJ1Y3RvcnMnOiAxLCB9LAogICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKICAgICAgICAg J3dlYmNvcmVfcHJlcmVxdWlzaXRlcycsCiAgICAgICBdLApAQCAtMTc4Myw3ICsxNzc5LDYgQEAK ICAgICB7CiAgICAgICAndGFyZ2V0X25hbWUnOiAnd2ViY29yZV9yZW1haW5pbmcnLAogICAgICAg J3R5cGUnOiAnc3RhdGljX2xpYnJhcnknLAotICAgICAgJ3ZhcmlhYmxlcyc6IHsgJ2VuYWJsZV93 ZXhpdF90aW1lX2Rlc3RydWN0b3JzJzogMSwgfSwKICAgICAgICdkZXBlbmRlbmNpZXMnOiBbCiAg ICAgICAgICd3ZWJjb3JlX3ByZXJlcXVpc2l0ZXMnLAogICAgICAgICAnPChjaHJvbWl1bV9zcmNf ZGlyKS90aGlyZF9wYXJ0eS92OC1pMThuL2J1aWxkL2FsbC5neXA6djgtaTE4bicsCkBAIC0xOTg1 LDcgKzE5ODAsNiBAQAogICAgIHsKICAgICAgICd0YXJnZXRfbmFtZSc6ICd3ZWJjb3JlX3Rlc3Rf c3VwcG9ydCcsCiAgICAgICAndHlwZSc6ICdzdGF0aWNfbGlicmFyeScsCi0gICAgICAndmFyaWFi bGVzJzogeyAnZW5hYmxlX3dleGl0X3RpbWVfZGVzdHJ1Y3RvcnMnOiAxLCB9LAogICAgICAgJ2Rl cGVuZGVuY2llcyc6IFsKICAgICAgICAgJ3dlYmNvcmUnLAogICAgICAgXSwK