74945 2011-12-20 11:32:00 -0800 HTMLMediaElement::configureTextTrackDisplay is unnecessary 2011-12-21 12:24:32 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson webkit-bug-importer oldest_to_newest 524709 0 eric.carlson 2011-12-20 11:32:00 -0800 HTMLMediaElement hides and shows the cue display element tracks are shown and hidden, but MediaControlRootElement::updateTextTrackDisplay already hides and shows the display element when cues are necessary. Both are not necessary. 524710 1 webkit-bug-importer 2011-12-20 11:33:20 -0800 <rdar://problem/10608586> 524753 2 120058 eric.carlson 2011-12-20 12:17:22 -0800 Created attachment 120058 Proposed patch 525333 3 120058 darin 2011-12-21 10:34:55 -0800 Comment on attachment 120058 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=120058&action=review B > Source/WebCore/ChangeLog:8 > + Nothing to test, just removing redundant code. But what existing test covers this code? 525462 4 eric.carlson 2011-12-21 12:24:32 -0800 http://trac.webkit.org/changeset/103428 120058 2011-12-20 12:17:22 -0800 2011-12-21 10:34:55 -0800 Proposed patch patch_show_hide_display.txt text/plain 1601 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzM0MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDExLTEyLTIwICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIEhUTUxNZWRpYUVsZW1l bnQ6OmNvbmZpZ3VyZVRleHRUcmFja0Rpc3BsYXkgaXMgdW5uZWNlc3NhcnkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0OTQ1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm90aGluZyB0byB0ZXN0LCBqdXN0 IHJlbW92aW5nIHJlZHVuZGFudCBjb2RlLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmNvbmZpZ3VyZVRl eHRUcmFja0Rpc3BsYXkpOiBEb24ndCBzaG93IGFuZCBoaWRlIHRyYWNrLCBqdXN0IGNhbGwKKyAg ICAgICAgICAgIHVwZGF0ZVRleHRUcmFja0Rpc3BsYXkgYW5kIGl0IHdpbGwgZG8gdGhlIHJpZ2h0 IHRoaW5nLgorCiAyMDExLTEyLTE5ICBBZGFtIEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJlbmFtZSBFbGVtZW50OjpzZXRBdHRyaWJ1dGVNYXAgdG8gcGFyc2VyU2V0QXR0 cmlidXRlTWFwIGFuZCBsaW1pdCBpdHMgdXNlIHRvIHRoZSBwYXJzZXIKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAkocmV2aXNpb24gMTAzMjQyKQorKysgU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAt MzUwMywxNSArMzUwMywxMSBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OmNvbmZpZ3VyZVRleHRU cmFjCiAgICAgICAgIHJldHVybjsKICAgICBtX2hhdmVWaXNpYmxlVGV4dFRyYWNrID0gaGF2ZVZp c2libGVUZXh0VHJhY2s7CiAKLSAgICBpZiAoIW1faGF2ZVZpc2libGVUZXh0VHJhY2spIHsKLSAg ICAgICAgaWYgKGhhc01lZGlhQ29udHJvbHMoKSkKLSAgICAgICAgICAgIG1lZGlhQ29udHJvbHMo KS0+aGlkZVRleHRUcmFja0Rpc3BsYXkoKTsKKyAgICBpZiAoIW1faGF2ZVZpc2libGVUZXh0VHJh Y2sgJiYgIWhhc01lZGlhQ29udHJvbHMoKSkKICAgICAgICAgcmV0dXJuOwotICAgIH0KLQogICAg IGlmICghaGFzTWVkaWFDb250cm9scygpICYmICFjcmVhdGVNZWRpYUNvbnRyb2xzKCkpCiAgICAg ICAgIHJldHVybjsKLSAgICBtZWRpYUNvbnRyb2xzKCktPnNob3dUZXh0VHJhY2tEaXNwbGF5KCk7 CisgICAgbWVkaWFDb250cm9scygpLT51cGRhdGVUZXh0VHJhY2tEaXNwbGF5KCk7CiB9CiAjZW5k aWYKIAo=