74943 2011-12-20 10:55:03 -0800 [Coverity] Fix leak in V8HTMLDocument 2011-12-20 15:46:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gbillock gbillock abarth groby japhet webkit.review.bot oldest_to_newest 524685 0 gbillock 2011-12-20 10:55:03 -0800 [Coverity] Fix leak in V8HTMLDocument 524686 1 120044 gbillock 2011-12-20 10:55:42 -0800 Created attachment 120044 Patch 524718 2 120044 abarth 2011-12-20 11:43:24 -0800 Comment on attachment 120044 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120044&action=review > Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp:156 > + delete[] params; We should use OwnArrayPtr instead of manual delete. 524737 3 120044 gbillock 2011-12-20 12:00:14 -0800 Comment on attachment 120044 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120044&action=review >> Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp:156 >> + delete[] params; > > We should use OwnArrayPtr instead of manual delete. Done. 524742 4 120055 gbillock 2011-12-20 12:01:39 -0800 Created attachment 120055 Patch 524898 5 120055 webkit.review.bot 2011-12-20 15:46:18 -0800 Comment on attachment 120055 Patch Clearing flags on attachment: 120055 Committed r103358: <http://trac.webkit.org/changeset/103358> 524899 6 webkit.review.bot 2011-12-20 15:46:22 -0800 All reviewed patches have been landed. Closing bug. 120044 2011-12-20 10:55:42 -0800 2011-12-20 12:01:35 -0800 Patch bug-74943-20111220105540.patch text/plain 1531 gbillock U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWVjMTc4Nzg3N2U2N2U2 ZjhkODAxY2NjNzYzYmJiMjdhNzE5OGIxYi4uZTg0OTU2MzNhMGUxYjBjMzVlMTQzNDVhN2E2OWE1 MzczY2Y5OWFkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTEyLTIwICBHcmVn IEJpbGxvY2sgIDxnYmlsbG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFtDb3Zlcml0eV0gRml4 IGxlYWsgaW4gVjhIVE1MRG9jdW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTc0OTQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRG9jdW1lbnRDdXN0b20u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhIVE1MRG9jdW1lbnQ6Om9wZW5DYWxsYmFjayk6CisK IDIwMTEtMTItMTIgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMDI2NDguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRG9jdW1lbnRDdXN0b20uY3BwIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTERvY3VtZW50Q3VzdG9tLmNwcAppbmRl eCA3NDg2NTMxY2VhMzgyNjQ4MTU4MjhlMTRlZTY5YjQxNjNjZmI3OGYyLi4xYzhkZDUzNTJlMjI2 MGE5MmExMjI3MThkMjcyOTEwNmFhOWNiMzU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRG9jdW1lbnRDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxEb2N1bWVudEN1c3RvbS5jcHAKQEAgLTE1 Miw4ICsxNTIsMTAgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4SFRNTERvY3VtZW50OjpvcGVu Q2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncykKICAgICAgICAgICAgICAgICBwYXJh bXNbaV0gPSBhcmdzW2ldOwogCiAgICAgICAgICAgICBWOFByb3h5KiBwcm94eSA9IFY4UHJveHk6 OnJldHJpZXZlKGZyYW1lLmdldCgpKTsKLSAgICAgICAgICAgIGlmICghcHJveHkpCisgICAgICAg ICAgICBpZiAoIXByb3h5KSB7CisgICAgICAgICAgICAgICAgZGVsZXRlW10gcGFyYW1zOwogICAg ICAgICAgICAgICAgIHJldHVybiB2ODo6VW5kZWZpbmVkKCk7CisgICAgICAgICAgICB9CiAKICAg ICAgICAgICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+IHJlc3VsdCA9IHByb3h5LT5jYWxsRnVuY3Rp b24odjg6OkxvY2FsPHY4OjpGdW5jdGlvbj46OkNhc3QoZnVuY3Rpb24pLCBnbG9iYWwsIGFyZ3Mu TGVuZ3RoKCksIHBhcmFtcyk7CiAgICAgICAgICAgICBkZWxldGVbXSBwYXJhbXM7Cg== 120055 2011-12-20 12:01:39 -0800 2011-12-20 15:46:18 -0800 Patch bug-74943-20111220120138.patch text/plain 2227 gbillock U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWVjMTc4Nzg3N2U2N2U2 ZjhkODAxY2NjNzYzYmJiMjdhNzE5OGIxYi4uZTg0OTU2MzNhMGUxYjBjMzVlMTQzNDVhN2E2OWE1 MzczY2Y5OWFkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTEyLTIwICBHcmVn IEJpbGxvY2sgIDxnYmlsbG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFtDb3Zlcml0eV0gRml4 IGxlYWsgaW4gVjhIVE1MRG9jdW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTc0OTQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRG9jdW1lbnRDdXN0b20u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhIVE1MRG9jdW1lbnQ6Om9wZW5DYWxsYmFjayk6CisK IDIwMTEtMTItMTIgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMDI2NDguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRG9jdW1lbnRDdXN0b20uY3BwIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTERvY3VtZW50Q3VzdG9tLmNwcAppbmRl eCA3NDg2NTMxY2VhMzgyNjQ4MTU4MjhlMTRlZTY5YjQxNjNjZmI3OGYyLi5hZWYzN2M3OGJkZTZl Nzg0MGE1YzVkNjZiZGQzOGU0NjNjMTg1YTc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9jdXN0b20vVjhIVE1MRG9jdW1lbnRDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxEb2N1bWVudEN1c3RvbS5jcHAKQEAgLTQ0 LDYgKzQ0LDcgQEAKICNpbmNsdWRlICJWOElzb2xhdGVkQ29udGV4dC5oIgogI2luY2x1ZGUgIlY4 Tm9kZS5oIgogI2luY2x1ZGUgIlY4UHJveHkuaCIKKyNpbmNsdWRlIDx3dGYvT3duQXJyYXlQdHIu aD4KICNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1N0ZExpYkV4dHJhcy5o PgogCkBAIC0xNDcsNyArMTQ4LDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4SFRNTERvY3Vt ZW50OjpvcGVuQ2FsbGJhY2soY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncykKICAgICAgICAgICAg ICAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOwogICAgICAgICAgICAgfQogICAgICAgICAgICAg Ly8gV3JhcCB1cCB0aGUgYXJndW1lbnRzIGFuZCBjYWxsIHRoZSBmdW5jdGlvbi4KLSAgICAgICAg ICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+KiBwYXJhbXMgPSBuZXcgdjg6OkxvY2FsPHY4OjpWYWx1 ZT5bYXJncy5MZW5ndGgoKV07CisgICAgICAgICAgICBPd25BcnJheVB0cjx2ODo6TG9jYWw8djg6 OlZhbHVlPiA+IHBhcmFtcyA9IGFkb3B0QXJyYXlQdHIobmV3IHY4OjpMb2NhbDx2ODo6VmFsdWU+ W2FyZ3MuTGVuZ3RoKCldKTsKICAgICAgICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgYXJncy5M ZW5ndGgoKTsgaSsrKQogICAgICAgICAgICAgICAgIHBhcmFtc1tpXSA9IGFyZ3NbaV07CiAKQEAg LTE1NSw4ICsxNTYsNyBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhIVE1MRG9jdW1lbnQ6Om9w ZW5DYWxsYmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcmdzKQogICAgICAgICAgICAgaWYgKCFw cm94eSkKICAgICAgICAgICAgICAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOwogCi0gICAgICAg ICAgICB2ODo6TG9jYWw8djg6OlZhbHVlPiByZXN1bHQgPSBwcm94eS0+Y2FsbEZ1bmN0aW9uKHY4 OjpMb2NhbDx2ODo6RnVuY3Rpb24+OjpDYXN0KGZ1bmN0aW9uKSwgZ2xvYmFsLCBhcmdzLkxlbmd0 aCgpLCBwYXJhbXMpOwotICAgICAgICAgICAgZGVsZXRlW10gcGFyYW1zOworICAgICAgICAgICAg djg6OkxvY2FsPHY4OjpWYWx1ZT4gcmVzdWx0ID0gcHJveHktPmNhbGxGdW5jdGlvbih2ODo6TG9j YWw8djg6OkZ1bmN0aW9uPjo6Q2FzdChmdW5jdGlvbiksIGdsb2JhbCwgYXJncy5MZW5ndGgoKSwg cGFyYW1zLmdldCgpKTsKICAgICAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgICAgIH0KICAg ICB9Cg==