74938 2011-12-20 09:58:39 -0800 Web Inspector: CSSStyleSheet::cssRules can return 0 and InspectorStyleSheet dosen't check 2011-12-21 05:45:31 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 0 timothy apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 524659 0 timothy 2011-12-20 09:58:39 -0800 InspectorStyleSheet looks like it can run into security origin checks in CSSStyleSheet::cssRules. There should be a way to prevent the security origin checks or at the very least catch the null and bail from InspectorStyleSheet. Steps: 1) Navigate to http://www.theonion.com/articles/circus-train-wreck-not-funny-investigators-emphasi,21252/ 2) Select paywall pop-up element and inspect it 3) Add new style rule 4) Press enter to type in new style rule such as "display: none" Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x00007fff932d4b50 WebCore::CSSRuleList::length() const + 4 1 com.apple.WebCore 0x00007fff9374c341 WebCore::InspectorStyleSheet::addRule(WTF::String const&) + 181 2 com.apple.WebCore 0x00007fff9374c0dc WebCore::InspectorCSSAgent::addRule(WTF::String*, int, WTF::String const&, WTF::RefPtr<WebCore::InspectorObject>*) + 82 3 com.apple.WebCore 0x00007fff9374bba0 WebCore::InspectorBackendDispatcher::CSS_addRule(long, WebCore::InspectorObject*) + 668 4 com.apple.WebCore 0x00007fff936ef928 WebCore::InspectorBackendDispatcher::dispatch(WTF::String const&) + 14266 5 com.apple.WebCore 0x00007fff936ec0f6 WebCore::jsInspectorFrontendHostPrototypeFunctionSendMessageToBackend(JSC::ExecState*) + 246 6 ??? 0x00003e42116011e8 0 + 68453480272360 7 com.apple.JavaScriptCore 0x00007fff8ffdcf96 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 1046 8 com.apple.JavaScriptCore 0x00007fff8ffdcb6d JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 45 9 com.apple.WebCore 0x00007fff931a349d WebCore::JSEventListener::handleEvent(WebCore::ScriptExecutionContext*, WebCore::Event*) + 1195 10 com.apple.WebCore 0x00007fff931a2f74 WebCore::EventTarget::fireEventListeners(WebCore::Event*, WebCore::EventTargetData*, WTF::Vector<WebCore::RegisteredEventListener, 1ul>&) + 494 11 com.apple.WebCore 0x00007fff930c2393 WebCore::EventTarget::fireEventListeners(WebCore::Event*) + 85 12 com.apple.WebCore 0x00007fff930c2480 WebCore::Node::handleLocalEvents(WebCore::Event*) + 180 13 com.apple.WebCore 0x00007fff930c1b04 WebCore::EventDispatcher::dispatchEvent(WTF::PassRefPtr<WebCore::Event>) + 832 14 com.apple.WebCore 0x00007fff930c1788 WebCore::EventDispatchMediator::dispatchEvent(WebCore::EventDispatcher*) const + 40 15 com.apple.WebCore 0x00007fff930c1689 WebCore::EventDispatcher::dispatchEvent(WebCore::Node*, WebCore::EventDispatchMediator const&) + 41 16 com.apple.WebCore 0x00007fff930c15f7 WebCore::Node::dispatchEvent(WTF::PassRefPtr<WebCore::Event>) + 55 17 com.apple.WebCore 0x00007fff931d7d28 WebCore::Node::dispatchBlurEvent() + 82 18 com.apple.WebCore 0x00007fff93119a83 WebCore::Document::setFocusedNode(WTF::PassRefPtr<WebCore::Node>) + 251 19 com.apple.WebCore 0x00007fff931adb4b WebCore::FocusController::setFocusedNode(WebCore::Node*, WTF::PassRefPtr<WebCore::Frame>) + 645 20 com.apple.WebCore 0x00007fff9326c0ba WebCore::EventHandler::dispatchMouseEvent(WTF::AtomicString const&, WebCore::Node*, bool, int, WebCore::PlatformMouseEvent const&, bool) + 618 21 com.apple.WebCore 0x00007fff9326f6a5 WebCore::EventHandler::handleMousePressEvent(WebCore::PlatformMouseEvent const&) + 1557 22 com.apple.WebKit2 0x00007fff902d33fd WebKit::WebPage::mouseEvent(WebKit::WebMouseEvent const&) + 267 23 com.apple.WebKit2 0x00007fff902f9882 void CoreIPC::handleMessage<Messages::WebPage::MouseEvent, WebKit::WebPage, void (WebKit::WebPage::*)(WebKit::WebMouseEvent const&)>(CoreIPC::ArgumentDecoder*, WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::WebMouseEvent const&)) + 74 24 com.apple.WebKit2 0x00007fff90260f26 CoreIPC::Connection::dispatchMessage(CoreIPC::Connection::Message<CoreIPC::ArgumentDecoder>&) + 172 25 com.apple.WebKit2 0x00007fff90260e3f CoreIPC::Connection::dispatchMessages() + 145 26 com.apple.WebKit2 0x00007fff9025d77f RunLoop::performWork() + 111 <rdar://problem/10066239> 525199 1 120162 apavlov 2011-12-21 02:16:58 -0800 Created attachment 120162 Patch 525229 2 120162 webkit.review.bot 2011-12-21 05:45:27 -0800 Comment on attachment 120162 Patch Clearing flags on attachment: 120162 Committed r103403: <http://trac.webkit.org/changeset/103403> 525230 3 webkit.review.bot 2011-12-21 05:45:31 -0800 All reviewed patches have been landed. Closing bug. 120162 2011-12-21 02:16:58 -0800 2011-12-21 05:45:27 -0800 Patch bug-74938-20111221141655.patch text/plain 1618 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMzk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTk0N2M2ZjNjYmExNzFi N2ExYWJhMWU0MmUzOGIwZGQxYmQ5ZjgxNS4uY2ZjZTZkNDYxOGExNDc5ZGIyZWEwOTQ1OTQ0NTI0 MDQ4MTg4ZWFhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTEyLTIxICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogQ1NTU3R5bGVTaGVldDo6Y3NzUnVsZXMgY2FuIHJldHVybiAwIGFuZCBJbnNwZWN0b3JT dHlsZVNoZWV0IGRvc2VuJ3QgY2hlY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTc0OTM4CisKKyAgICAgICAgUHJldmVudCBzZWN1cml0eSBjaGVja3Mg d2hlbiByZXRyaWV2aW5nIGEganVzdC1hZGRlZCBDU1MgcnVsZSBmcm9tIHRoZSAiaW5zcGVjdG9y IHN0eWxlc2hlZXQiLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SW5zcGVjdG9yU3R5bGVTaGVldDo6YWRkUnVsZSk6CisKIDIwMTEtMTItMjEgIE1hdHQg RmFsa2VuaGFnZW4gIDxmYWxrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBhbGwgSUNV IGxhbmd1YWdlcyB0byBMb2NhbGVUb1NjcmlwdE1hcHBpbmdEZWZhdWx0LmNwcApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuY3BwIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuY3BwCmluZGV4IDJiMTAx MTM1Yzk2NTQ5YjAwNmE0ZTNkZTRjN2MxNzRhZjhmNjZjMTUuLjhiMDAyY2E0MmRlOGNlMTkzYjk2 M2ZlYWRkM2E1NWVhOTQxYzc2NzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yU3R5bGVTaGVldC5jcHAKQEAgLTczMCw3ICs3MzAsNyBAQCBDU1NTdHlsZVJ1bGUq IEluc3BlY3RvclN0eWxlU2hlZXQ6OmFkZFJ1bGUoY29uc3QgU3RyaW5nJiBzZWxlY3RvcikKICAg ICBtX3BhZ2VTdHlsZVNoZWV0LT5hZGRSdWxlKHNlbGVjdG9yLCAiIiwgZWMpOwogICAgIGlmIChl YykKICAgICAgICAgcmV0dXJuIDA7Ci0gICAgUmVmUHRyPENTU1J1bGVMaXN0PiBydWxlcyA9IG1f cGFnZVN0eWxlU2hlZXQtPmNzc1J1bGVzKCk7CisgICAgUmVmUHRyPENTU1J1bGVMaXN0PiBydWxl cyA9IENTU1J1bGVMaXN0OjpjcmVhdGUobV9wYWdlU3R5bGVTaGVldC5nZXQoKSk7CiAgICAgQVNT RVJUKHJ1bGVzLT5sZW5ndGgoKSk7CiAgICAgQ1NTU3R5bGVSdWxlKiBydWxlID0gSW5zcGVjdG9y Q1NTQWdlbnQ6OmFzQ1NTU3R5bGVSdWxlKHJ1bGVzLT5pdGVtKHJ1bGVzLT5sZW5ndGgoKSAtIDEp KTsKICAgICBBU1NFUlQocnVsZSk7Cg==